New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 612549 link

Starred by 2 users
Status: Fixed
Owner:
█ hubbe@chromium.org
Last visit > 30 days ago
Closed: May 2016
Cc:
█ sshruthi@chromium.org
dalecur...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 588903



Sign in to add a comment

Progress events are not reported on every byte with multibuffers

Project Member Reported by hubbe@chromium.org, May 17 2016 
Version: ToT
OS: All

What steps will reproduce the problem?
Run this layout test:
third_party/WebKit/LayoutTests/http/tests/media/progress-events-generated-correctly.html

Comment 1 by hubbe@chromium.org, May 17 2016

Labels: OS-All

Comment 2 by hubbe@chromium.org, May 17 2016

Labels: -Pri-3 Pri-2

Comment 3 by hubbe@chromium.org, May 17 2016

Status: Fixed (was: Started)
Fixed in: https://codereview.chromium.org/1971373002/

Comment 4 by hubbe@chromium.org, May 17 2016

Cc: dalecur...@chromium.org

Comment 5 by hubbe@chromium.org, May 17 2016

Labels: Merge-Request-51

Comment 6 by gov...@chromium.org, May 17 2016 

Before we approve merge to M51, Could you please confirm whether this bug is baked/verified in Canary and safe to merge?

Comment 7 Deleted

Comment 8 by hubbe@chromium.org, May 17 2016 

This was checked in on trunk 4 days ago, not sure if that's considered enough "bake" time or not.

Comment 9 by gov...@chromium.org, May 18 2016

Cc: sshruthi@chromium.org
Labels: -Merge-Request-51 Merge-Approved-51
Approving merge to M51 branch 2704 based on comment #8.

Comment 10 by dalecur...@chromium.org, May 18 2016

Blocking: 588903
Project Member

Comment 11 by bugdroid1@chromium.org, May 18 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/711cac9cf1bedff9713528d792aebdf8368d7a4b

commit 711cac9cf1bedff9713528d792aebdf8368d7a4b
Author: Fredrik Hubinette <hubbe@google.com>
Date: Wed May 18 23:27:32 2016

Fix progress reporting for multibuffers to report progress for every byte we receive.

Review-Url: https://codereview.chromium.org/1971373002
Cr-Commit-Position: refs/heads/master@{#393609}
(cherry picked from commit 1d3e7432173300d1f65be0ec988178b8aae80726)

BUG= 612549 

Review URL: https://codereview.chromium.org/1989123003 .

Cr-Commit-Position: refs/branch-heads/2704@{#595}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/711cac9cf1bedff9713528d792aebdf8368d7a4b/media/blink/multibuffer.cc
[modify] https://crrev.com/711cac9cf1bedff9713528d792aebdf8368d7a4b/media/blink/multibuffer.h
[modify] https://crrev.com/711cac9cf1bedff9713528d792aebdf8368d7a4b/media/blink/multibuffer_data_source_unittest.cc
[modify] https://crrev.com/711cac9cf1bedff9713528d792aebdf8368d7a4b/media/blink/multibuffer_reader.cc
[modify] https://crrev.com/711cac9cf1bedff9713528d792aebdf8368d7a4b/media/blink/multibuffer_unittest.cc
[modify] https://crrev.com/711cac9cf1bedff9713528d792aebdf8368d7a4b/media/blink/resource_multibuffer_data_provider.cc
[modify] https://crrev.com/711cac9cf1bedff9713528d792aebdf8368d7a4b/media/blink/resource_multibuffer_data_provider.h
►

Sign in to add a comment