New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 612546 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug-Regression

Blocking:
issue 588903



Sign in to add a comment

http/tests/media/audio-seekable-contains-zero-without-ranges.html fails with multibuffers on windows

Project Member Reported by hubbe@chromium.org, May 17 2016

Issue description

Version: ToT
OS: Windows

Run layout tests with multibuffers enabled.

What is the expected output?

Tests pass

What do you see instead?

Tests fail.


 
Blocking: 588903
Components: Internals>Media>Network
Labels: -OS-Windows -Type-Bug Proj-Spitzer M-51 OS-All Type-Bug-Regression
Updating labels since 
Project Member

Comment 2 by bugdroid1@chromium.org, May 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d435e1e789fe2036570c608d024ba9bcbe64314

commit 4d435e1e789fe2036570c608d024ba9bcbe64314
Author: hubbe <hubbe@chromium.org>
Date: Tue May 17 20:35:16 2016

Make http/tests/media/audio-seekable-contains-zero-without-ranges.html work with multibuffers.

This failed on windows with multibuffers.
On all other platforms, the file is delivered immediately and the size is known, on windows it's a little
slower, and we must remember to copy the size of the file when we reach the end. This behavior is a direct
copy from buffered_data_source.cc, passes all tests so far and is unlikely to cause any problems.

BUG= 612546 

Review-Url: https://codereview.chromium.org/1983793003
Cr-Commit-Position: refs/heads/master@{#394217}

[modify] https://crrev.com/4d435e1e789fe2036570c608d024ba9bcbe64314/media/blink/multibuffer_data_source.cc
[modify] https://crrev.com/4d435e1e789fe2036570c608d024ba9bcbe64314/media/blink/multibuffer_data_source_unittest.cc

Comment 3 by hubbe@chromium.org, May 17 2016

Cc: dalecur...@chromium.org
Labels: Merge-Request-51

Comment 4 by gov...@chromium.org, May 17 2016

Before we approve merge to M51, Could you please confirm whether this bug is baked/verified in Canary and safe to merge?

Comment 5 by hubbe@chromium.org, May 17 2016

This is a very minor change, and that change was copied directly from the non-multibuffer code and should thus be safe. It has not been tested in a canary build yet.


Comment 6 by gov...@chromium.org, May 17 2016

Cc: sshruthi@chromium.org
Thank you for the update. Please update the bug once it is tested in canary. I will approve it then.

Comment 7 by tin...@google.com, May 18 2016

Labels: -Merge-Request-51 Merge-Review-51 Hotlist-Merge-Review
[Automated comment] Less than 2 weeks to go before stable on M51, manual review required.
This has now soaked on canary overnight w/o any reported crashes or issues.

Comment 9 by sshru...@google.com, May 18 2016

Labels: -Merge-Review-51 Merge-Approved-51
Merge approved for M51 (branch 2704). Please merge your change ASAP, as we are getting close to cutting a stable candidate. 
Thank you for confirmation. Approving merge to M51 branch 2704. Please merge asap as we're getting closer to M51 stable launch. 
Project Member

Comment 11 by bugdroid1@chromium.org, May 18 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e1ea09a8a6027398e41445245943a9a786854be

commit 5e1ea09a8a6027398e41445245943a9a786854be
Author: Fredrik Hubinette <hubbe@google.com>
Date: Wed May 18 23:19:43 2016

Make http/tests/media/audio-seekable-contains-zero-without-ranges.html work with multibuffers.

This failed on windows with multibuffers.
On all other platforms, the file is delivered immediately and the size is known, on windows it's a little
slower, and we must remember to copy the size of the file when we reach the end. This behavior is a direct
copy from buffered_data_source.cc, passes all tests so far and is unlikely to cause any problems.

BUG= 612546 

Review-Url: https://codereview.chromium.org/1983793003
Cr-Commit-Position: refs/heads/master@{#394217}
(cherry picked from commit 4d435e1e789fe2036570c608d024ba9bcbe64314)

Review URL: https://codereview.chromium.org/1991033002 .

Cr-Commit-Position: refs/branch-heads/2704@{#593}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/5e1ea09a8a6027398e41445245943a9a786854be/media/blink/multibuffer_data_source.cc
[modify] https://crrev.com/5e1ea09a8a6027398e41445245943a9a786854be/media/blink/multibuffer_data_source_unittest.cc

Comment 12 by hubbe@chromium.org, May 18 2016

Status: Fixed (was: Started)

Sign in to add a comment