New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 612535 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2016
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Font settings don't update the fixed font size

Project Member Reported by michae...@chromium.org, May 17 2016

Issue description

Options (chrome://settings/fonts)

1. Change the standard (default) font size from 16 to 32.
2. Observe the fixed width font sample get larger.
3. Set the standard font size back to 16.
3. CLOSE ALL SETTINGS TABS.

MD Settings (chrome://md-settings -> Customize fonts):

1. Change the standard (default) font size from 16 to 32.
2. Observe the fixed width sample get larger.
3. Open Options again and open the Fonts dialog.

Expected: the fixed-width font is sample is large, like the other fonts.
Actual: the fixed-width font sample has not been updated.

MD Settings is "cheating" by using the default font size to display the fixed width font size, which is why this bug was hard to see. It shouldn't cheat, for the same reason.

The root of the bug: appearance_fonts_page.js sets 'prefs.webkit.webprefs.default_fixed_font_size.value', but since that pref is never actually fetched from C++, there is no Polymer path there, and the function does nothing.

The result is that the fixed font size is not updated when the default font size is updated.

You can verify this with:
chrome.settingsPrivate.getPref('webkit.webprefs.default_fixed_font_size', console.log.bind(console));

Note that Options must be closed for the bug to repro.


 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0a3e2fd2fd68600528faa0796120fd395219437

commit b0a3e2fd2fd68600528faa0796120fd395219437
Author: dschuyler <dschuyler@chromium.org>
Date: Thu Jun 16 01:34:25 2016

[MD settings] set default fixed font size

This CL fixes a bug where the default fixed font size is not saved in
the prefs.

BUG= 612535 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2066123002
Cr-Commit-Position: refs/heads/master@{#400070}

[modify] https://crrev.com/b0a3e2fd2fd68600528faa0796120fd395219437/chrome/browser/extensions/api/settings_private/prefs_util.cc
[modify] https://crrev.com/b0a3e2fd2fd68600528faa0796120fd395219437/chrome/browser/resources/settings/appearance_page/appearance_fonts_page.html

Status: Fixed (was: Started)

Sign in to add a comment