New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 612533 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: May 2016
Cc:
skare@chromium.org
isherman@chromium.org
asvitk...@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Expired studies incorrectly evaluate feature associations

Project Member Reported by asvitk...@chromium.org, May 17 2016 
Expired studies incorrectly evaluate feature associations
Project Member

Comment 1 by bugdroid1@chromium.org, May 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7141106df26d989fa4a37bee08a0353fa84901ab

commit 7141106df26d989fa4a37bee08a0353fa84901ab
Author: asvitkine <asvitkine@chromium.org>
Date: Tue May 17 20:09:44 2016

Expired studies should not enable features.

Previosuly, the "chosen group" was queried before an
expired study was marked as enabled, which resulted in
the wrong features being activated/de-activated for
disabled studies (i.e. it would apply the ones based
on the dice roll, rather then the default group ones).

This CL fixes that and adds a test.

BUG= 612533 

Review-Url: https://codereview.chromium.org/1986073003
Cr-Commit-Position: refs/heads/master@{#394202}

[modify] https://crrev.com/7141106df26d989fa4a37bee08a0353fa84901ab/components/variations/variations_seed_processor.cc
[modify] https://crrev.com/7141106df26d989fa4a37bee08a0353fa84901ab/components/variations/variations_seed_processor_unittest.cc

Comment 2 by asvitk...@chromium.org, May 17 2016

Status: Fixed (was: Started)
►

Sign in to add a comment