New issue
Advanced search Search tips

Issue 612528 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug

Blocking:
issue 431177



Sign in to add a comment

gn:cc_blink_unittests missing on mac

Project Member Reported by thakis@chromium.org, May 17 2016

Issue description

https://code.google.com/p/chromium/codesearch#chromium/src/cc/blink/BUILD.gn&q=cc_blink_unittests&sq=package:chromium&type=cs&l=52

# GYP version: //cc/blink/cc_blink_tests.gyp:cc_blink_unittests
# TODO(GYP): make linking work on the mac.
if (!is_mac) {
  test("cc_blink_unittests")
 

Comment 1 by thakis@chromium.org, May 17 2016

Status: Started (was: Untriaged)
https://codereview.chromium.org/1988713007/
Project Member

Comment 2 by bugdroid1@chromium.org, May 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e87a03db441fbf78968898ba0078aef67d6b62a8

commit e87a03db441fbf78968898ba0078aef67d6b62a8
Author: thakis <thakis@chromium.org>
Date: Tue May 17 22:37:49 2016

gn/mac: Build cc_blink_unittests

This seems to Just Work.

BUG= 612528 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/1988713007
Cr-Commit-Position: refs/heads/master@{#394248}

[modify] https://crrev.com/e87a03db441fbf78968898ba0078aef67d6b62a8/cc/blink/BUILD.gn

Comment 3 by thakis@chromium.org, May 18 2016

Owner: thakis@chromium.org
Status: Fixed (was: Started)

Sign in to add a comment