New issue
Advanced search Search tips

Issue 612511 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Update comments for FormatOriginForSecurityDisplay() function

Project Member Reported by juncai@chromium.org, May 17 2016

Issue description

The comments for FormatOriginForSecurityDisplay() function needs to be more descriptive.
 

Comment 1 by juncai@chromium.org, May 17 2016

Also need to update the comments at:
//components/url_formatter/OWNERS to include FormatOriginForSecurityDisplay() function.

Comment 2 by juncai@chromium.org, Jun 17 2016

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72b749dad66cb8f0f4a3247e076ebdce0330e4de

commit 72b749dad66cb8f0f4a3247e076ebdce0330e4de
Author: juncai <juncai@chromium.org>
Date: Fri Jun 17 21:19:38 2016

Update FormatOriginForSecurityDisplay() comments

This patch updated comments for FormatOriginForSecurityDisplay() function.
Also updated //components/url_formatter/OWNERS to
include FormatOriginForSecurityDisplay() function.

BUG= 612511 

Review-Url: https://codereview.chromium.org/2072863002
Cr-Commit-Position: refs/heads/master@{#400505}

[modify] https://crrev.com/72b749dad66cb8f0f4a3247e076ebdce0330e4de/components/url_formatter/OWNERS
[modify] https://crrev.com/72b749dad66cb8f0f4a3247e076ebdce0330e4de/components/url_formatter/elide_url.h

Comment 4 by juncai@chromium.org, Jun 17 2016

Status: Fixed (was: Started)

Sign in to add a comment