CM API - Account Chooser with Sign in button for single account (mobile) |
||||||
Issue descriptionProvide "Sign in" button when there's only one account listed on the chooser.
,
Jul 7 2016
Screenshot
,
Jul 7 2016
Is there a spec for this? We're getting increasingly inconsistent with button formatting. Some primary buttons (e.g. SIGN IN or OK) have blue backgrounds and white text, while this one has blue text and no background.
,
Jul 7 2016
Er I guess the spec is in comment #2. Hwi: are you sure about the primary button formatting here?
,
Jul 7 2016
c4: yes dfalcantara@ - we've been using the blue bg button when it needs to more stand out from the surroundings. On dialogs, the no bg button works fine.
,
Jul 7 2016
Hokay, thanks for clarification. lgtmed the CL.
,
Jul 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae78f7fefdeea8deb1a14a98626909628da6a36b commit ae78f7fefdeea8deb1a14a98626909628da6a36b Author: melandory <melandory@chromium.org> Date: Fri Jul 08 14:05:53 2016 [CM API] Account Chooser with Sign in button for single account BUG= 612504 Review-Url: https://codereview.chromium.org/2126353003 Cr-Commit-Position: refs/heads/master@{#404350} [modify] https://crrev.com/ae78f7fefdeea8deb1a14a98626909628da6a36b/chrome/android/java/src/org/chromium/chrome/browser/password_manager/AccountChooserDialog.java [modify] https://crrev.com/ae78f7fefdeea8deb1a14a98626909628da6a36b/chrome/browser/password_manager/account_chooser_dialog_android.cc [modify] https://crrev.com/ae78f7fefdeea8deb1a14a98626909628da6a36b/chrome/browser/password_manager/account_chooser_dialog_android.h [add] https://crrev.com/ae78f7fefdeea8deb1a14a98626909628da6a36b/chrome/browser/password_manager/account_chooser_dialog_android_unittest.cc [modify] https://crrev.com/ae78f7fefdeea8deb1a14a98626909628da6a36b/chrome/chrome_tests_unit.gypi
,
Jul 8 2016
,
Jul 8 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Jul 12 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 16 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9a39c8f88cea1ea694241ae094c83101ed469f28 commit 9a39c8f88cea1ea694241ae094c83101ed469f28 Author: Tatiana Gornak <melandory@chromium.org> Date: Tue Jul 19 10:18:23 2016 [CM API] Account Chooser with Sign in button for single account BUG= 612504 Review-Url: https://codereview.chromium.org/2126353003 Cr-Commit-Position: refs/heads/master@{#404350} (cherry picked from commit ae78f7fefdeea8deb1a14a98626909628da6a36b) Review URL: https://codereview.chromium.org/2164573002 . Cr-Commit-Position: refs/branch-heads/2785@{#214} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/9a39c8f88cea1ea694241ae094c83101ed469f28/chrome/android/java/src/org/chromium/chrome/browser/password_manager/AccountChooserDialog.java [modify] https://crrev.com/9a39c8f88cea1ea694241ae094c83101ed469f28/chrome/browser/password_manager/account_chooser_dialog_android.cc [modify] https://crrev.com/9a39c8f88cea1ea694241ae094c83101ed469f28/chrome/browser/password_manager/account_chooser_dialog_android.h [add] https://crrev.com/9a39c8f88cea1ea694241ae094c83101ed469f28/chrome/browser/password_manager/account_chooser_dialog_android_unittest.cc [modify] https://crrev.com/9a39c8f88cea1ea694241ae094c83101ed469f28/chrome/chrome_tests_unit.gypi
,
Jul 19 2016
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by hwi@chromium.org
, May 17 201673.0 KB
73.0 KB View Download