New issue
Advanced search Search tips

Issue 612501 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Feature



Sign in to add a comment

CM API - Account Chooser with Sign in button for single account

Project Member Reported by hwi@chromium.org, May 17 2016

Issue description

Provide "Sign in" button when there's only one account listed on the chooser. 
 
ac-singleaccount.png
47.6 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, May 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d69c3927d11b6fccbbecd34632b8f2ed34e19108

commit d69c3927d11b6fccbbecd34632b8f2ed34e19108
Author: vasilii <vasilii@chromium.org>
Date: Thu May 19 12:05:09 2016

Add "Sign In" button to the account chooser on Mac.

BUG= 612501 

Review-Url: https://codereview.chromium.org/1992633003
Cr-Commit-Position: refs/heads/master@{#394744}

[modify] https://crrev.com/d69c3927d11b6fccbbecd34632b8f2ed34e19108/chrome/app/generated_resources.grd
[modify] https://crrev.com/d69c3927d11b6fccbbecd34632b8f2ed34e19108/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/d69c3927d11b6fccbbecd34632b8f2ed34e19108/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.h
[modify] https://crrev.com/d69c3927d11b6fccbbecd34632b8f2ed34e19108/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.mm
[modify] https://crrev.com/d69c3927d11b6fccbbecd34632b8f2ed34e19108/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm
[modify] https://crrev.com/d69c3927d11b6fccbbecd34632b8f2ed34e19108/chrome/browser/ui/cocoa/passwords/autosignin_prompt_view_controller.mm
[modify] https://crrev.com/d69c3927d11b6fccbbecd34632b8f2ed34e19108/chrome/browser/ui/cocoa/passwords/autosignin_prompt_view_controller_unittest.mm
[modify] https://crrev.com/d69c3927d11b6fccbbecd34632b8f2ed34e19108/chrome/browser/ui/cocoa/passwords/passwords_bubble_utils.h
[modify] https://crrev.com/d69c3927d11b6fccbbecd34632b8f2ed34e19108/chrome/browser/ui/cocoa/passwords/passwords_bubble_utils.mm
[modify] https://crrev.com/d69c3927d11b6fccbbecd34632b8f2ed34e19108/chrome/browser/ui/passwords/password_dialog_controller.h
[modify] https://crrev.com/d69c3927d11b6fccbbecd34632b8f2ed34e19108/chrome/browser/ui/passwords/password_dialog_controller_impl.cc
[modify] https://crrev.com/d69c3927d11b6fccbbecd34632b8f2ed34e19108/chrome/browser/ui/passwords/password_dialog_controller_impl.h
[modify] https://crrev.com/d69c3927d11b6fccbbecd34632b8f2ed34e19108/chrome/browser/ui/passwords/password_dialog_controller_impl_unittest.cc
[add] https://crrev.com/d69c3927d11b6fccbbecd34632b8f2ed34e19108/chrome/browser/ui/passwords/password_dialog_controller_mock.cc
[add] https://crrev.com/d69c3927d11b6fccbbecd34632b8f2ed34e19108/chrome/browser/ui/passwords/password_dialog_controller_mock.h
[modify] https://crrev.com/d69c3927d11b6fccbbecd34632b8f2ed34e19108/chrome/chrome_tests_unit.gypi
[modify] https://crrev.com/d69c3927d11b6fccbbecd34632b8f2ed34e19108/components/password_manager/core/browser/password_manager_metrics_util.h
[modify] https://crrev.com/d69c3927d11b6fccbbecd34632b8f2ed34e19108/tools/metrics/histograms/histograms.xml

Project Member

Comment 3 by bugdroid1@chromium.org, May 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09230ce8c499ed846ac7f0a1b5ca169cb18cbcec

commit 09230ce8c499ed846ac7f0a1b5ca169cb18cbcec
Author: vasilii <vasilii@chromium.org>
Date: Mon May 23 15:09:13 2016

Add a test for the "Sign in" button in the account chooser on Views.

BUG= 612501 

Review-Url: https://codereview.chromium.org/1998993003
Cr-Commit-Position: refs/heads/master@{#395326}

[modify] https://crrev.com/09230ce8c499ed846ac7f0a1b5ca169cb18cbcec/chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc

Labels: Merge-Request-52 M-52
I'd like to merge r395556. It just adds more UMA data.

Comment 6 by tin...@google.com, May 25 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Status: Fixed (was: Assigned)

Sign in to add a comment