Provide "Sign in" button when there's only one account listed on the chooser.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d69c3927d11b6fccbbecd34632b8f2ed34e19108 commit d69c3927d11b6fccbbecd34632b8f2ed34e19108 Author: vasilii <vasilii@chromium.org> Date: Thu May 19 12:05:09 2016 Add "Sign In" button to the account chooser on Mac. BUG= 612501 Review-Url: https://codereview.chromium.org/1992633003 Cr-Commit-Position: refs/heads/master@{#394744} [modify] https://crrev.com/d69c3927d11b6fccbbecd34632b8f2ed34e19108/chrome/app/generated_resources.grd [modify] https://crrev.com/d69c3927d11b6fccbbecd34632b8f2ed34e19108/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/d69c3927d11b6fccbbecd34632b8f2ed34e19108/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.h [modify] https://crrev.com/d69c3927d11b6fccbbecd34632b8f2ed34e19108/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.mm [modify] https://crrev.com/d69c3927d11b6fccbbecd34632b8f2ed34e19108/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm [modify] https://crrev.com/d69c3927d11b6fccbbecd34632b8f2ed34e19108/chrome/browser/ui/cocoa/passwords/autosignin_prompt_view_controller.mm [modify] https://crrev.com/d69c3927d11b6fccbbecd34632b8f2ed34e19108/chrome/browser/ui/cocoa/passwords/autosignin_prompt_view_controller_unittest.mm [modify] https://crrev.com/d69c3927d11b6fccbbecd34632b8f2ed34e19108/chrome/browser/ui/cocoa/passwords/passwords_bubble_utils.h [modify] https://crrev.com/d69c3927d11b6fccbbecd34632b8f2ed34e19108/chrome/browser/ui/cocoa/passwords/passwords_bubble_utils.mm [modify] https://crrev.com/d69c3927d11b6fccbbecd34632b8f2ed34e19108/chrome/browser/ui/passwords/password_dialog_controller.h [modify] https://crrev.com/d69c3927d11b6fccbbecd34632b8f2ed34e19108/chrome/browser/ui/passwords/password_dialog_controller_impl.cc [modify] https://crrev.com/d69c3927d11b6fccbbecd34632b8f2ed34e19108/chrome/browser/ui/passwords/password_dialog_controller_impl.h [modify] https://crrev.com/d69c3927d11b6fccbbecd34632b8f2ed34e19108/chrome/browser/ui/passwords/password_dialog_controller_impl_unittest.cc [add] https://crrev.com/d69c3927d11b6fccbbecd34632b8f2ed34e19108/chrome/browser/ui/passwords/password_dialog_controller_mock.cc [add] https://crrev.com/d69c3927d11b6fccbbecd34632b8f2ed34e19108/chrome/browser/ui/passwords/password_dialog_controller_mock.h [modify] https://crrev.com/d69c3927d11b6fccbbecd34632b8f2ed34e19108/chrome/chrome_tests_unit.gypi [modify] https://crrev.com/d69c3927d11b6fccbbecd34632b8f2ed34e19108/components/password_manager/core/browser/password_manager_metrics_util.h [modify] https://crrev.com/d69c3927d11b6fccbbecd34632b8f2ed34e19108/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e9bd3a48d2f22859543a1a80209ed6c56d8fa3c commit 3e9bd3a48d2f22859543a1a80209ed6c56d8fa3c Author: vasilii <vasilii@chromium.org> Date: Thu May 19 18:51:16 2016 Add "Sign In" button to the account chooser on Aura. BUG= 612501 Review-Url: https://codereview.chromium.org/1990213003 Cr-Commit-Position: refs/heads/master@{#394825} [modify] https://crrev.com/3e9bd3a48d2f22859543a1a80209ed6c56d8fa3c/chrome/browser/ui/views/passwords/account_chooser_dialog_view.cc [modify] https://crrev.com/3e9bd3a48d2f22859543a1a80209ed6c56d8fa3c/chrome/browser/ui/views/passwords/account_chooser_dialog_view.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09230ce8c499ed846ac7f0a1b5ca169cb18cbcec commit 09230ce8c499ed846ac7f0a1b5ca169cb18cbcec Author: vasilii <vasilii@chromium.org> Date: Mon May 23 15:09:13 2016 Add a test for the "Sign in" button in the account chooser on Views. BUG= 612501 Review-Url: https://codereview.chromium.org/1998993003 Cr-Commit-Position: refs/heads/master@{#395326} [modify] https://crrev.com/09230ce8c499ed846ac7f0a1b5ca169cb18cbcec/chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d7185e01e17811c2e0beafdb88bcc0ad0d286e57 commit d7185e01e17811c2e0beafdb88bcc0ad0d286e57 Author: vasilii <vasilii@chromium.org> Date: Tue May 24 09:28:42 2016 Add separate UMA histograms for the account chooser with 1/many accounts. BUG= 612501 Review-Url: https://codereview.chromium.org/2002643002 Cr-Commit-Position: refs/heads/master@{#395556} [modify] https://crrev.com/d7185e01e17811c2e0beafdb88bcc0ad0d286e57/chrome/browser/ui/passwords/password_dialog_controller_impl.cc [modify] https://crrev.com/d7185e01e17811c2e0beafdb88bcc0ad0d286e57/chrome/browser/ui/passwords/password_dialog_controller_impl_unittest.cc [modify] https://crrev.com/d7185e01e17811c2e0beafdb88bcc0ad0d286e57/components/password_manager/core/browser/password_manager_metrics_util.cc [modify] https://crrev.com/d7185e01e17811c2e0beafdb88bcc0ad0d286e57/components/password_manager/core/browser/password_manager_metrics_util.h [modify] https://crrev.com/d7185e01e17811c2e0beafdb88bcc0ad0d286e57/tools/metrics/histograms/histograms.xml
I'd like to merge r395556. It just adds more UMA data.
Your change meets the bar and is auto-approved for M52 (branch: 2743)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e99986ea903de6fb2e19f1a3f4f84182b0f0e5f7 commit e99986ea903de6fb2e19f1a3f4f84182b0f0e5f7 Author: Vasilii Sukhanov <vasilii@google.com> Date: Wed May 25 09:22:06 2016 Add separate UMA histograms for the account chooser with 1/many accounts. BUG= 612501 Review-Url: https://codereview.chromium.org/2002643002 Cr-Commit-Position: refs/heads/master@{#395556} (cherry picked from commit d7185e01e17811c2e0beafdb88bcc0ad0d286e57) Review URL: https://codereview.chromium.org/2012723002 . Cr-Commit-Position: refs/branch-heads/2743@{#49} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/e99986ea903de6fb2e19f1a3f4f84182b0f0e5f7/chrome/browser/ui/passwords/password_dialog_controller_impl.cc [modify] https://crrev.com/e99986ea903de6fb2e19f1a3f4f84182b0f0e5f7/chrome/browser/ui/passwords/password_dialog_controller_impl_unittest.cc [modify] https://crrev.com/e99986ea903de6fb2e19f1a3f4f84182b0f0e5f7/components/password_manager/core/browser/password_manager_metrics_util.cc [modify] https://crrev.com/e99986ea903de6fb2e19f1a3f4f84182b0f0e5f7/components/password_manager/core/browser/password_manager_metrics_util.h [modify] https://crrev.com/e99986ea903de6fb2e19f1a3f4f84182b0f0e5f7/tools/metrics/histograms/histograms.xml
Comment 1 by bugdroid1@chromium.org
, May 19 2016