Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 6125 [edit search engines] after hitting right ctrl+shift, can't change insersion point with the mouse
Starred by 2 users Project Member Reported by xji@chromium.org, Jan 8 2009 Back to list
Status: Verified
Owner: xji@chromium.org
Closed: Apr 2009
Cc: xlyuan@chromium.org, jeremy@chromium.org, hbono@chromium.org, xji@chromium.org, js...@chromium.org, idana@chromium.org
Components:
OS: All
Pri: 2
Type: Bug
RTL

Restricted
  • Only users with Commit permission may comment.


Sign in to add a comment
<see b\1329600>

What steps will reproduce the problem?
1) Open Chrome, Hebrew UI
2) right click on the omni bar, and select "edit search engines"
3) select any search engine and click "edit"
4) hit right + ctrl shift, in the name or keyword area, to set the box to
RTL mode
5) try to change the location of the insertion point by clicking with the
mouse at the middle or the end of the text


What is the expected output? What do you see instead?
actual result:
after hitting right ctrl shift, insertion point from the mouse is always
the rightmost one

expected result:
user should be able to click anywhere to change insertion point

Please use labels and text to provide additional information.
* moving the insertion point with the keyboard works as expected
* hitting left ctrl +shift (for LTR) does not cause a similar problem
* Wordpad works ok for the above keyboard/mouse movement.



 
Comment 1 by xji@chromium.org, Jan 8 2009
Labels: I18N RTL
Comment 2 by xji@chromium.org, Jan 22 2009
Status: Assigned
Comment 3 by prog...@gmail.com, Apr 15 2009
very much like Issue 8686
Comment 4 by xji@chromium.org, Apr 15 2009
progame, yes, you are right.
they are both text field, which is CRichEditCtrl, and there is problem in cursor 
positioning and cursor selection in the presence of RTL characters.
Comment 5 by xji@chromium.org, Apr 21 2009
Status: Fixed
review URL:
http://codereview.chromium.org/86003

fixed in r14158
Comment 6 by bugdro...@gmail.com, Apr 22 2009
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=14158 

------------------------------------------------------------------------
r14158 | xji@chromium.org | 2009-04-21 16:44:02 -0700 (Tue, 21 Apr 2009) | 13 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc?r1=14158&r2=14157
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/views/controls/text_field.cc?r1=14158&r2=14157

This CL fixes 
issue 6125 - [edit search engines] after hitting right ctrl+shift, can't change insertion point with the mouse
and 
issue 8686 - RTL: Can't select RTL text from Chrome UI boxes

The problem is cursor positioning and cursor selection in CRichEditCtrl in RTL layout. (cursor positioning is fine even for RTL characters in LTR layout, but cursor positioning is not working even for LTR characters in RTL layout).

The fix is correctly calculation of input boundary in ClipXCoordToVisibleText(), and the fix is mostly part of Nick Carter's un-committed fix in  https://svn.corp.google.com/review/chrome/desc/cb/ncarter/rtl_richedit_fixes@50605

BUG= 6125 
BUG= 8686 

Review URL: http://codereview.chromium.org/86003
------------------------------------------------------------------------

Comment 7 by xlyuan@chromium.org, Apr 23 2009
Status: Verified
Verified on 2.0.176.0 (Official Build ), fixed.
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=15136 

------------------------------------------------------------------------
r15136 | mal@chromium.org | 2009-05-01 23:47:30 -0700 (Fri, 01 May 2009) | 16 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/172/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc?r1=15136&r2=15135
   M http://src.chromium.org/viewvc/chrome/branches/172/src/chrome/views/controls/text_field.cc?r1=15136&r2=15135

Merge r14158.

This CL fixes 
issue 6125 - [edit search engines] after hitting right ctrl+shift, can't change insertion point with the mouse
and 
issue 8686 - RTL: Can't select RTL text from Chrome UI boxes

The problem is cursor positioning and cursor selection in CRichEditCtrl in RTL layout. (cursor positioning is fine even for RTL characters in LTR layout, but cursor positioning is not working even for LTR characters in RTL layout).

The fix is correctly calculation of input boundary in ClipXCoordToVisibleText(), and the fix is mostly part of Nick Carter's un-committed fix in  https://svn.corp.google.com/review/chrome/desc/cb/ncarter/rtl_richedit_fixes@50605

BUG= 6125 
BUG= 8686 
TBR= xji

Review URL: http://codereview.chromium.org/100296
------------------------------------------------------------------------

Labels: -I18N bulkmove Feature-I18N
&lt;see b\1329600&gt;

What steps will reproduce the problem?
1) Open Chrome, Hebrew UI
2) right click on the omni bar, and select &quot;edit search engines&quot;
3) select any search engine and click &quot;edit&quot;
4) hit right + ctrl shift, in the name or keyword area, to set the box to
RTL mode
5) try to change the location of the insertion point by clicking with the
mouse at the middle or the end of the text


What is the expected output? What do you see instead?
actual result:
after hitting right ctrl shift, insertion point from the mouse is always
the rightmost one

expected result:
user should be able to click anywhere to change insertion point

Please use labels and text to provide additional information.
* moving the insertion point with the keyboard works as expected
* hitting left ctrl +shift (for LTR) does not cause a similar problem
* Wordpad works ok for the above keyboard/mouse movement.
Project Member Comment 10 by bugdroid1@chromium.org, Oct 13 2012
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member Comment 11 by bugdroid1@chromium.org, Mar 11 2013
Labels: -Feature-I18N Cr-UI-I18N
Project Member Comment 12 by bugdroid1@chromium.org, Mar 20 2013
Labels: -Cr-UI-I18N Cr-UI-Internationalization
Sign in to add a comment