Blimp presubmit check for unit tests |
||||
Issue descriptionThe presubmit script in the Blimp directory should be altered so that: 1. New code files have corresponding unit test files. 2. (Maybe?) Changes to existing files have changes to corresponding test files. I'm still not sure on the exact specification: if there are any exceptions to these rules, whether rule #2 is something we want, etc.
,
May 25 2016
Removing Blocking tag, since this is closely-related-to issue 543268 but does not block it. :)
,
Jun 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/18b2942b8f1890e8307cde644b448830a7a89411 commit 18b2942b8f1890e8307cde644b448830a7a89411 Author: bgoldman <bgoldman@chromium.org> Date: Fri Jun 03 19:17:10 2016 Blimp presubmit to check for unit tests on new .cc files. BUG= 612498 ,543268 TEST=Added the files blimp/science.cc, blimp/science_unittest.cc, blimp/science2.cc, blimp/science2_unittest.cc, blimp/science_browsertest.cc, and science.cc. Verified that blimp/science.cc was flagged for missing unit tests. Review-Url: https://codereview.chromium.org/2005023002 Cr-Commit-Position: refs/heads/master@{#397773} [modify] https://crrev.com/18b2942b8f1890e8307cde644b448830a7a89411/blimp/PRESUBMIT.py
,
Jun 7 2016
,
Dec 9 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by w...@chromium.org
, May 24 2016