RTL: Misplaced separator in Zoom display in browser's main (app) menu |
|||
Issue descriptionVersion: 52.0.2724.0 OS: Chrome, probably others What steps will reproduce the problem? (1) Switch browser to RTL language (e.g. Hebrew) (2) Open main menu What is the expected output? What do you see instead? In RTL, the Zoom row in the menu should be formatted [ ] | + 100% - | Zoom Instead, it is [ ] | + 100% | - Zoom (see attached screenshot).
,
May 18 2016
This bug is also affecting the Edit row (see screenshot). In multi-button rows, separators are drawn as left button edges. These aren't being mirrored in RTL, except for the Full Screen button (because it's an image button).
,
May 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7a1a61e269ba16a335eab35a6eab3e1ae1b30b6 commit e7a1a61e269ba16a335eab35a6eab3e1ae1b30b6 Author: glevin <glevin@chromium.org> Date: Thu May 19 20:44:27 2016 Fix app menu borders for RTL BUG= 612485 TEST=Set to RTL language, open main browser (app) menu, observe that button separators in Zoom and Edit rows are properly placed, e.g. [ ] | + 100% - | Zoom Paste | Copy | Cut | Edit Review-Url: https://codereview.chromium.org/1988983004 Cr-Commit-Position: refs/heads/master@{#394850} [modify] https://crrev.com/e7a1a61e269ba16a335eab35a6eab3e1ae1b30b6/chrome/browser/ui/views/toolbar/app_menu.cc
,
May 23 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by glevin@chromium.org
, May 17 2016