New issue
Advanced search Search tips

Issue 612483 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

OfflineAudioContext doesn't update channelCount and maxChannelCount

Project Member Reported by rtoy@chromium.org, May 17 2016

Issue description

OS: All

What steps will reproduce the problem?
(1) c = new OfflineAudioContext(18, 44, 48000)
(2) c.destination.channelCount is 2
(3) c.destination.maxChannelCount is 0.

What is the expected output?

I was expecting both channelCount and maxChannelCount to be 18.

Edge produces the same results as Chrome.  Firefox has channelCount = maxChannelCount = 18.

I think Firefox is right. 
 

Comment 1 by rtoy@chromium.org, May 24 2016

Owner: rtoy@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, May 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9beda74dbeb23068d79e76a2706cfcb65c8c5e6a

commit 9beda74dbeb23068d79e76a2706cfcb65c8c5e6a
Author: rtoy <rtoy@chromium.org>
Date: Thu May 26 03:53:23 2016

Set channelCount and maxChannelCount correctly for OfflineAudioContext.

Set the channelCount and maxChannelCount to the number of
channels specified when creating the offline context.

Also, we were not correctly setting the channelCountMode to
"explicit", as required by the spec.

BUG= 612483 
TEST=offlineaudiocontext-constructor.html

Review-Url: https://codereview.chromium.org/2013623002
Cr-Commit-Position: refs/heads/master@{#396110}

[modify] https://crrev.com/9beda74dbeb23068d79e76a2706cfcb65c8c5e6a/third_party/WebKit/LayoutTests/webaudio/offlineaudiocontext-constructor-expected.txt
[modify] https://crrev.com/9beda74dbeb23068d79e76a2706cfcb65c8c5e6a/third_party/WebKit/LayoutTests/webaudio/offlineaudiocontext-constructor.html
[modify] https://crrev.com/9beda74dbeb23068d79e76a2706cfcb65c8c5e6a/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp
[modify] https://crrev.com/9beda74dbeb23068d79e76a2706cfcb65c8c5e6a/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.h

Comment 3 by rtoy@chromium.org, May 27 2016

Status: Fixed (was: Started)

Sign in to add a comment