New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 612443 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

preload downloads resources when the media attribute does not match

Project Member Reported by y...@yoav.ws, May 17 2016

Issue description

Version: M52
OS: all

What steps will reproduce the problem?
(1) https://bulledev.com
(2) Open network inspector
(3) See both bulledev-logo-{small,big}.png get downloaded

What is the expected output?

Only the matching resource should be downloaded.

What do you see instead?

Both are.

Please use labels and text to provide additional information.

 
Components: -Blink Blink>CSS

Comment 2 by y...@yoav.ws, May 18 2016

Components: -Blink>CSS
This is not a problem with the media attribute matching logic, and therefore, not really CSS related. Removing the label.
Project Member

Comment 4 by bugdroid1@chromium.org, May 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd9e1daef514feb5f0b1e0788f57b68b4adeec84

commit dd9e1daef514feb5f0b1e0788f57b68b4adeec84
Author: yoav <yoav@yoav.ws>
Date: Fri May 20 00:40:58 2016

Fix preloadScanner double download issue with link preload and media

The preloadScanner was not checking the media attribute when preloading
<link rel=preload> based resources, due to a bug that bypassed that logic for preloads.

This CL fixes that and adds unit tests to make sure it stays fixed.

BUG= 612443 

Review-Url: https://codereview.chromium.org/1982263002
Cr-Commit-Position: refs/heads/master@{#394932}

[modify] https://crrev.com/dd9e1daef514feb5f0b1e0788f57b68b4adeec84/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp
[modify] https://crrev.com/dd9e1daef514feb5f0b1e0788f57b68b4adeec84/third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerTest.cpp

Comment 5 by y...@yoav.ws, May 30 2016

Status: Fixed (was: Started)
This issue is fixed AFAICT. Let me know if you see otherwise.
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d40e4273ef4e91ead360b399a87702a5a1d06d7

commit 0d40e4273ef4e91ead360b399a87702a5a1d06d7
Author: Eric Karl <ericrk@chromium.org>
Date: Mon Oct 09 21:11:32 2017

Low end check should be <= 512MB, not just <

The current check misses devices with exactly 512MB.

Bug:  612443 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: If2c0866797f173c57d9e716ae277ef58e3e06e0b
Reviewed-on: https://chromium-review.googlesource.com/706952
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507488}
[modify] https://crrev.com/0d40e4273ef4e91ead360b399a87702a5a1d06d7/gpu/command_buffer/client/shared_memory_limits.h

Labels: Needs-Feedback
Tried this issue on latest Canary 63.0.3238.0 on Mac OS 10.12.6 by following the below steps,

1. Launched Chrome and navigated to https://bulledev.com site.
2. Opened Devtools -> Network and reloaded the page.
could observe that https://bulledev.com/wp-content/uploads/2016/05/bulledev-logo-small.png is getting downloaded.

Please find the attached screen shot for reference.

yoav@ Can you please check and confirm if the fix is working as intended?

Thanks..
612443.png
820 KB View Download

Sign in to add a comment