The following tests fails on Win7 debug bot: media/audio-controls-rendering.html media/audio-repaint.html media/controls-after-reload.html media/controls-layout-direction.html media/controls-strict.html media/controls-styling-strict.html media/controls-styling.html media/controls-without-preload.html media/media-controls-clone.html media/media-document-audio-repaint.html media/video-controls-rendering.html media/video-controls-with-cast-rendering.html media/video-display-toggle.html media/video-empty-source.html media/video-no-audio.html media/video-paint-invalidation.html Dashboard: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=media%2Faudio-controls-rendering.html%0Amedia%2Faudio-repaint.html%0Amedia%2Fcontrols-after-reload.html%0Amedia%2Fcontrols-layout-direction.html%0Amedia%2Fcontrols-strict.html%0Amedia%2Fcontrols-styling-strict.html%0Amedia%2Fcontrols-styling.html%0Amedia%2Fcontrols-without-preload.html%0Amedia%2Fmedia-controls-clone.html%0Amedia%2Fmedia-document-audio-repaint.html%0Amedia%2Fvideo-controls-rendering.html%0Amedia%2Fvideo-controls-with-cast-rendering.html%0Amedia%2Fvideo-display-toggle.html%0Amedia%2Fvideo-empty-source.html%0Amedia%2Fvideo-no-audio.html%0Amedia%2Fvideo-paint-invalidation.html Suspected range by sheriff-o-matic: chromium 393568 : 393610 http://test-results.appspot.com/revision_range?start=393568&end=393610 Suspected CL: r393582 https://codereview.chromium.org/1974373002. Discussion is found in the comments. This is rebaseline for r393557 https://codereview.chromium.org/1811003002
Deprecating component:Blink>LayoutTests, to use label Test=Layout instead.
Frank, is it something you'll be looking into according to the code review? Seems like the tests are still failing.
there was another thread about this somewhere -- let me see if i can find it. TL;DR is that some of the win7 builders were using the wrong font.
Seems like the color of the timeline slider isn't correct. See the attached screenshots. Should we just update the test expectation png files?
i've started a run on win / mac / linux with these removed from TestExpectations. i'll verify if they're all still just needs-rebaseline.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7be4df953a97f8508fb8fe70679031ce3913b52e commit 7be4df953a97f8508fb8fe70679031ce3913b52e Author: liberato@chromium.org <liberato@chromium.org> Date: Mon Mar 12 16:57:24 2018 Rebaseline some video tests. This rebaselines the following tests, which had minor visual differences from their refs: media/audio-controls-rendering.html media/controls-after-reload.html media/controls-layout-direction.html media/controls-styling.html media/controls-styling-strict.html media/controls-without-preload.html media/media-controls-clone.html media/video-controls-rendering.html media/video-display-toggle.html media/video-empty-source.html Change-Id: Ic664381c7d16a85f94724d69fa65cb179ef5ea66 Bug: 612442 , 654477, 821025 Reviewed-on: https://chromium-review.googlesource.com/956227 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#542512} [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/audio-controls-rendering-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/audio-controls-rendering-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/controls-after-reload-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/controls-after-reload-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/controls-layout-direction-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/controls-strict-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/controls-strict-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-strict-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-strict-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/controls-without-preload-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/controls-without-preload-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/media-controls-clone-expected.png [delete] https://crrev.com/8d6af533c71cc145c291b7e62a02b5b2de197241/third_party/WebKit/LayoutTests/platform/linux/media/media-controls-clone-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/video-controls-rendering-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/video-controls-rendering-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/video-display-toggle-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/video-display-toggle-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/video-empty-source-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/video-empty-source-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/video-no-audio-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/video-no-audio-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/audio-controls-rendering-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/audio-controls-rendering-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/controls-after-reload-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/controls-after-reload-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/controls-layout-direction-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/controls-strict-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/controls-strict-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/controls-styling-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/controls-styling-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/controls-styling-strict-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/controls-styling-strict-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/controls-without-preload-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/controls-without-preload-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/media-controls-clone-expected.png [rename] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/media-controls-clone-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/video-controls-rendering-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/video-controls-rendering-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/video-display-toggle-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/video-display-toggle-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/video-empty-source-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/video-empty-source-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/video-no-audio-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/video-no-audio-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/audio-controls-rendering-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/audio-controls-rendering-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/controls-after-reload-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/controls-after-reload-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/controls-layout-direction-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/controls-strict-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/controls-strict-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/controls-styling-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/controls-styling-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/controls-styling-strict-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/controls-styling-strict-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/controls-without-preload-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/controls-without-preload-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/media-controls-clone-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/media-controls-clone-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/video-controls-rendering-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/video-controls-rendering-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/video-display-toggle-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/video-display-toggle-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/video-empty-source-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/video-empty-source-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/video-no-audio-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/video-no-audio-expected.txt [delete] https://crrev.com/8d6af533c71cc145c291b7e62a02b5b2de197241/third_party/WebKit/LayoutTests/platform/win7/media/controls-strict-expected.png [delete] https://crrev.com/8d6af533c71cc145c291b7e62a02b5b2de197241/third_party/WebKit/LayoutTests/platform/win7/media/controls-strict-expected.txt [copy] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win7/media/media-controls-clone-expected.txt [delete] https://crrev.com/8d6af533c71cc145c291b7e62a02b5b2de197241/third_party/WebKit/LayoutTests/platform/win7/media/video-no-audio-expected.png [delete] https://crrev.com/8d6af533c71cc145c291b7e62a02b5b2de197241/third_party/WebKit/LayoutTests/platform/win7/media/video-no-audio-expected.txt
Comment 1 by hirosh...@chromium.org
, May 17 2016