New issue
Advanced search Search tips

Issue 612437 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: May 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 0
Type: Bug



Sign in to add a comment

FirstRunMasterPrefsWithTrackedPreferencesInstance_FirstRunMasterPrefsWithTrackedPreferences.TrackedPreferencesSurviveFirstRun_0 etc broke in official builds on Windows

Project Member Reported by thakis@chromium.org, May 17 2016

Issue description

Started here: https://build.chromium.org/p/chromium.fyi/builders/CrWinClang64%20tester/builds/3239

FirstRunMasterPrefsWithTrackedPreferencesInstance/FirstRunMasterPrefsWithTrackedPreferences.TrackedPreferencesSurviveFirstRun/0 (run #1):
[ RUN      ] FirstRunMasterPrefsWithTrackedPreferencesInstance/FirstRunMasterPrefsWithTrackedPreferences.TrackedPreferencesSurviveFirstRun/0
[1560:1536:0516/194757:WARNING:chrome_browser_main_win.cc(420)] Command line too long for RegisterApplicationRestart
..\..\chromerowserirst_runirst_run_browsertest.cc(288): error: Value of: user_prefs->GetString(prefs::kHomePage)
  Actual: ""
Expected: "example.com"
..\..\chromerowserirst_runirst_run_browsertest.cc(289): error: Value of: user_prefs->GetBoolean(prefs::kHomePageIsNewTabPage)
  Actual: true
Expected: false
[  FAILED  ] FirstRunMasterPrefsWithTrackedPreferencesInstance/FirstRunMasterPrefsWithTrackedPreferences.TrackedPreferencesSurviveFirstRun/0, where GetParam() = "no_enforcement" (715 ms)

(looks like something is interpreting backslashes in path names incorrectly :-/)

That bot uses clang to build, but that's irrelevant. What's triggering the failure is that the bot does official builds. The "real" official builds will show this soon too.

This was likely triggered by https://codereview.chromium.org/1955773002 which added channel-specific code (which we never want to do btw: If something's ready to ship, we turn it on, and if it turns out to not be ready after all, we turn it off. We rely on the usual dev->beta->stable promotion. Explicit channel checks are an antipattern</aside>) and a field trial. This is probably doing the wrong thing in official builds somehow and might need a fix similar to https://codereview.chromium.org/1984583002
 

Comment 1 by varkha@chromium.org, May 17 2016

Cc: varkha@chromium.org

Comment 2 by thakis@chromium.org, May 17 2016

Cc: grunell@chromium.org
The Cl got reverted in https://codereview.chromium.org/1988733002, so this is currently fixed. Please check this works in official builds before relanding :-)
Regarding the channel-check being an anti-pattern, I was directed to do that by the PM and engineering team here, because we want feedback from real users sooner than we're ready to actually turn this on for beta and stable.
Status: WontFix (was: Assigned)
We're going to try to avoid relanding this CL.

Sign in to add a comment