New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 612424 link

Starred by 5 users
Status: Fixed
Owner: ----
Closed: Oct 15
Cc:
mstensho@chromium.org
futhark@chromium.org
robertma@chromium.org
█ davve@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

<form> in quirks mode should have margin-block-end: 1em

Reported by sim...@opera.com, May 17 2016 
See https://github.com/whatwg/html/pull/1252


A form in quirks mode has a block-end margin in Gecko/Edge; bottom margin in WebKit/Chromium.

<style>html { writing-mode: vertical-lr } </style>
x<form id=form></form>y
<script>
w('marginRight ' + getComputedStyle(form).marginRight);
w('marginBottom ' + getComputedStyle(form).marginBottom);
</script>

http://software.hixie.ch/utilities/js/live-dom-viewer/saved/4197

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/core/css/quirks.css&l=53

Comment 1 by davve@opera.com, Mar 28 2017

Cc: davve@chromium.org

Comment 2 by davve@opera.com, Mar 28 2017

Cc: -davve@opera.com
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 13 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by kojii@chromium.org, Apr 16 2018

Components: -Blink>Layout>WritingMode Blink>Forms

Comment 5 by tkent@chromium.org, Apr 16 2018

Labels: -Hotlist-Recharge-Cold Hotlist-Interop
Status: Available (was: Untriaged)
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fadc1d0a4cf3e09fe3806c03cc6ca38f3c02c418

commit fadc1d0a4cf3e09fe3806c03cc6ca38f3c02c418
Author: Boaz Sender <boaz@bocoup.com>
Date: Tue Oct 02 13:22:07 2018

Change default style sheet for forms in quirks mode in vertical writing-mode.

This change matches the behavior of Edge, Firefox and the spec:
https://html.spec.whatwg.org/multipage/rendering.html#flow-content-3

Bug:  612424 
Change-Id: Ib085301f732b259f2789d50b92aff9e12dcf4ae7
Reviewed-on: https://chromium-review.googlesource.com/1254724
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595815}
[modify] https://crrev.com/fadc1d0a4cf3e09fe3806c03cc6ca38f3c02c418/AUTHORS
[delete] https://crrev.com/4da02a0f4dcc4c366b1dddd17e3c32f63090dc09/third_party/WebKit/LayoutTests/external/wpt/html/rendering/non-replaced-elements/flow-content-0/form-margin-quirk-expected.txt
[modify] https://crrev.com/fadc1d0a4cf3e09fe3806c03cc6ca38f3c02c418/third_party/blink/renderer/core/css/quirks.css

Comment 7 by mstensho@chromium.org, Oct 14

Cc: futhark@chromium.org robertma@chromium.org mstensho@chromium.org
 Issue 891079  has been merged into this issue.

Comment 8 by futhark@chromium.org, Oct 15

Status: Fixed (was: Available)
Assuming this can be marked as fixed now.
►

Sign in to add a comment