New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 612422 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature



Sign in to add a comment

Log aborts before user interaction in Page Load Metrics

Project Member Reported by mushan@google.com, May 17 2016

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.94 Safari/537.36

Steps to reproduce the problem:
Log aborts before user interaction in Page Load Metrics

What is the expected behavior?
This allows us to track user aborts before any user interaction on the page. It'd better filter user aborts because of page quality / satisfaction from aborts because of page loads.

What went wrong?
This helps to user behavior analysis on user perceived latency.

Did this work before? N/A 

Chrome version: 50.0.2661.94  Channel: stable
OS Version: OS X 10.11.4
Flash Version: Shockwave Flash 21.0 r0
 
Cc: caseq@chromium.org
Is this about Timeline?

Comment 2 by mushan@google.com, May 18 2016

It's not relevant to Timeline. We're adding user input recognition which is outside rendering process.

Comment 3 by caseq@chromium.org, May 19 2016

Cc: -caseq@chromium.org
Components: -Platform>DevTools
Components: Metrics Blink>Loader
Labels: Needs-Feedback
mushan@Could you please provide sample file or code with actual and expected behavior screencast for further triaging the issue.

Comment 5 by mushan@google.com, May 20 2016

ssamanoori@ the CL is here: https://codereview.chromium.org/1984173002/

It's yet in a refine progress.
Project Member

Comment 6 by sheriffbot@chromium.org, May 20 2016

Labels: -Needs-Feedback Needs-Review
Owner: ssamanoori@chromium.org
Thank you for providing more feedback. Adding requester "ssamanoori@chromium.org" for another review and adding "Needs-Review" label for tracking.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Needs-Review
Owner: ----
Owner: bmcquade@chromium.org
Status: Started (was: Unconfirmed)
I can not assign mushan@ as an Owner because he isn't member of chromium, but let me change the status to Started because his change is under review.

Bryan: Can I assign you to this because you are reviewing his change?

When I wasn't a committer yet, I could assign myself to work on any bug to send a patch, IIRC. But current system seems to allow nothing for non-committers other than writing comments.
Project Member

Comment 9 by sheriffbot@chromium.org, Jun 2 2016

Labels: Hotlist-Google
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48cac60dbb50219805cc59e04ad50022c0288bc7

commit 48cac60dbb50219805cc59e04ad50022c0288bc7
Author: mushan <mushan@google.com>
Date: Mon Jun 06 21:21:53 2016

Log First User Interaction in Page Load Metrics

Learn more at: https://docs.google.com/document/d/1-OEDCDZPjWQHpmuGzaNxz9cRH4bEQXCo4x04ydazYtQ/edit

BUG= 612422 

Review-Url: https://codereview.chromium.org/1984173002
Cr-Commit-Position: refs/heads/master@{#398128}

[modify] https://crrev.com/48cac60dbb50219805cc59e04ad50022c0288bc7/blimp/engine/feature/engine_render_widget_feature_unittest.cc
[modify] https://crrev.com/48cac60dbb50219805cc59e04ad50022c0288bc7/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc
[modify] https://crrev.com/48cac60dbb50219805cc59e04ad50022c0288bc7/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h
[modify] https://crrev.com/48cac60dbb50219805cc59e04ad50022c0288bc7/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/48cac60dbb50219805cc59e04ad50022c0288bc7/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc
[modify] https://crrev.com/48cac60dbb50219805cc59e04ad50022c0288bc7/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h
[modify] https://crrev.com/48cac60dbb50219805cc59e04ad50022c0288bc7/components/page_load_metrics/browser/BUILD.gn
[modify] https://crrev.com/48cac60dbb50219805cc59e04ad50022c0288bc7/components/page_load_metrics/browser/DEPS
[modify] https://crrev.com/48cac60dbb50219805cc59e04ad50022c0288bc7/components/page_load_metrics/browser/metrics_web_contents_observer.cc
[modify] https://crrev.com/48cac60dbb50219805cc59e04ad50022c0288bc7/components/page_load_metrics/browser/metrics_web_contents_observer.h
[modify] https://crrev.com/48cac60dbb50219805cc59e04ad50022c0288bc7/components/page_load_metrics/browser/page_load_metrics_observer.h
[modify] https://crrev.com/48cac60dbb50219805cc59e04ad50022c0288bc7/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/48cac60dbb50219805cc59e04ad50022c0288bc7/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/48cac60dbb50219805cc59e04ad50022c0288bc7/content/public/browser/render_widget_host.h
[modify] https://crrev.com/48cac60dbb50219805cc59e04ad50022c0288bc7/tools/metrics/histograms/histograms.xml

Labels: Merge-Request-52

Comment 12 by tin...@google.com, Jun 13 2016

Labels: -Merge-Request-52 Merge-Review-52 Hotlist-Merge-Review
[Automated comment] DEPS changes referenced in bugdroid comments, needs manual review.
Labels: -OS-Mac OS-All
Labels: -Type-Bug Type-Feature
Project Member

Comment 15 by bugdroid1@chromium.org, Jun 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f3cb63668af8ed70776626da8ad10474a8768b4

commit 7f3cb63668af8ed70776626da8ad10474a8768b4
Author: mushan <mushan@chromium.org>
Date: Thu Jun 16 09:55:21 2016

Add missing enum label for InternalErrorLoadEvent

BUG= 612422 

Review-Url: https://codereview.chromium.org/2067163002
Cr-Commit-Position: refs/heads/master@{#400119}

[modify] https://crrev.com/7f3cb63668af8ed70776626da8ad10474a8768b4/tools/metrics/histograms/histograms.xml

Before we approve merge to M52, Could you please confirm whether this change is baked/verified in Canary and safe to merge?
Yes. The change requested for merge is the one landed in comment 10 on Jun 06 21:21:53 2016. It has baked in canary for the last 10 days. To clarify, we are not requesting a merge for the change in comment 15, just the change landed in comment 10.
Cc: pucchakayala@chromium.org
Labels: -Merge-Review-52 Merge-Approved-52
OK, thank you for the clarification.

Approving merge to M52 branch 2743 for ONLY Cl listed in comment #10. Please merge asap. Thank you.

Please request merge for CL listed in comment #15 once it is baked/verified in Canary if it is needed for M52.
Thanks guys!
Project Member

Comment 20 by sheriffbot@chromium.org, Jun 20 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Sorry I missed this. Performing the merge now.
Project Member

Comment 22 by bugdroid1@chromium.org, Jun 20 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0255e00f2f74012409472f6112556749e174e2d3

commit 0255e00f2f74012409472f6112556749e174e2d3
Author: csharrison <csharrison@chromium.org>
Date: Mon Jun 20 14:04:02 2016

Log First User Interaction in Page Load Metrics

Learn more at: https://docs.google.com/document/d/1-OEDCDZPjWQHpmuGzaNxz9cRH4bEQXCo4x04ydazYtQ/edit

BUG= 612422 
NOPRESUBMIT=true
NOTRY=true
TBR=bmcquade@chromium.org,asvitkine@chromium.org,jam@chromium.org

Review-Url: https://codereview.chromium.org/1984173002
Cr-Commit-Position: refs/heads/master@{#398128}
(cherry picked from commit 48cac60dbb50219805cc59e04ad50022c0288bc7)

Review-Url: https://codereview.chromium.org/2086453002
Cr-Commit-Position: refs/branch-heads/2743@{#395}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/0255e00f2f74012409472f6112556749e174e2d3/blimp/engine/feature/engine_render_widget_feature_unittest.cc
[modify] https://crrev.com/0255e00f2f74012409472f6112556749e174e2d3/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc
[modify] https://crrev.com/0255e00f2f74012409472f6112556749e174e2d3/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h
[modify] https://crrev.com/0255e00f2f74012409472f6112556749e174e2d3/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/0255e00f2f74012409472f6112556749e174e2d3/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc
[modify] https://crrev.com/0255e00f2f74012409472f6112556749e174e2d3/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h
[modify] https://crrev.com/0255e00f2f74012409472f6112556749e174e2d3/components/page_load_metrics/browser/BUILD.gn
[modify] https://crrev.com/0255e00f2f74012409472f6112556749e174e2d3/components/page_load_metrics/browser/DEPS
[modify] https://crrev.com/0255e00f2f74012409472f6112556749e174e2d3/components/page_load_metrics/browser/metrics_web_contents_observer.cc
[modify] https://crrev.com/0255e00f2f74012409472f6112556749e174e2d3/components/page_load_metrics/browser/metrics_web_contents_observer.h
[modify] https://crrev.com/0255e00f2f74012409472f6112556749e174e2d3/components/page_load_metrics/browser/page_load_metrics_observer.h
[modify] https://crrev.com/0255e00f2f74012409472f6112556749e174e2d3/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/0255e00f2f74012409472f6112556749e174e2d3/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/0255e00f2f74012409472f6112556749e174e2d3/content/public/browser/render_widget_host.h
[modify] https://crrev.com/0255e00f2f74012409472f6112556749e174e2d3/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)
Components: -Metrics Internals>Metrics

Sign in to add a comment