New issue
Advanced search Search tips

Issue 612414 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

CLs that were merged by CQ are not shown as closed by git-cl-status.

Project Member Reported by tandrii@chromium.org, May 17 2016

Issue description

Instead they remain at status (lgtm).

I reproduced it locally. Fix coming.
 
Project Member

Comment 2 by bugdroid1@chromium.org, May 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/5e1bf38efa541327843845f1988f3462e9235b64

commit 5e1bf38efa541327843845f1988f3462e9235b64
Author: tandrii@chromium.org <tandrii@chromium.org>
Date: Tue May 17 08:43:24 2016

Fix git cl status for MERGED CLs.

TBR=sergiyb@chromium.org
BUG= 612414 

Review-Url: https://codereview.chromium.org/1980323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300621 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/5e1bf38efa541327843845f1988f3462e9235b64/git_cl.py

Status: Fixed (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, May 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/15e7a090406d632d026a246b188e1cf645eea539

commit 15e7a090406d632d026a246b188e1cf645eea539
Author: recipe-roller@chromium.org <recipe-roller@chromium.org>
Date: Tue May 17 08:55:42 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

depot_tools:
  https://crrev.com/5e1bf38efa541327843845f1988f3462e9235b64 Fix git cl status for MERGED CLs. (tandrii@chromium.org)

R=sergiyb@chromium.org,tandrii@chromium.org
BUG= 612414 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/1986073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@300622 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/15e7a090406d632d026a246b188e1cf645eea539/infra/config/recipes.cfg

Project Member

Comment 5 by bugdroid1@chromium.org, May 17 2016

The following revision refers to this bug:
  http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=87968

------------------------------------------------------------------
r87968 | recipe-roller@chromium.org | 2016-05-17T09:03:25.649488Z

-----------------------------------------------------------------

Sign in to add a comment