Cursor is not seen in source file while opening from 'Quick source' option of dev tools.
Reported by
rk...@etouch.net,
May 17 2016
|
|||||||
Issue descriptionChrome version : 52.0.2739.0 (Official Build) e63177a3d418d078a8777d83f817c11e30831d7b-refs/heads/master@{#393996} 32/64 bit OS : Windows (7, 8, 10), Linux (14.04 LTS) and Mac OS X(10.10.5, 10.11.4) What steps will reproduce the problem? 1. Launch chrome,open devtools window. 2. Press Esc key, click on 'Iron icon' and select 'Quick source' option. 3. Press ctrl+p, select any source file and observe. Focus does not travel on opened source file i.e. Cursor is not seen in source file. Focus should travel on opened source file i.e. Cursor should seen in source file. This is a non-regression issue, seen from M-52 (Build 52.0.2739.0) as this is a newly added feature. Change log info: https://chromium.googlesource.com/chromium/src/+log/52.0.2738.0..52.0.2739.0?pretty=fuller&n=10000 Suspecting : 393767 from Change log
,
May 17 2016
One more focus bug for Eric.
,
May 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d436b82c55a2d1d5ad217b59afd2744e1aa6fa77 commit d436b82c55a2d1d5ad217b59afd2744e1aa6fa77 Author: luoe <luoe@chromium.org> Date: Tue May 31 22:35:11 2016 DevTools: rework focus logic Summary of changes: - We actually have 3 places where GlassPanes are instantiated [Dialogs, Options in Toolbar, DraggingElements (e.g. Colorpicker)] - DefaultFocusedViewStack is not necessary and is removed. Previously, it was only used by Dialogs anyways. Dialogs are the only GlassPanes that will save the previously focused element and call .focus() when the dialog closes - Showing a different tab (switching to a drawer panel) will now focus on the new tab, if no previous focus was set - DeviceMode's toolbar previously depended on .setSelectionRange() to keep focus in its size input field while resizing. Now, dragging the splitter won't steal focus at all, so DeviceMode doesn't need to force focus on itself - When using the Command Menu to open a panel/file, it will close the GlassPane first (which may call .focus() on the previous element) before calling .show() on the new panel/file, so that the new panel/file gets the final focus BUG= 604427 , 609013 , 612397 Review-Url: https://codereview.chromium.org/2016963002 Cr-Commit-Position: refs/heads/master@{#396955} [modify] https://crrev.com/d436b82c55a2d1d5ad217b59afd2744e1aa6fa77/third_party/WebKit/Source/devtools/front_end/ui/Dialog.js [modify] https://crrev.com/d436b82c55a2d1d5ad217b59afd2744e1aa6fa77/third_party/WebKit/Source/devtools/front_end/ui/Drawer.js [modify] https://crrev.com/d436b82c55a2d1d5ad217b59afd2744e1aa6fa77/third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js [modify] https://crrev.com/d436b82c55a2d1d5ad217b59afd2744e1aa6fa77/third_party/WebKit/Source/devtools/front_end/ui/ShortcutRegistry.js [modify] https://crrev.com/d436b82c55a2d1d5ad217b59afd2744e1aa6fa77/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js [modify] https://crrev.com/d436b82c55a2d1d5ad217b59afd2744e1aa6fa77/third_party/WebKit/Source/devtools/front_end/ui_lazy/FilteredListWidget.js
,
Jun 1 2016
Focus should now be given to the opened file in Quick Source. Please verify if needed. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by ashej...@chromium.org
, May 17 2016