You don't need enum class to forward-delare an enum: Just giving the enum an explicit underlying type is enough. That should be much easier to roll out, right?

Hm. It would indeed be easier, but it feels like there would need to be a lot of arbitrary decisions to "pick a size" for each enum. And is there a risk if a forward-declared size gets "stale"? E.g. it looks like you can do silly stuff like the following without generating an error

enum E : short;
int f(E e);
int main() {
  f(static_cast<E>(0));
}


Since we'd likely have to change all the idl files anyway, I think switching to enum class would be preferred in the long run.

The main downside is the churn in renaming, e.g., AX_EVENT_FOO to AXEvent::FOO. But all http://crrev.com/1988613002 needed was a sed script and the wonders of `git cl format` (and since in this case the strings were the same length, that was really only needed in areas that weren't already correctly formatted, and that was cl-format enforced by a presubmit).

The only thing I had to change were a couple of static_casts -- a DLOG(WARNING), and an iterator.

Enum classes have implicit underlying type in. Explicit underlying into gives you the same without the renaming churn.

Ooh - making them all enum Foo : int - does sound like a cool shortcut. Something like this?: https://codereview.chromium.org/1999633002/ . We wouldn't have to change any idl files if we just enforce 'int' on everything enum.

( currently this generates a clang crash -> filed https://llvm.org/bugs/show_bug.cgi?id=27822 -> but it might just be getting triggered due to a compile error)

@tapted, any updates?

I think we should still do this, but it's low priority.

gn is better at tracking dependencies, but it's still easy to forget to add a public_deps entry when you expose a generated header via a component's public API.

This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

I think this can be shelved. mojo uses enum class. We should just deprecate json_schema_compiler.