New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 612342 link

Starred by 8 users
Status: Archived
Owner: ----
Closed: Nov 13
Cc:
█ ke...@intel.com
█ kbr@chromium.org
█ hendr...@chromium.org
bajones@chromium.org
ddorwin@chromium.org
█ amp@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task
Proj-XR
Proj-XR-VR

Blocked on:
issue 680518
Blocking:
issue 598069



Sign in to add a comment

Content Modularization Project: VR

Project Member Reported by jam@chromium.org, May 17 2016 
Tracking bug for the VR part of the Content Modularization Project. The end goal should be to have a self-contained service. As part of getting rid (or greatly reducing) content/, this code should move out of content/. Most likely to device/vr to be consistent with what's being done for other device related APIs.

Strawman proposal, following other services that we're extracting from content:
-eliminate the dependencies in this code on other code in content/
-move remaining code in content/browser/vr and the mojom in third_party/webkit to device/time_zone_monitor

Comment 1 by jam@chromium.org, May 17 2016

Blocking: -598073 598069
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98f9652e82de64155e08f422017fede4e051af51

commit 98f9652e82de64155e08f422017fede4e051af51
Author: bajones <bajones@chromium.org>
Date: Fri Jun 03 22:43:57 2016

Moving VR service from /content/browser to /device

BUG= 612342 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2029703002
Cr-Commit-Position: refs/heads/master@{#397828}

[modify] https://crrev.com/98f9652e82de64155e08f422017fede4e051af51/content/browser/BUILD.gn
[modify] https://crrev.com/98f9652e82de64155e08f422017fede4e051af51/content/browser/DEPS
[modify] https://crrev.com/98f9652e82de64155e08f422017fede4e051af51/content/browser/android/browser_jni_registrar.cc
[modify] https://crrev.com/98f9652e82de64155e08f422017fede4e051af51/content/browser/frame_host/render_frame_host_impl.cc
[delete] https://crrev.com/73a640d498ea36d6c60daca10c5a2b7979511660/content/browser/vr/OWNERS
[delete] https://crrev.com/73a640d498ea36d6c60daca10c5a2b7979511660/content/browser/vr/test/fake_vr_device.cc
[delete] https://crrev.com/73a640d498ea36d6c60daca10c5a2b7979511660/content/browser/vr/test/fake_vr_device.h
[modify] https://crrev.com/98f9652e82de64155e08f422017fede4e051af51/content/public/android/BUILD.gn
[modify] https://crrev.com/98f9652e82de64155e08f422017fede4e051af51/device/BUILD.gn
[add] https://crrev.com/98f9652e82de64155e08f422017fede4e051af51/device/vr/BUILD.gn
[add] https://crrev.com/98f9652e82de64155e08f422017fede4e051af51/device/vr/DEPS
[add] https://crrev.com/98f9652e82de64155e08f422017fede4e051af51/device/vr/OWNERS
[add] https://crrev.com/98f9652e82de64155e08f422017fede4e051af51/device/vr/android/BUILD.gn
[rename] https://crrev.com/98f9652e82de64155e08f422017fede4e051af51/device/vr/android/cardboard/cardboard_vr_device.cc
[rename] https://crrev.com/98f9652e82de64155e08f422017fede4e051af51/device/vr/android/cardboard/cardboard_vr_device.h
[rename] https://crrev.com/98f9652e82de64155e08f422017fede4e051af51/device/vr/android/cardboard/cardboard_vr_device_provider.cc
[rename] https://crrev.com/98f9652e82de64155e08f422017fede4e051af51/device/vr/android/cardboard/cardboard_vr_device_provider.h
[rename] https://crrev.com/98f9652e82de64155e08f422017fede4e051af51/device/vr/android/java/src/org/chromium/device/vr/CardboardVRDevice.java
[add] https://crrev.com/98f9652e82de64155e08f422017fede4e051af51/device/vr/android/vr_jni_registrar.cc
[add] https://crrev.com/98f9652e82de64155e08f422017fede4e051af51/device/vr/android/vr_jni_registrar.h
[add] https://crrev.com/98f9652e82de64155e08f422017fede4e051af51/device/vr/test/fake_vr_device.cc
[add] https://crrev.com/98f9652e82de64155e08f422017fede4e051af51/device/vr/test/fake_vr_device.h
[rename] https://crrev.com/98f9652e82de64155e08f422017fede4e051af51/device/vr/test/fake_vr_device_provider.cc
[rename] https://crrev.com/98f9652e82de64155e08f422017fede4e051af51/device/vr/test/fake_vr_device_provider.h
[rename] https://crrev.com/98f9652e82de64155e08f422017fede4e051af51/device/vr/vr_device.cc
[rename] https://crrev.com/98f9652e82de64155e08f422017fede4e051af51/device/vr/vr_device.h
[rename] https://crrev.com/98f9652e82de64155e08f422017fede4e051af51/device/vr/vr_device_manager.cc
[rename] https://crrev.com/98f9652e82de64155e08f422017fede4e051af51/device/vr/vr_device_manager.h
[rename] https://crrev.com/98f9652e82de64155e08f422017fede4e051af51/device/vr/vr_device_manager_unittest.cc
[rename] https://crrev.com/98f9652e82de64155e08f422017fede4e051af51/device/vr/vr_device_provider.h
[add] https://crrev.com/98f9652e82de64155e08f422017fede4e051af51/device/vr/vr_export.h
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ce365c1e195a8b28e632a890076a5c598875e03

commit 4ce365c1e195a8b28e632a890076a5c598875e03
Author: bajones <bajones@chromium.org>
Date: Wed Jun 08 00:42:34 2016

Moved vr_service.mojom from blink to device

BUG= 612342 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2041003003
Cr-Commit-Position: refs/heads/master@{#398439}

[modify] https://crrev.com/4ce365c1e195a8b28e632a890076a5c598875e03/content/browser/DEPS
[modify] https://crrev.com/4ce365c1e195a8b28e632a890076a5c598875e03/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/4ce365c1e195a8b28e632a890076a5c598875e03/content/renderer/BUILD.gn
[modify] https://crrev.com/4ce365c1e195a8b28e632a890076a5c598875e03/device/BUILD.gn
[modify] https://crrev.com/4ce365c1e195a8b28e632a890076a5c598875e03/device/vr/BUILD.gn
[modify] https://crrev.com/4ce365c1e195a8b28e632a890076a5c598875e03/device/vr/android/cardboard/cardboard_vr_device.cc
[modify] https://crrev.com/4ce365c1e195a8b28e632a890076a5c598875e03/device/vr/android/cardboard/cardboard_vr_device.h
[modify] https://crrev.com/4ce365c1e195a8b28e632a890076a5c598875e03/device/vr/test/fake_vr_device.cc
[modify] https://crrev.com/4ce365c1e195a8b28e632a890076a5c598875e03/device/vr/test/fake_vr_device.h
[add] https://crrev.com/4ce365c1e195a8b28e632a890076a5c598875e03/device/vr/vr.gyp
[modify] https://crrev.com/4ce365c1e195a8b28e632a890076a5c598875e03/device/vr/vr_device.h
[modify] https://crrev.com/4ce365c1e195a8b28e632a890076a5c598875e03/device/vr/vr_device_manager.cc
[modify] https://crrev.com/4ce365c1e195a8b28e632a890076a5c598875e03/device/vr/vr_device_manager.h
[modify] https://crrev.com/4ce365c1e195a8b28e632a890076a5c598875e03/device/vr/vr_device_manager_unittest.cc
[rename] https://crrev.com/4ce365c1e195a8b28e632a890076a5c598875e03/device/vr/vr_service.mojom
[modify] https://crrev.com/4ce365c1e195a8b28e632a890076a5c598875e03/third_party/WebKit/Source/modules/BUILD.gn
[modify] https://crrev.com/4ce365c1e195a8b28e632a890076a5c598875e03/third_party/WebKit/Source/modules/modules.gyp
[add] https://crrev.com/4ce365c1e195a8b28e632a890076a5c598875e03/third_party/WebKit/Source/modules/vr/DEPS
[modify] https://crrev.com/4ce365c1e195a8b28e632a890076a5c598875e03/third_party/WebKit/Source/modules/vr/VRController.cpp
[modify] https://crrev.com/4ce365c1e195a8b28e632a890076a5c598875e03/third_party/WebKit/Source/modules/vr/VRController.h
[modify] https://crrev.com/4ce365c1e195a8b28e632a890076a5c598875e03/third_party/WebKit/Source/modules/vr/VRDisplay.cpp
[modify] https://crrev.com/4ce365c1e195a8b28e632a890076a5c598875e03/third_party/WebKit/Source/modules/vr/VRDisplay.h
[modify] https://crrev.com/4ce365c1e195a8b28e632a890076a5c598875e03/third_party/WebKit/Source/modules/vr/VRDisplayCollection.cpp
[modify] https://crrev.com/4ce365c1e195a8b28e632a890076a5c598875e03/third_party/WebKit/Source/modules/vr/VRDisplayCollection.h
[modify] https://crrev.com/4ce365c1e195a8b28e632a890076a5c598875e03/third_party/WebKit/Source/modules/vr/VREyeParameters.cpp
[modify] https://crrev.com/4ce365c1e195a8b28e632a890076a5c598875e03/third_party/WebKit/Source/modules/vr/VREyeParameters.h
[modify] https://crrev.com/4ce365c1e195a8b28e632a890076a5c598875e03/third_party/WebKit/Source/modules/vr/VRGetDevicesCallback.cpp
[modify] https://crrev.com/4ce365c1e195a8b28e632a890076a5c598875e03/third_party/WebKit/Source/modules/vr/VRGetDevicesCallback.h
[modify] https://crrev.com/4ce365c1e195a8b28e632a890076a5c598875e03/third_party/WebKit/Source/modules/vr/VRPose.cpp
[modify] https://crrev.com/4ce365c1e195a8b28e632a890076a5c598875e03/third_party/WebKit/Source/modules/vr/VRPose.h
[modify] https://crrev.com/4ce365c1e195a8b28e632a890076a5c598875e03/third_party/WebKit/Source/modules/vr/VRStageParameters.cpp
[modify] https://crrev.com/4ce365c1e195a8b28e632a890076a5c598875e03/third_party/WebKit/Source/modules/vr/VRStageParameters.h
[modify] https://crrev.com/4ce365c1e195a8b28e632a890076a5c598875e03/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/4ce365c1e195a8b28e632a890076a5c598875e03/third_party/WebKit/public/blink.gyp
[delete] https://crrev.com/fac8aa8c63e77e543d6ea0afe4de1929be4c8194/third_party/WebKit/public/platform/modules/vr/OWNERS

Comment 4 by bajones@chromium.org, Jun 8 2016

Status: Fixed (was: Available)
Migration to /device now complete. Pretty happy with how clean and self contained the result is!

Comment 5 by blundell@chromium.org, Dec 29 2016

Owner: ke...@intel.com
Status: Started (was: Fixed)
Re-opening to track the move of VR into its own service (in the Mojo sense). ke.he@intel.com is performing this work.

Comment 6 by blundell@chromium.org, Jan 12 2017

Blockedon: 680518

Comment 7 by blundell@chromium.org, Feb 6 2017

Labels: DeviceService

Comment 8 by blundell@chromium.org, Feb 7 2017

Blockedon: 689437

Comment 9 by ddorwin@chromium.org, Mar 11 2017

Cc: ddorwin@chromium.org amp@chromium.org
Components: UI>Browser>VR
Labels: Proj-VR

Comment 10 by ke...@intel.com, May 19 2017

Owner: blundell@chromium.org
Status: Available (was: Started)

Comment 11 by ke...@intel.com, May 19 2017

Cc: ke...@intel.com

Comment 12 by blundell@chromium.org, Sep 28 2017

Blocking: -612328
Labels: -DeviceService
Owner: ----
Removing the DeviceService relationship as VR is not going to end up in the Device Service but rather in its own service.

Comment 13 by blundell@chromium.org, Sep 28 2017

Blockedon: -689437

Comment 14 by cjgrant@chromium.org, Oct 10 2017 

Quick question regarding bug dependencies.

- The root Content Modularization / Servicification bug is issue 598069.
- This issue initially tracked moving code from content to device, which Brandon did in June (comment 4).
- Servicification of VR is explicitly tracked by  issue 680518 .

jam@ and blundell@, should we keep this open as an umbrella, or just make 598069 depend on 680518 and close this one?

Comment 15 by blundell@chromium.org, Oct 13 2017 

Re: c#14, the VRService Mojo interface is still exposed by content::RenderFrameHostImpl, so the decoupling of VR from //content isn't actually yet complete. IOW, we should keep this bug open (or add that information into the bug blocking this one so that it tracks the end-to-end work involved).

Comment 16 by laforge@google.com, Nov 7 2017

Components: Internals>Services
Labels: Type-Task
Appending component Internals>Services to S13N projects and changing the Type (for tracking sake) to Type=Task.
Project Member

Comment 17 by sheriffbot@chromium.org, Nov 8

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 18 by ericde@google.com, Nov 13

Status: Archived (was: Untriaged)
please reactivate if this is critical
►

Sign in to add a comment