New issue
Advanced search Search tips

Issue 612337 link

Starred by 3 users
Status: Fixed
Owner:
scottmg@chromium.org
Closed: Jun 2016
Cc:
michaelbai@chromium.org
derat@chromium.org
boliu@chromium.org
mark@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task
Proj-Servicification

Blocked on:
issue 614617
Blocking:
issue 598069
issue 612328
issue 612563



Sign in to add a comment

Content Modularization Project: Power Save Blocker

Project Member Reported by jam@chromium.org, May 16 2016 
Tracking bug for the power save blocker part of the Content Modularization Project. The end goal should be to have a self-contained service. As part of getting rid (or greatly reducing) content/, this code should move out of content/. Most likely to device/power_save_blocker to be consistent with what's being done for other device related APIs.

Strawman proposal, following other services that we're extracting from content:
-eliminate the dependencies in this code on other code in content/
-move remaining code in content/browser/power_save_blockerto device/power_save_blocker

Comment 1 by jam@chromium.org, May 16 2016

Cc: derat@chromium.org

Comment 2 by jam@chromium.org, May 16 2016

Cc: mark@chromium.org

Comment 3 by jam@chromium.org, May 17 2016

Blocking: -598073 598069

Comment 4 by scottmg@chromium.org, May 17 2016

Blocking: 612563

Comment 5 by scottmg@chromium.org, May 17 2016

Cc: boliu@chromium.org
Owner: scottmg@chromium.org
Status: Started (was: Available)
Took a quick look, the dependencies to remove look like:

cros, win, linux, & android:
- content/public/browser/browser_thread.h
To run various system calls on the UI thread. It looks like passing a SingleThreadTaskRunner would sort this out.

android:
- c/b/android/content_view_core_impl.h
- c/b/web_contents/web_contents_impl.h (don't think this is actually used)
- c/p/b/android/content_view_core.h
- c/p/b/web_contents_observer.h

I think WebContentsObserver is to be able to get to the ContentViewCore, which I think is there because it needs to be passed through to content/public/android/java/src/org/chromium/content/browser/PowerSaveBlocker.java, which I think it needs to get a View to call setKeepScreenOn() on.

I don't know much about Android or how to get rid of this. Could we use Activity.getWindow().addFlags() WindowManager.LayoutParams.FLAG_KEEP_SCREEN_ON instead? +boliu based on git log.

(It turns out this is sort of a false dependency for  bug 612563 , as it only cares about keeping things running, not keeping the screen on, so we could potentially split screen saving and power saving into separate things too.)

Comment 6 by boliu@chromium.org, May 17 2016

Cc: michaelbai@chromium.org
> I don't know much about Android or how to get rid of this. Could we use Activity.getWindow().addFlags() WindowManager.LayoutParams.FLAG_KEEP_SCREEN_ON instead? +boliu based on git log.

No, because.. android webview. +michaelbai who actually did the work

Messing with WindowManager for power saver is fine for chrome, but not for webview. In webview, WindowManager is global and shared with the app, and webview should in general not touch global state. More practically, we've ran into issues where both webview and the app tries to set that state and they stomp each other. So then Michael changed android to the view-based solution.

Comment 7 by scottmg@chromium.org, May 17 2016 

Ah, I see, thanks.

So I guess content just needs to pass in the two bound callbacks (for acquireAnchorView and releaseAnchorView). I have no idea how to do that, but I'll assume it's straightforward (or at least possible) until I get lost in Java-world. :)

Comment 8 by boliu@chromium.org, May 17 2016 

I will point out there is a fundamental incompatibility between the content API and the anchorView.setKeepScreenOn implementation, as you've discovered with those android-only dependencies.

The content power save blocker API is supposed to take effect globally, and does not depend on a particular WebContents instance.

But anchorView implementation need to be tied to a WebContents instance, since the anchor view needs to be attached to some other view to take affect. This also has the nice property (for webview at least) that the effect of power save blocker is limited to the view, and if the view is detached, then blocker should have no effect. I kinda wish the content API behaved this way instead..

> So I guess content just needs to pass in the two bound callbacks (for acquireAnchorView and releaseAnchorView). I have no idea how to do that, but I'll assume it's straightforward (or at least possible) until I get lost in Java-world. :)

Annonymous runnables like this? https://code.google.com/p/chromium/codesearch#chromium/src/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java&l=912

If it's two callbacks, maybe it's worth defining an interface instead

Comment 9 by scottmg@chromium.org, May 18 2016 

I started removing BrowserThread here https://codereview.chromium.org/1991593002 but then realized power_save_blocker_x11 needs a UI thread runner *and* a FILE thread runner. Bother.
Project Member

Comment 10 by bugdroid1@chromium.org, May 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1a9581197708b4f5d62fb542242aeeb03fdb87b

commit b1a9581197708b4f5d62fb542242aeeb03fdb87b
Author: scottmg <scottmg@chromium.org>
Date: Wed May 18 17:29:01 2016

Add DEPS include rules for c/b/power_save_blocker*

R=jam@chromium.org
BUG= 612337 

Review-Url: https://codereview.chromium.org/1992483002
Cr-Commit-Position: refs/heads/master@{#394460}

[modify] https://crrev.com/b1a9581197708b4f5d62fb542242aeeb03fdb87b/content/browser/DEPS
Project Member

Comment 11 by bugdroid1@chromium.org, May 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11c0c210570c67f7b32ebc706102c9e8833cc9a1

commit 11c0c210570c67f7b32ebc706102c9e8833cc9a1
Author: scottmg <scottmg@chromium.org>
Date: Tue May 24 23:20:50 2016

Pass SequencedTaskRunner to PowerSaveBlocker for ui/file operations

Beginning of moving PowerSaveBlocker to //device/power_save_blocker.

power_save_blocker_factory is a wrapper to pass down the required
SequencedTaskRunners. It will stay in content when the rest of the
power_save_blocker files move to //device.

BUG= 612337 , 257943 , 612563 

Review-Url: https://codereview.chromium.org/1991593002
Cr-Commit-Position: refs/heads/master@{#395727}

[modify] https://crrev.com/11c0c210570c67f7b32ebc706102c9e8833cc9a1/chrome/browser/media/cast_transport_host_filter.cc
[modify] https://crrev.com/11c0c210570c67f7b32ebc706102c9e8833cc9a1/components/drive/DEPS
[modify] https://crrev.com/11c0c210570c67f7b32ebc706102c9e8833cc9a1/components/drive/drive_uploader.cc
[modify] https://crrev.com/11c0c210570c67f7b32ebc706102c9e8833cc9a1/content/browser/DEPS
[modify] https://crrev.com/11c0c210570c67f7b32ebc706102c9e8833cc9a1/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/11c0c210570c67f7b32ebc706102c9e8833cc9a1/content/browser/download/download_browsertest.cc
[modify] https://crrev.com/11c0c210570c67f7b32ebc706102c9e8833cc9a1/content/browser/download/download_request_core.cc
[modify] https://crrev.com/11c0c210570c67f7b32ebc706102c9e8833cc9a1/content/browser/loader/DEPS
[modify] https://crrev.com/11c0c210570c67f7b32ebc706102c9e8833cc9a1/content/browser/loader/power_save_block_resource_throttle.cc
[modify] https://crrev.com/11c0c210570c67f7b32ebc706102c9e8833cc9a1/content/browser/media/capture/aura_window_capture_machine.cc
[modify] https://crrev.com/11c0c210570c67f7b32ebc706102c9e8833cc9a1/content/browser/media/capture/desktop_capture_device.cc
[modify] https://crrev.com/11c0c210570c67f7b32ebc706102c9e8833cc9a1/content/browser/media/media_web_contents_observer.cc
[modify] https://crrev.com/11c0c210570c67f7b32ebc706102c9e8833cc9a1/content/browser/media/webrtc/webrtc_internals.cc
[modify] https://crrev.com/11c0c210570c67f7b32ebc706102c9e8833cc9a1/content/browser/power_save_blocker_android.cc
[modify] https://crrev.com/11c0c210570c67f7b32ebc706102c9e8833cc9a1/content/browser/power_save_blocker_chromeos.cc
[add] https://crrev.com/11c0c210570c67f7b32ebc706102c9e8833cc9a1/content/browser/power_save_blocker_factory.cc
[modify] https://crrev.com/11c0c210570c67f7b32ebc706102c9e8833cc9a1/content/browser/power_save_blocker_impl.cc
[modify] https://crrev.com/11c0c210570c67f7b32ebc706102c9e8833cc9a1/content/browser/power_save_blocker_impl.h
[modify] https://crrev.com/11c0c210570c67f7b32ebc706102c9e8833cc9a1/content/browser/power_save_blocker_mac.cc
[modify] https://crrev.com/11c0c210570c67f7b32ebc706102c9e8833cc9a1/content/browser/power_save_blocker_ozone.cc
[modify] https://crrev.com/11c0c210570c67f7b32ebc706102c9e8833cc9a1/content/browser/power_save_blocker_win.cc
[modify] https://crrev.com/11c0c210570c67f7b32ebc706102c9e8833cc9a1/content/browser/power_save_blocker_x11.cc
[modify] https://crrev.com/11c0c210570c67f7b32ebc706102c9e8833cc9a1/content/browser/wake_lock/wake_lock_service_context.cc
[modify] https://crrev.com/11c0c210570c67f7b32ebc706102c9e8833cc9a1/content/content_browser.gypi
[modify] https://crrev.com/11c0c210570c67f7b32ebc706102c9e8833cc9a1/content/public/browser/power_save_blocker.h
[add] https://crrev.com/11c0c210570c67f7b32ebc706102c9e8833cc9a1/content/public/browser/power_save_blocker_factory.h
[modify] https://crrev.com/11c0c210570c67f7b32ebc706102c9e8833cc9a1/extensions/browser/api/power/power_api.cc
Project Member

Comment 12 by bugdroid1@chromium.org, May 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da0a45ca416398c5942e135a00bed17a78297adf

commit da0a45ca416398c5942e135a00bed17a78297adf
Author: hajimehoshi <hajimehoshi@chromium.org>
Date: Wed May 25 09:35:40 2016

Revert of Pass SequencedTaskRunner to PowerSaveBlocker for ui/file operations (patchset #13 id:240001 of https://codereview.chromium.org/1991593002/ )

Reason for revert:
This causes flaky test failures (e.g. https://build.chromium.org/p/chromium.gpu/builders/Linux%20Release%20%28NVIDIA%29/builds/78794)

Original issue's description:
> Pass SequencedTaskRunner to PowerSaveBlocker for ui/file operations
>
> Beginning of moving PowerSaveBlocker to //device/power_save_blocker.
>
> power_save_blocker_factory is a wrapper to pass down the required
> SequencedTaskRunners. It will stay in content when the rest of the
> power_save_blocker files move to //device.
>
> BUG= 612337 , 257943 , 612563 
>
> Committed: https://crrev.com/11c0c210570c67f7b32ebc706102c9e8833cc9a1
> Cr-Commit-Position: refs/heads/master@{#395727}

TBR=hashimoto@chromium.org,nick@chromium.org,asargent@chromium.org,tommi@chromium.org,scottmg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 612337 , 257943 , 612563 

Review-Url: https://codereview.chromium.org/2006143006
Cr-Commit-Position: refs/heads/master@{#395840}

[modify] https://crrev.com/da0a45ca416398c5942e135a00bed17a78297adf/chrome/browser/media/cast_transport_host_filter.cc
[modify] https://crrev.com/da0a45ca416398c5942e135a00bed17a78297adf/components/drive/DEPS
[modify] https://crrev.com/da0a45ca416398c5942e135a00bed17a78297adf/components/drive/drive_uploader.cc
[modify] https://crrev.com/da0a45ca416398c5942e135a00bed17a78297adf/content/browser/DEPS
[modify] https://crrev.com/da0a45ca416398c5942e135a00bed17a78297adf/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/da0a45ca416398c5942e135a00bed17a78297adf/content/browser/download/download_browsertest.cc
[modify] https://crrev.com/da0a45ca416398c5942e135a00bed17a78297adf/content/browser/download/download_request_core.cc
[modify] https://crrev.com/da0a45ca416398c5942e135a00bed17a78297adf/content/browser/loader/DEPS
[modify] https://crrev.com/da0a45ca416398c5942e135a00bed17a78297adf/content/browser/loader/power_save_block_resource_throttle.cc
[modify] https://crrev.com/da0a45ca416398c5942e135a00bed17a78297adf/content/browser/media/capture/aura_window_capture_machine.cc
[modify] https://crrev.com/da0a45ca416398c5942e135a00bed17a78297adf/content/browser/media/capture/desktop_capture_device.cc
[modify] https://crrev.com/da0a45ca416398c5942e135a00bed17a78297adf/content/browser/media/media_web_contents_observer.cc
[modify] https://crrev.com/da0a45ca416398c5942e135a00bed17a78297adf/content/browser/media/webrtc/webrtc_internals.cc
[modify] https://crrev.com/da0a45ca416398c5942e135a00bed17a78297adf/content/browser/power_save_blocker_android.cc
[modify] https://crrev.com/da0a45ca416398c5942e135a00bed17a78297adf/content/browser/power_save_blocker_chromeos.cc
[delete] https://crrev.com/11d95dfff19cea0f59e859b21629041722d5dad0/content/browser/power_save_blocker_factory.cc
[modify] https://crrev.com/da0a45ca416398c5942e135a00bed17a78297adf/content/browser/power_save_blocker_impl.cc
[modify] https://crrev.com/da0a45ca416398c5942e135a00bed17a78297adf/content/browser/power_save_blocker_impl.h
[modify] https://crrev.com/da0a45ca416398c5942e135a00bed17a78297adf/content/browser/power_save_blocker_mac.cc
[modify] https://crrev.com/da0a45ca416398c5942e135a00bed17a78297adf/content/browser/power_save_blocker_ozone.cc
[modify] https://crrev.com/da0a45ca416398c5942e135a00bed17a78297adf/content/browser/power_save_blocker_win.cc
[modify] https://crrev.com/da0a45ca416398c5942e135a00bed17a78297adf/content/browser/power_save_blocker_x11.cc
[modify] https://crrev.com/da0a45ca416398c5942e135a00bed17a78297adf/content/browser/wake_lock/wake_lock_service_context.cc
[modify] https://crrev.com/da0a45ca416398c5942e135a00bed17a78297adf/content/content_browser.gypi
[modify] https://crrev.com/da0a45ca416398c5942e135a00bed17a78297adf/content/public/browser/power_save_blocker.h
[delete] https://crrev.com/11d95dfff19cea0f59e859b21629041722d5dad0/content/public/browser/power_save_blocker_factory.h
[modify] https://crrev.com/da0a45ca416398c5942e135a00bed17a78297adf/extensions/browser/api/power/power_api.cc

Comment 13 by kbr@chromium.org, May 25 2016

Blockedon: 614617
Project Member

Comment 14 by bugdroid1@chromium.org, May 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e132b810a0e3c898705bcd70c7fa93da70482d13

commit e132b810a0e3c898705bcd70c7fa93da70482d13
Author: scottmg <scottmg@chromium.org>
Date: Thu May 26 15:51:43 2016

Reland of Pass SequencedTaskRunner to PowerSaveBlocker for ui/file ops

This is a reland of https://codereview.chromium.org/1991593002/, the
diff is PS1 -> PS2, and passes a SingleThreadTaskRunner for _x11 (for
DBus), rather than just a SequencedTaskRunner.

R=nick,hashimoto
TBR=asargent,tommi
BUG= 612337 ,  257943 ,  612563 ,  614629 

Review-Url: https://codereview.chromium.org/2012853003
Cr-Commit-Position: refs/heads/master@{#396189}

[modify] https://crrev.com/e132b810a0e3c898705bcd70c7fa93da70482d13/chrome/browser/media/cast_transport_host_filter.cc
[modify] https://crrev.com/e132b810a0e3c898705bcd70c7fa93da70482d13/components/drive/DEPS
[modify] https://crrev.com/e132b810a0e3c898705bcd70c7fa93da70482d13/components/drive/drive_uploader.cc
[modify] https://crrev.com/e132b810a0e3c898705bcd70c7fa93da70482d13/content/browser/DEPS
[modify] https://crrev.com/e132b810a0e3c898705bcd70c7fa93da70482d13/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/e132b810a0e3c898705bcd70c7fa93da70482d13/content/browser/download/download_browsertest.cc
[modify] https://crrev.com/e132b810a0e3c898705bcd70c7fa93da70482d13/content/browser/download/download_request_core.cc
[modify] https://crrev.com/e132b810a0e3c898705bcd70c7fa93da70482d13/content/browser/loader/DEPS
[modify] https://crrev.com/e132b810a0e3c898705bcd70c7fa93da70482d13/content/browser/loader/power_save_block_resource_throttle.cc
[modify] https://crrev.com/e132b810a0e3c898705bcd70c7fa93da70482d13/content/browser/media/capture/aura_window_capture_machine.cc
[modify] https://crrev.com/e132b810a0e3c898705bcd70c7fa93da70482d13/content/browser/media/capture/desktop_capture_device.cc
[modify] https://crrev.com/e132b810a0e3c898705bcd70c7fa93da70482d13/content/browser/media/media_web_contents_observer.cc
[modify] https://crrev.com/e132b810a0e3c898705bcd70c7fa93da70482d13/content/browser/media/webrtc/webrtc_internals.cc
[modify] https://crrev.com/e132b810a0e3c898705bcd70c7fa93da70482d13/content/browser/power_save_blocker_android.cc
[modify] https://crrev.com/e132b810a0e3c898705bcd70c7fa93da70482d13/content/browser/power_save_blocker_chromeos.cc
[add] https://crrev.com/e132b810a0e3c898705bcd70c7fa93da70482d13/content/browser/power_save_blocker_factory.cc
[modify] https://crrev.com/e132b810a0e3c898705bcd70c7fa93da70482d13/content/browser/power_save_blocker_impl.cc
[modify] https://crrev.com/e132b810a0e3c898705bcd70c7fa93da70482d13/content/browser/power_save_blocker_impl.h
[modify] https://crrev.com/e132b810a0e3c898705bcd70c7fa93da70482d13/content/browser/power_save_blocker_mac.cc
[modify] https://crrev.com/e132b810a0e3c898705bcd70c7fa93da70482d13/content/browser/power_save_blocker_ozone.cc
[modify] https://crrev.com/e132b810a0e3c898705bcd70c7fa93da70482d13/content/browser/power_save_blocker_win.cc
[modify] https://crrev.com/e132b810a0e3c898705bcd70c7fa93da70482d13/content/browser/power_save_blocker_x11.cc
[modify] https://crrev.com/e132b810a0e3c898705bcd70c7fa93da70482d13/content/browser/wake_lock/wake_lock_service_context.cc
[modify] https://crrev.com/e132b810a0e3c898705bcd70c7fa93da70482d13/content/content_browser.gypi
[modify] https://crrev.com/e132b810a0e3c898705bcd70c7fa93da70482d13/content/public/browser/power_save_blocker.h
[add] https://crrev.com/e132b810a0e3c898705bcd70c7fa93da70482d13/content/public/browser/power_save_blocker_factory.h
[modify] https://crrev.com/e132b810a0e3c898705bcd70c7fa93da70482d13/extensions/browser/api/power/power_api.cc
Project Member

Comment 15 by bugdroid1@chromium.org, Jun 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a25943038ebc706537cdd5e6229924c53217ed31

commit a25943038ebc706537cdd5e6229924c53217ed31
Author: scottmg <scottmg@chromium.org>
Date: Mon Jun 13 21:37:16 2016

Remove dependency of power_save_blocker_android on various content bits

BUG= 612337 , 612563 
TEST=start/stop video on m.youtube.com, content_browsertests

Review-Url: https://codereview.chromium.org/2003803002
Cr-Commit-Position: refs/heads/master@{#399549}

[modify] https://crrev.com/a25943038ebc706537cdd5e6229924c53217ed31/content/browser/DEPS
[modify] https://crrev.com/a25943038ebc706537cdd5e6229924c53217ed31/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/a25943038ebc706537cdd5e6229924c53217ed31/content/browser/devtools/render_frame_devtools_agent_host.h
[modify] https://crrev.com/a25943038ebc706537cdd5e6229924c53217ed31/content/browser/media/media_web_contents_observer.cc
[modify] https://crrev.com/a25943038ebc706537cdd5e6229924c53217ed31/content/browser/media/media_web_contents_observer.h
[modify] https://crrev.com/a25943038ebc706537cdd5e6229924c53217ed31/content/browser/power_save_blocker_android.cc
[modify] https://crrev.com/a25943038ebc706537cdd5e6229924c53217ed31/content/browser/power_save_blocker_impl.h
[modify] https://crrev.com/a25943038ebc706537cdd5e6229924c53217ed31/content/browser/wake_lock/wake_lock_service_context.cc
[modify] https://crrev.com/a25943038ebc706537cdd5e6229924c53217ed31/content/browser/wake_lock/wake_lock_service_context.h
[modify] https://crrev.com/a25943038ebc706537cdd5e6229924c53217ed31/content/public/android/java/src/org/chromium/content/browser/PowerSaveBlocker.java
Project Member

Comment 16 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a25943038ebc706537cdd5e6229924c53217ed31

commit a25943038ebc706537cdd5e6229924c53217ed31
Author: scottmg <scottmg@chromium.org>
Date: Mon Jun 13 21:37:16 2016

Remove dependency of power_save_blocker_android on various content bits

BUG= 612337 , 612563 
TEST=start/stop video on m.youtube.com, content_browsertests

Review-Url: https://codereview.chromium.org/2003803002
Cr-Commit-Position: refs/heads/master@{#399549}

[modify] https://crrev.com/a25943038ebc706537cdd5e6229924c53217ed31/content/browser/DEPS
[modify] https://crrev.com/a25943038ebc706537cdd5e6229924c53217ed31/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/a25943038ebc706537cdd5e6229924c53217ed31/content/browser/devtools/render_frame_devtools_agent_host.h
[modify] https://crrev.com/a25943038ebc706537cdd5e6229924c53217ed31/content/browser/media/media_web_contents_observer.cc
[modify] https://crrev.com/a25943038ebc706537cdd5e6229924c53217ed31/content/browser/media/media_web_contents_observer.h
[modify] https://crrev.com/a25943038ebc706537cdd5e6229924c53217ed31/content/browser/power_save_blocker_android.cc
[modify] https://crrev.com/a25943038ebc706537cdd5e6229924c53217ed31/content/browser/power_save_blocker_impl.h
[modify] https://crrev.com/a25943038ebc706537cdd5e6229924c53217ed31/content/browser/wake_lock/wake_lock_service_context.cc
[modify] https://crrev.com/a25943038ebc706537cdd5e6229924c53217ed31/content/browser/wake_lock/wake_lock_service_context.h
[modify] https://crrev.com/a25943038ebc706537cdd5e6229924c53217ed31/content/public/android/java/src/org/chromium/content/browser/PowerSaveBlocker.java
Project Member

Comment 17 by bugdroid1@chromium.org, Jun 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/327630a7735fc91aedea5e164064c4dd18c04cc4

commit 327630a7735fc91aedea5e164064c4dd18c04cc4
Author: scottmg <scottmg@chromium.org>
Date: Fri Jun 17 05:08:59 2016

Move content/browser/power_save_blocker to //device/power_save_blocker

This is mostly a mechanical move. The only "new" code is the new build
files, and the Android JNI registration that has its own version in
//device now instead of being part of the //content registration.

R=jam@chromium.org
TBR=rockot,tedchoc
BUG= 612337 ,  612563 ,  257943 

Review-Url: https://codereview.chromium.org/1999953002
Cr-Commit-Position: refs/heads/master@{#400361}

[modify] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/chrome/browser/media/DEPS
[modify] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/chrome/browser/media/cast_transport_host_filter.cc
[modify] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/chrome/browser/media/cast_transport_host_filter.h
[modify] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/components/drive/BUILD.gn
[modify] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/components/drive/DEPS
[modify] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/components/drive/drive_uploader.cc
[modify] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/content/app/DEPS
[modify] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/content/app/android/library_loader_hooks.cc
[modify] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/content/browser/BUILD.gn
[modify] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/content/browser/DEPS
[modify] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/content/browser/android/browser_jni_registrar.cc
[modify] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/content/browser/devtools/render_frame_devtools_agent_host.h
[modify] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/content/browser/download/download_browsertest.cc
[modify] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/content/browser/download/download_request_core.cc
[modify] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/content/browser/download/download_request_core.h
[modify] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/content/browser/download/drag_download_file_browsertest.cc
[modify] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/content/browser/loader/DEPS
[modify] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/content/browser/loader/power_save_block_resource_throttle.cc
[modify] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/content/browser/loader/power_save_block_resource_throttle.h
[modify] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/content/browser/media/capture/aura_window_capture_machine.cc
[modify] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/content/browser/media/capture/aura_window_capture_machine.h
[modify] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/content/browser/media/capture/desktop_capture_device.cc
[modify] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/content/browser/media/media_web_contents_observer.cc
[modify] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/content/browser/media/media_web_contents_observer.h
[modify] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/content/browser/media/webrtc/webrtc_internals.cc
[modify] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/content/browser/media/webrtc/webrtc_internals.h
[delete] https://crrev.com/f1a02d60a6f16a56e35f69ab6e4efaeaf64f6820/content/browser/power_save_blocker_android.h
[modify] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/content/browser/power_save_blocker_factory.cc
[add] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/content/browser/power_save_blocker_factory.h
[modify] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/content/browser/wake_lock/wake_lock_service_context.cc
[modify] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/content/browser/wake_lock/wake_lock_service_context.h
[modify] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/content/content_browser.gypi
[modify] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/content/content_jni.gypi
[modify] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/content/public/android/BUILD.gn
[modify] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/content/public/browser/BUILD.gn
[delete] https://crrev.com/f1a02d60a6f16a56e35f69ab6e4efaeaf64f6820/content/public/browser/power_save_blocker_factory.h
[modify] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/device/BUILD.gn
[add] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/device/power_save_blocker/BUILD.gn
[add] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/device/power_save_blocker/DEPS
[add] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/device/power_save_blocker/OWNERS
[rename] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/device/power_save_blocker/android/java/src/org/chromium/device/power_save_blocker/PowerSaveBlocker.java
[add] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/device/power_save_blocker/power_save_blocker.gyp
[rename] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/device/power_save_blocker/power_save_blocker.h
[rename] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/device/power_save_blocker/power_save_blocker_android.cc
[add] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/device/power_save_blocker/power_save_blocker_android.h
[rename] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/device/power_save_blocker/power_save_blocker_chromeos.cc
[add] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/device/power_save_blocker/power_save_blocker_export.h
[rename] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/device/power_save_blocker/power_save_blocker_impl.cc
[rename] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/device/power_save_blocker/power_save_blocker_impl.h
[add] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/device/power_save_blocker/power_save_blocker_jni_registrar.cc
[add] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/device/power_save_blocker/power_save_blocker_jni_registrar.h
[rename] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/device/power_save_blocker/power_save_blocker_mac.cc
[rename] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/device/power_save_blocker/power_save_blocker_ozone.cc
[rename] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/device/power_save_blocker/power_save_blocker_win.cc
[rename] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/device/power_save_blocker/power_save_blocker_x11.cc
[modify] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/device/test/run_all_unittests.cc
[modify] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/extensions/browser/BUILD.gn
[modify] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/extensions/browser/DEPS
[modify] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/extensions/browser/api/power/power_api.cc
[modify] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/extensions/browser/api/power/power_api.h
[modify] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/extensions/browser/api/power/power_api_unittest.cc
[modify] https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4/extensions/extensions.gyp
Project Member

Comment 18 by bugdroid1@chromium.org, Jun 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38c8d5e962f463b4abf1eade953bc89941bba534

commit 38c8d5e962f463b4abf1eade953bc89941bba534
Author: scottmg <scottmg@chromium.org>
Date: Fri Jun 17 05:21:32 2016

Revert of Move content/browser/power_save_blocker to //device/power_save_blocker (patchset #19 id:400001 of https://codereview.chromium.org/1999953002/ )

Reason for revert:
Broke https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Builder%20%28dbg%29/builds/158097 but not CQ bots

Original issue's description:
> Move content/browser/power_save_blocker to //device/power_save_blocker
>
> This is mostly a mechanical move. The only "new" code is the new build
> files, and the Android JNI registration that has its own version in
> //device now instead of being part of the //content registration.
>
> R=jam@chromium.org
> TBR=rockot,tedchoc
> BUG= 612337 ,  612563 ,  257943 
>
> Committed: https://crrev.com/327630a7735fc91aedea5e164064c4dd18c04cc4
> Cr-Commit-Position: refs/heads/master@{#400361}

TBR=jam@chromium.org,hashimoto@chromium.org,tedchoc@chromium.org,sadrul@chromium.org,rockot@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 612337 ,  612563 ,  257943 

Review-Url: https://codereview.chromium.org/2075973002
Cr-Commit-Position: refs/heads/master@{#400364}

[modify] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/chrome/browser/media/DEPS
[modify] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/chrome/browser/media/cast_transport_host_filter.cc
[modify] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/chrome/browser/media/cast_transport_host_filter.h
[modify] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/components/drive/BUILD.gn
[modify] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/components/drive/DEPS
[modify] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/components/drive/drive_uploader.cc
[modify] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/content/app/DEPS
[modify] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/content/app/android/library_loader_hooks.cc
[modify] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/content/browser/BUILD.gn
[modify] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/content/browser/DEPS
[modify] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/content/browser/android/browser_jni_registrar.cc
[modify] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/content/browser/devtools/render_frame_devtools_agent_host.h
[modify] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/content/browser/download/download_browsertest.cc
[modify] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/content/browser/download/download_request_core.cc
[modify] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/content/browser/download/download_request_core.h
[modify] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/content/browser/download/drag_download_file_browsertest.cc
[modify] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/content/browser/loader/DEPS
[modify] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/content/browser/loader/power_save_block_resource_throttle.cc
[modify] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/content/browser/loader/power_save_block_resource_throttle.h
[modify] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/content/browser/media/capture/aura_window_capture_machine.cc
[modify] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/content/browser/media/capture/aura_window_capture_machine.h
[modify] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/content/browser/media/capture/desktop_capture_device.cc
[modify] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/content/browser/media/media_web_contents_observer.cc
[modify] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/content/browser/media/media_web_contents_observer.h
[modify] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/content/browser/media/webrtc/webrtc_internals.cc
[modify] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/content/browser/media/webrtc/webrtc_internals.h
[rename] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/content/browser/power_save_blocker_android.cc
[add] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/content/browser/power_save_blocker_android.h
[rename] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/content/browser/power_save_blocker_chromeos.cc
[modify] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/content/browser/power_save_blocker_factory.cc
[delete] https://crrev.com/43df003ba3e7c4660ecd964d87cae61da6181b6e/content/browser/power_save_blocker_factory.h
[rename] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/content/browser/power_save_blocker_impl.cc
[rename] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/content/browser/power_save_blocker_impl.h
[rename] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/content/browser/power_save_blocker_mac.cc
[rename] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/content/browser/power_save_blocker_ozone.cc
[rename] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/content/browser/power_save_blocker_win.cc
[rename] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/content/browser/power_save_blocker_x11.cc
[modify] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/content/browser/wake_lock/wake_lock_service_context.cc
[modify] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/content/browser/wake_lock/wake_lock_service_context.h
[modify] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/content/content_browser.gypi
[modify] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/content/content_jni.gypi
[modify] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/content/public/android/BUILD.gn
[rename] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/content/public/android/java/src/org/chromium/content/browser/PowerSaveBlocker.java
[modify] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/content/public/browser/BUILD.gn
[rename] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/content/public/browser/power_save_blocker.h
[add] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/content/public/browser/power_save_blocker_factory.h
[modify] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/device/BUILD.gn
[delete] https://crrev.com/43df003ba3e7c4660ecd964d87cae61da6181b6e/device/power_save_blocker/BUILD.gn
[delete] https://crrev.com/43df003ba3e7c4660ecd964d87cae61da6181b6e/device/power_save_blocker/DEPS
[delete] https://crrev.com/43df003ba3e7c4660ecd964d87cae61da6181b6e/device/power_save_blocker/OWNERS
[delete] https://crrev.com/43df003ba3e7c4660ecd964d87cae61da6181b6e/device/power_save_blocker/power_save_blocker.gyp
[delete] https://crrev.com/43df003ba3e7c4660ecd964d87cae61da6181b6e/device/power_save_blocker/power_save_blocker_android.h
[delete] https://crrev.com/43df003ba3e7c4660ecd964d87cae61da6181b6e/device/power_save_blocker/power_save_blocker_export.h
[delete] https://crrev.com/43df003ba3e7c4660ecd964d87cae61da6181b6e/device/power_save_blocker/power_save_blocker_jni_registrar.cc
[delete] https://crrev.com/43df003ba3e7c4660ecd964d87cae61da6181b6e/device/power_save_blocker/power_save_blocker_jni_registrar.h
[modify] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/device/test/run_all_unittests.cc
[modify] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/extensions/browser/BUILD.gn
[modify] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/extensions/browser/DEPS
[modify] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/extensions/browser/api/power/power_api.cc
[modify] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/extensions/browser/api/power/power_api.h
[modify] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/extensions/browser/api/power/power_api_unittest.cc
[modify] https://crrev.com/38c8d5e962f463b4abf1eade953bc89941bba534/extensions/extensions.gyp
Project Member

Comment 19 by bugdroid1@chromium.org, Jun 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c40e88210fdf15e85a553573584d217d6f8273b9

commit c40e88210fdf15e85a553573584d217d6f8273b9
Author: scottmg <scottmg@chromium.org>
Date: Fri Jun 17 17:57:48 2016

Reland of 'Move content/browser/power_save_blocker to //device/power_save_blocker'

Original at https://codereview.chromium.org/1999953002.

Changes are ps#1 to ps#2 (fix for Mac build files).

R=jam@chromium.org
TBR=rockot
BUG= 612337 ,  612563 ,  257943 

Review-Url: https://codereview.chromium.org/2075153002
Cr-Commit-Position: refs/heads/master@{#400451}

[modify] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/chrome/browser/media/DEPS
[modify] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/chrome/browser/media/cast_transport_host_filter.cc
[modify] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/chrome/browser/media/cast_transport_host_filter.h
[modify] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/components/drive/BUILD.gn
[modify] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/components/drive/DEPS
[modify] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/components/drive/drive_uploader.cc
[modify] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/content/app/DEPS
[modify] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/content/app/android/library_loader_hooks.cc
[modify] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/content/browser/BUILD.gn
[modify] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/content/browser/DEPS
[modify] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/content/browser/android/browser_jni_registrar.cc
[modify] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/content/browser/devtools/render_frame_devtools_agent_host.h
[modify] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/content/browser/download/download_browsertest.cc
[modify] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/content/browser/download/download_request_core.cc
[modify] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/content/browser/download/download_request_core.h
[modify] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/content/browser/download/drag_download_file_browsertest.cc
[modify] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/content/browser/loader/DEPS
[modify] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/content/browser/loader/power_save_block_resource_throttle.cc
[modify] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/content/browser/loader/power_save_block_resource_throttle.h
[modify] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/content/browser/media/capture/aura_window_capture_machine.cc
[modify] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/content/browser/media/capture/aura_window_capture_machine.h
[modify] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/content/browser/media/capture/desktop_capture_device.cc
[modify] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/content/browser/media/media_web_contents_observer.cc
[modify] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/content/browser/media/media_web_contents_observer.h
[modify] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/content/browser/media/webrtc/webrtc_internals.cc
[modify] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/content/browser/media/webrtc/webrtc_internals.h
[delete] https://crrev.com/04542485cce24e64e794c1dfd47d97fa5fbdf20c/content/browser/power_save_blocker_android.h
[modify] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/content/browser/power_save_blocker_factory.cc
[add] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/content/browser/power_save_blocker_factory.h
[modify] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/content/browser/wake_lock/wake_lock_service_context.cc
[modify] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/content/browser/wake_lock/wake_lock_service_context.h
[modify] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/content/content_browser.gypi
[modify] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/content/content_jni.gypi
[modify] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/content/public/android/BUILD.gn
[modify] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/content/public/browser/BUILD.gn
[delete] https://crrev.com/04542485cce24e64e794c1dfd47d97fa5fbdf20c/content/public/browser/power_save_blocker_factory.h
[modify] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/device/BUILD.gn
[add] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/device/power_save_blocker/BUILD.gn
[add] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/device/power_save_blocker/DEPS
[add] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/device/power_save_blocker/OWNERS
[rename] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/device/power_save_blocker/android/java/src/org/chromium/device/power_save_blocker/PowerSaveBlocker.java
[add] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/device/power_save_blocker/power_save_blocker.gyp
[rename] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/device/power_save_blocker/power_save_blocker.h
[rename] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/device/power_save_blocker/power_save_blocker_android.cc
[add] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/device/power_save_blocker/power_save_blocker_android.h
[rename] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/device/power_save_blocker/power_save_blocker_chromeos.cc
[add] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/device/power_save_blocker/power_save_blocker_export.h
[rename] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/device/power_save_blocker/power_save_blocker_impl.cc
[rename] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/device/power_save_blocker/power_save_blocker_impl.h
[add] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/device/power_save_blocker/power_save_blocker_jni_registrar.cc
[add] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/device/power_save_blocker/power_save_blocker_jni_registrar.h
[rename] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/device/power_save_blocker/power_save_blocker_mac.cc
[rename] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/device/power_save_blocker/power_save_blocker_ozone.cc
[rename] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/device/power_save_blocker/power_save_blocker_win.cc
[rename] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/device/power_save_blocker/power_save_blocker_x11.cc
[modify] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/device/test/run_all_unittests.cc
[modify] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/extensions/browser/BUILD.gn
[modify] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/extensions/browser/DEPS
[modify] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/extensions/browser/api/power/power_api.cc
[modify] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/extensions/browser/api/power/power_api.h
[modify] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/extensions/browser/api/power/power_api_unittest.cc
[modify] https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9/extensions/extensions.gyp
Project Member

Comment 20 by bugdroid1@chromium.org, Jun 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90f7c1198c9c1ceb406834061b31f8f980b672ea

commit 90f7c1198c9c1ceb406834061b31f8f980b672ea
Author: scottmg <scottmg@chromium.org>
Date: Fri Jun 17 23:07:57 2016

Remove content/browser/power_save_blocker_factory.*

Followup to https://codereview.chromium.org/1999953002. Just inline the creation
call rather than having a separate factory function.

R=jam@chromium.org
BUG= 612337 , 612563 

Review-Url: https://codereview.chromium.org/2072403002
Cr-Commit-Position: refs/heads/master@{#400534}

[modify] https://crrev.com/90f7c1198c9c1ceb406834061b31f8f980b672ea/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/90f7c1198c9c1ceb406834061b31f8f980b672ea/content/browser/download/download_browsertest.cc
[modify] https://crrev.com/90f7c1198c9c1ceb406834061b31f8f980b672ea/content/browser/download/download_request_core.cc
[modify] https://crrev.com/90f7c1198c9c1ceb406834061b31f8f980b672ea/content/browser/loader/DEPS
[modify] https://crrev.com/90f7c1198c9c1ceb406834061b31f8f980b672ea/content/browser/media/capture/aura_window_capture_machine.cc
[modify] https://crrev.com/90f7c1198c9c1ceb406834061b31f8f980b672ea/content/browser/media/capture/desktop_capture_device.cc
[modify] https://crrev.com/90f7c1198c9c1ceb406834061b31f8f980b672ea/content/browser/media/media_web_contents_observer.cc
[modify] https://crrev.com/90f7c1198c9c1ceb406834061b31f8f980b672ea/content/browser/media/webrtc/webrtc_internals.cc
[delete] https://crrev.com/d266d0a340d9e9dd84d852efa1079349f6426b14/content/browser/power_save_blocker_factory.cc
[delete] https://crrev.com/d266d0a340d9e9dd84d852efa1079349f6426b14/content/browser/power_save_blocker_factory.h
[modify] https://crrev.com/90f7c1198c9c1ceb406834061b31f8f980b672ea/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/90f7c1198c9c1ceb406834061b31f8f980b672ea/content/browser/wake_lock/wake_lock_service_context.cc
[modify] https://crrev.com/90f7c1198c9c1ceb406834061b31f8f980b672ea/content/content_browser.gypi
[modify] https://crrev.com/90f7c1198c9c1ceb406834061b31f8f980b672ea/content/content_tests.gypi
[modify] https://crrev.com/90f7c1198c9c1ceb406834061b31f8f980b672ea/content/test/BUILD.gn
Project Member

Comment 21 by bugdroid1@chromium.org, Jun 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05236db107f7843dcbff08718f2ef2bd2c248969

commit 05236db107f7843dcbff08718f2ef2bd2c248969
Author: scottmg <scottmg@chromium.org>
Date: Sat Jun 18 01:33:12 2016

Merge PowerSaveBlockerImpl and PowerSaveBlocker

Followup to https://codereview.chromium.org/1999953002. The split was
previously required to expose via the content API, but now we can
collapse them after moving to //device.

BUG= 612337 ,  612563 

Review-Url: https://codereview.chromium.org/2073353002
Cr-Commit-Position: refs/heads/master@{#400567}

[modify] https://crrev.com/05236db107f7843dcbff08718f2ef2bd2c248969/chrome/browser/media/cast_transport_host_filter.cc
[modify] https://crrev.com/05236db107f7843dcbff08718f2ef2bd2c248969/components/drive/drive_uploader.cc
[modify] https://crrev.com/05236db107f7843dcbff08718f2ef2bd2c248969/content/browser/DEPS
[modify] https://crrev.com/05236db107f7843dcbff08718f2ef2bd2c248969/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/05236db107f7843dcbff08718f2ef2bd2c248969/content/browser/devtools/render_frame_devtools_agent_host.h
[modify] https://crrev.com/05236db107f7843dcbff08718f2ef2bd2c248969/content/browser/download/download_browsertest.cc
[modify] https://crrev.com/05236db107f7843dcbff08718f2ef2bd2c248969/content/browser/download/download_request_core.cc
[modify] https://crrev.com/05236db107f7843dcbff08718f2ef2bd2c248969/content/browser/loader/power_save_block_resource_throttle.cc
[modify] https://crrev.com/05236db107f7843dcbff08718f2ef2bd2c248969/content/browser/media/capture/aura_window_capture_machine.cc
[modify] https://crrev.com/05236db107f7843dcbff08718f2ef2bd2c248969/content/browser/media/capture/desktop_capture_device.cc
[modify] https://crrev.com/05236db107f7843dcbff08718f2ef2bd2c248969/content/browser/media/media_web_contents_observer.cc
[modify] https://crrev.com/05236db107f7843dcbff08718f2ef2bd2c248969/content/browser/media/webrtc/webrtc_internals.cc
[modify] https://crrev.com/05236db107f7843dcbff08718f2ef2bd2c248969/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/05236db107f7843dcbff08718f2ef2bd2c248969/content/browser/wake_lock/wake_lock_service_context.cc
[modify] https://crrev.com/05236db107f7843dcbff08718f2ef2bd2c248969/device/power_save_blocker/BUILD.gn
[modify] https://crrev.com/05236db107f7843dcbff08718f2ef2bd2c248969/device/power_save_blocker/power_save_blocker.gyp
[modify] https://crrev.com/05236db107f7843dcbff08718f2ef2bd2c248969/device/power_save_blocker/power_save_blocker.h
[modify] https://crrev.com/05236db107f7843dcbff08718f2ef2bd2c248969/device/power_save_blocker/power_save_blocker_android.cc
[modify] https://crrev.com/05236db107f7843dcbff08718f2ef2bd2c248969/device/power_save_blocker/power_save_blocker_chromeos.cc
[delete] https://crrev.com/8b69356ad2c80fcde148542b22b407860b224643/device/power_save_blocker/power_save_blocker_impl.cc
[delete] https://crrev.com/8b69356ad2c80fcde148542b22b407860b224643/device/power_save_blocker/power_save_blocker_impl.h
[modify] https://crrev.com/05236db107f7843dcbff08718f2ef2bd2c248969/device/power_save_blocker/power_save_blocker_mac.cc
[modify] https://crrev.com/05236db107f7843dcbff08718f2ef2bd2c248969/device/power_save_blocker/power_save_blocker_ozone.cc
[modify] https://crrev.com/05236db107f7843dcbff08718f2ef2bd2c248969/device/power_save_blocker/power_save_blocker_win.cc
[modify] https://crrev.com/05236db107f7843dcbff08718f2ef2bd2c248969/device/power_save_blocker/power_save_blocker_x11.cc
[modify] https://crrev.com/05236db107f7843dcbff08718f2ef2bd2c248969/extensions/browser/api/power/power_api.cc
[modify] https://crrev.com/05236db107f7843dcbff08718f2ef2bd2c248969/extensions/browser/api/power/power_api_unittest.cc
Project Member

Comment 22 by bugdroid1@chromium.org, Jun 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d031a4bc2c65557c7ade9268f4cbb538e15d7e58

commit d031a4bc2c65557c7ade9268f4cbb538e15d7e58
Author: mostynb <mostynb@opera.com>
Date: Mon Jun 20 18:05:38 2016

add some missing power_save_blocker gyp deps

Followup to https://codereview.chromium.org/2075153002

BUG= 612337 ,  612563 ,  257943 

Review-Url: https://codereview.chromium.org/2073393002
Cr-Commit-Position: refs/heads/master@{#400723}

[modify] https://crrev.com/d031a4bc2c65557c7ade9268f4cbb538e15d7e58/device/power_save_blocker/power_save_blocker.gyp

Comment 23 by scottmg@chromium.org, Jun 20 2016

Status: Fixed (was: Started)

Comment 24 by laforge@google.com, Nov 7 2017

Components: Internals>Network>Service

Comment 25 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.

Comment 26 by laforge@google.com, Nov 7 2017

Labels: Type-Task
Migrating S13N meta bugs to Type=Task, so that they can be distinguished from technical work.
►

Sign in to add a comment