Issue 612334 link

Starred by 6 users

Issue metadata

Status:	Fixed
Owner:	mcasas@chromium.org
Closed:	Aug 2016
Cc:	w...@chromium.org mvanouwe...@chromium.org timvolod...@chromium.org █ tsergeant@chromium.org lethalantidote@chromium.org
Components:	Blink>Geolocation Internals>Services
EstimatedDays:	----
NextAction:	----
OS:	All
Pri:	2
Type:	Task
Hotlist-Merge-Review merge-merged-2804 merge-merged-2810

Blocked on:
issue 623114
issue 623132

Blocking:
issue 598069
issue 612328

Content Modularization Project: Geolocation service

Project Member Reported by jam@chromium.org, May 16 2016

Issue description

Tracking bug for the geolocation part of the Content Modularization Project. The end goal should be to have a self-contained service. As part of getting rid (or greatly reducing) content/, this code should move out of content/. Most likely to device/geolocation to be consistent with what's being done for other device related APIs.

Strawman proposal, following other services that we're extracting from content:
-eliminate the dependencies in this code on other code in content/
-move remaining code in content/browser/geolocation to device/geolocation

Comment 1 by jam@chromium.org, May 17 2016

Blocking: -598073 598069

Comment 2 by mvanouwe...@chromium.org, May 17 2016

Components: Blink>Location

Comment 3 by leon....@intel.com, Jun 7 2016

Hi, anyone working for this now? If possible I'd like to take this issue, WDYT? Thanks~

Comment 4 by mvanouwe...@chromium.org, Jun 7 2016

There's currently some discussion on whether to tackle this, but no one has committed to it yet.

Comment 5 by jam@chromium.org, Jun 7 2016

Thanks for the offer Leon. As Michael mentions, a team at Google might do this because they need it soon. If they don't, then your help doing this would be very appreciated. We'll update this bug within a day or two.

Comment 6 by leon....@intel.com, Jun 8 2016

OK I see. Thanks for your feedback ;-)

Comment 7 by leon....@intel.com, Jun 8 2016

And, I'm happy to contribute for the Content Modularization Project if there have any tasks considered needed and possible for me. Just ping me at any time~ Thanks~

Comment 8 by jam@chromium.org, Jun 17 2016

Cc: mcasas@chromium.org

Comment 9 by mcasas@chromium.org, Jun 17 2016

Cc: -mcasas@chromium.org
Labels: OS-All
Owner: mcasas@chromium.org
Status: Started (was: Available)

Project Member

Comment 10 by bugdroid1@chromium.org, Jun 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb78b8ad1bc06869f1d0c3b533dc3f0a81f75811

commit fb78b8ad1bc06869f1d0c3b533dc3f0a81f75811
Author: mcasas <mcasas@chromium.org>
Date: Tue Jun 28 20:24:38 2016

Geolocation: extract ContentBrowserClient methods specific to Geolocation into a class

ToT ContentBrowserClient defines three methods:
+ bool UseNetworkLocationProvider()
  (overriden in {blimp,content}_browser_client)
+ LocationProvider* OverrideSystemLocationProvider()
 (overriden in (a) downstream project(s) and
   blimp_content_browser_client.)
+ AccessTokenStore* CreateAccessTokenStore()
 (overriden in {aw,cast,chrome,content,shell}_browser_client.)

which are used from LocationArbitratorImpl, after
accessing the embedder via GetContentClient()->browser().

This CL changes LocationArbitratorImpl to get a (weak)
GeolocationProvider::Delegate* on ctor; this object
encapsulates the 3 previously mentioned  methods, that are
(partially) overriden in each Client.

This CL also changes all those implementations and
the unittests (which is quite simplified) to follow the
object-getter pattern.

This CL is a preliminary step to move Geolocation to //device/
and is a refactoring.

BUG=612334
TEST=all relevant unittests and browser_tests working, in
particular
./out/gn/browser_tests --gtest_filter="GeolocationBrowserTest.*"
./out/gn/content_unittests --gtest_filter="GeolocationLocationArbitratorTest.*"

Review-Url: https://codereview.chromium.org/2098553002
Cr-Commit-Position: refs/heads/master@{#402526}

[modify] https://crrev.com/fb78b8ad1bc06869f1d0c3b533dc3f0a81f75811/android_webview/browser/aw_content_browser_client.cc
[modify] https://crrev.com/fb78b8ad1bc06869f1d0c3b533dc3f0a81f75811/android_webview/browser/aw_content_browser_client.h
[modify] https://crrev.com/fb78b8ad1bc06869f1d0c3b533dc3f0a81f75811/blimp/engine/app/blimp_content_browser_client.cc
[modify] https://crrev.com/fb78b8ad1bc06869f1d0c3b533dc3f0a81f75811/blimp/engine/app/blimp_content_browser_client.h
[modify] https://crrev.com/fb78b8ad1bc06869f1d0c3b533dc3f0a81f75811/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/fb78b8ad1bc06869f1d0c3b533dc3f0a81f75811/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/fb78b8ad1bc06869f1d0c3b533dc3f0a81f75811/chromecast/browser/cast_content_browser_client.cc
[modify] https://crrev.com/fb78b8ad1bc06869f1d0c3b533dc3f0a81f75811/chromecast/browser/cast_content_browser_client.h
[modify] https://crrev.com/fb78b8ad1bc06869f1d0c3b533dc3f0a81f75811/content/browser/geolocation/geolocation_provider_impl.cc
[modify] https://crrev.com/fb78b8ad1bc06869f1d0c3b533dc3f0a81f75811/content/browser/geolocation/geolocation_provider_impl.h
[modify] https://crrev.com/fb78b8ad1bc06869f1d0c3b533dc3f0a81f75811/content/browser/geolocation/location_arbitrator_impl.cc
[modify] https://crrev.com/fb78b8ad1bc06869f1d0c3b533dc3f0a81f75811/content/browser/geolocation/location_arbitrator_impl.h
[modify] https://crrev.com/fb78b8ad1bc06869f1d0c3b533dc3f0a81f75811/content/browser/geolocation/location_arbitrator_impl_unittest.cc
[modify] https://crrev.com/fb78b8ad1bc06869f1d0c3b533dc3f0a81f75811/content/content_browser.gypi
[modify] https://crrev.com/fb78b8ad1bc06869f1d0c3b533dc3f0a81f75811/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/fb78b8ad1bc06869f1d0c3b533dc3f0a81f75811/content/public/browser/content_browser_client.h
[add] https://crrev.com/fb78b8ad1bc06869f1d0c3b533dc3f0a81f75811/content/public/browser/geolocation_provider.cc
[modify] https://crrev.com/fb78b8ad1bc06869f1d0c3b533dc3f0a81f75811/content/public/browser/geolocation_provider.h
[modify] https://crrev.com/fb78b8ad1bc06869f1d0c3b533dc3f0a81f75811/content/shell/browser/shell_content_browser_client.cc
[modify] https://crrev.com/fb78b8ad1bc06869f1d0c3b533dc3f0a81f75811/content/shell/browser/shell_content_browser_client.h

Project Member

Comment 11 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b05e977fa72205d2b7d8da7b8c82be063d02db98

commit b05e977fa72205d2b7d8da7b8c82be063d02db98
Author: mcasas <mcasas@chromium.org>
Date: Wed Jun 29 19:44:04 2016

Geolocation: Extract GeolocationProvider::Delegate into GeolocationDelegate (no new code)

This CL extracts GeolocationProvider::Delegate into
GeolocationDelegate, and adjust call/use sites. The
implementation is moved to content internals and to
a file on its own. No new code is added, this CL just
shoves code around.

Following up on https://codereview.chromium.org/2098553002/#msg33 :
> nit: I realize this is moving to device/. I would encourage you to make this to
> be a separate header (i.e. geolocation_delegate.) for two reasons:
> 1) it can be overridden and forward declared without including the this header
> 2) once you move this to device/geolocation, there's no more need for an
> interface/impl split of GeolocationProvider since it's out of content. so more
> stuff will move to this parent class.

BUG=612334

Review-Url: https://codereview.chromium.org/2104193002
Cr-Commit-Position: refs/heads/master@{#402904}

[modify] https://crrev.com/b05e977fa72205d2b7d8da7b8c82be063d02db98/android_webview/browser/aw_content_browser_client.cc
[modify] https://crrev.com/b05e977fa72205d2b7d8da7b8c82be063d02db98/android_webview/browser/aw_content_browser_client.h
[modify] https://crrev.com/b05e977fa72205d2b7d8da7b8c82be063d02db98/blimp/engine/app/blimp_content_browser_client.cc
[modify] https://crrev.com/b05e977fa72205d2b7d8da7b8c82be063d02db98/blimp/engine/app/blimp_content_browser_client.h
[modify] https://crrev.com/b05e977fa72205d2b7d8da7b8c82be063d02db98/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/b05e977fa72205d2b7d8da7b8c82be063d02db98/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/b05e977fa72205d2b7d8da7b8c82be063d02db98/chromecast/browser/cast_content_browser_client.cc
[modify] https://crrev.com/b05e977fa72205d2b7d8da7b8c82be063d02db98/chromecast/browser/cast_content_browser_client.h
[modify] https://crrev.com/b05e977fa72205d2b7d8da7b8c82be063d02db98/content/browser/geolocation/geolocation_provider_impl.cc
[modify] https://crrev.com/b05e977fa72205d2b7d8da7b8c82be063d02db98/content/browser/geolocation/geolocation_provider_impl.h
[modify] https://crrev.com/b05e977fa72205d2b7d8da7b8c82be063d02db98/content/browser/geolocation/location_arbitrator_impl.cc
[modify] https://crrev.com/b05e977fa72205d2b7d8da7b8c82be063d02db98/content/browser/geolocation/location_arbitrator_impl.h
[modify] https://crrev.com/b05e977fa72205d2b7d8da7b8c82be063d02db98/content/browser/geolocation/location_arbitrator_impl_unittest.cc
[modify] https://crrev.com/b05e977fa72205d2b7d8da7b8c82be063d02db98/content/content_browser.gypi
[modify] https://crrev.com/b05e977fa72205d2b7d8da7b8c82be063d02db98/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/b05e977fa72205d2b7d8da7b8c82be063d02db98/content/public/browser/content_browser_client.h
[add] https://crrev.com/b05e977fa72205d2b7d8da7b8c82be063d02db98/content/public/browser/geolocation_delegate.cc
[add] https://crrev.com/b05e977fa72205d2b7d8da7b8c82be063d02db98/content/public/browser/geolocation_delegate.h
[delete] https://crrev.com/d056e7e6f2591527523c92b429d70b5df3c3114f/content/public/browser/geolocation_provider.cc
[modify] https://crrev.com/b05e977fa72205d2b7d8da7b8c82be063d02db98/content/public/browser/geolocation_provider.h
[modify] https://crrev.com/b05e977fa72205d2b7d8da7b8c82be063d02db98/content/shell/browser/shell_content_browser_client.cc
[modify] https://crrev.com/b05e977fa72205d2b7d8da7b8c82be063d02db98/content/shell/browser/shell_content_browser_client.h

Comment 12 by mcasas@chromium.org, Jul 8 2016

Blockedon: 623114 623132

Project Member

Comment 13 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19677cb9f1901f0eb7881380ac85a0255195e06d

commit 19677cb9f1901f0eb7881380ac85a0255195e06d
Author: mcasas <mcasas@chromium.org>
Date: Fri Jul 22 03:20:27 2016

Geolocation: change GeolocationDelegate to injected by content/

GeolocationProviderImpl is a singleton that directly references
GetContentClient()::browser() on ctor, to retrieve an embedder-
provider GeolocationDelegate. This blocks moving Geolocation
out of content/

This CL changes that mechanism: the GeolocationDelegate
is injected in BrowserMainLoop::PostMainMessageLoopStart()
(so it won't affect startup time IIUC), and kept in a variable
until the singleton construction.

This CL is the last blocking factor before taking Geolocation
out of content/browser and into device.

BUG=612334
TEST=./out/gn/browser_tests --gtest_filter="GeolocationBrowserTest.*"

PS:
A note about shell_content_browser_client.cc: Changing
GeolocationDelegate to injected, causes component's
AutofillRiskFingerprintTest  to start failing because
ShellGeolocationDelegate was initialized too early
and could not get a correct ShellBrowserContext*.
This CL also changes the ShellGeolocationDelegate to get
the browser_context() when is needed.

Review-Url: https://codereview.chromium.org/2127973002
Cr-Commit-Position: refs/heads/master@{#407015}

[modify] https://crrev.com/19677cb9f1901f0eb7881380ac85a0255195e06d/content/browser/browser_main_loop.cc
[modify] https://crrev.com/19677cb9f1901f0eb7881380ac85a0255195e06d/content/browser/geolocation/geolocation_provider_impl.cc
[modify] https://crrev.com/19677cb9f1901f0eb7881380ac85a0255195e06d/content/browser/geolocation/geolocation_provider_impl.h
[modify] https://crrev.com/19677cb9f1901f0eb7881380ac85a0255195e06d/content/public/browser/geolocation_provider.h
[modify] https://crrev.com/19677cb9f1901f0eb7881380ac85a0255195e06d/content/shell/browser/shell_content_browser_client.cc

Project Member

Comment 14 by bugdroid1@chromium.org, Jul 22 2016

Labels: merge-merged-2804

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19677cb9f1901f0eb7881380ac85a0255195e06d

commit 19677cb9f1901f0eb7881380ac85a0255195e06d
Author: mcasas <mcasas@chromium.org>
Date: Fri Jul 22 03:20:27 2016

Geolocation: change GeolocationDelegate to injected by content/

GeolocationProviderImpl is a singleton that directly references
GetContentClient()::browser() on ctor, to retrieve an embedder-
provider GeolocationDelegate. This blocks moving Geolocation
out of content/

This CL changes that mechanism: the GeolocationDelegate
is injected in BrowserMainLoop::PostMainMessageLoopStart()
(so it won't affect startup time IIUC), and kept in a variable
until the singleton construction.

This CL is the last blocking factor before taking Geolocation
out of content/browser and into device.

BUG=612334
TEST=./out/gn/browser_tests --gtest_filter="GeolocationBrowserTest.*"

PS:
A note about shell_content_browser_client.cc: Changing
GeolocationDelegate to injected, causes component's
AutofillRiskFingerprintTest  to start failing because
ShellGeolocationDelegate was initialized too early
and could not get a correct ShellBrowserContext*.
This CL also changes the ShellGeolocationDelegate to get
the browser_context() when is needed.

Review-Url: https://codereview.chromium.org/2127973002
Cr-Commit-Position: refs/heads/master@{#407015}

[modify] https://crrev.com/19677cb9f1901f0eb7881380ac85a0255195e06d/content/browser/browser_main_loop.cc
[modify] https://crrev.com/19677cb9f1901f0eb7881380ac85a0255195e06d/content/browser/geolocation/geolocation_provider_impl.cc
[modify] https://crrev.com/19677cb9f1901f0eb7881380ac85a0255195e06d/content/browser/geolocation/geolocation_provider_impl.h
[modify] https://crrev.com/19677cb9f1901f0eb7881380ac85a0255195e06d/content/public/browser/geolocation_provider.h
[modify] https://crrev.com/19677cb9f1901f0eb7881380ac85a0255195e06d/content/shell/browser/shell_content_browser_client.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80ef5237b1c8089848df230b25dad099acf0dff6

commit 80ef5237b1c8089848df230b25dad099acf0dff6
Author: mcasas <mcasas@chromium.org>
Date: Fri Jul 22 23:00:47 2016

Geolocation: move creation of the GeolocationDelegate to the embedders

This CL nukes ContentBrowserClient::CreateGeolocationDelegate()
and their overrides, and transfers each embedder's callsite to the
appropriate correspondent BrowserMainParts. These embedders are
namely: android_webview,  blimp, cast, chrome and content_shell.

Continuation of https://crrev.com/2127973002/.

BUG=612334

Review-Url: https://codereview.chromium.org/2174613002
Cr-Commit-Position: refs/heads/master@{#407291}

[modify] https://crrev.com/80ef5237b1c8089848df230b25dad099acf0dff6/android_webview/browser/aw_browser_main_parts.cc
[modify] https://crrev.com/80ef5237b1c8089848df230b25dad099acf0dff6/android_webview/browser/aw_content_browser_client.cc
[modify] https://crrev.com/80ef5237b1c8089848df230b25dad099acf0dff6/android_webview/browser/aw_content_browser_client.h
[modify] https://crrev.com/80ef5237b1c8089848df230b25dad099acf0dff6/blimp/engine/app/blimp_browser_main_parts.cc
[modify] https://crrev.com/80ef5237b1c8089848df230b25dad099acf0dff6/blimp/engine/app/blimp_content_browser_client.cc
[modify] https://crrev.com/80ef5237b1c8089848df230b25dad099acf0dff6/blimp/engine/app/blimp_content_browser_client.h
[modify] https://crrev.com/80ef5237b1c8089848df230b25dad099acf0dff6/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/80ef5237b1c8089848df230b25dad099acf0dff6/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/80ef5237b1c8089848df230b25dad099acf0dff6/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/80ef5237b1c8089848df230b25dad099acf0dff6/chromecast/browser/cast_browser_main_parts.cc
[modify] https://crrev.com/80ef5237b1c8089848df230b25dad099acf0dff6/chromecast/browser/cast_content_browser_client.cc
[modify] https://crrev.com/80ef5237b1c8089848df230b25dad099acf0dff6/chromecast/browser/cast_content_browser_client.h
[modify] https://crrev.com/80ef5237b1c8089848df230b25dad099acf0dff6/content/browser/browser_main_loop.cc
[modify] https://crrev.com/80ef5237b1c8089848df230b25dad099acf0dff6/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/80ef5237b1c8089848df230b25dad099acf0dff6/content/public/browser/content_browser_client.h
[modify] https://crrev.com/80ef5237b1c8089848df230b25dad099acf0dff6/content/shell/browser/shell_browser_main_parts.cc
[modify] https://crrev.com/80ef5237b1c8089848df230b25dad099acf0dff6/content/shell/browser/shell_content_browser_client.cc
[modify] https://crrev.com/80ef5237b1c8089848df230b25dad099acf0dff6/content/shell/browser/shell_content_browser_client.h

Comment 16 by mcasas@chromium.org, Jul 27 2016

Cc: lethalantidote@chromium.org w...@chromium.org

Project Member

Comment 17 by bugdroid1@chromium.org, Jul 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/822d05507b47dffc998a77e30e9f46c9c070045b

commit 822d05507b47dffc998a77e30e9f46c9c070045b
Author: mcasas <mcasas@chromium.org>
Date: Wed Jul 27 17:07:24 2016

Geolocation: move from content/browser to device/

This CL:

- moves all of content/browser/geolocation to device/geolocation
- the public geolocation files in content/common/{browser, public}
 are also relocated to device/geolocation
- the geolocation-specific unittests are compiled into
 (already existing) device_unittests
- adds new fancy new device/geolocation BUILD.gn  and
 geolocation.gyp as well
- makes a component of geolocation (at least for gn) and that forces
 adding geolocation_export.h (like other //device/ folders).
- Java Geolocation files are moved as well, and a new
 geolocation_jni_registrar is added.
- classes are moved to device namespace.

All paths and include/call sites updated, DEPS, BUILD.gn files,
gypi files etc.

Some tricks:
- can't use BrowserThread::CurrentlyOn, etc; instead, the
 task runner is cached on constructor and used for both thread
 checking and PostTask()ing (a few unittest and wifi_data_provider*
 needed that substitution).
- GeolocationServiceContext is moved to public/cpp so it can
 be referenced from WebContentsImpl.
- MockLocationProvider.java is also moved to device/geolocation.

BUG=612334
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

TBR=pstew@chromium.org
rationale:device/geolocation depends on dbus and this triggers
a DEPS presubmit rule -- however, this CL adds no new dependencies,
hence moving on in the interest of speed (and avoiding more rebases).

Review-Url: https://codereview.chromium.org/2176753003
Cr-Commit-Position: refs/heads/master@{#408160}

[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/android_webview/browser/DEPS
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/android_webview/browser/aw_browser_main_parts.cc
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/android_webview/browser/aw_content_browser_client.cc
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/android_webview/javatests/DEPS
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/android_webview/javatests/src/org/chromium/android_webview/test/GeolocationTest.java
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/android_webview/test/BUILD.gn
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/blimp/engine/BUILD.gn
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/blimp/engine/DEPS
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/blimp/engine/app/blimp_content_browser_client.cc
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/blimp/engine/feature/geolocation/blimp_location_provider.cc
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/blimp/engine/feature/geolocation/blimp_location_provider.h
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/blimp/engine/feature/geolocation/blimp_location_provider_unittest.cc
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/blimp/engine/feature/geolocation/engine_geolocation_feature.cc
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/blimp/engine/feature/geolocation/engine_geolocation_feature.h
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/blimp/engine/feature/geolocation/engine_geolocation_feature_unittest.cc
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/blimp/engine/feature/geolocation/mock_blimp_location_provider_delegate.h
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/blimp/engine/session/blimp_engine_session.cc
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/chrome/android/BUILD.gn
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/chrome/android/javatests/DEPS
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/chrome/android/javatests/src/org/chromium/chrome/browser/GeolocationTest.java
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/chrome/browser/DEPS
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/chrome/browser/chromeos/policy/device_status_collector.cc
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/chrome/browser/chromeos/policy/device_status_collector.h
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/chrome/browser/chromeos/policy/device_status_collector_browsertest.cc
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/chrome/browser/geolocation/access_token_store_browsertest.cc
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/chrome/browser/geolocation/chrome_access_token_store.cc
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/chrome/browser/geolocation/chrome_access_token_store.h
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/chrome/browser/geolocation/geolocation_browsertest.cc
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/chrome/browser/geolocation/geolocation_permission_context.cc
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/chrome/test/DEPS
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/chrome/test/base/ui_test_utils.cc
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/chromecast/browser/BUILD.gn
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/chromecast/browser/DEPS
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/chromecast/browser/cast_browser_main_parts.cc
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/chromecast/browser/geolocation/cast_access_token_store.h
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/chromeos/geolocation/DEPS
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/chromeos/geolocation/geoposition.h
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/components/BUILD.gn
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/components/autofill.gypi
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/components/autofill/content/browser/BUILD.gn
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/components/autofill/content/browser/DEPS
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/components/autofill/content/browser/risk/fingerprint.cc
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/components/autofill/content/browser/risk/fingerprint_browsertest.cc
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/content/DEPS
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/content/app/BUILD.gn
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/content/app/DEPS
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/content/app/android/library_loader_hooks.cc
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/content/browser/BUILD.gn
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/content/browser/DEPS
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/content/browser/android/browser_jni_registrar.cc
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/content/browser/android/content_view_core_impl.cc
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/content/browser/browser_main_loop.cc
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/content/browser/devtools/protocol/emulation_handler.cc
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/content/browser/frame_host/render_frame_host_delegate.cc
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/content/browser/frame_host/render_frame_host_delegate.h
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/content/browser/frame_host/render_frame_host_impl.cc
[delete] https://crrev.com/c0338f99bca56370f27ba0d785c2f168264a9acd/content/browser/geolocation/DEPS
[delete] https://crrev.com/c0338f99bca56370f27ba0d785c2f168264a9acd/content/browser/geolocation/wifi_data_provider_win.h
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/content/content_browser.gypi
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/content/content_common.gypi
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/content/content_jni.gypi
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/content/content_shell.gypi
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/content/content_tests.gypi
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/content/public/android/BUILD.gn
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/content/public/android/javatests/src/org/chromium/content/browser/ContentViewLocationTest.java
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/content/public/android/javatests/src/org/chromium/content/browser/LocationProviderTest.java
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/content/public/browser/BUILD.gn
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/content/public/test/DEPS
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/content/public/test/android/BUILD.gn
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/content/public/test/content_test_suite_base.cc
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/content/shell/BUILD.gn
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/content/shell/android/BUILD.gn
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/content/shell/browser/DEPS
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/content/shell/browser/shell_access_token_store.h
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/content/shell/browser/shell_browser_main_parts.cc
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/content/test/BUILD.gn
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/BUILD.gn
[add] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/BUILD.gn
[add] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/DEPS
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/OWNERS
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/access_token_store.h
[add] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/android/geolocation_jni_registrar.cc
[add] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/android/geolocation_jni_registrar.h
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/android/java/org/chromium/device/geolocation/LocationProviderAdapter.java
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/android/java/org/chromium/device/geolocation/LocationProviderFactory.java
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/android/java/org/chromium/device/geolocation/MockLocationProvider.java
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/empty_wifi_data_provider.cc
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/empty_wifi_data_provider.h
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/fake_access_token_store.cc
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/fake_access_token_store.h
[add] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/geolocation.gyp
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/geolocation_delegate.cc
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/geolocation_delegate.h
[add] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/geolocation_export.h
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/geolocation_provider.h
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/geolocation_provider_impl.cc
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/geolocation_provider_impl.h
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/geolocation_provider_impl_unittest.cc
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/geolocation_service_context.cc
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/geolocation_service_context.h
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/geolocation_service_impl.cc
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/geolocation_service_impl.h
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/geoposition.cc
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/geoposition.h
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/location_api_adapter_android.cc
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/location_api_adapter_android.h
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/location_arbitrator.h
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/location_arbitrator_impl.cc
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/location_arbitrator_impl.h
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/location_arbitrator_impl_unittest.cc
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/location_provider.h
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/location_provider_android.cc
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/location_provider_android.h
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/location_provider_base.cc
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/location_provider_base.h
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/mock_location_arbitrator.cc
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/mock_location_arbitrator.h
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/mock_location_provider.cc
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/mock_location_provider.h
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/network_location_provider.cc
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/network_location_provider.h
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/network_location_provider_unittest.cc
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/network_location_request.cc
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/network_location_request.h
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/wifi_data.cc
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/wifi_data.h
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/wifi_data_provider.cc
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/wifi_data_provider.h
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/wifi_data_provider_chromeos.cc
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/wifi_data_provider_chromeos.h
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/wifi_data_provider_chromeos_unittest.cc
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/wifi_data_provider_common.cc
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/wifi_data_provider_common.h
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/wifi_data_provider_common_unittest.cc
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/wifi_data_provider_common_win.cc
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/wifi_data_provider_common_win.h
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/wifi_data_provider_corewlan_mac.mm
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/wifi_data_provider_linux.cc
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/wifi_data_provider_linux.h
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/wifi_data_provider_linux_unittest.cc
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/wifi_data_provider_mac.cc
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/wifi_data_provider_mac.h
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/wifi_data_provider_manager.cc
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/wifi_data_provider_manager.h
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/wifi_data_provider_win.cc
[add] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/wifi_data_provider_win.h
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/wifi_data_provider_win_unittest.cc
[rename] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/geolocation/wifi_polling_policy.h
[modify] https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b/device/test/run_all_unittests.cc

Project Member

Comment 18 by bugdroid1@chromium.org, Jul 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70e925bf7b6e6314034bf4af238adc03991f6d15

commit 70e925bf7b6e6314034bf4af238adc03991f6d15
Author: robliao <robliao@chromium.org>
Date: Wed Jul 27 18:00:51 2016

Revert of Geolocation: move from content/browser to device/ (patchset #3 id:580001 of https://codereview.chromium.org/2176753003/ )

Reason for revert:
Failed on a MSVC build

e:\b\c\b\win_gyp\src\device\geolocation\geolocation_delegate.cc(12): error C2220: warning treated as error - no 'object' file generated
e:\b\c\b\win_gyp\src\device\geolocation\geolocation_delegate.cc(12): warning C4273: 'device::GeolocationDelegate::UseNetworkLocationProviders': inconsistent dll linkage
e:\b\c\b\win_gyp\src\device\geolocation\geolocation_delegate.h(25): note: see previous definition of 'UseNetworkLocationProviders'
e:\b\c\b\win_gyp\src\device\geolocation\geolocation_delegate.cc(16): warning C4273: 'device::GeolocationDelegate::CreateAccessTokenStore': inconsistent dll linkage
e:\b\c\b\win_gyp\src\device\geolocation\geolocation_delegate.h(28): note: see previous definition of 'CreateAccessTokenStore'
e:\b\c\b\win_gyp\src\device\geolocation\geolocation_delegate.cc(21): warning C4273: 'device::GeolocationDelegate::OverrideSystemLocationProvider': inconsistent dll linkage
e:\b\c\b\win_gyp\src\device\geolocation\geolocation_delegate.h(34): note: see previous definition of 'OverrideSystemLocationProvider'
[210/2191] CXX obj\third_party\WebKit\Source\platform\graphics\paint\blink_platform.Transform3DDisplayItem.obj

Original issue's description:
> Geolocation: move from content/browser to device/
>
> This CL:
>
> - moves all of content/browser/geolocation to device/geolocation
> - the public geolocation files in content/common/{browser, public}
>  are also relocated to device/geolocation
> - the geolocation-specific unittests are compiled into
>  (already existing) device_unittests
> - adds new fancy new device/geolocation BUILD.gn  and
>  geolocation.gyp as well
> - makes a component of geolocation (at least for gn) and that forces
>  adding geolocation_export.h (like other //device/ folders).
> - Java Geolocation files are moved as well, and a new
>  geolocation_jni_registrar is added.
> - classes are moved to device namespace.
>
> All paths and include/call sites updated, DEPS, BUILD.gn files,
> gypi files etc.
>
> Some tricks:
> - can't use BrowserThread::CurrentlyOn, etc; instead, the
>  task runner is cached on constructor and used for both thread
>  checking and PostTask()ing (a few unittest and wifi_data_provider*
>  needed that substitution).
> - GeolocationServiceContext is moved to public/cpp so it can
>  be referenced from WebContentsImpl.
> - MockLocationProvider.java is also moved to device/geolocation.
>
> BUG=612334
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>
> TBR=pstew@chromium.org
> rationale:device/geolocation depends on dbus and this triggers
> a DEPS presubmit rule -- however, this CL adds no new dependencies,
> hence moving on in the interest of speed (and avoiding more rebases).
>
> Committed: https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b
> Cr-Commit-Position: refs/heads/master@{#408160}

TBR=jam@chromium.org,mcasas@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=612334

Review-Url: https://codereview.chromium.org/2191613002
Cr-Commit-Position: refs/heads/master@{#408178}

[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/android_webview/browser/DEPS
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/android_webview/browser/aw_browser_main_parts.cc
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/android_webview/browser/aw_content_browser_client.cc
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/android_webview/javatests/DEPS
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/android_webview/javatests/src/org/chromium/android_webview/test/GeolocationTest.java
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/android_webview/test/BUILD.gn
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/blimp/engine/BUILD.gn
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/blimp/engine/DEPS
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/blimp/engine/app/blimp_content_browser_client.cc
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/blimp/engine/feature/geolocation/blimp_location_provider.cc
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/blimp/engine/feature/geolocation/blimp_location_provider.h
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/blimp/engine/feature/geolocation/blimp_location_provider_unittest.cc
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/blimp/engine/feature/geolocation/engine_geolocation_feature.cc
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/blimp/engine/feature/geolocation/engine_geolocation_feature.h
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/blimp/engine/feature/geolocation/engine_geolocation_feature_unittest.cc
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/blimp/engine/feature/geolocation/mock_blimp_location_provider_delegate.h
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/blimp/engine/session/blimp_engine_session.cc
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/chrome/android/BUILD.gn
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/chrome/android/javatests/DEPS
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/chrome/android/javatests/src/org/chromium/chrome/browser/GeolocationTest.java
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/chrome/browser/DEPS
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/chrome/browser/chromeos/policy/device_status_collector.cc
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/chrome/browser/chromeos/policy/device_status_collector.h
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/chrome/browser/chromeos/policy/device_status_collector_browsertest.cc
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/chrome/browser/geolocation/access_token_store_browsertest.cc
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/chrome/browser/geolocation/chrome_access_token_store.cc
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/chrome/browser/geolocation/chrome_access_token_store.h
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/chrome/browser/geolocation/geolocation_browsertest.cc
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/chrome/browser/geolocation/geolocation_permission_context.cc
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/chrome/test/DEPS
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/chrome/test/base/ui_test_utils.cc
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/chromecast/browser/BUILD.gn
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/chromecast/browser/DEPS
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/chromecast/browser/cast_browser_main_parts.cc
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/chromecast/browser/geolocation/cast_access_token_store.h
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/chromeos/geolocation/DEPS
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/chromeos/geolocation/geoposition.h
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/components/BUILD.gn
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/components/autofill.gypi
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/components/autofill/content/browser/BUILD.gn
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/components/autofill/content/browser/DEPS
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/components/autofill/content/browser/risk/fingerprint.cc
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/components/autofill/content/browser/risk/fingerprint_browsertest.cc
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/DEPS
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/app/BUILD.gn
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/app/DEPS
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/app/android/library_loader_hooks.cc
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/BUILD.gn
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/DEPS
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/android/browser_jni_registrar.cc
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/android/content_view_core_impl.cc
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/browser_main_loop.cc
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/devtools/protocol/emulation_handler.cc
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/frame_host/render_frame_host_delegate.cc
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/frame_host/render_frame_host_delegate.h
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/frame_host/render_frame_host_impl.cc
[add] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/DEPS
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/OWNERS
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/empty_wifi_data_provider.cc
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/empty_wifi_data_provider.h
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/fake_access_token_store.cc
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/fake_access_token_store.h
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/geolocation_provider_impl.cc
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/geolocation_provider_impl.h
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/geolocation_provider_impl_unittest.cc
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/geolocation_service_context.cc
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/geolocation_service_context.h
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/geolocation_service_impl.cc
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/geolocation_service_impl.h
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/location_api_adapter_android.cc
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/location_api_adapter_android.h
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/location_arbitrator.h
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/location_arbitrator_impl.cc
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/location_arbitrator_impl.h
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/location_arbitrator_impl_unittest.cc
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/location_provider_android.cc
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/location_provider_android.h
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/location_provider_base.cc
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/location_provider_base.h
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/mock_location_arbitrator.cc
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/mock_location_arbitrator.h
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/mock_location_provider.cc
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/mock_location_provider.h
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/network_location_provider.cc
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/network_location_provider.h
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/network_location_provider_unittest.cc
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/network_location_request.cc
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/network_location_request.h
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/wifi_data.cc
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/wifi_data.h
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/wifi_data_provider.cc
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/wifi_data_provider.h
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/wifi_data_provider_chromeos.cc
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/wifi_data_provider_chromeos.h
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/wifi_data_provider_chromeos_unittest.cc
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/wifi_data_provider_common.cc
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/wifi_data_provider_common.h
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/wifi_data_provider_common_unittest.cc
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/wifi_data_provider_common_win.cc
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/wifi_data_provider_common_win.h
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/wifi_data_provider_corewlan_mac.mm
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/wifi_data_provider_linux.cc
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/wifi_data_provider_linux.h
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/wifi_data_provider_linux_unittest.cc
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/wifi_data_provider_mac.cc
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/wifi_data_provider_mac.h
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/wifi_data_provider_manager.cc
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/wifi_data_provider_manager.h
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/wifi_data_provider_win.cc
[add] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/wifi_data_provider_win.h
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/wifi_data_provider_win_unittest.cc
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/geolocation/wifi_polling_policy.h
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/content_browser.gypi
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/content_common.gypi
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/content_jni.gypi
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/content_shell.gypi
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/content_tests.gypi
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/public/android/BUILD.gn
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/public/android/java/src/org/chromium/content/browser/LocationProviderAdapter.java
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/public/android/java/src/org/chromium/content/browser/LocationProviderFactory.java
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/public/android/javatests/src/org/chromium/content/browser/ContentViewLocationTest.java
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/public/android/javatests/src/org/chromium/content/browser/LocationProviderTest.java
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/public/browser/BUILD.gn
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/public/browser/access_token_store.h
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/public/browser/geolocation_delegate.cc
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/public/browser/geolocation_delegate.h
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/public/browser/geolocation_provider.h
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/public/browser/location_provider.h
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/public/common/geoposition.cc
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/public/common/geoposition.h
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/public/test/DEPS
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/public/test/android/BUILD.gn
[rename] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/MockLocationProvider.java
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/public/test/content_test_suite_base.cc
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/shell/BUILD.gn
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/shell/android/BUILD.gn
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/shell/browser/DEPS
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/shell/browser/shell_access_token_store.h
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/shell/browser/shell_browser_main_parts.cc
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/content/test/BUILD.gn
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/device/BUILD.gn
[delete] https://crrev.com/d72245c40eb38ad816d5984e3d57d9d280c237a6/device/geolocation/BUILD.gn
[delete] https://crrev.com/d72245c40eb38ad816d5984e3d57d9d280c237a6/device/geolocation/DEPS
[delete] https://crrev.com/d72245c40eb38ad816d5984e3d57d9d280c237a6/device/geolocation/android/geolocation_jni_registrar.cc
[delete] https://crrev.com/d72245c40eb38ad816d5984e3d57d9d280c237a6/device/geolocation/android/geolocation_jni_registrar.h
[delete] https://crrev.com/d72245c40eb38ad816d5984e3d57d9d280c237a6/device/geolocation/geolocation.gyp
[delete] https://crrev.com/d72245c40eb38ad816d5984e3d57d9d280c237a6/device/geolocation/geolocation_export.h
[delete] https://crrev.com/d72245c40eb38ad816d5984e3d57d9d280c237a6/device/geolocation/wifi_data_provider_win.h
[modify] https://crrev.com/70e925bf7b6e6314034bf4af238adc03991f6d15/device/test/run_all_unittests.cc

Project Member

Comment 19 by bugdroid1@chromium.org, Jul 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7

commit cc322ebcb1c911072c8dc4fc38d41c1a41c426b7
Author: mcasas <mcasas@chromium.org>
Date: Wed Jul 27 23:34:39 2016

Reland: Geolocation: move from content/browser to device/

Original CL was reverted because it broke Win Gyp Component-build
bot(s). This CL (PS2) defines the geolocation gyp component
correctly.

Original CL description ------------------------------------------------
Geolocation: move from content/browser to device/

This CL:

- moves all of content/browser/geolocation to device/geolocation
- the public geolocation files in content/common/{browser, public}
 are also relocated to device/geolocation
- the geolocation-specific unittests are compiled into
 (already existing) device_unittests
- adds new fancy new device/geolocation BUILD.gn  and
 geolocation.gyp as well
- makes a component of geolocation (at least for gn) and that forces
 adding geolocation_export.h (like other //device/ folders).
- Java Geolocation files are moved as well, and a new
 geolocation_jni_registrar is added.
- classes are moved to device namespace.

All paths and include/call sites updated, DEPS, BUILD.gn files,
gypi files etc.

Some tricks:
- can't use BrowserThread::CurrentlyOn, etc; instead, the
 task runner is cached on constructor and used for both thread
 checking and PostTask()ing (a few unittest and wifi_data_provider*
 needed that substitution).
- GeolocationServiceContext is moved to public/cpp so it can
 be referenced from WebContentsImpl.
- MockLocationProvider.java is also moved to device/geolocation.

BUG=612334
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

TBR=pstew@chromium.org
rationale:device/geolocation depends on dbus and this triggers
a DEPS presubmit rule -- however, this CL adds no new dependencies,
hence moving on in the interest of speed (and avoiding more rebases).

Review-Url: https://codereview.chromium.org/2185993003
Cr-Commit-Position: refs/heads/master@{#408272}

[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/android_webview/browser/DEPS
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/android_webview/browser/aw_browser_main_parts.cc
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/android_webview/browser/aw_content_browser_client.cc
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/android_webview/javatests/DEPS
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/android_webview/javatests/src/org/chromium/android_webview/test/GeolocationTest.java
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/android_webview/test/BUILD.gn
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/blimp/engine/BUILD.gn
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/blimp/engine/DEPS
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/blimp/engine/app/blimp_content_browser_client.cc
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/blimp/engine/feature/geolocation/blimp_location_provider.cc
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/blimp/engine/feature/geolocation/blimp_location_provider.h
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/blimp/engine/feature/geolocation/blimp_location_provider_unittest.cc
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/blimp/engine/feature/geolocation/engine_geolocation_feature.cc
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/blimp/engine/feature/geolocation/engine_geolocation_feature.h
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/blimp/engine/feature/geolocation/engine_geolocation_feature_unittest.cc
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/blimp/engine/feature/geolocation/mock_blimp_location_provider_delegate.h
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/blimp/engine/session/blimp_engine_session.cc
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/chrome/android/BUILD.gn
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/chrome/android/javatests/DEPS
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/chrome/android/javatests/src/org/chromium/chrome/browser/GeolocationTest.java
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/chrome/browser/DEPS
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/chrome/browser/chromeos/policy/device_status_collector.cc
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/chrome/browser/chromeos/policy/device_status_collector.h
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/chrome/browser/chromeos/policy/device_status_collector_browsertest.cc
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/chrome/browser/geolocation/access_token_store_browsertest.cc
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/chrome/browser/geolocation/chrome_access_token_store.cc
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/chrome/browser/geolocation/chrome_access_token_store.h
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/chrome/browser/geolocation/geolocation_browsertest.cc
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/chrome/browser/geolocation/geolocation_permission_context.cc
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/chrome/test/DEPS
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/chrome/test/base/ui_test_utils.cc
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/chromecast/browser/BUILD.gn
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/chromecast/browser/DEPS
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/chromecast/browser/cast_browser_main_parts.cc
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/chromecast/browser/geolocation/cast_access_token_store.h
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/chromeos/geolocation/DEPS
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/chromeos/geolocation/geoposition.h
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/components/BUILD.gn
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/components/autofill.gypi
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/components/autofill/content/browser/BUILD.gn
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/components/autofill/content/browser/DEPS
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/components/autofill/content/browser/risk/fingerprint.cc
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/components/autofill/content/browser/risk/fingerprint_browsertest.cc
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/content/DEPS
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/content/app/BUILD.gn
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/content/app/DEPS
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/content/app/android/library_loader_hooks.cc
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/content/browser/BUILD.gn
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/content/browser/DEPS
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/content/browser/android/browser_jni_registrar.cc
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/content/browser/android/content_view_core_impl.cc
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/content/browser/browser_main_loop.cc
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/content/browser/devtools/protocol/emulation_handler.cc
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/content/browser/frame_host/render_frame_host_delegate.cc
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/content/browser/frame_host/render_frame_host_delegate.h
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/content/browser/frame_host/render_frame_host_impl.cc
[delete] https://crrev.com/a3c45128cb054e43525f64c05477d136ff89a708/content/browser/geolocation/DEPS
[delete] https://crrev.com/a3c45128cb054e43525f64c05477d136ff89a708/content/browser/geolocation/wifi_data_provider_win.h
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/content/content_browser.gypi
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/content/content_common.gypi
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/content/content_jni.gypi
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/content/content_shell.gypi
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/content/content_tests.gypi
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/content/public/android/BUILD.gn
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/content/public/android/javatests/src/org/chromium/content/browser/ContentViewLocationTest.java
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/content/public/android/javatests/src/org/chromium/content/browser/LocationProviderTest.java
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/content/public/browser/BUILD.gn
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/content/public/test/DEPS
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/content/public/test/android/BUILD.gn
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/content/public/test/content_test_suite_base.cc
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/content/shell/BUILD.gn
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/content/shell/android/BUILD.gn
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/content/shell/browser/DEPS
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/content/shell/browser/shell_access_token_store.h
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/content/shell/browser/shell_browser_main_parts.cc
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/content/test/BUILD.gn
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/BUILD.gn
[add] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/BUILD.gn
[add] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/DEPS
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/OWNERS
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/access_token_store.h
[add] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/android/geolocation_jni_registrar.cc
[add] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/android/geolocation_jni_registrar.h
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/android/java/org/chromium/device/geolocation/LocationProviderAdapter.java
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/android/java/org/chromium/device/geolocation/LocationProviderFactory.java
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/android/java/org/chromium/device/geolocation/MockLocationProvider.java
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/empty_wifi_data_provider.cc
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/empty_wifi_data_provider.h
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/fake_access_token_store.cc
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/fake_access_token_store.h
[add] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/geolocation.gyp
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/geolocation_delegate.cc
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/geolocation_delegate.h
[add] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/geolocation_export.h
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/geolocation_provider.h
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/geolocation_provider_impl.cc
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/geolocation_provider_impl.h
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/geolocation_provider_impl_unittest.cc
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/geolocation_service_context.cc
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/geolocation_service_context.h
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/geolocation_service_impl.cc
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/geolocation_service_impl.h
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/geoposition.cc
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/geoposition.h
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/location_api_adapter_android.cc
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/location_api_adapter_android.h
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/location_arbitrator.h
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/location_arbitrator_impl.cc
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/location_arbitrator_impl.h
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/location_arbitrator_impl_unittest.cc
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/location_provider.h
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/location_provider_android.cc
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/location_provider_android.h
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/location_provider_base.cc
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/location_provider_base.h
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/mock_location_arbitrator.cc
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/mock_location_arbitrator.h
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/mock_location_provider.cc
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/mock_location_provider.h
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/network_location_provider.cc
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/network_location_provider.h
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/network_location_provider_unittest.cc
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/network_location_request.cc
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/network_location_request.h
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/wifi_data.cc
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/wifi_data.h
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/wifi_data_provider.cc
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/wifi_data_provider.h
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/wifi_data_provider_chromeos.cc
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/wifi_data_provider_chromeos.h
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/wifi_data_provider_chromeos_unittest.cc
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/wifi_data_provider_common.cc
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/wifi_data_provider_common.h
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/wifi_data_provider_common_unittest.cc
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/wifi_data_provider_common_win.cc
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/wifi_data_provider_common_win.h
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/wifi_data_provider_corewlan_mac.mm
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/wifi_data_provider_linux.cc
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/wifi_data_provider_linux.h
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/wifi_data_provider_linux_unittest.cc
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/wifi_data_provider_mac.cc
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/wifi_data_provider_mac.h
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/wifi_data_provider_manager.cc
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/wifi_data_provider_manager.h
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/wifi_data_provider_win.cc
[add] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/wifi_data_provider_win.h
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/wifi_data_provider_win_unittest.cc
[rename] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/geolocation/wifi_polling_policy.h
[modify] https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7/device/test/run_all_unittests.cc

Project Member

Comment 20 by bugdroid1@chromium.org, Jul 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a5f51a5304bdcff7eea91f71be843b72c160d94

commit 6a5f51a5304bdcff7eea91f71be843b72c160d94
Author: robliao <robliao@chromium.org>
Date: Thu Jul 28 01:18:59 2016

Revert of Reland: Geolocation: move from content/browser to device/ (patchset #2 id:20001 of https://codereview.chromium.org/2185993003/ )

Reason for revert:
Build failure:
FAILED: obj/device/geolocation/device_geolocation.network_location_request.obj
ninja -t msvc -e environment.x64 -- "C:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\device\geolocation\device_geolocation.network_location_request.obj.rsp /c ..\..\device\geolocation\network_location_request.cc /Foobj\device\geolocation\device_geolocation.network_location_request.obj /Fdobj\device\geolocation\device_geolocation.cc.pdb
c:\b\build\slave\win64_trunk\build\src\device\geolocation\network_location_request.cc(119): error C2220: warning treated as error - no 'object' file generated
c:\b\build\slave\win64_trunk\build\src\device\geolocation\network_location_request.cc(119): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data

Original issue's description:
> Reland: Geolocation: move from content/browser to device/
>
> Original CL was reverted because it broke Win Gyp Component-build
> bot(s). This CL (PS2) defines the geolocation gyp component
> correctly.
>
> Original CL description ------------------------------------------------
> Geolocation: move from content/browser to device/
>
> This CL:
>
> - moves all of content/browser/geolocation to device/geolocation
> - the public geolocation files in content/common/{browser, public}
>  are also relocated to device/geolocation
> - the geolocation-specific unittests are compiled into
>  (already existing) device_unittests
> - adds new fancy new device/geolocation BUILD.gn  and
>  geolocation.gyp as well
> - makes a component of geolocation (at least for gn) and that forces
>  adding geolocation_export.h (like other //device/ folders).
> - Java Geolocation files are moved as well, and a new
>  geolocation_jni_registrar is added.
> - classes are moved to device namespace.
>
> All paths and include/call sites updated, DEPS, BUILD.gn files,
> gypi files etc.
>
> Some tricks:
> - can't use BrowserThread::CurrentlyOn, etc; instead, the
>  task runner is cached on constructor and used for both thread
>  checking and PostTask()ing (a few unittest and wifi_data_provider*
>  needed that substitution).
> - GeolocationServiceContext is moved to public/cpp so it can
>  be referenced from WebContentsImpl.
> - MockLocationProvider.java is also moved to device/geolocation.
>
> BUG=612334
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>
> TBR=pstew@chromium.org
> rationale:device/geolocation depends on dbus and this triggers
> a DEPS presubmit rule -- however, this CL adds no new dependencies,
> hence moving on in the interest of speed (and avoiding more rebases).
>
> Committed: https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7
> Cr-Commit-Position: refs/heads/master@{#408272}

TBR=pstew@chromium.org,mcasas@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=612334

Review-Url: https://codereview.chromium.org/2188933002
Cr-Commit-Position: refs/heads/master@{#408303}

[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/android_webview/browser/DEPS
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/android_webview/browser/aw_browser_main_parts.cc
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/android_webview/browser/aw_content_browser_client.cc
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/android_webview/javatests/DEPS
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/android_webview/javatests/src/org/chromium/android_webview/test/GeolocationTest.java
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/android_webview/test/BUILD.gn
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/blimp/engine/BUILD.gn
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/blimp/engine/DEPS
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/blimp/engine/app/blimp_content_browser_client.cc
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/blimp/engine/feature/geolocation/blimp_location_provider.cc
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/blimp/engine/feature/geolocation/blimp_location_provider.h
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/blimp/engine/feature/geolocation/blimp_location_provider_unittest.cc
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/blimp/engine/feature/geolocation/engine_geolocation_feature.cc
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/blimp/engine/feature/geolocation/engine_geolocation_feature.h
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/blimp/engine/feature/geolocation/engine_geolocation_feature_unittest.cc
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/blimp/engine/feature/geolocation/mock_blimp_location_provider_delegate.h
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/blimp/engine/session/blimp_engine_session.cc
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/chrome/android/BUILD.gn
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/chrome/android/javatests/DEPS
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/chrome/android/javatests/src/org/chromium/chrome/browser/GeolocationTest.java
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/chrome/browser/DEPS
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/chrome/browser/chromeos/policy/device_status_collector.cc
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/chrome/browser/chromeos/policy/device_status_collector.h
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/chrome/browser/chromeos/policy/device_status_collector_browsertest.cc
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/chrome/browser/geolocation/access_token_store_browsertest.cc
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/chrome/browser/geolocation/chrome_access_token_store.cc
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/chrome/browser/geolocation/chrome_access_token_store.h
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/chrome/browser/geolocation/geolocation_browsertest.cc
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/chrome/browser/geolocation/geolocation_permission_context.cc
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/chrome/test/DEPS
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/chrome/test/base/ui_test_utils.cc
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/chromecast/browser/BUILD.gn
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/chromecast/browser/DEPS
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/chromecast/browser/cast_browser_main_parts.cc
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/chromecast/browser/geolocation/cast_access_token_store.h
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/chromeos/geolocation/DEPS
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/chromeos/geolocation/geoposition.h
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/components/BUILD.gn
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/components/autofill.gypi
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/components/autofill/content/browser/BUILD.gn
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/components/autofill/content/browser/DEPS
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/components/autofill/content/browser/risk/fingerprint.cc
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/components/autofill/content/browser/risk/fingerprint_browsertest.cc
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/DEPS
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/app/BUILD.gn
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/app/DEPS
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/app/android/library_loader_hooks.cc
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/BUILD.gn
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/DEPS
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/android/browser_jni_registrar.cc
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/android/content_view_core_impl.cc
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/browser_main_loop.cc
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/devtools/protocol/emulation_handler.cc
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/frame_host/render_frame_host_delegate.cc
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/frame_host/render_frame_host_delegate.h
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/frame_host/render_frame_host_impl.cc
[add] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/DEPS
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/OWNERS
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/empty_wifi_data_provider.cc
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/empty_wifi_data_provider.h
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/fake_access_token_store.cc
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/fake_access_token_store.h
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/geolocation_provider_impl.cc
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/geolocation_provider_impl.h
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/geolocation_provider_impl_unittest.cc
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/geolocation_service_context.cc
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/geolocation_service_context.h
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/geolocation_service_impl.cc
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/geolocation_service_impl.h
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/location_api_adapter_android.cc
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/location_api_adapter_android.h
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/location_arbitrator.h
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/location_arbitrator_impl.cc
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/location_arbitrator_impl.h
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/location_arbitrator_impl_unittest.cc
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/location_provider_android.cc
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/location_provider_android.h
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/location_provider_base.cc
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/location_provider_base.h
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/mock_location_arbitrator.cc
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/mock_location_arbitrator.h
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/mock_location_provider.cc
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/mock_location_provider.h
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/network_location_provider.cc
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/network_location_provider.h
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/network_location_provider_unittest.cc
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/network_location_request.cc
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/network_location_request.h
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/wifi_data.cc
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/wifi_data.h
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/wifi_data_provider.cc
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/wifi_data_provider.h
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/wifi_data_provider_chromeos.cc
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/wifi_data_provider_chromeos.h
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/wifi_data_provider_chromeos_unittest.cc
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/wifi_data_provider_common.cc
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/wifi_data_provider_common.h
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/wifi_data_provider_common_unittest.cc
[add] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/wifi_data_provider_common_win.cc
[add] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/wifi_data_provider_common_win.h
[add] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/wifi_data_provider_corewlan_mac.mm
[add] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/wifi_data_provider_linux.cc
[add] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/wifi_data_provider_linux.h
[add] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/wifi_data_provider_linux_unittest.cc
[add] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/wifi_data_provider_mac.cc
[add] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/wifi_data_provider_mac.h
[add] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/wifi_data_provider_manager.cc
[add] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/wifi_data_provider_manager.h
[add] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/wifi_data_provider_win.cc
[add] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/wifi_data_provider_win.h
[add] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/wifi_data_provider_win_unittest.cc
[add] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/geolocation/wifi_polling_policy.h
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/content_browser.gypi
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/content_common.gypi
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/content_jni.gypi
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/content_shell.gypi
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/content_tests.gypi
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/public/android/BUILD.gn
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/public/android/java/src/org/chromium/content/browser/LocationProviderAdapter.java
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/public/android/java/src/org/chromium/content/browser/LocationProviderFactory.java
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/public/android/javatests/src/org/chromium/content/browser/ContentViewLocationTest.java
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/public/android/javatests/src/org/chromium/content/browser/LocationProviderTest.java
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/public/browser/BUILD.gn
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/public/browser/access_token_store.h
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/public/browser/geolocation_delegate.cc
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/public/browser/geolocation_delegate.h
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/public/browser/geolocation_provider.h
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/public/browser/location_provider.h
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/public/common/geoposition.cc
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/public/common/geoposition.h
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/public/test/DEPS
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/public/test/android/BUILD.gn
[rename] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/MockLocationProvider.java
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/public/test/content_test_suite_base.cc
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/shell/BUILD.gn
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/shell/android/BUILD.gn
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/shell/browser/DEPS
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/shell/browser/shell_access_token_store.h
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/shell/browser/shell_browser_main_parts.cc
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/content/test/BUILD.gn
[modify] https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94/device/BUILD.gn
[delete] https://crrev.com/0ed6bff02abb9dce0df94e89264758d8e356419c/device/geolocation/BUILD.gn
[delete] https://crrev.com/0ed6bff02abb9dce0df94e89264758d8e356419c/device/geolocation/DEPS
[delete] https://crrev.com/0ed6bff02abb9dce0df94e89264758d8e356419c/device/geolocation/android/geolocation_jni_registrar.cc
[delete] https://crrev.com/0ed6bff02abb9dce0df94e89264758d8e356419c/device/geolocation/android/geolocation_jni_registrar.h
[delete] https://crrev.com/0ed6bff02abb9dce0df94e89264758d8e356419c/device/geolocation/geolocation.gyp
[delete] https://crrev.com/0ed6bff02abb9dce0df94e89264758d8e356419c/device/geolocation/geolocation_export.h

Project Member

Comment 21 by bugdroid1@chromium.org, Jul 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77d0c290852d4d0042ec117ca28592b77c084729

commit 77d0c290852d4d0042ec117ca28592b77c084729
Author: tsergeant <tsergeant@chromium.org>
Date: Thu Jul 28 01:56:39 2016

Revert changes to device/test/run_all_unittests.cc

Changes to this file were made in https://codereview.chromium.org/2185993003/.
However, they were not reverted when the remainder of that patch was reverted in
https://codereview.chromium.org/2188933002/.

This should fix the Android build.

TBR=pstew@chromium.org,mcasas@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=612334

Review-Url: https://codereview.chromium.org/2185303002
Cr-Commit-Position: refs/heads/master@{#408310}

[modify] https://crrev.com/77d0c290852d4d0042ec117ca28592b77c084729/device/test/run_all_unittests.cc

Comment 22 by tsergeant@chromium.org, Jul 28 2016

Re #21: I'm not sure exactly what went wrong with the revert, but a bunch of files got left out. There's another patch landing now (https://codereview.chromium.org/2179903007/) that brings the tree back to the state it was in before #19.

Project Member

Comment 23 by bugdroid1@chromium.org, Jul 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/443e536b532688a5f1cb64fe99098ccaaa81e399

commit 443e536b532688a5f1cb64fe99098ccaaa81e399
Author: tsergeant <tsergeant@chromium.org>
Date: Thu Jul 28 03:48:48 2016

Delete remaining leftover files in //device/geolocation

These were left behind by a bad revert in
https://codereview.chromium.org/2188933002. Deleting them completely
reverts the changes in https://codereview.chromium.org/2185993003, and
fixes DEPS failures on the Linux Tests bot.

BUG=612334
TBR=pstew@chromium.org,mcasas@chromium.org

Review-Url: https://codereview.chromium.org/2179903007
Cr-Commit-Position: refs/heads/master@{#408332}

[delete] https://crrev.com/89e44b6df97a0f5c63586de6a9716b4e18339c23/device/geolocation/wifi_data_provider_common_win.cc
[delete] https://crrev.com/89e44b6df97a0f5c63586de6a9716b4e18339c23/device/geolocation/wifi_data_provider_common_win.h
[delete] https://crrev.com/89e44b6df97a0f5c63586de6a9716b4e18339c23/device/geolocation/wifi_data_provider_corewlan_mac.mm
[delete] https://crrev.com/89e44b6df97a0f5c63586de6a9716b4e18339c23/device/geolocation/wifi_data_provider_linux.cc
[delete] https://crrev.com/89e44b6df97a0f5c63586de6a9716b4e18339c23/device/geolocation/wifi_data_provider_linux.h
[delete] https://crrev.com/89e44b6df97a0f5c63586de6a9716b4e18339c23/device/geolocation/wifi_data_provider_linux_unittest.cc
[delete] https://crrev.com/89e44b6df97a0f5c63586de6a9716b4e18339c23/device/geolocation/wifi_data_provider_mac.cc
[delete] https://crrev.com/89e44b6df97a0f5c63586de6a9716b4e18339c23/device/geolocation/wifi_data_provider_mac.h
[delete] https://crrev.com/89e44b6df97a0f5c63586de6a9716b4e18339c23/device/geolocation/wifi_data_provider_manager.cc
[delete] https://crrev.com/89e44b6df97a0f5c63586de6a9716b4e18339c23/device/geolocation/wifi_data_provider_manager.h
[delete] https://crrev.com/89e44b6df97a0f5c63586de6a9716b4e18339c23/device/geolocation/wifi_data_provider_win.cc
[delete] https://crrev.com/89e44b6df97a0f5c63586de6a9716b4e18339c23/device/geolocation/wifi_data_provider_win.h
[delete] https://crrev.com/89e44b6df97a0f5c63586de6a9716b4e18339c23/device/geolocation/wifi_data_provider_win_unittest.cc
[delete] https://crrev.com/89e44b6df97a0f5c63586de6a9716b4e18339c23/device/geolocation/wifi_polling_policy.h

Comment 24 by tsergeant@chromium.org, Jul 28 2016

Cc: tsergeant@chromium.org
Labels: Merge-Request-54

Looks like we got unlucky with timing on the revert.

Requesting to merge #20 and #21 to M54 (see issue 632239).

Comment 25 by dimu@chromium.org, Jul 28 2016

Labels: -Merge-Request-54 Merge-Review-54 Hotlist-Merge-Review

[Automated comment] DEPS changes referenced in bugdroid comments, needs manual review.

Comment 26 by tsergeant@chromium.org, Jul 28 2016

Considering this is merging a fairly straightforward set of changes to Dev channel, I'm going to ignore this warning.

Project Member

Comment 27 by bugdroid1@chromium.org, Jul 28 2016

Labels: merge-merged-2810

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2

commit 3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2
Author: Tim Sergeant <tsergeant@chromium.org>
Date: Thu Jul 28 04:53:05 2016

Revert of Reland: Geolocation: move from content/browser to device/ (patchset #2 id:20001 of https://codereview.chromium.org/2185993003/ )

Reason for revert:
Build failure:
FAILED: obj/device/geolocation/device_geolocation.network_location_request.obj
ninja -t msvc -e environment.x64 -- "C:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\device\geolocation\device_geolocation.network_location_request.obj.rsp /c ..\..\device\geolocation\network_location_request.cc /Foobj\device\geolocation\device_geolocation.network_location_request.obj /Fdobj\device\geolocation\device_geolocation.cc.pdb
c:\b\build\slave\win64_trunk\build\src\device\geolocation\network_location_request.cc(119): error C2220: warning treated as error - no 'object' file generated
c:\b\build\slave\win64_trunk\build\src\device\geolocation\network_location_request.cc(119): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data

Original issue's description:
> Reland: Geolocation: move from content/browser to device/
>
> Original CL was reverted because it broke Win Gyp Component-build
> bot(s). This CL (PS2) defines the geolocation gyp component
> correctly.
>
> Original CL description ------------------------------------------------
> Geolocation: move from content/browser to device/
>
> This CL:
>
> - moves all of content/browser/geolocation to device/geolocation
> - the public geolocation files in content/common/{browser, public}
>  are also relocated to device/geolocation
> - the geolocation-specific unittests are compiled into
>  (already existing) device_unittests
> - adds new fancy new device/geolocation BUILD.gn  and
>  geolocation.gyp as well
> - makes a component of geolocation (at least for gn) and that forces
>  adding geolocation_export.h (like other //device/ folders).
> - Java Geolocation files are moved as well, and a new
>  geolocation_jni_registrar is added.
> - classes are moved to device namespace.
>
> All paths and include/call sites updated, DEPS, BUILD.gn files,
> gypi files etc.
>
> Some tricks:
> - can't use BrowserThread::CurrentlyOn, etc; instead, the
>  task runner is cached on constructor and used for both thread
>  checking and PostTask()ing (a few unittest and wifi_data_provider*
>  needed that substitution).
> - GeolocationServiceContext is moved to public/cpp so it can
>  be referenced from WebContentsImpl.
> - MockLocationProvider.java is also moved to device/geolocation.
>
> BUG=612334
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>
> TBR=pstew@chromium.org
> rationale:device/geolocation depends on dbus and this triggers
> a DEPS presubmit rule -- however, this CL adds no new dependencies,
> hence moving on in the interest of speed (and avoiding more rebases).
>
> Committed: https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7
> Cr-Commit-Position: refs/heads/master@{#408272}

TBR=pstew@chromium.org,mcasas@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=612334,632239

Review-Url: https://codereview.chromium.org/2188933002
Cr-Commit-Position: refs/heads/master@{#408303}
(cherry picked from commit 6a5f51a5304bdcff7eea91f71be843b72c160d94)

Review URL: https://codereview.chromium.org/2192683003 .

Cr-Commit-Position: refs/branch-heads/2810@{#2}
Cr-Branched-From: 24d606bb2a3e6290b97d9731c1dfd4dbfcb948e7-refs/heads/master@{#408294}

[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/android_webview/browser/DEPS
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/android_webview/browser/aw_browser_main_parts.cc
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/android_webview/browser/aw_content_browser_client.cc
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/android_webview/javatests/DEPS
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/android_webview/javatests/src/org/chromium/android_webview/test/GeolocationTest.java
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/android_webview/test/BUILD.gn
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/blimp/engine/BUILD.gn
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/blimp/engine/DEPS
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/blimp/engine/app/blimp_content_browser_client.cc
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/blimp/engine/feature/geolocation/blimp_location_provider.cc
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/blimp/engine/feature/geolocation/blimp_location_provider.h
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/blimp/engine/feature/geolocation/blimp_location_provider_unittest.cc
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/blimp/engine/feature/geolocation/engine_geolocation_feature.cc
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/blimp/engine/feature/geolocation/engine_geolocation_feature.h
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/blimp/engine/feature/geolocation/engine_geolocation_feature_unittest.cc
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/blimp/engine/feature/geolocation/mock_blimp_location_provider_delegate.h
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/blimp/engine/session/blimp_engine_session.cc
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/chrome/android/BUILD.gn
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/chrome/android/javatests/DEPS
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/chrome/android/javatests/src/org/chromium/chrome/browser/GeolocationTest.java
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/chrome/browser/DEPS
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/chrome/browser/chromeos/policy/device_status_collector.cc
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/chrome/browser/chromeos/policy/device_status_collector.h
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/chrome/browser/chromeos/policy/device_status_collector_browsertest.cc
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/chrome/browser/geolocation/access_token_store_browsertest.cc
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/chrome/browser/geolocation/chrome_access_token_store.cc
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/chrome/browser/geolocation/chrome_access_token_store.h
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/chrome/browser/geolocation/geolocation_browsertest.cc
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/chrome/browser/geolocation/geolocation_permission_context.cc
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/chrome/test/DEPS
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/chrome/test/base/ui_test_utils.cc
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/chromecast/browser/BUILD.gn
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/chromecast/browser/DEPS
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/chromecast/browser/cast_browser_main_parts.cc
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/chromecast/browser/geolocation/cast_access_token_store.h
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/chromeos/geolocation/DEPS
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/chromeos/geolocation/geoposition.h
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/components/BUILD.gn
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/components/autofill.gypi
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/components/autofill/content/browser/BUILD.gn
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/components/autofill/content/browser/DEPS
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/components/autofill/content/browser/risk/fingerprint.cc
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/components/autofill/content/browser/risk/fingerprint_browsertest.cc
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/DEPS
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/app/BUILD.gn
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/app/DEPS
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/app/android/library_loader_hooks.cc
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/BUILD.gn
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/DEPS
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/android/browser_jni_registrar.cc
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/android/content_view_core_impl.cc
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/browser_main_loop.cc
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/devtools/protocol/emulation_handler.cc
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/frame_host/render_frame_host_delegate.cc
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/frame_host/render_frame_host_delegate.h
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/frame_host/render_frame_host_impl.cc
[add] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/DEPS
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/OWNERS
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/empty_wifi_data_provider.cc
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/empty_wifi_data_provider.h
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/fake_access_token_store.cc
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/fake_access_token_store.h
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/geolocation_provider_impl.cc
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/geolocation_provider_impl.h
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/geolocation_provider_impl_unittest.cc
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/geolocation_service_context.cc
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/geolocation_service_context.h
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/geolocation_service_impl.cc
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/geolocation_service_impl.h
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/location_api_adapter_android.cc
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/location_api_adapter_android.h
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/location_arbitrator.h
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/location_arbitrator_impl.cc
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/location_arbitrator_impl.h
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/location_arbitrator_impl_unittest.cc
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/location_provider_android.cc
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/location_provider_android.h
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/location_provider_base.cc
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/location_provider_base.h
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/mock_location_arbitrator.cc
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/mock_location_arbitrator.h
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/mock_location_provider.cc
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/mock_location_provider.h
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/network_location_provider.cc
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/network_location_provider.h
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/network_location_provider_unittest.cc
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/network_location_request.cc
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/network_location_request.h
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/wifi_data.cc
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/wifi_data.h
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/wifi_data_provider.cc
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/wifi_data_provider.h
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/wifi_data_provider_chromeos.cc
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/wifi_data_provider_chromeos.h
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/wifi_data_provider_chromeos_unittest.cc
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/wifi_data_provider_common.cc
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/wifi_data_provider_common.h
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/wifi_data_provider_common_unittest.cc
[add] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/wifi_data_provider_common_win.cc
[add] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/wifi_data_provider_common_win.h
[add] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/wifi_data_provider_corewlan_mac.mm
[add] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/wifi_data_provider_linux.cc
[add] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/wifi_data_provider_linux.h
[add] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/wifi_data_provider_linux_unittest.cc
[add] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/wifi_data_provider_mac.cc
[add] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/wifi_data_provider_mac.h
[add] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/wifi_data_provider_manager.cc
[add] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/wifi_data_provider_manager.h
[add] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/wifi_data_provider_win.cc
[add] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/wifi_data_provider_win.h
[add] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/wifi_data_provider_win_unittest.cc
[add] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/geolocation/wifi_polling_policy.h
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/content_browser.gypi
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/content_common.gypi
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/content_jni.gypi
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/content_shell.gypi
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/content_tests.gypi
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/public/android/BUILD.gn
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/public/android/java/src/org/chromium/content/browser/LocationProviderAdapter.java
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/public/android/java/src/org/chromium/content/browser/LocationProviderFactory.java
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/public/android/javatests/src/org/chromium/content/browser/ContentViewLocationTest.java
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/public/android/javatests/src/org/chromium/content/browser/LocationProviderTest.java
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/public/browser/BUILD.gn
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/public/browser/access_token_store.h
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/public/browser/geolocation_delegate.cc
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/public/browser/geolocation_delegate.h
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/public/browser/geolocation_provider.h
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/public/browser/location_provider.h
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/public/common/geoposition.cc
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/public/common/geoposition.h
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/public/test/DEPS
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/public/test/android/BUILD.gn
[rename] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/MockLocationProvider.java
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/public/test/content_test_suite_base.cc
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/shell/BUILD.gn
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/shell/android/BUILD.gn
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/shell/browser/DEPS
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/shell/browser/shell_access_token_store.h
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/shell/browser/shell_browser_main_parts.cc
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/content/test/BUILD.gn
[modify] https://crrev.com/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2/device/BUILD.gn
[delete] https://crrev.com/319acb2b0ac8778cf1da822ee112ecc36373c215/device/geolocation/BUILD.gn
[delete] https://crrev.com/319acb2b0ac8778cf1da822ee112ecc36373c215/device/geolocation/DEPS
[delete] https://crrev.com/319acb2b0ac8778cf1da822ee112ecc36373c215/device/geolocation/android/geolocation_jni_registrar.cc
[delete] https://crrev.com/319acb2b0ac8778cf1da822ee112ecc36373c215/device/geolocation/android/geolocation_jni_registrar.h
[delete] https://crrev.com/319acb2b0ac8778cf1da822ee112ecc36373c215/device/geolocation/geolocation.gyp
[delete] https://crrev.com/319acb2b0ac8778cf1da822ee112ecc36373c215/device/geolocation/geolocation_export.h

Project Member

Comment 28 by bugdroid1@chromium.org, Jul 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7212bbc083ff30c65ffa5ca0333f73f0b63221a3

commit 7212bbc083ff30c65ffa5ca0333f73f0b63221a3
Author: Tim Sergeant <tsergeant@chromium.org>
Date: Thu Jul 28 05:06:26 2016

Revert changes to device/test/run_all_unittests.cc

Changes to this file were made in https://codereview.chromium.org/2185993003/.
However, they were not reverted when the remainder of that patch was reverted in
https://codereview.chromium.org/2188933002/.

This should fix the Android build.

TBR=pstew@chromium.org,mcasas@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=612334,632239

Review-Url: https://codereview.chromium.org/2185303002
Cr-Commit-Position: refs/heads/master@{#408310}
(cherry picked from commit 77d0c290852d4d0042ec117ca28592b77c084729)

Review URL: https://codereview.chromium.org/2190863002 .

Cr-Commit-Position: refs/branch-heads/2810@{#3}
Cr-Branched-From: 24d606bb2a3e6290b97d9731c1dfd4dbfcb948e7-refs/heads/master@{#408294}

[modify] https://crrev.com/7212bbc083ff30c65ffa5ca0333f73f0b63221a3/device/test/run_all_unittests.cc

Project Member

Comment 29 by bugdroid1@chromium.org, Jul 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/776a0264fe53792dff39ed60ea1e5194b2a5073a

commit 776a0264fe53792dff39ed60ea1e5194b2a5073a
Author: Tim Sergeant <tsergeant@chromium.org>
Date: Thu Jul 28 05:13:35 2016

Delete remaining leftover files in //device/geolocation

These were left behind by a bad revert in
https://codereview.chromium.org/2188933002. Deleting them completely
reverts the changes in https://codereview.chromium.org/2185993003, and
fixes DEPS failures on the Linux Tests bot.

BUG=612334,632239
TBR=pstew@chromium.org,mcasas@chromium.org

Review-Url: https://codereview.chromium.org/2179903007
Cr-Commit-Position: refs/heads/master@{#408332}
(cherry picked from commit 443e536b532688a5f1cb64fe99098ccaaa81e399)

Review URL: https://codereview.chromium.org/2191773002 .

Cr-Commit-Position: refs/branch-heads/2810@{#4}
Cr-Branched-From: 24d606bb2a3e6290b97d9731c1dfd4dbfcb948e7-refs/heads/master@{#408294}

[delete] https://crrev.com/7212bbc083ff30c65ffa5ca0333f73f0b63221a3/device/geolocation/wifi_data_provider_common_win.cc
[delete] https://crrev.com/7212bbc083ff30c65ffa5ca0333f73f0b63221a3/device/geolocation/wifi_data_provider_common_win.h
[delete] https://crrev.com/7212bbc083ff30c65ffa5ca0333f73f0b63221a3/device/geolocation/wifi_data_provider_corewlan_mac.mm
[delete] https://crrev.com/7212bbc083ff30c65ffa5ca0333f73f0b63221a3/device/geolocation/wifi_data_provider_linux.cc
[delete] https://crrev.com/7212bbc083ff30c65ffa5ca0333f73f0b63221a3/device/geolocation/wifi_data_provider_linux.h
[delete] https://crrev.com/7212bbc083ff30c65ffa5ca0333f73f0b63221a3/device/geolocation/wifi_data_provider_linux_unittest.cc
[delete] https://crrev.com/7212bbc083ff30c65ffa5ca0333f73f0b63221a3/device/geolocation/wifi_data_provider_mac.cc
[delete] https://crrev.com/7212bbc083ff30c65ffa5ca0333f73f0b63221a3/device/geolocation/wifi_data_provider_mac.h
[delete] https://crrev.com/7212bbc083ff30c65ffa5ca0333f73f0b63221a3/device/geolocation/wifi_data_provider_manager.cc
[delete] https://crrev.com/7212bbc083ff30c65ffa5ca0333f73f0b63221a3/device/geolocation/wifi_data_provider_manager.h
[delete] https://crrev.com/7212bbc083ff30c65ffa5ca0333f73f0b63221a3/device/geolocation/wifi_data_provider_win.cc
[delete] https://crrev.com/7212bbc083ff30c65ffa5ca0333f73f0b63221a3/device/geolocation/wifi_data_provider_win.h
[delete] https://crrev.com/7212bbc083ff30c65ffa5ca0333f73f0b63221a3/device/geolocation/wifi_data_provider_win_unittest.cc
[delete] https://crrev.com/7212bbc083ff30c65ffa5ca0333f73f0b63221a3/device/geolocation/wifi_polling_policy.h

Project Member

Comment 30 by bugdroid1@chromium.org, Jul 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67553346ccc4dcb3c2da968bd98f1b15136d2d08

commit 67553346ccc4dcb3c2da968bd98f1b15136d2d08
Author: mcasas <mcasas@chromium.org>
Date: Thu Jul 28 15:10:42 2016

Reland 2:Geolocation: move from content/browser to device/

Reland was reverted due to a build failure in an official win64 builder
that hit the infamous size_t to int conversion warning [1]:

FAILED: obj/device/geolocation/device_geolocation.network_location_request.obj
ninja -t msvc -e environment.x64 -- "C:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\device\geolocation\device_geolocation.network_location_request.obj.rsp /c ..\..\device\geolocation\network_location_request.cc /Foobj\device\geolocation\device_geolocation.network_location_request.obj /Fdobj\device\geolocation\device_geolocation.cc.pdb
c:\b\build\slave\win64_trunk\build\src\device\geolocation\network_location_request.cc(119): error C2220: warning treated as error - no 'object' file generated
c:\b\build\slave\win64_trunk\build\src\device\geolocation\network_location_request.cc(119): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data

[1] https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win64%20trunk/builds/1125/steps/compile/logs/stdio/text

Original Reland description --------------------------------------------

Original CL was reverted because it broke Win Gyp Component-build
bot(s). This CL (PS2) defines the geolocation gyp component
correctly.

Original CL description ------------------------------------------------
Geolocation: move from content/browser to device/

This CL:

- moves all of content/browser/geolocation to device/geolocation
- the public geolocation files in content/common/{browser, public}
 are also relocated to device/geolocation
- the geolocation-specific unittests are compiled into
 (already existing) device_unittests
- adds new fancy new device/geolocation BUILD.gn  and
 geolocation.gyp as well
- makes a component of geolocation (at least for gn) and that forces
 adding geolocation_export.h (like other //device/ folders).
- Java Geolocation files are moved as well, and a new
 geolocation_jni_registrar is added.
- classes are moved to device namespace.

All paths and include/call sites updated, DEPS, BUILD.gn files,
gypi files etc.

Some tricks:
- can't use BrowserThread::CurrentlyOn, etc; instead, the
 task runner is cached on constructor and used for both thread
 checking and PostTask()ing (a few unittest and wifi_data_provider*
 needed that substitution).
- GeolocationServiceContext is moved to public/cpp so it can
 be referenced from WebContentsImpl.
- MockLocationProvider.java is also moved to device/geolocation.

BUG=612334
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

TBR=pstew@chromium.org
rationale:device/geolocation depends on dbus and this triggers
a DEPS presubmit rule -- however, this CL adds no new dependencies,
hence moving on in the interest of speed (and avoiding more rebases).

Review-Url: https://codereview.chromium.org/2192683002
Cr-Commit-Position: refs/heads/master@{#408393}

[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/android_webview/browser/DEPS
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/android_webview/browser/aw_browser_main_parts.cc
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/android_webview/browser/aw_content_browser_client.cc
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/android_webview/javatests/DEPS
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/android_webview/javatests/src/org/chromium/android_webview/test/GeolocationTest.java
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/android_webview/test/BUILD.gn
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/blimp/engine/BUILD.gn
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/blimp/engine/DEPS
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/blimp/engine/app/blimp_content_browser_client.cc
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/blimp/engine/feature/geolocation/blimp_location_provider.cc
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/blimp/engine/feature/geolocation/blimp_location_provider.h
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/blimp/engine/feature/geolocation/blimp_location_provider_unittest.cc
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/blimp/engine/feature/geolocation/engine_geolocation_feature.cc
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/blimp/engine/feature/geolocation/engine_geolocation_feature.h
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/blimp/engine/feature/geolocation/engine_geolocation_feature_unittest.cc
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/blimp/engine/feature/geolocation/mock_blimp_location_provider_delegate.h
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/blimp/engine/session/blimp_engine_session.cc
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/chrome/android/BUILD.gn
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/chrome/android/javatests/DEPS
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/chrome/android/javatests/src/org/chromium/chrome/browser/GeolocationTest.java
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/chrome/browser/DEPS
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/chrome/browser/chromeos/policy/device_status_collector.cc
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/chrome/browser/chromeos/policy/device_status_collector.h
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/chrome/browser/chromeos/policy/device_status_collector_browsertest.cc
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/chrome/browser/geolocation/access_token_store_browsertest.cc
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/chrome/browser/geolocation/chrome_access_token_store.cc
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/chrome/browser/geolocation/chrome_access_token_store.h
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/chrome/browser/geolocation/geolocation_browsertest.cc
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/chrome/browser/geolocation/geolocation_permission_context.cc
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/chrome/test/DEPS
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/chrome/test/base/ui_test_utils.cc
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/chromecast/browser/BUILD.gn
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/chromecast/browser/DEPS
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/chromecast/browser/cast_browser_main_parts.cc
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/chromecast/browser/geolocation/cast_access_token_store.h
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/chromeos/geolocation/DEPS
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/chromeos/geolocation/geoposition.h
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/components/BUILD.gn
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/components/autofill.gypi
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/components/autofill/content/browser/BUILD.gn
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/components/autofill/content/browser/DEPS
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/components/autofill/content/browser/risk/fingerprint.cc
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/components/autofill/content/browser/risk/fingerprint_browsertest.cc
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/content/DEPS
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/content/app/BUILD.gn
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/content/app/DEPS
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/content/app/android/library_loader_hooks.cc
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/content/browser/BUILD.gn
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/content/browser/DEPS
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/content/browser/android/browser_jni_registrar.cc
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/content/browser/android/content_view_core_impl.cc
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/content/browser/browser_main_loop.cc
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/content/browser/devtools/protocol/emulation_handler.cc
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/content/browser/frame_host/render_frame_host_delegate.cc
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/content/browser/frame_host/render_frame_host_delegate.h
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/content/browser/frame_host/render_frame_host_impl.cc
[delete] https://crrev.com/da4da3a788baf26de1125de03e9169af56b00fb4/content/browser/geolocation/DEPS
[delete] https://crrev.com/da4da3a788baf26de1125de03e9169af56b00fb4/content/browser/geolocation/wifi_data_provider_common_win.cc
[delete] https://crrev.com/da4da3a788baf26de1125de03e9169af56b00fb4/content/browser/geolocation/wifi_data_provider_common_win.h
[delete] https://crrev.com/da4da3a788baf26de1125de03e9169af56b00fb4/content/browser/geolocation/wifi_data_provider_corewlan_mac.mm
[delete] https://crrev.com/da4da3a788baf26de1125de03e9169af56b00fb4/content/browser/geolocation/wifi_data_provider_linux.cc
[delete] https://crrev.com/da4da3a788baf26de1125de03e9169af56b00fb4/content/browser/geolocation/wifi_data_provider_linux.h
[delete] https://crrev.com/da4da3a788baf26de1125de03e9169af56b00fb4/content/browser/geolocation/wifi_data_provider_linux_unittest.cc
[delete] https://crrev.com/da4da3a788baf26de1125de03e9169af56b00fb4/content/browser/geolocation/wifi_data_provider_mac.cc
[delete] https://crrev.com/da4da3a788baf26de1125de03e9169af56b00fb4/content/browser/geolocation/wifi_data_provider_mac.h
[delete] https://crrev.com/da4da3a788baf26de1125de03e9169af56b00fb4/content/browser/geolocation/wifi_data_provider_manager.cc
[delete] https://crrev.com/da4da3a788baf26de1125de03e9169af56b00fb4/content/browser/geolocation/wifi_data_provider_manager.h
[delete] https://crrev.com/da4da3a788baf26de1125de03e9169af56b00fb4/content/browser/geolocation/wifi_data_provider_win.cc
[delete] https://crrev.com/da4da3a788baf26de1125de03e9169af56b00fb4/content/browser/geolocation/wifi_data_provider_win.h
[delete] https://crrev.com/da4da3a788baf26de1125de03e9169af56b00fb4/content/browser/geolocation/wifi_data_provider_win_unittest.cc
[delete] https://crrev.com/da4da3a788baf26de1125de03e9169af56b00fb4/content/browser/geolocation/wifi_polling_policy.h
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/content/content_browser.gypi
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/content/content_common.gypi
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/content/content_jni.gypi
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/content/content_shell.gypi
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/content/content_tests.gypi
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/content/public/android/BUILD.gn
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/content/public/android/javatests/src/org/chromium/content/browser/ContentViewLocationTest.java
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/content/public/android/javatests/src/org/chromium/content/browser/LocationProviderTest.java
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/content/public/browser/BUILD.gn
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/content/public/test/DEPS
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/content/public/test/android/BUILD.gn
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/content/public/test/content_test_suite_base.cc
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/content/shell/BUILD.gn
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/content/shell/android/BUILD.gn
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/content/shell/browser/DEPS
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/content/shell/browser/shell_access_token_store.h
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/content/shell/browser/shell_browser_main_parts.cc
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/content/test/BUILD.gn
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/BUILD.gn
[add] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/BUILD.gn
[add] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/DEPS
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/OWNERS
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/access_token_store.h
[add] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/android/geolocation_jni_registrar.cc
[add] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/android/geolocation_jni_registrar.h
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/android/java/org/chromium/device/geolocation/LocationProviderAdapter.java
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/android/java/org/chromium/device/geolocation/LocationProviderFactory.java
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/android/java/org/chromium/device/geolocation/MockLocationProvider.java
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/empty_wifi_data_provider.cc
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/empty_wifi_data_provider.h
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/fake_access_token_store.cc
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/fake_access_token_store.h
[add] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/geolocation.gyp
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/geolocation_delegate.cc
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/geolocation_delegate.h
[add] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/geolocation_export.h
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/geolocation_provider.h
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/geolocation_provider_impl.cc
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/geolocation_provider_impl.h
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/geolocation_provider_impl_unittest.cc
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/geolocation_service_context.cc
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/geolocation_service_context.h
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/geolocation_service_impl.cc
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/geolocation_service_impl.h
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/geoposition.cc
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/geoposition.h
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/location_api_adapter_android.cc
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/location_api_adapter_android.h
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/location_arbitrator.h
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/location_arbitrator_impl.cc
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/location_arbitrator_impl.h
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/location_arbitrator_impl_unittest.cc
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/location_provider.h
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/location_provider_android.cc
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/location_provider_android.h
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/location_provider_base.cc
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/location_provider_base.h
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/mock_location_arbitrator.cc
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/mock_location_arbitrator.h
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/mock_location_provider.cc
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/mock_location_provider.h
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/network_location_provider.cc
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/network_location_provider.h
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/network_location_provider_unittest.cc
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/network_location_request.cc
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/network_location_request.h
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/wifi_data.cc
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/wifi_data.h
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/wifi_data_provider.cc
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/wifi_data_provider.h
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/wifi_data_provider_chromeos.cc
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/wifi_data_provider_chromeos.h
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/wifi_data_provider_chromeos_unittest.cc
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/wifi_data_provider_common.cc
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/wifi_data_provider_common.h
[rename] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/geolocation/wifi_data_provider_common_unittest.cc
[modify] https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08/device/test/run_all_unittests.cc

Project Member

Comment 31 by bugdroid1@chromium.org, Jul 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c921b9b68dcc60f686cd9e1c2cae352506addb48

commit c921b9b68dcc60f686cd9e1c2cae352506addb48
Author: dpranke <dpranke@chromium.org>
Date: Thu Jul 28 15:36:58 2016

Revert of Reland 2:Geolocation: move from content/browser to device/ (patchset #2 id:20001 of https://codereview.chromium.org/2192683002/ )

Reason for revert:
Looks like this is still breaking builders:

http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Builder/builds/40523

https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/112343/steps/generate_build_files%20%28with%20patch%29/logs/stdio

Original issue's description:
> Reland 2:Geolocation: move from content/browser to device/
>
> Reland was reverted due to a build failure in an official win64 builder
> that hit the infamous size_t to int conversion warning [1]:
>
> FAILED: obj/device/geolocation/device_geolocation.network_location_request.obj
> ninja -t msvc -e environment.x64 -- "C:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\device\geolocation\device_geolocation.network_location_request.obj.rsp /c ..\..\device\geolocation\network_location_request.cc /Foobj\device\geolocation\device_geolocation.network_location_request.obj /Fdobj\device\geolocation\device_geolocation.cc.pdb
> c:\b\build\slave\win64_trunk\build\src\device\geolocation\network_location_request.cc(119): error C2220: warning treated as error - no 'object' file generated
> c:\b\build\slave\win64_trunk\build\src\device\geolocation\network_location_request.cc(119): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data
>
> [1] https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win64%20trunk/builds/1125/steps/compile/logs/stdio/text
>
> Original Reland description --------------------------------------------
>
> Original CL was reverted because it broke Win Gyp Component-build
> bot(s). This CL (PS2) defines the geolocation gyp component
> correctly.
>
> Original CL description ------------------------------------------------
> Geolocation: move from content/browser to device/
>
> This CL:
>
> - moves all of content/browser/geolocation to device/geolocation
> - the public geolocation files in content/common/{browser, public}
>  are also relocated to device/geolocation
> - the geolocation-specific unittests are compiled into
>  (already existing) device_unittests
> - adds new fancy new device/geolocation BUILD.gn  and
>  geolocation.gyp as well
> - makes a component of geolocation (at least for gn) and that forces
>  adding geolocation_export.h (like other //device/ folders).
> - Java Geolocation files are moved as well, and a new
>  geolocation_jni_registrar is added.
> - classes are moved to device namespace.
>
> All paths and include/call sites updated, DEPS, BUILD.gn files,
> gypi files etc.
>
> Some tricks:
> - can't use BrowserThread::CurrentlyOn, etc; instead, the
>  task runner is cached on constructor and used for both thread
>  checking and PostTask()ing (a few unittest and wifi_data_provider*
>  needed that substitution).
> - GeolocationServiceContext is moved to public/cpp so it can
>  be referenced from WebContentsImpl.
> - MockLocationProvider.java is also moved to device/geolocation.
>
> BUG=612334
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>
> TBR=pstew@chromium.org
> rationale:device/geolocation depends on dbus and this triggers
> a DEPS presubmit rule -- however, this CL adds no new dependencies,
> hence moving on in the interest of speed (and avoiding more rebases).
>
> Committed: https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08
> Cr-Commit-Position: refs/heads/master@{#408393}

TBR=pstew@chromium.org,mcasas@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=612334

Review-Url: https://codereview.chromium.org/2187923003
Cr-Commit-Position: refs/heads/master@{#408396}

[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/android_webview/browser/DEPS
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/android_webview/browser/aw_browser_main_parts.cc
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/android_webview/browser/aw_content_browser_client.cc
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/android_webview/javatests/DEPS
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/android_webview/javatests/src/org/chromium/android_webview/test/GeolocationTest.java
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/android_webview/test/BUILD.gn
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/blimp/engine/BUILD.gn
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/blimp/engine/DEPS
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/blimp/engine/app/blimp_content_browser_client.cc
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/blimp/engine/feature/geolocation/blimp_location_provider.cc
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/blimp/engine/feature/geolocation/blimp_location_provider.h
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/blimp/engine/feature/geolocation/blimp_location_provider_unittest.cc
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/blimp/engine/feature/geolocation/engine_geolocation_feature.cc
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/blimp/engine/feature/geolocation/engine_geolocation_feature.h
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/blimp/engine/feature/geolocation/engine_geolocation_feature_unittest.cc
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/blimp/engine/feature/geolocation/mock_blimp_location_provider_delegate.h
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/blimp/engine/session/blimp_engine_session.cc
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/chrome/android/BUILD.gn
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/chrome/android/javatests/DEPS
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/chrome/android/javatests/src/org/chromium/chrome/browser/GeolocationTest.java
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/chrome/browser/DEPS
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/chrome/browser/chromeos/policy/device_status_collector.cc
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/chrome/browser/chromeos/policy/device_status_collector.h
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/chrome/browser/chromeos/policy/device_status_collector_browsertest.cc
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/chrome/browser/geolocation/access_token_store_browsertest.cc
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/chrome/browser/geolocation/chrome_access_token_store.cc
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/chrome/browser/geolocation/chrome_access_token_store.h
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/chrome/browser/geolocation/geolocation_browsertest.cc
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/chrome/browser/geolocation/geolocation_permission_context.cc
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/chrome/test/DEPS
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/chrome/test/base/ui_test_utils.cc
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/chromecast/browser/BUILD.gn
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/chromecast/browser/DEPS
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/chromecast/browser/cast_browser_main_parts.cc
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/chromecast/browser/geolocation/cast_access_token_store.h
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/chromeos/geolocation/DEPS
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/chromeos/geolocation/geoposition.h
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/components/BUILD.gn
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/components/autofill.gypi
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/components/autofill/content/browser/BUILD.gn
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/components/autofill/content/browser/DEPS
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/components/autofill/content/browser/risk/fingerprint.cc
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/components/autofill/content/browser/risk/fingerprint_browsertest.cc
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/DEPS
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/app/BUILD.gn
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/app/DEPS
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/app/android/library_loader_hooks.cc
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/BUILD.gn
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/DEPS
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/android/browser_jni_registrar.cc
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/android/content_view_core_impl.cc
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/browser_main_loop.cc
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/devtools/protocol/emulation_handler.cc
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/frame_host/render_frame_host_delegate.cc
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/frame_host/render_frame_host_delegate.h
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/frame_host/render_frame_host_impl.cc
[add] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/DEPS
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/OWNERS
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/empty_wifi_data_provider.cc
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/empty_wifi_data_provider.h
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/fake_access_token_store.cc
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/fake_access_token_store.h
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/geolocation_provider_impl.cc
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/geolocation_provider_impl.h
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/geolocation_provider_impl_unittest.cc
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/geolocation_service_context.cc
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/geolocation_service_context.h
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/geolocation_service_impl.cc
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/geolocation_service_impl.h
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/location_api_adapter_android.cc
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/location_api_adapter_android.h
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/location_arbitrator.h
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/location_arbitrator_impl.cc
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/location_arbitrator_impl.h
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/location_arbitrator_impl_unittest.cc
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/location_provider_android.cc
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/location_provider_android.h
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/location_provider_base.cc
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/location_provider_base.h
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/mock_location_arbitrator.cc
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/mock_location_arbitrator.h
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/mock_location_provider.cc
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/mock_location_provider.h
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/network_location_provider.cc
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/network_location_provider.h
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/network_location_provider_unittest.cc
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/network_location_request.cc
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/network_location_request.h
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/wifi_data.cc
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/wifi_data.h
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/wifi_data_provider.cc
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/wifi_data_provider.h
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/wifi_data_provider_chromeos.cc
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/wifi_data_provider_chromeos.h
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/wifi_data_provider_chromeos_unittest.cc
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/wifi_data_provider_common.cc
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/wifi_data_provider_common.h
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/wifi_data_provider_common_unittest.cc
[add] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/wifi_data_provider_common_win.cc
[add] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/wifi_data_provider_common_win.h
[add] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/wifi_data_provider_corewlan_mac.mm
[add] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/wifi_data_provider_linux.cc
[add] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/wifi_data_provider_linux.h
[add] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/wifi_data_provider_linux_unittest.cc
[add] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/wifi_data_provider_mac.cc
[add] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/wifi_data_provider_mac.h
[add] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/wifi_data_provider_manager.cc
[add] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/wifi_data_provider_manager.h
[add] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/wifi_data_provider_win.cc
[add] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/wifi_data_provider_win.h
[add] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/wifi_data_provider_win_unittest.cc
[add] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/geolocation/wifi_polling_policy.h
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/content_browser.gypi
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/content_common.gypi
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/content_jni.gypi
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/content_shell.gypi
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/content_tests.gypi
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/public/android/BUILD.gn
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/public/android/java/src/org/chromium/content/browser/LocationProviderAdapter.java
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/public/android/java/src/org/chromium/content/browser/LocationProviderFactory.java
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/public/android/javatests/src/org/chromium/content/browser/ContentViewLocationTest.java
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/public/android/javatests/src/org/chromium/content/browser/LocationProviderTest.java
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/public/browser/BUILD.gn
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/public/browser/access_token_store.h
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/public/browser/geolocation_delegate.cc
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/public/browser/geolocation_delegate.h
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/public/browser/geolocation_provider.h
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/public/browser/location_provider.h
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/public/common/geoposition.cc
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/public/common/geoposition.h
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/public/test/DEPS
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/public/test/android/BUILD.gn
[rename] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/MockLocationProvider.java
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/public/test/content_test_suite_base.cc
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/shell/BUILD.gn
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/shell/android/BUILD.gn
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/shell/browser/DEPS
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/shell/browser/shell_access_token_store.h
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/shell/browser/shell_browser_main_parts.cc
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/content/test/BUILD.gn
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/device/BUILD.gn
[delete] https://crrev.com/3dde872aab6a3f346bedb65efb1562bc396d9c92/device/geolocation/BUILD.gn
[delete] https://crrev.com/3dde872aab6a3f346bedb65efb1562bc396d9c92/device/geolocation/DEPS
[delete] https://crrev.com/3dde872aab6a3f346bedb65efb1562bc396d9c92/device/geolocation/android/geolocation_jni_registrar.cc
[delete] https://crrev.com/3dde872aab6a3f346bedb65efb1562bc396d9c92/device/geolocation/android/geolocation_jni_registrar.h
[delete] https://crrev.com/3dde872aab6a3f346bedb65efb1562bc396d9c92/device/geolocation/geolocation.gyp
[delete] https://crrev.com/3dde872aab6a3f346bedb65efb1562bc396d9c92/device/geolocation/geolocation_export.h
[modify] https://crrev.com/c921b9b68dcc60f686cd9e1c2cae352506addb48/device/test/run_all_unittests.cc

Project Member

Comment 32 by bugdroid1@chromium.org, Jul 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e216e71b1e151982bc0b08919b3264febf6e46a

commit 4e216e71b1e151982bc0b08919b3264febf6e46a
Author: mcasas <mcasas@chromium.org>
Date: Thu Jul 28 21:28:38 2016

Reland 3: Geolocation: move from content/browser to device/

Something went wrong between revert 2 and reland 2 and not all files
were included in reland 2, however the dry-run passed, because the
dangling files were still there, and by the time Re2 landed, they
were gone, bots were not retried and everything stopped compiling after
landing :(

So this CL is just verbatim Reland 2, with a sane master branch.

Original Reland 2 description ------------------------------------------

Reland 2:Geolocation: move from content/browser to device/

Reland was reverted due to a build failure in an official win64 builder
that hit the infamous size_t to int conversion warning [1]:

FAILED: obj/device/geolocation/device_geolocation.network_location_request.obj
ninja -t msvc -e environment.x64 -- "C:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\device\geolocation\device_geolocation.network_location_request.obj.rsp /c ..\..\device\geolocation\network_location_request.cc /Foobj\device\geolocation\device_geolocation.network_location_request.obj /Fdobj\device\geolocation\device_geolocation.cc.pdb
c:\b\build\slave\win64_trunk\build\src\device\geolocation\network_location_request.cc(119): error C2220: warning treated as error - no 'object' file generated
c:\b\build\slave\win64_trunk\build\src\device\geolocation\network_location_request.cc(119): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data

[1] https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win64%20trunk/builds/1125/steps/compile/logs/stdio/text

Original Reland description --------------------------------------------

Original CL was reverted because it broke Win Gyp Component-build
bot(s). This CL (PS2) defines the geolocation gyp component
correctly.

Original CL description ------------------------------------------------
Geolocation: move from content/browser to device/

This CL:

- moves all of content/browser/geolocation to device/geolocation
- the public geolocation files in content/common/{browser, public}
 are also relocated to device/geolocation
- the geolocation-specific unittests are compiled into
 (already existing) device_unittests
- adds new fancy new device/geolocation BUILD.gn  and
 geolocation.gyp as well
- makes a component of geolocation (at least for gn) and that forces
 adding geolocation_export.h (like other //device/ folders).
- Java Geolocation files are moved as well, and a new
 geolocation_jni_registrar is added.
- classes are moved to device namespace.

All paths and include/call sites updated, DEPS, BUILD.gn files,
gypi files etc.

Some tricks:
- can't use BrowserThread::CurrentlyOn, etc; instead, the
 task runner is cached on constructor and used for both thread
 checking and PostTask()ing (a few unittest and wifi_data_provider*
 needed that substitution).
- GeolocationServiceContext is moved to public/cpp so it can
 be referenced from WebContentsImpl.
- MockLocationProvider.java is also moved to device/geolocation.

BUG=612334
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

TBR=pstew@chromium.org
rationale:device/geolocation depends on dbus and this triggers
a DEPS presubmit rule -- however, this CL adds no new dependencies,
hence moving on in the interest of speed (and avoiding more rebases).

Review-Url: https://codereview.chromium.org/2184013004
Cr-Commit-Position: refs/heads/master@{#408481}

[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/android_webview/browser/DEPS
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/android_webview/browser/aw_browser_main_parts.cc
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/android_webview/browser/aw_content_browser_client.cc
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/android_webview/javatests/DEPS
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/android_webview/javatests/src/org/chromium/android_webview/test/GeolocationTest.java
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/android_webview/test/BUILD.gn
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/blimp/engine/BUILD.gn
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/blimp/engine/DEPS
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/blimp/engine/app/blimp_content_browser_client.cc
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/blimp/engine/feature/geolocation/blimp_location_provider.cc
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/blimp/engine/feature/geolocation/blimp_location_provider.h
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/blimp/engine/feature/geolocation/blimp_location_provider_unittest.cc
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/blimp/engine/feature/geolocation/engine_geolocation_feature.cc
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/blimp/engine/feature/geolocation/engine_geolocation_feature.h
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/blimp/engine/feature/geolocation/engine_geolocation_feature_unittest.cc
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/blimp/engine/feature/geolocation/mock_blimp_location_provider_delegate.h
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/blimp/engine/session/blimp_engine_session.cc
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/chrome/android/BUILD.gn
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/chrome/android/javatests/DEPS
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/chrome/android/javatests/src/org/chromium/chrome/browser/GeolocationTest.java
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/chrome/browser/DEPS
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/chrome/browser/chromeos/policy/device_status_collector.cc
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/chrome/browser/chromeos/policy/device_status_collector.h
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/chrome/browser/chromeos/policy/device_status_collector_browsertest.cc
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/chrome/browser/geolocation/access_token_store_browsertest.cc
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/chrome/browser/geolocation/chrome_access_token_store.cc
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/chrome/browser/geolocation/chrome_access_token_store.h
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/chrome/browser/geolocation/geolocation_browsertest.cc
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/chrome/browser/geolocation/geolocation_permission_context.cc
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/chrome/test/DEPS
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/chrome/test/base/ui_test_utils.cc
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/chromecast/browser/BUILD.gn
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/chromecast/browser/DEPS
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/chromecast/browser/cast_browser_main_parts.cc
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/chromecast/browser/geolocation/cast_access_token_store.h
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/chromeos/geolocation/DEPS
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/chromeos/geolocation/geoposition.h
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/components/BUILD.gn
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/components/autofill.gypi
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/components/autofill/content/browser/BUILD.gn
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/components/autofill/content/browser/DEPS
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/components/autofill/content/browser/risk/fingerprint.cc
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/components/autofill/content/browser/risk/fingerprint_browsertest.cc
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/content/DEPS
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/content/app/BUILD.gn
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/content/app/DEPS
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/content/app/android/library_loader_hooks.cc
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/content/browser/BUILD.gn
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/content/browser/DEPS
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/content/browser/android/browser_jni_registrar.cc
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/content/browser/android/content_view_core_impl.cc
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/content/browser/browser_main_loop.cc
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/content/browser/devtools/protocol/emulation_handler.cc
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/content/browser/frame_host/render_frame_host_delegate.cc
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/content/browser/frame_host/render_frame_host_delegate.h
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/content/browser/frame_host/render_frame_host_impl.cc
[delete] https://crrev.com/26a2b5d483ff5bba97f62777a8d62b5e252c6401/content/browser/geolocation/DEPS
[delete] https://crrev.com/26a2b5d483ff5bba97f62777a8d62b5e252c6401/content/browser/geolocation/wifi_data_provider_win.h
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/content/content_browser.gypi
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/content/content_common.gypi
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/content/content_jni.gypi
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/content/content_shell.gypi
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/content/content_tests.gypi
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/content/public/android/BUILD.gn
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/content/public/android/javatests/src/org/chromium/content/browser/ContentViewLocationTest.java
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/content/public/android/javatests/src/org/chromium/content/browser/LocationProviderTest.java
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/content/public/browser/BUILD.gn
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/content/public/test/DEPS
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/content/public/test/android/BUILD.gn
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/content/public/test/content_test_suite_base.cc
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/content/shell/BUILD.gn
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/content/shell/android/BUILD.gn
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/content/shell/browser/DEPS
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/content/shell/browser/shell_access_token_store.h
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/content/shell/browser/shell_browser_main_parts.cc
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/content/test/BUILD.gn
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/BUILD.gn
[add] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/BUILD.gn
[add] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/DEPS
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/OWNERS
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/access_token_store.h
[add] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/android/geolocation_jni_registrar.cc
[add] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/android/geolocation_jni_registrar.h
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/android/java/org/chromium/device/geolocation/LocationProviderAdapter.java
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/android/java/org/chromium/device/geolocation/LocationProviderFactory.java
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/android/java/org/chromium/device/geolocation/MockLocationProvider.java
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/empty_wifi_data_provider.cc
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/empty_wifi_data_provider.h
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/fake_access_token_store.cc
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/fake_access_token_store.h
[add] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/geolocation.gyp
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/geolocation_delegate.cc
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/geolocation_delegate.h
[add] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/geolocation_export.h
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/geolocation_provider.h
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/geolocation_provider_impl.cc
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/geolocation_provider_impl.h
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/geolocation_provider_impl_unittest.cc
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/geolocation_service_context.cc
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/geolocation_service_context.h
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/geolocation_service_impl.cc
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/geolocation_service_impl.h
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/geoposition.cc
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/geoposition.h
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/location_api_adapter_android.cc
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/location_api_adapter_android.h
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/location_arbitrator.h
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/location_arbitrator_impl.cc
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/location_arbitrator_impl.h
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/location_arbitrator_impl_unittest.cc
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/location_provider.h
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/location_provider_android.cc
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/location_provider_android.h
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/location_provider_base.cc
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/location_provider_base.h
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/mock_location_arbitrator.cc
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/mock_location_arbitrator.h
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/mock_location_provider.cc
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/mock_location_provider.h
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/network_location_provider.cc
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/network_location_provider.h
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/network_location_provider_unittest.cc
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/network_location_request.cc
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/network_location_request.h
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/wifi_data.cc
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/wifi_data.h
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/wifi_data_provider.cc
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/wifi_data_provider.h
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/wifi_data_provider_chromeos.cc
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/wifi_data_provider_chromeos.h
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/wifi_data_provider_chromeos_unittest.cc
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/wifi_data_provider_common.cc
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/wifi_data_provider_common.h
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/wifi_data_provider_common_unittest.cc
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/wifi_data_provider_common_win.cc
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/wifi_data_provider_common_win.h
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/wifi_data_provider_corewlan_mac.mm
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/wifi_data_provider_linux.cc
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/wifi_data_provider_linux.h
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/wifi_data_provider_linux_unittest.cc
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/wifi_data_provider_mac.cc
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/wifi_data_provider_mac.h
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/wifi_data_provider_manager.cc
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/wifi_data_provider_manager.h
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/wifi_data_provider_win.cc
[add] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/wifi_data_provider_win.h
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/wifi_data_provider_win_unittest.cc
[rename] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/geolocation/wifi_polling_policy.h
[modify] https://crrev.com/4e216e71b1e151982bc0b08919b3264febf6e46a/device/test/run_all_unittests.cc

Comment 33 by gov...@chromium.org, Jul 31 2016

Labels: -Merge-Review-54

M54 is not branched yet so remvoing "Merge-Review-54" label. Thank you.

Project Member

Comment 34 by bugdroid1@chromium.org, Aug 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8720394fae3de0684dbe539423483ca1195b06f4

commit 8720394fae3de0684dbe539423483ca1195b06f4
Author: mcasas <mcasas@chromium.org>
Date: Wed Aug 03 22:42:38 2016

Geolocation: move mojom from WebKit to device/geolocation/public/interfaces

This CL moves geolocation.mojom from its location in third_party/WebKit
to device/geolocation/public/interfaces (following the example of its
peers in device/).
Call/include sites updated. Changed to using new mojo wrapper types.

BUG=612334

Review-Url: https://codereview.chromium.org/2201883003
Cr-Commit-Position: refs/heads/master@{#409646}

[modify] https://crrev.com/8720394fae3de0684dbe539423483ca1195b06f4/content/browser/BUILD.gn
[modify] https://crrev.com/8720394fae3de0684dbe539423483ca1195b06f4/content/browser/DEPS
[modify] https://crrev.com/8720394fae3de0684dbe539423483ca1195b06f4/device/geolocation/BUILD.gn
[modify] https://crrev.com/8720394fae3de0684dbe539423483ca1195b06f4/device/geolocation/DEPS
[modify] https://crrev.com/8720394fae3de0684dbe539423483ca1195b06f4/device/geolocation/geolocation_service_context.cc
[modify] https://crrev.com/8720394fae3de0684dbe539423483ca1195b06f4/device/geolocation/geolocation_service_context.h
[modify] https://crrev.com/8720394fae3de0684dbe539423483ca1195b06f4/device/geolocation/geolocation_service_impl.cc
[modify] https://crrev.com/8720394fae3de0684dbe539423483ca1195b06f4/device/geolocation/geolocation_service_impl.h
[add] https://crrev.com/8720394fae3de0684dbe539423483ca1195b06f4/device/geolocation/public/interfaces/BUILD.gn
[rename] https://crrev.com/8720394fae3de0684dbe539423483ca1195b06f4/device/geolocation/public/interfaces/OWNERS
[rename] https://crrev.com/8720394fae3de0684dbe539423483ca1195b06f4/device/geolocation/public/interfaces/geolocation.mojom
[modify] https://crrev.com/8720394fae3de0684dbe539423483ca1195b06f4/third_party/WebKit/LayoutTests/fast/dom/Geolocation/resources/geolocation-mock.js
[modify] https://crrev.com/8720394fae3de0684dbe539423483ca1195b06f4/third_party/WebKit/Source/modules/BUILD.gn
[modify] https://crrev.com/8720394fae3de0684dbe539423483ca1195b06f4/third_party/WebKit/Source/modules/geolocation/DEPS
[modify] https://crrev.com/8720394fae3de0684dbe539423483ca1195b06f4/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp
[modify] https://crrev.com/8720394fae3de0684dbe539423483ca1195b06f4/third_party/WebKit/Source/modules/geolocation/Geolocation.h
[modify] https://crrev.com/8720394fae3de0684dbe539423483ca1195b06f4/third_party/WebKit/public/BUILD.gn

Comment 35 by mcasas@chromium.org, Aug 23 2016

Status: Fixed (was: Started)

Marking this bug as fixed since geolocation seems to 
be sticking to //device/geolocation. If and when
needed, it can be further transferred elsewhere
(//services?) but that should be tracked separately.

Comment 36 by benhenry@chromium.org, Sep 22 2017

Components: Blink>Geolocation

Comment 37 by benhenry@chromium.org, Sep 22 2017

Components: -Blink>Location

Comment 38 by laforge@google.com, Nov 7 2017

Components: Internals>Services
Labels: Type-Task

Appending component Internals>Services to S13N projects and changing the Type (for tracking sake) to Type=Task.

►

Issue 612334 link

Issue metadata

Content Modularization Project: Geolocation service

Issue description

Comment 1 by jam@chromium.org, May 17 2016

Comment 1 Deleted

Comment 2 by mvanouwe...@chromium.org, May 17 2016

Comment 2 Deleted

Comment 3 by leon....@intel.com, Jun 7 2016

Comment 3 Deleted

Comment 4 by mvanouwe...@chromium.org, Jun 7 2016

Comment 4 Deleted

Comment 5 by jam@chromium.org, Jun 7 2016

Comment 5 Deleted

Comment 6 by leon....@intel.com, Jun 8 2016

Comment 6 Deleted

Comment 7 by leon....@intel.com, Jun 8 2016

Comment 7 Deleted

Comment 8 by jam@chromium.org, Jun 17 2016

Comment 8 Deleted

Comment 9 by mcasas@chromium.org, Jun 17 2016

Comment 9 Deleted

Comment 10 by bugdroid1@chromium.org, Jun 28 2016

Comment 10 Deleted

Comment 11 by bugdroid1@chromium.org, Jun 29 2016

Comment 11 Deleted

Comment 12 by mcasas@chromium.org, Jul 8 2016

Comment 12 Deleted

Comment 13 by bugdroid1@chromium.org, Jul 22 2016

Comment 13 Deleted

Comment 14 by bugdroid1@chromium.org, Jul 22 2016

Comment 14 Deleted

Comment 15 by bugdroid1@chromium.org, Jul 22 2016

Comment 15 Deleted

Comment 16 by mcasas@chromium.org, Jul 27 2016

Comment 16 Deleted

Comment 17 by bugdroid1@chromium.org, Jul 27 2016

Comment 17 Deleted

Comment 18 by bugdroid1@chromium.org, Jul 27 2016

Comment 18 Deleted

Comment 19 by bugdroid1@chromium.org, Jul 27 2016

Comment 19 Deleted

Comment 20 by bugdroid1@chromium.org, Jul 28 2016

Comment 20 Deleted

Comment 21 by bugdroid1@chromium.org, Jul 28 2016

Comment 21 Deleted

Comment 22 by tsergeant@chromium.org, Jul 28 2016

Comment 22 Deleted

Comment 23 by bugdroid1@chromium.org, Jul 28 2016

Comment 23 Deleted

Comment 24 by tsergeant@chromium.org, Jul 28 2016

Comment 24 Deleted

Comment 25 by dimu@chromium.org, Jul 28 2016

Comment 25 Deleted

Comment 26 by tsergeant@chromium.org, Jul 28 2016

Comment 26 Deleted

Comment 27 by bugdroid1@chromium.org, Jul 28 2016

Comment 27 Deleted

Comment 28 by bugdroid1@chromium.org, Jul 28 2016

Comment 28 Deleted

Comment 29 by bugdroid1@chromium.org, Jul 28 2016

Comment 29 Deleted

Comment 30 by bugdroid1@chromium.org, Jul 28 2016

Comment 30 Deleted

Comment 31 by bugdroid1@chromium.org, Jul 28 2016

Comment 31 Deleted

Comment 32 by bugdroid1@chromium.org, Jul 28 2016

Comment 32 Deleted

Comment 33 by gov...@chromium.org, Jul 31 2016

Comment 33 Deleted

Comment 34 by bugdroid1@chromium.org, Aug 3 2016

Comment 34 Deleted

Comment 35 by mcasas@chromium.org, Aug 23 2016

Comment 35 Deleted

Comment 36 by benhenry@chromium.org, Sep 22 2017

Comment 36 Deleted

Comment 37 by benhenry@chromium.org, Sep 22 2017

Comment 37 Deleted

Comment 38 by laforge@google.com, Nov 7 2017

Comment 38 Deleted