mash needs support for various WM accelerators ash has (e.g. alt + + = maximize, alt + ] = snap left, etc.)
I'm going to lower to a 2, I agree this is important, but we have bigger things that need to be done before accelerators are an issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/76d46665b53e76c0d8c2e6a642ae686ef2b44048 commit 76d46665b53e76c0d8c2e6a642ae686ef2b44048 Author: sky <sky@chromium.org> Date: Fri Jul 08 18:43:01 2016 Adds ability for pre-target accelerators to not consume events Prior to this change if you registered an accelerator for a key event then only the accelerator got the event. After this change the tree that registered the accelerator (wm) need not consume the event. If the wm doesn't consume the event it'll be processed normally. BUG= 612331 TEST=covered by tests R=sadrul@chromium.org, dcheng@chromium.org Review-Url: https://codereview.chromium.org/2125883003 Cr-Commit-Position: refs/heads/master@{#404450} [modify] https://crrev.com/76d46665b53e76c0d8c2e6a642ae686ef2b44048/ash/accelerators/accelerator_delegate.cc [modify] https://crrev.com/76d46665b53e76c0d8c2e6a642ae686ef2b44048/ash/mus/window_manager.cc [modify] https://crrev.com/76d46665b53e76c0d8c2e6a642ae686ef2b44048/ash/mus/window_manager.h [modify] https://crrev.com/76d46665b53e76c0d8c2e6a642ae686ef2b44048/services/ui/demo/mus_demo.cc [modify] https://crrev.com/76d46665b53e76c0d8c2e6a642ae686ef2b44048/services/ui/demo/mus_demo.h [modify] https://crrev.com/76d46665b53e76c0d8c2e6a642ae686ef2b44048/services/ui/public/cpp/BUILD.gn [modify] https://crrev.com/76d46665b53e76c0d8c2e6a642ae686ef2b44048/services/ui/public/cpp/lib/window_tree_client.cc [modify] https://crrev.com/76d46665b53e76c0d8c2e6a642ae686ef2b44048/services/ui/public/cpp/tests/window_server_test_base.cc [modify] https://crrev.com/76d46665b53e76c0d8c2e6a642ae686ef2b44048/services/ui/public/cpp/tests/window_server_test_base.h [add] https://crrev.com/76d46665b53e76c0d8c2e6a642ae686ef2b44048/services/ui/public/cpp/window_manager_delegate.cc [modify] https://crrev.com/76d46665b53e76c0d8c2e6a642ae686ef2b44048/services/ui/public/cpp/window_manager_delegate.h [modify] https://crrev.com/76d46665b53e76c0d8c2e6a642ae686ef2b44048/services/ui/public/cpp/window_tree_client.h [modify] https://crrev.com/76d46665b53e76c0d8c2e6a642ae686ef2b44048/services/ui/public/interfaces/event_matcher.mojom [modify] https://crrev.com/76d46665b53e76c0d8c2e6a642ae686ef2b44048/services/ui/public/interfaces/window_manager.mojom [modify] https://crrev.com/76d46665b53e76c0d8c2e6a642ae686ef2b44048/services/ui/public/interfaces/window_tree.mojom [modify] https://crrev.com/76d46665b53e76c0d8c2e6a642ae686ef2b44048/services/ui/test_wm/test_wm.cc [modify] https://crrev.com/76d46665b53e76c0d8c2e6a642ae686ef2b44048/services/ui/ws/event_dispatcher.cc [modify] https://crrev.com/76d46665b53e76c0d8c2e6a642ae686ef2b44048/services/ui/ws/event_dispatcher.h [modify] https://crrev.com/76d46665b53e76c0d8c2e6a642ae686ef2b44048/services/ui/ws/event_dispatcher_delegate.h [modify] https://crrev.com/76d46665b53e76c0d8c2e6a642ae686ef2b44048/services/ui/ws/event_dispatcher_unittest.cc [modify] https://crrev.com/76d46665b53e76c0d8c2e6a642ae686ef2b44048/services/ui/ws/test_utils.cc [modify] https://crrev.com/76d46665b53e76c0d8c2e6a642ae686ef2b44048/services/ui/ws/test_utils.h [modify] https://crrev.com/76d46665b53e76c0d8c2e6a642ae686ef2b44048/services/ui/ws/window_manager_client_unittest.cc [modify] https://crrev.com/76d46665b53e76c0d8c2e6a642ae686ef2b44048/services/ui/ws/window_manager_state.cc [modify] https://crrev.com/76d46665b53e76c0d8c2e6a642ae686ef2b44048/services/ui/ws/window_manager_state.h [modify] https://crrev.com/76d46665b53e76c0d8c2e6a642ae686ef2b44048/services/ui/ws/window_manager_state_unittest.cc [modify] https://crrev.com/76d46665b53e76c0d8c2e6a642ae686ef2b44048/services/ui/ws/window_tree.cc [modify] https://crrev.com/76d46665b53e76c0d8c2e6a642ae686ef2b44048/services/ui/ws/window_tree.h [modify] https://crrev.com/76d46665b53e76c0d8c2e6a642ae686ef2b44048/services/ui/ws/window_tree_client_unittest.cc [add] https://crrev.com/76d46665b53e76c0d8c2e6a642ae686ef2b44048/ui/events/mojo/OWNERS [modify] https://crrev.com/76d46665b53e76c0d8c2e6a642ae686ef2b44048/ui/events/mojo/event_constants.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/44a098967d846660aea85e1ae5e6758ff3b6589e commit 44a098967d846660aea85e1ae5e6758ff3b6589e Author: sky <sky@chromium.org> Date: Wed Jul 20 17:46:58 2016 Separates out accelerators using non-common types These are the set of accelerators that have dependencies on parts not ported. I suspect some of these won't make sense in a mash world, but for now I'm lumping it all together. BUG= 612331 TEST=covered by tests R=jamescook@chromium.org, reveman@chromium.org Review-Url: https://codereview.chromium.org/2162193003 Cr-Commit-Position: refs/heads/master@{#406607} [modify] https://crrev.com/44a098967d846660aea85e1ae5e6758ff3b6589e/ash/accelerators/accelerator_commands.cc [modify] https://crrev.com/44a098967d846660aea85e1ae5e6758ff3b6589e/ash/accelerators/accelerator_commands.h [add] https://crrev.com/44a098967d846660aea85e1ae5e6758ff3b6589e/ash/accelerators/accelerator_commands_aura.cc [add] https://crrev.com/44a098967d846660aea85e1ae5e6758ff3b6589e/ash/accelerators/accelerator_commands_aura.h [modify] https://crrev.com/44a098967d846660aea85e1ae5e6758ff3b6589e/ash/accelerators/accelerator_commands_unittest.cc [modify] https://crrev.com/44a098967d846660aea85e1ae5e6758ff3b6589e/ash/accelerators/accelerator_controller.cc [modify] https://crrev.com/44a098967d846660aea85e1ae5e6758ff3b6589e/ash/accelerators/accelerator_controller.h [add] https://crrev.com/44a098967d846660aea85e1ae5e6758ff3b6589e/ash/accelerators/accelerator_controller_delegate.h [add] https://crrev.com/44a098967d846660aea85e1ae5e6758ff3b6589e/ash/accelerators/accelerator_controller_delegate_aura.cc [add] https://crrev.com/44a098967d846660aea85e1ae5e6758ff3b6589e/ash/accelerators/accelerator_controller_delegate_aura.h [modify] https://crrev.com/44a098967d846660aea85e1ae5e6758ff3b6589e/ash/ash.gyp [modify] https://crrev.com/44a098967d846660aea85e1ae5e6758ff3b6589e/ash/common/wm/window_positioning_utils.cc [modify] https://crrev.com/44a098967d846660aea85e1ae5e6758ff3b6589e/ash/common/wm/window_positioning_utils.h [modify] https://crrev.com/44a098967d846660aea85e1ae5e6758ff3b6589e/ash/display/display_manager_unittest.cc [modify] https://crrev.com/44a098967d846660aea85e1ae5e6758ff3b6589e/ash/shell.cc [modify] https://crrev.com/44a098967d846660aea85e1ae5e6758ff3b6589e/ash/shell.h [modify] https://crrev.com/44a098967d846660aea85e1ae5e6758ff3b6589e/ash/test/ash_test_helper.cc [modify] https://crrev.com/44a098967d846660aea85e1ae5e6758ff3b6589e/ash/wm/window_util.cc [modify] https://crrev.com/44a098967d846660aea85e1ae5e6758ff3b6589e/ash/wm/window_util.h [modify] https://crrev.com/44a098967d846660aea85e1ae5e6758ff3b6589e/ash/wm/window_util_unittest.cc [modify] https://crrev.com/44a098967d846660aea85e1ae5e6758ff3b6589e/chrome/browser/policy/policy_browsertest.cc [modify] https://crrev.com/44a098967d846660aea85e1ae5e6758ff3b6589e/chrome/browser/ui/ash/accelerator_commands_browsertest.cc [modify] https://crrev.com/44a098967d846660aea85e1ae5e6758ff3b6589e/chrome/browser/ui/ash/ash_init.cc [modify] https://crrev.com/44a098967d846660aea85e1ae5e6758ff3b6589e/chrome/browser/ui/browser_command_controller.cc [modify] https://crrev.com/44a098967d846660aea85e1ae5e6758ff3b6589e/chrome/browser/ui/browser_commands_chromeos.cc [modify] https://crrev.com/44a098967d846660aea85e1ae5e6758ff3b6589e/components/exo/pointer_unittest.cc [modify] https://crrev.com/44a098967d846660aea85e1ae5e6758ff3b6589e/components/exo/touch_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/004dce53fdc0eabb8c4413a74ee854a686621299 commit 004dce53fdc0eabb8c4413a74ee854a686621299 Author: sky <sky@chromium.org> Date: Wed Jul 20 21:28:27 2016 Moves ToastManager from Shell to WmShell BUG= 612331 TEST=covered by tests R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2171493002 Cr-Commit-Position: refs/heads/master@{#406673} [modify] https://crrev.com/004dce53fdc0eabb8c4413a74ee854a686621299/ash/accelerators/debug_commands.cc [modify] https://crrev.com/004dce53fdc0eabb8c4413a74ee854a686621299/ash/common/wm_shell.cc [modify] https://crrev.com/004dce53fdc0eabb8c4413a74ee854a686621299/ash/common/wm_shell.h [modify] https://crrev.com/004dce53fdc0eabb8c4413a74ee854a686621299/ash/mus/bridge/wm_shell_mus.cc [modify] https://crrev.com/004dce53fdc0eabb8c4413a74ee854a686621299/ash/shell.cc [modify] https://crrev.com/004dce53fdc0eabb8c4413a74ee854a686621299/ash/shell.h [modify] https://crrev.com/004dce53fdc0eabb8c4413a74ee854a686621299/ash/system/toast/toast_manager_unittest.cc [modify] https://crrev.com/004dce53fdc0eabb8c4413a74ee854a686621299/ui/arc/notification/arc_notification_manager.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de61f98917bb57f90490a730b23168b85722868d commit de61f98917bb57f90490a730b23168b85722868d Author: sky <sky@chromium.org> Date: Thu Jul 21 16:56:13 2016 Moves accelerator code using common types to ash/common BUG= 612331 TEST=none R=jamescook@chromium.org TBR=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2166793005 Cr-Commit-Position: refs/heads/master@{#406877} [modify] https://crrev.com/de61f98917bb57f90490a730b23168b85722868d/ash/accelerators/accelerator_commands_unittest.cc [modify] https://crrev.com/de61f98917bb57f90490a730b23168b85722868d/ash/accelerators/accelerator_controller_delegate_aura.cc [modify] https://crrev.com/de61f98917bb57f90490a730b23168b85722868d/ash/accelerators/accelerator_controller_delegate_aura.h [modify] https://crrev.com/de61f98917bb57f90490a730b23168b85722868d/ash/accelerators/accelerator_controller_unittest.cc [modify] https://crrev.com/de61f98917bb57f90490a730b23168b85722868d/ash/accelerators/accelerator_delegate.cc [modify] https://crrev.com/de61f98917bb57f90490a730b23168b85722868d/ash/accelerators/accelerator_filter_unittest.cc [modify] https://crrev.com/de61f98917bb57f90490a730b23168b85722868d/ash/accelerators/accelerator_interactive_uitest_chromeos.cc [modify] https://crrev.com/de61f98917bb57f90490a730b23168b85722868d/ash/accelerators/focus_manager_factory.cc [modify] https://crrev.com/de61f98917bb57f90490a730b23168b85722868d/ash/ash.gyp [rename] https://crrev.com/de61f98917bb57f90490a730b23168b85722868d/ash/common/accelerators/accelerator_commands.cc [rename] https://crrev.com/de61f98917bb57f90490a730b23168b85722868d/ash/common/accelerators/accelerator_commands.h [rename] https://crrev.com/de61f98917bb57f90490a730b23168b85722868d/ash/common/accelerators/accelerator_controller.cc [rename] https://crrev.com/de61f98917bb57f90490a730b23168b85722868d/ash/common/accelerators/accelerator_controller.h [rename] https://crrev.com/de61f98917bb57f90490a730b23168b85722868d/ash/common/accelerators/accelerator_controller_delegate.h [rename] https://crrev.com/de61f98917bb57f90490a730b23168b85722868d/ash/common/accelerators/accelerator_table.cc [rename] https://crrev.com/de61f98917bb57f90490a730b23168b85722868d/ash/common/accelerators/accelerator_table.h [rename] https://crrev.com/de61f98917bb57f90490a730b23168b85722868d/ash/common/accelerators/accelerator_table_unittest.cc [rename] https://crrev.com/de61f98917bb57f90490a730b23168b85722868d/ash/common/accelerators/debug_commands.cc [rename] https://crrev.com/de61f98917bb57f90490a730b23168b85722868d/ash/common/accelerators/debug_commands.h [rename] https://crrev.com/de61f98917bb57f90490a730b23168b85722868d/ash/common/accelerators/exit_warning_handler.cc [rename] https://crrev.com/de61f98917bb57f90490a730b23168b85722868d/ash/common/accelerators/exit_warning_handler.h [rename] https://crrev.com/de61f98917bb57f90490a730b23168b85722868d/ash/common/ime_control_delegate.h [modify] https://crrev.com/de61f98917bb57f90490a730b23168b85722868d/ash/content/keyboard_overlay/keyboard_overlay_view_unittest.cc [modify] https://crrev.com/de61f98917bb57f90490a730b23168b85722868d/ash/magnifier/magnification_controller.cc [modify] https://crrev.com/de61f98917bb57f90490a730b23168b85722868d/ash/shelf/shelf_layout_manager.cc [modify] https://crrev.com/de61f98917bb57f90490a730b23168b85722868d/ash/shelf/shelf_layout_manager_unittest.cc [modify] https://crrev.com/de61f98917bb57f90490a730b23168b85722868d/ash/shell.cc [modify] https://crrev.com/de61f98917bb57f90490a730b23168b85722868d/ash/wm/power_button_controller.cc [modify] https://crrev.com/de61f98917bb57f90490a730b23168b85722868d/ash/wm/system_gesture_event_filter_unittest.cc [modify] https://crrev.com/de61f98917bb57f90490a730b23168b85722868d/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc [modify] https://crrev.com/de61f98917bb57f90490a730b23168b85722868d/chrome/browser/extensions/api/automation/automation_apitest.cc [modify] https://crrev.com/de61f98917bb57f90490a730b23168b85722868d/chrome/browser/extensions/global_shortcut_listener_chromeos.cc [modify] https://crrev.com/de61f98917bb57f90490a730b23168b85722868d/chrome/browser/policy/policy_browsertest.cc [modify] https://crrev.com/de61f98917bb57f90490a730b23168b85722868d/chrome/browser/ui/ash/accelerator_commands_browsertest.cc [modify] https://crrev.com/de61f98917bb57f90490a730b23168b85722868d/chrome/browser/ui/ash/accelerator_controller_browsertest.cc [modify] https://crrev.com/de61f98917bb57f90490a730b23168b85722868d/chrome/browser/ui/ash/ash_init.cc [modify] https://crrev.com/de61f98917bb57f90490a730b23168b85722868d/chrome/browser/ui/ash/ash_util.cc [modify] https://crrev.com/de61f98917bb57f90490a730b23168b85722868d/chrome/browser/ui/ash/chrome_screenshot_grabber_unittest.cc [modify] https://crrev.com/de61f98917bb57f90490a730b23168b85722868d/chrome/browser/ui/ash/ime_controller_chromeos.h [modify] https://crrev.com/de61f98917bb57f90490a730b23168b85722868d/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc [modify] https://crrev.com/de61f98917bb57f90490a730b23168b85722868d/chrome/browser/ui/views/accelerator_table.cc [modify] https://crrev.com/de61f98917bb57f90490a730b23168b85722868d/chrome/browser/ui/views/accelerator_table_unittest.cc [modify] https://crrev.com/de61f98917bb57f90490a730b23168b85722868d/chrome/browser/ui/views/accelerator_utils_aura.cc [modify] https://crrev.com/de61f98917bb57f90490a730b23168b85722868d/chrome/browser/ui/views/chrome_views_delegate.cc [modify] https://crrev.com/de61f98917bb57f90490a730b23168b85722868d/chrome/browser/ui/views/tabs/tab_drag_controller.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/89eb8019e501cf7434f275481ddf0ba0f9d618c0 commit 89eb8019e501cf7434f275481ddf0ba0f9d618c0 Author: sky <sky@chromium.org> Date: Fri Jul 22 03:28:31 2016 Moves AcceleratorController from Shell to WmShell BUG= 612331 TEST=none R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2170753005 Cr-Commit-Position: refs/heads/master@{#407024} [modify] https://crrev.com/89eb8019e501cf7434f275481ddf0ba0f9d618c0/ash/accelerators/accelerator_controller_unittest.cc [modify] https://crrev.com/89eb8019e501cf7434f275481ddf0ba0f9d618c0/ash/accelerators/accelerator_delegate.cc [modify] https://crrev.com/89eb8019e501cf7434f275481ddf0ba0f9d618c0/ash/accelerators/focus_manager_factory.cc [modify] https://crrev.com/89eb8019e501cf7434f275481ddf0ba0f9d618c0/ash/common/wm_shell.cc [modify] https://crrev.com/89eb8019e501cf7434f275481ddf0ba0f9d618c0/ash/common/wm_shell.h [modify] https://crrev.com/89eb8019e501cf7434f275481ddf0ba0f9d618c0/ash/mus/BUILD.gn [add] https://crrev.com/89eb8019e501cf7434f275481ddf0ba0f9d618c0/ash/mus/accelerators/accelerator_controller_delegate_mus.cc [add] https://crrev.com/89eb8019e501cf7434f275481ddf0ba0f9d618c0/ash/mus/accelerators/accelerator_controller_delegate_mus.h [modify] https://crrev.com/89eb8019e501cf7434f275481ddf0ba0f9d618c0/ash/mus/bridge/wm_shell_mus.cc [modify] https://crrev.com/89eb8019e501cf7434f275481ddf0ba0f9d618c0/ash/mus/bridge/wm_shell_mus.h [modify] https://crrev.com/89eb8019e501cf7434f275481ddf0ba0f9d618c0/ash/shelf/shelf_layout_manager_unittest.cc [modify] https://crrev.com/89eb8019e501cf7434f275481ddf0ba0f9d618c0/ash/shell.cc [modify] https://crrev.com/89eb8019e501cf7434f275481ddf0ba0f9d618c0/ash/shell.h [modify] https://crrev.com/89eb8019e501cf7434f275481ddf0ba0f9d618c0/ash/wm/power_button_controller.cc [modify] https://crrev.com/89eb8019e501cf7434f275481ddf0ba0f9d618c0/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc [modify] https://crrev.com/89eb8019e501cf7434f275481ddf0ba0f9d618c0/chrome/browser/extensions/api/automation/automation_apitest.cc [modify] https://crrev.com/89eb8019e501cf7434f275481ddf0ba0f9d618c0/chrome/browser/extensions/global_shortcut_listener_chromeos.cc [modify] https://crrev.com/89eb8019e501cf7434f275481ddf0ba0f9d618c0/chrome/browser/policy/policy_browsertest.cc [modify] https://crrev.com/89eb8019e501cf7434f275481ddf0ba0f9d618c0/chrome/browser/ui/ash/accelerator_controller_browsertest.cc [modify] https://crrev.com/89eb8019e501cf7434f275481ddf0ba0f9d618c0/chrome/browser/ui/ash/ash_init.cc [modify] https://crrev.com/89eb8019e501cf7434f275481ddf0ba0f9d618c0/chrome/browser/ui/ash/ash_util.cc [modify] https://crrev.com/89eb8019e501cf7434f275481ddf0ba0f9d618c0/chrome/browser/ui/views/chrome_views_delegate.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eed46f8917f47c85ac37c8f04267058905beda56 commit eed46f8917f47c85ac37c8f04267058905beda56 Author: sky <sky@chromium.org> Date: Fri Jul 22 17:58:21 2016 Move processing out of AcceleratorDelegate AcceleratorDelegate now trivially forwards to AcceleratorRouter, which is now in terms of ash/common types. BUG= 612331 TEST=none R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2171983002 Cr-Commit-Position: refs/heads/master@{#407198} [modify] https://crrev.com/eed46f8917f47c85ac37c8f04267058905beda56/ash/accelerators/accelerator_delegate.cc [modify] https://crrev.com/eed46f8917f47c85ac37c8f04267058905beda56/ash/accelerators/accelerator_delegate.h [modify] https://crrev.com/eed46f8917f47c85ac37c8f04267058905beda56/ash/ash.gyp [modify] https://crrev.com/eed46f8917f47c85ac37c8f04267058905beda56/ash/aura/wm_window_aura.cc [modify] https://crrev.com/eed46f8917f47c85ac37c8f04267058905beda56/ash/aura/wm_window_aura.h [add] https://crrev.com/eed46f8917f47c85ac37c8f04267058905beda56/ash/common/accelerators/accelerator_router.cc [add] https://crrev.com/eed46f8917f47c85ac37c8f04267058905beda56/ash/common/accelerators/accelerator_router.h [modify] https://crrev.com/eed46f8917f47c85ac37c8f04267058905beda56/ash/common/wm_window.h [modify] https://crrev.com/eed46f8917f47c85ac37c8f04267058905beda56/ash/mus/bridge/wm_window_mus.cc [modify] https://crrev.com/eed46f8917f47c85ac37c8f04267058905beda56/ash/mus/bridge/wm_window_mus.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/853669a14f2788e508597bf9e72235ff6d77945a commit 853669a14f2788e508597bf9e72235ff6d77945a Author: sky <sky@chromium.org> Date: Fri Jul 22 18:43:12 2016 Separates out accelerator handling in windowmanager This will make it easy for different parts of the ash wm code to register accelerators. BUG= 612331 TEST=none R=ben@chromium.org Review-Url: https://codereview.chromium.org/2171973003 Cr-Commit-Position: refs/heads/master@{#407216} [modify] https://crrev.com/853669a14f2788e508597bf9e72235ff6d77945a/ash/mus/BUILD.gn [add] https://crrev.com/853669a14f2788e508597bf9e72235ff6d77945a/ash/mus/accelerators/accelerator_handler.h [add] https://crrev.com/853669a14f2788e508597bf9e72235ff6d77945a/ash/mus/accelerators/accelerator_ids.h [rename] https://crrev.com/853669a14f2788e508597bf9e72235ff6d77945a/ash/mus/accelerators/accelerator_registrar_impl.cc [rename] https://crrev.com/853669a14f2788e508597bf9e72235ff6d77945a/ash/mus/accelerators/accelerator_registrar_impl.h [rename] https://crrev.com/853669a14f2788e508597bf9e72235ff6d77945a/ash/mus/accelerators/accelerator_registrar_unittest.cc [modify] https://crrev.com/853669a14f2788e508597bf9e72235ff6d77945a/ash/mus/window_manager.cc [modify] https://crrev.com/853669a14f2788e508597bf9e72235ff6d77945a/ash/mus/window_manager.h [modify] https://crrev.com/853669a14f2788e508597bf9e72235ff6d77945a/ash/mus/window_manager_application.cc [modify] https://crrev.com/853669a14f2788e508597bf9e72235ff6d77945a/ash/mus/window_manager_observer.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0420380e5d69fbc523b00cda0b94da515bc693f9 commit 0420380e5d69fbc523b00cda0b94da515bc693f9 Author: sky <sky@chromium.org> Date: Mon Jul 25 19:08:11 2016 Adds AcceleratorManagerDelegate Which is notified as accelerators are added/removed. BUG= 612331 TEST=none R=ben@chromium.org Review-Url: https://codereview.chromium.org/2177983002 Cr-Commit-Position: refs/heads/master@{#407538} [modify] https://crrev.com/0420380e5d69fbc523b00cda0b94da515bc693f9/ui/base/BUILD.gn [modify] https://crrev.com/0420380e5d69fbc523b00cda0b94da515bc693f9/ui/base/accelerators/accelerator_manager.cc [modify] https://crrev.com/0420380e5d69fbc523b00cda0b94da515bc693f9/ui/base/accelerators/accelerator_manager.h [add] https://crrev.com/0420380e5d69fbc523b00cda0b94da515bc693f9/ui/base/accelerators/accelerator_manager_delegate.h [modify] https://crrev.com/0420380e5d69fbc523b00cda0b94da515bc693f9/ui/base/accelerators/accelerator_manager_unittest.cc [modify] https://crrev.com/0420380e5d69fbc523b00cda0b94da515bc693f9/ui/base/ui_base.gyp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd4636a3c3637df3ec2343f3a3f4b3bb26f074c2 commit dd4636a3c3637df3ec2343f3a3f4b3bb26f074c2 Author: sky <sky@chromium.org> Date: Wed Jul 27 16:28:37 2016 Changes WindowTreeHostMus to not always StopPropagation Other code should mark the event as handled/stop-propagation as appropriate. If we always mark as consumed accelerators won't be notified appropriately. BUG= 612331 TEST=none R=sadrul@chromium.org Review-Url: https://codereview.chromium.org/2188613002 Cr-Commit-Position: refs/heads/master@{#408148} [modify] https://crrev.com/dd4636a3c3637df3ec2343f3a3f4b3bb26f074c2/ui/views/mus/window_tree_host_mus.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/99106ee359c78c25120afe69e2d6964a3cd8a593 commit 99106ee359c78c25120afe69e2d6964a3cd8a593 Author: sky <sky@chromium.org> Date: Wed Jul 27 17:40:59 2016 Fixes bug in accelerator handling in mus Here's the problematic case: . Add a post accelerator. . Event comes in matching accelerator. * Target window responds with handled. . Different event comes in. . Target window response with unhandled. . Accelerator matching earlier event is notified. The accelerator should not have been notified at that last step. Things went wrong at * because post_target_accelerator_ was not getting reset. BUG= 612331 TEST=covered by tests R=sadrul@chromium.org Review-Url: https://codereview.chromium.org/2184613005 Cr-Commit-Position: refs/heads/master@{#408170} [modify] https://crrev.com/99106ee359c78c25120afe69e2d6964a3cd8a593/services/ui/ws/window_manager_state.cc [modify] https://crrev.com/99106ee359c78c25120afe69e2d6964a3cd8a593/services/ui/ws/window_manager_state_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4930de5975cdc4985da68b9be6ecc05d09c9f7c4 commit 4930de5975cdc4985da68b9be6ecc05d09c9f7c4 Author: sky <sky@chromium.org> Date: Wed Jul 27 18:32:28 2016 Copies AcceleratorControllerTest to mash Doing this in a single step to preserve history and make subsequent diffs easy. BUG= 612331 TEST=none R=sadrul@chromium.org TBR=sadrul@chromium.org Review-Url: https://codereview.chromium.org/2186093002 Cr-Commit-Position: refs/heads/master@{#408194} [add] https://crrev.com/4930de5975cdc4985da68b9be6ecc05d09c9f7c4/ash/mus/accelerators/accelerator_controller_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f0891a90a6cdb92d0a205d17df42acd81e796a30 commit f0891a90a6cdb92d0a205d17df42acd81e796a30 Author: sky <sky@chromium.org> Date: Wed Jul 27 19:00:06 2016 Wires up registering accelerators from mash with the wm AcceleratorControllerRegistrar is responsible for registering accelerators known to ash (in AcceleratorController) with the wm. In addition AcceleratorRegistrarImpl now registers keyboard accelerators with AcceleratorController. Accelerators are now registered for pre and post. This better matches how ash/chrome interact to process accelerators. See comment in AcceleratorControllerRegistrar for details on this. BUG= 612331 , 631545 TEST=none R=sadrul@chromium.org Review-Url: https://codereview.chromium.org/2187703003 Cr-Commit-Position: refs/heads/master@{#408205} [modify] https://crrev.com/f0891a90a6cdb92d0a205d17df42acd81e796a30/ash/ash.gyp [modify] https://crrev.com/f0891a90a6cdb92d0a205d17df42acd81e796a30/ash/common/accelerators/accelerator_controller.cc [modify] https://crrev.com/f0891a90a6cdb92d0a205d17df42acd81e796a30/ash/common/accelerators/accelerator_controller.h [rename] https://crrev.com/f0891a90a6cdb92d0a205d17df42acd81e796a30/ash/common/accelerators/ash_focus_manager_factory.cc [rename] https://crrev.com/f0891a90a6cdb92d0a205d17df42acd81e796a30/ash/common/accelerators/ash_focus_manager_factory.h [modify] https://crrev.com/f0891a90a6cdb92d0a205d17df42acd81e796a30/ash/common/wm_shell.cc [modify] https://crrev.com/f0891a90a6cdb92d0a205d17df42acd81e796a30/ash/mus/BUILD.gn [add] https://crrev.com/f0891a90a6cdb92d0a205d17df42acd81e796a30/ash/mus/accelerators/accelerator_controller_registrar.cc [add] https://crrev.com/f0891a90a6cdb92d0a205d17df42acd81e796a30/ash/mus/accelerators/accelerator_controller_registrar.h [modify] https://crrev.com/f0891a90a6cdb92d0a205d17df42acd81e796a30/ash/mus/accelerators/accelerator_registrar_impl.cc [modify] https://crrev.com/f0891a90a6cdb92d0a205d17df42acd81e796a30/ash/mus/accelerators/accelerator_registrar_impl.h [modify] https://crrev.com/f0891a90a6cdb92d0a205d17df42acd81e796a30/ash/mus/accelerators/accelerator_registrar_unittest.cc [modify] https://crrev.com/f0891a90a6cdb92d0a205d17df42acd81e796a30/ash/mus/bridge/wm_shell_mus.cc [modify] https://crrev.com/f0891a90a6cdb92d0a205d17df42acd81e796a30/ash/mus/bridge/wm_shell_mus.h [modify] https://crrev.com/f0891a90a6cdb92d0a205d17df42acd81e796a30/ash/mus/window_manager.cc [modify] https://crrev.com/f0891a90a6cdb92d0a205d17df42acd81e796a30/ash/shell.cc [modify] https://crrev.com/f0891a90a6cdb92d0a205d17df42acd81e796a30/ui/base/accelerators/accelerator_history.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2bf17c37aec28112cbf60e49c53c33d07497ccfd commit 2bf17c37aec28112cbf60e49c53c33d07497ccfd Author: sky <sky@chromium.org> Date: Wed Jul 27 20:39:20 2016 Moves TestVolumeControlDelegate to ash/common/test BUG= 612331 TEST=none R=msw@chromium.org Review-Url: https://codereview.chromium.org/2182443005 Cr-Commit-Position: refs/heads/master@{#408228} [modify] https://crrev.com/2bf17c37aec28112cbf60e49c53c33d07497ccfd/ash/accelerators/accelerator_controller_unittest.cc [modify] https://crrev.com/2bf17c37aec28112cbf60e49c53c33d07497ccfd/ash/accelerators/accelerator_interactive_uitest_chromeos.cc [modify] https://crrev.com/2bf17c37aec28112cbf60e49c53c33d07497ccfd/ash/ash.gyp [rename] https://crrev.com/2bf17c37aec28112cbf60e49c53c33d07497ccfd/ash/common/test/test_volume_control_delegate.cc [rename] https://crrev.com/2bf17c37aec28112cbf60e49c53c33d07497ccfd/ash/common/test/test_volume_control_delegate.h [modify] https://crrev.com/2bf17c37aec28112cbf60e49c53c33d07497ccfd/ash/wm/maximize_mode/maximize_mode_controller_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a279c7c6f9c39d546588e2d1ffd80f9ea3c306cb commit a279c7c6f9c39d546588e2d1ffd80f9ea3c306cb Author: sky <sky@chromium.org> Date: Wed Jul 27 23:08:42 2016 Moves NewWindowDelegate to ash/common And updates accelerators appropriately. BUG= 612331 TEST=none R=jamescook@chromium.org,stevenjb@chromium.org,reveman@chromium.org TBR=stevenjb@chromium.org,reveman@chromium.org Review-Url: https://codereview.chromium.org/2192613002 Cr-Commit-Position: refs/heads/master@{#408264} [modify] https://crrev.com/a279c7c6f9c39d546588e2d1ffd80f9ea3c306cb/ash/accelerators/accelerator_controller_delegate_aura.cc [modify] https://crrev.com/a279c7c6f9c39d546588e2d1ffd80f9ea3c306cb/ash/common/accelerators/accelerator_controller.cc [rename] https://crrev.com/a279c7c6f9c39d546588e2d1ffd80f9ea3c306cb/ash/common/new_window_delegate.h [modify] https://crrev.com/a279c7c6f9c39d546588e2d1ffd80f9ea3c306cb/ash/common/wm_shell.cc [modify] https://crrev.com/a279c7c6f9c39d546588e2d1ffd80f9ea3c306cb/ash/common/wm_shell.h [modify] https://crrev.com/a279c7c6f9c39d546588e2d1ffd80f9ea3c306cb/ash/display/display_util.cc [modify] https://crrev.com/a279c7c6f9c39d546588e2d1ffd80f9ea3c306cb/ash/mus/BUILD.gn [modify] https://crrev.com/a279c7c6f9c39d546588e2d1ffd80f9ea3c306cb/ash/mus/accelerators/accelerator_controller_delegate_mus.cc [add] https://crrev.com/a279c7c6f9c39d546588e2d1ffd80f9ea3c306cb/ash/mus/new_window_delegate_mus.cc [add] https://crrev.com/a279c7c6f9c39d546588e2d1ffd80f9ea3c306cb/ash/mus/new_window_delegate_mus.h [modify] https://crrev.com/a279c7c6f9c39d546588e2d1ffd80f9ea3c306cb/ash/mus/shell_delegate_mus.cc [modify] https://crrev.com/a279c7c6f9c39d546588e2d1ffd80f9ea3c306cb/ash/shell.cc [modify] https://crrev.com/a279c7c6f9c39d546588e2d1ffd80f9ea3c306cb/ash/shell.h [modify] https://crrev.com/a279c7c6f9c39d546588e2d1ffd80f9ea3c306cb/ash/shell/shell_delegate_impl.cc [modify] https://crrev.com/a279c7c6f9c39d546588e2d1ffd80f9ea3c306cb/ash/test/test_shell_delegate.cc [modify] https://crrev.com/a279c7c6f9c39d546588e2d1ffd80f9ea3c306cb/chrome/browser/ui/ash/chrome_new_window_delegate.h [modify] https://crrev.com/a279c7c6f9c39d546588e2d1ffd80f9ea3c306cb/chrome/browser/ui/ash/chrome_new_window_delegate_browsertest.cc [modify] https://crrev.com/a279c7c6f9c39d546588e2d1ffd80f9ea3c306cb/chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc [modify] https://crrev.com/a279c7c6f9c39d546588e2d1ffd80f9ea3c306cb/chrome/browser/ui/webui/settings/chromeos/device_keyboard_handler.cc [modify] https://crrev.com/a279c7c6f9c39d546588e2d1ffd80f9ea3c306cb/components/arc/intent_helper/arc_intent_helper_bridge.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d4038f3350e3a2206801adbac1c31553157a38b commit 6d4038f3350e3a2206801adbac1c31553157a38b Author: sky <sky@chromium.org> Date: Thu Jul 28 00:04:28 2016 Moves handling of toggling applist back to common code Implementation is no longer aura specific. BUG= 612331 TEST=none R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2183993005 Cr-Commit-Position: refs/heads/master@{#408284} [modify] https://crrev.com/6d4038f3350e3a2206801adbac1c31553157a38b/ash/accelerators/accelerator_controller_delegate_aura.cc [modify] https://crrev.com/6d4038f3350e3a2206801adbac1c31553157a38b/ash/common/accelerators/accelerator_controller.cc [modify] https://crrev.com/6d4038f3350e3a2206801adbac1c31553157a38b/ash/mus/accelerators/accelerator_controller_delegate_mus.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e commit aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e Author: sky <sky@chromium.org> Date: Wed Aug 03 00:14:55 2016 Get AcceleratorControllerTest working with mash A couple of tests have been commented or disabled because of current lacking functionality in mash. Bugs are filed for all the cases. BUG= 612331 , 632208 ,632209, 630683 , 632211 , 632180 , 632189 , 632192 , 632200 , 632201 TEST=AcceleratorControllerTest* in mash_unittests R=sadrul@chromium.org Review-Url: https://codereview.chromium.org/2203003003 Cr-Commit-Position: refs/heads/master@{#409393} [modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/accelerators/accelerator_controller_unittest.cc [modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/BUILD.gn [modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/accelerators/accelerator_controller_registrar.h [add] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/accelerators/accelerator_controller_registrar_test_api.cc [add] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/accelerators/accelerator_controller_registrar_test_api.h [modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/accelerators/accelerator_controller_unittest.cc [modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/bridge/wm_root_window_controller_mus.cc [modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/bridge/wm_shell_mus.h [add] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/bridge/wm_shell_mus_test_api.h [modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/bridge/wm_window_mus.cc [modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/property_util.cc [modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/property_util.h [modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/test/wm_test_helper.cc [modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/test/ash_md_test_base.h [modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/test/ash_test_helper.cc [modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ui/views/mus/native_widget_mus.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4edef864ea405f5ede2f2fde973a63855bc784f commit c4edef864ea405f5ede2f2fde973a63855bc784f Author: kylechar <kylechar@chromium.org> Date: Wed Jul 12 01:08:44 2017 Remove mustash accelerator special cases. Display management is part of the ash process again in mustash. Remove the special cases for most display management accelerators since they no longer work. Bug: 612331 , 657816 Change-Id: I43d4f495347a1b8e880f3e5c5125c9144e68ed15 Reviewed-on: https://chromium-review.googlesource.com/567137 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#485756} [modify] https://crrev.com/c4edef864ea405f5ede2f2fde973a63855bc784f/ash/accelerators/accelerator_commands.cc [modify] https://crrev.com/c4edef864ea405f5ede2f2fde973a63855bc784f/ash/accelerators/accelerator_commands.h [modify] https://crrev.com/c4edef864ea405f5ede2f2fde973a63855bc784f/ash/accelerators/accelerator_commands_aura.cc [modify] https://crrev.com/c4edef864ea405f5ede2f2fde973a63855bc784f/ash/accelerators/accelerator_commands_aura.h [modify] https://crrev.com/c4edef864ea405f5ede2f2fde973a63855bc784f/ash/accelerators/accelerator_controller.cc [modify] https://crrev.com/c4edef864ea405f5ede2f2fde973a63855bc784f/ash/accelerators/accelerator_controller_delegate_aura.cc [modify] https://crrev.com/c4edef864ea405f5ede2f2fde973a63855bc784f/ash/accelerators/debug_commands.cc [modify] https://crrev.com/c4edef864ea405f5ede2f2fde973a63855bc784f/ash/display/display_manager_unittest.cc [modify] https://crrev.com/c4edef864ea405f5ede2f2fde973a63855bc784f/ash/mus/accelerators/accelerator_controller_delegate_mus.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1bfa5903161c35849dd45040babc610aa6d8b7dc commit 1bfa5903161c35849dd45040babc610aa6d8b7dc Author: James Cook <jamescook@chromium.org> Date: Sat Dec 02 00:18:42 2017 cros: Eliminate ash::AcceleratorControllerDelegate A previous CL left AcceleratorControllerDelegateMash empty. Most of the commands in AcceleratorControllerDelegateClassic work fine under mash, so put all the commands back in AcceleratorController. Add early exits for the few that don't work under mash. These files were split up during the WmWindow conversion, when some ash subdirectories were not allowed to use aura. Bug: 612331 Test: ash_unittests, chrome browser_tests Change-Id: Ic4ce3783c1c50ef85091bd012c7b366b26761120 Reviewed-on: https://chromium-review.googlesource.com/803054 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#521140} [modify] https://crrev.com/1bfa5903161c35849dd45040babc610aa6d8b7dc/ash/BUILD.gn [modify] https://crrev.com/1bfa5903161c35849dd45040babc610aa6d8b7dc/ash/accelerators/accelerator_commands.cc [modify] https://crrev.com/1bfa5903161c35849dd45040babc610aa6d8b7dc/ash/accelerators/accelerator_commands.h [delete] https://crrev.com/611240397ce4a4e1a12afe219727c2d68da8ebf3/ash/accelerators/accelerator_commands_classic.cc [delete] https://crrev.com/611240397ce4a4e1a12afe219727c2d68da8ebf3/ash/accelerators/accelerator_commands_classic.h [modify] https://crrev.com/1bfa5903161c35849dd45040babc610aa6d8b7dc/ash/accelerators/accelerator_commands_unittest.cc [modify] https://crrev.com/1bfa5903161c35849dd45040babc610aa6d8b7dc/ash/accelerators/accelerator_controller.cc [modify] https://crrev.com/1bfa5903161c35849dd45040babc610aa6d8b7dc/ash/accelerators/accelerator_controller.h [delete] https://crrev.com/611240397ce4a4e1a12afe219727c2d68da8ebf3/ash/accelerators/accelerator_controller_delegate.h [delete] https://crrev.com/611240397ce4a4e1a12afe219727c2d68da8ebf3/ash/accelerators/accelerator_controller_delegate_classic.cc [delete] https://crrev.com/611240397ce4a4e1a12afe219727c2d68da8ebf3/ash/accelerators/accelerator_controller_delegate_classic.h [delete] https://crrev.com/611240397ce4a4e1a12afe219727c2d68da8ebf3/ash/accelerators/accelerator_controller_delegate_mash.cc [delete] https://crrev.com/611240397ce4a4e1a12afe219727c2d68da8ebf3/ash/accelerators/accelerator_controller_delegate_mash.h [modify] https://crrev.com/1bfa5903161c35849dd45040babc610aa6d8b7dc/ash/accelerators/accelerator_controller_unittest.cc [modify] https://crrev.com/1bfa5903161c35849dd45040babc610aa6d8b7dc/ash/shell_port_classic.cc [modify] https://crrev.com/1bfa5903161c35849dd45040babc610aa6d8b7dc/ash/shell_port_classic.h [modify] https://crrev.com/1bfa5903161c35849dd45040babc610aa6d8b7dc/ash/shell_port_mash.cc [modify] https://crrev.com/1bfa5903161c35849dd45040babc610aa6d8b7dc/ash/shell_port_mash.h [modify] https://crrev.com/1bfa5903161c35849dd45040babc610aa6d8b7dc/ash/shell_port_mus.cc [modify] https://crrev.com/1bfa5903161c35849dd45040babc610aa6d8b7dc/ash/shell_port_mus.h [modify] https://crrev.com/1bfa5903161c35849dd45040babc610aa6d8b7dc/chrome/browser/ui/ash/accelerator_commands_browsertest.cc
I'm going to close this out as in theory this should work now. I will leave open a bug for end-to-end accelerators, which is still definitely valid.
Comment 1 by sky@chromium.org
, May 20 2016