Issue 612320 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	rdevlin....@chromium.org
Closed:	May 2016
Cc:	lazyboy@chromium.org █ asargent@chromium.org
Components:	Platform>Extensions
EstimatedDays:	----
NextAction:	----
OS:	Linux , Windows , Chrome , Mac
Pri:	2
Type:	Bug

Handle chrome url overrides having the file removed

Project Member Reported by rdevlin....@chromium.org, May 16 2016

Issue description

If an extension with an active url override has the replacement page file removed, we just show an ugly broken page to the user (see screenshot).  URL override pages should be part of the validation process for extensions, similar to how we verify other files exist.

	Selection_333.png 27.1 KB View Download

Project Member

Comment 1 by bugdroid1@chromium.org, May 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/005e330d08fcf87393e8c996b06161b18823c117

commit 005e330d08fcf87393e8c996b06161b18823c117
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Wed May 18 20:26:37 2016

[Extensions] Validate file existence for chrome url overrides

BUG= 612320 

Review-Url: https://codereview.chromium.org/1977303004
Cr-Commit-Position: refs/heads/master@{#394531}

[modify] https://crrev.com/005e330d08fcf87393e8c996b06161b18823c117/chrome/chrome_tests_unit.gypi
[modify] https://crrev.com/005e330d08fcf87393e8c996b06161b18823c117/chrome/common/extensions/chrome_manifest_url_handlers.cc
[modify] https://crrev.com/005e330d08fcf87393e8c996b06161b18823c117/chrome/common/extensions/chrome_manifest_url_handlers.h
[add] https://crrev.com/005e330d08fcf87393e8c996b06161b18823c117/chrome/common/extensions/chrome_manifest_url_handlers_unittest.cc
[modify] https://crrev.com/005e330d08fcf87393e8c996b06161b18823c117/extensions/common/manifest_constants.cc
[modify] https://crrev.com/005e330d08fcf87393e8c996b06161b18823c117/extensions/common/manifest_constants.h

Comment 2 by rdevlin....@chromium.org, May 25 2016

Status: Fixed (was: Assigned)

►

Issue 612320 link

Issue metadata

Handle chrome url overrides having the file removed

Issue description

Comment 1 by bugdroid1@chromium.org, May 18 2016

Comment 1 Deleted

Comment 2 by rdevlin....@chromium.org, May 25 2016

Comment 2 Deleted

Sign in to add a comment