Some tests don't cleanup a temporary file that they create before completing. |
||||
Issue descriptionDownloadProtectionServiceTest.CheckClientDownloadZip and DownloadProtectionServiceTest.CheckClientDownloadReportCorruptZip don't delete the temporary file "a.tmp" that they create. This file gets created in the current working directory.
,
May 16 2016
The tests that exhibit this are, all in DownloadProtectionServiceTest: 1. CheckClientDownloadZip 2. CheckClientDownloadReportCorruptZipNormal 3. CheckClientDownloadReportCorruptZipExtended 4. CheckClientDownloadReportCorruptZipIncognito
,
May 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e4f9ac949175541f148eee4b11488c30b7177623 commit e4f9ac949175541f148eee4b11488c30b7177623 Author: vakh <vakh@chromium.org> Date: Tue May 17 06:32:01 2016 Delete tmp_path_ at the end of the tests BUG= 612296 Review-Url: https://codereview.chromium.org/1984763003 Cr-Commit-Position: refs/heads/master@{#394069} [modify] https://crrev.com/e4f9ac949175541f148eee4b11488c30b7177623/chrome/browser/safe_browsing/download_protection_service_unittest.cc
,
May 17 2016
,
May 17 2016
[re-opening] asanka@ pointed out that it's better to use a base::ScopedTempDir for the following reasons: * the resulting path is entirely under the control of the test, and is known to be writeable by the test binary, * the resulting path is unique (i.e. the tests won't fail if there are concurrent tests running) * even if the test fails or crashes the files will still be cleaned up by the platform at some point.
,
May 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a1d3a937bb232bef874e846f4f5378f23554e27e commit a1d3a937bb232bef874e846f4f5378f23554e27e Author: vakh <vakh@chromium.org> Date: Sun May 22 23:41:12 2016 Use a temp directory for the temporary files that the tests create. BUG= 612296 Review-Url: https://codereview.chromium.org/1983153003 Cr-Commit-Position: refs/heads/master@{#395277} [modify] https://crrev.com/a1d3a937bb232bef874e846f4f5378f23554e27e/chrome/browser/safe_browsing/download_protection_service_unittest.cc
,
May 23 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by vakh@chromium.org
, May 16 2016Status: Started (was: Available)