webgl test expectation "no_angle" mode doesn't work |
|||
Issue description
If you look at any mac bots stdout on webgl2_conformance, you will see a bunch of "expected to fail, but passed" entries, all caused by "angle" and "no_angle" semantics.
For example,
self.Fail('conformance2/textures/misc/tex-unpack-params.html',
['d3d9', 'd3d11', 'opengl'], bug= 483282 )
self.Fail('conformance2/textures/misc/tex-unpack-params.html',
['mac', 'intel', 'no_angle'], bug= 483282 )
do not work as expected. Instead, this test is expected to fail (incorrectly) on all Mac.
,
May 16 2016
,
May 16 2016
Regression is from https://codereview.chromium.org/1974893002 .
,
May 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ef10b51b20d9d693d0484aad6f03951bac61e5c commit 9ef10b51b20d9d693d0484aad6f03951bac61e5c Author: cwallez <cwallez@google.com> Date: Tue May 17 22:40:33 2016 GPU test expectations: more precisely detect ANGLE Previously we only looked at the "OpenGL", "Direct3D9" and "Direct3D11" string in the GL_RENDERER to decide that we were using ANGLE. This would incorrectly match OSX's "Intel Iris Pro OpenGL Engine" as ANGLE with the OpenGL backend. We now check that "ANGLE" appears in GL_RENDERER to match ANGLE. Also adds a regression test and a unittest for the no_angle keyword. BUG= 612293 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/1980243004 Cr-Commit-Position: refs/heads/master@{#394249} [modify] https://crrev.com/9ef10b51b20d9d693d0484aad6f03951bac61e5c/content/test/gpu/gpu_tests/gpu_test_expectations.py [modify] https://crrev.com/9ef10b51b20d9d693d0484aad6f03951bac61e5c/content/test/gpu/gpu_tests/gpu_test_expectations_unittest.py
,
May 18 2016
Didn't see the string "expected to fail, but passed" in recent mac webgl2_conformance logs. |
|||
►
Sign in to add a comment |
|||
Comment 1 by zmo@chromium.org
, May 16 2016