New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 612287 link

Starred by 7 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jan 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task


Sign in to add a comment

Content Modularization Project: Cache Storage

Project Member Reported by jam@chromium.org, May 16 2016

Issue description

Tracking bug for the cache storage part of the Content Modularization Project.

-convert existing IPCs to mojo
-consume quota through its new mojo interface ( bug 611909 )
-given that service worker moves to components/service_worker, move to cache_storage subdirectory in there
  -this entails removing existing dependencies on content, to support SWs eventually running in the profile process

 

Comment 1 by jam@chromium.org, May 17 2016

btw above is for the content/browser code. The code in content/renderer should move to blink per onion soup project.
Project Member

Comment 2 by sheriffbot@chromium.org, May 17 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been available for more than 365 days, and should be re-evaluated. Please re-triage this issue.
The Hotlist-Recharge-Cold label is applied for tracking purposes, and should not be removed after re-triaging the issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by dmu...@chromium.org, Jun 26 2017

Blocking: 729795

Comment 4 by jsb...@chromium.org, Jul 11 2017

Components: Blink>Storage>CacheStorage

Comment 5 by jsb...@chromium.org, Jul 11 2017

Owner: cmumford@chromium.org
Status: Started (was: Untriaged)

Comment 6 by laforge@google.com, Nov 7 2017

Components: Internals>Services
Labels: Type-Task
Appending component Internals>Services to S13N projects and changing the Type (for tracking sake) to Type=Task.
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14fa8713627e3786df2c75cf13f4edb524e50f59

commit 14fa8713627e3786df2c75cf13f4edb524e50f59
Author: Chris Mumford <cmumford@chromium.org>
Date: Tue Nov 07 23:46:24 2017

Converted WebServiceWorkerResponseError to Mojo.

Replaced WebServiceWorkerResponseError with blink.mojom.ServiceWorkerResponseError.

Bug:  612287 
Change-Id: I78d008a6f64489650b9762e82576d443af53396d
Reviewed-on: https://chromium-review.googlesource.com/744641
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514654}
[modify] https://crrev.com/14fa8713627e3786df2c75cf13f4edb524e50f59/content/browser/DEPS
[modify] https://crrev.com/14fa8713627e3786df2c75cf13f4edb524e50f59/content/browser/background_fetch/background_fetch_service_unittest.cc
[modify] https://crrev.com/14fa8713627e3786df2c75cf13f4edb524e50f59/content/browser/cache_storage/cache_storage_cache.cc
[modify] https://crrev.com/14fa8713627e3786df2c75cf13f4edb524e50f59/content/browser/cache_storage/cache_storage_cache_unittest.cc
[modify] https://crrev.com/14fa8713627e3786df2c75cf13f4edb524e50f59/content/browser/cache_storage/cache_storage_manager_unittest.cc
[modify] https://crrev.com/14fa8713627e3786df2c75cf13f4edb524e50f59/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/14fa8713627e3786df2c75cf13f4edb524e50f59/content/browser/service_worker/service_worker_metrics.cc
[modify] https://crrev.com/14fa8713627e3786df2c75cf13f4edb524e50f59/content/browser/service_worker/service_worker_metrics.h
[modify] https://crrev.com/14fa8713627e3786df2c75cf13f4edb524e50f59/content/browser/service_worker/service_worker_url_loader_job_unittest.cc
[modify] https://crrev.com/14fa8713627e3786df2c75cf13f4edb524e50f59/content/browser/service_worker/service_worker_url_request_job.cc
[modify] https://crrev.com/14fa8713627e3786df2c75cf13f4edb524e50f59/content/browser/service_worker/service_worker_url_request_job.h
[modify] https://crrev.com/14fa8713627e3786df2c75cf13f4edb524e50f59/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/14fa8713627e3786df2c75cf13f4edb524e50f59/content/common/DEPS
[modify] https://crrev.com/14fa8713627e3786df2c75cf13f4edb524e50f59/content/common/service_worker/service_worker_messages.h
[modify] https://crrev.com/14fa8713627e3786df2c75cf13f4edb524e50f59/content/common/service_worker/service_worker_types.cc
[modify] https://crrev.com/14fa8713627e3786df2c75cf13f4edb524e50f59/content/common/service_worker/service_worker_types.h
[modify] https://crrev.com/14fa8713627e3786df2c75cf13f4edb524e50f59/content/renderer/service_worker/service_worker_subresource_loader_unittest.cc
[modify] https://crrev.com/14fa8713627e3786df2c75cf13f4edb524e50f59/third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp
[modify] https://crrev.com/14fa8713627e3786df2c75cf13f4edb524e50f59/third_party/WebKit/Source/modules/payments/AbortPaymentRespondWithObserver.cpp
[modify] https://crrev.com/14fa8713627e3786df2c75cf13f4edb524e50f59/third_party/WebKit/Source/modules/payments/AbortPaymentRespondWithObserver.h
[modify] https://crrev.com/14fa8713627e3786df2c75cf13f4edb524e50f59/third_party/WebKit/Source/modules/payments/CanMakePaymentRespondWithObserver.cpp
[modify] https://crrev.com/14fa8713627e3786df2c75cf13f4edb524e50f59/third_party/WebKit/Source/modules/payments/CanMakePaymentRespondWithObserver.h
[modify] https://crrev.com/14fa8713627e3786df2c75cf13f4edb524e50f59/third_party/WebKit/Source/modules/payments/PaymentHandlerUtils.cpp
[modify] https://crrev.com/14fa8713627e3786df2c75cf13f4edb524e50f59/third_party/WebKit/Source/modules/payments/PaymentHandlerUtils.h
[modify] https://crrev.com/14fa8713627e3786df2c75cf13f4edb524e50f59/third_party/WebKit/Source/modules/payments/PaymentRequestRespondWithObserver.cpp
[modify] https://crrev.com/14fa8713627e3786df2c75cf13f4edb524e50f59/third_party/WebKit/Source/modules/payments/PaymentRequestRespondWithObserver.h
[modify] https://crrev.com/14fa8713627e3786df2c75cf13f4edb524e50f59/third_party/WebKit/Source/modules/serviceworkers/FetchRespondWithObserver.cpp
[modify] https://crrev.com/14fa8713627e3786df2c75cf13f4edb524e50f59/third_party/WebKit/Source/modules/serviceworkers/FetchRespondWithObserver.h
[modify] https://crrev.com/14fa8713627e3786df2c75cf13f4edb524e50f59/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchRespondWithObserver.cpp
[modify] https://crrev.com/14fa8713627e3786df2c75cf13f4edb524e50f59/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp
[modify] https://crrev.com/14fa8713627e3786df2c75cf13f4edb524e50f59/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h
[modify] https://crrev.com/14fa8713627e3786df2c75cf13f4edb524e50f59/third_party/WebKit/Source/platform/exported/WebServiceWorkerResponse.cpp
[modify] https://crrev.com/14fa8713627e3786df2c75cf13f4edb524e50f59/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/14fa8713627e3786df2c75cf13f4edb524e50f59/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerResponse.h
[delete] https://crrev.com/2394cf4be5e2a606dd0e039890501ee13abde787/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerResponseError.h
[modify] https://crrev.com/14fa8713627e3786df2c75cf13f4edb524e50f59/third_party/WebKit/public/platform/modules/serviceworker/service_worker_error_type.mojom

Components: Internals>Services>Storage
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2070afee15bd030f90a471d293025f21376056c1

commit 2070afee15bd030f90a471d293025f21376056c1
Author: Chris Mumford <cmumford@chromium.org>
Date: Thu Nov 09 22:04:13 2017

CacheStorage: Created blink.mojom.CacheStorageError.

Deleted blink::WebServiceWorkerCacheError and content::CacheStorageError and
switched to using blink.mojom.CacheStorageError.

TBR=kenrb@chromium.org,jln@chromium.org,jkarlin@chromium.org

TBRing reviewers:
kenrb@
  content/browser/DEPS
  content/browser/render_host/*
jln@
  content/common/DEPS
jkarlin@
  tools/metrics/histograms/histograms.xml

Bug:  612287 
Change-Id: I4e9255beedc50313e43f1f4acfdcbf46285733c8
Reviewed-on: https://chromium-review.googlesource.com/745386
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515307}
[modify] https://crrev.com/2070afee15bd030f90a471d293025f21376056c1/content/browser/DEPS
[modify] https://crrev.com/2070afee15bd030f90a471d293025f21376056c1/content/browser/cache_storage/cache_storage.cc
[modify] https://crrev.com/2070afee15bd030f90a471d293025f21376056c1/content/browser/cache_storage/cache_storage.h
[modify] https://crrev.com/2070afee15bd030f90a471d293025f21376056c1/content/browser/cache_storage/cache_storage_cache.cc
[modify] https://crrev.com/2070afee15bd030f90a471d293025f21376056c1/content/browser/cache_storage/cache_storage_cache.h
[modify] https://crrev.com/2070afee15bd030f90a471d293025f21376056c1/content/browser/cache_storage/cache_storage_cache_unittest.cc
[modify] https://crrev.com/2070afee15bd030f90a471d293025f21376056c1/content/browser/cache_storage/cache_storage_dispatcher_host.cc
[modify] https://crrev.com/2070afee15bd030f90a471d293025f21376056c1/content/browser/cache_storage/cache_storage_dispatcher_host.h
[modify] https://crrev.com/2070afee15bd030f90a471d293025f21376056c1/content/browser/cache_storage/cache_storage_manager_unittest.cc
[modify] https://crrev.com/2070afee15bd030f90a471d293025f21376056c1/content/browser/renderer_host/render_message_filter.cc
[modify] https://crrev.com/2070afee15bd030f90a471d293025f21376056c1/content/browser/renderer_host/render_message_filter.h
[modify] https://crrev.com/2070afee15bd030f90a471d293025f21376056c1/content/browser/service_worker/service_worker_browsertest.cc
[modify] https://crrev.com/2070afee15bd030f90a471d293025f21376056c1/content/common/DEPS
[modify] https://crrev.com/2070afee15bd030f90a471d293025f21376056c1/content/common/cache_storage/cache_storage_messages.h
[modify] https://crrev.com/2070afee15bd030f90a471d293025f21376056c1/content/common/cache_storage/cache_storage_types.h
[modify] https://crrev.com/2070afee15bd030f90a471d293025f21376056c1/content/common/service_worker/service_worker_types.h
[modify] https://crrev.com/2070afee15bd030f90a471d293025f21376056c1/content/renderer/cache_storage/cache_storage_dispatcher.cc
[modify] https://crrev.com/2070afee15bd030f90a471d293025f21376056c1/content/renderer/cache_storage/cache_storage_dispatcher.h
[modify] https://crrev.com/2070afee15bd030f90a471d293025f21376056c1/content/renderer/cache_storage/webserviceworkercachestorage_impl.h
[modify] https://crrev.com/2070afee15bd030f90a471d293025f21376056c1/third_party/WebKit/Source/modules/cachestorage/Cache.cpp
[modify] https://crrev.com/2070afee15bd030f90a471d293025f21376056c1/third_party/WebKit/Source/modules/cachestorage/Cache.h
[modify] https://crrev.com/2070afee15bd030f90a471d293025f21376056c1/third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp
[modify] https://crrev.com/2070afee15bd030f90a471d293025f21376056c1/third_party/WebKit/Source/modules/cachestorage/CacheStorageError.cpp
[modify] https://crrev.com/2070afee15bd030f90a471d293025f21376056c1/third_party/WebKit/Source/modules/cachestorage/CacheStorageError.h
[modify] https://crrev.com/2070afee15bd030f90a471d293025f21376056c1/third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp
[modify] https://crrev.com/2070afee15bd030f90a471d293025f21376056c1/third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp
[modify] https://crrev.com/2070afee15bd030f90a471d293025f21376056c1/third_party/WebKit/public/BUILD.gn
[add] https://crrev.com/2070afee15bd030f90a471d293025f21376056c1/third_party/WebKit/public/platform/modules/cache_storage/OWNERS
[add] https://crrev.com/2070afee15bd030f90a471d293025f21376056c1/third_party/WebKit/public/platform/modules/cache_storage/cache_storage.mojom
[modify] https://crrev.com/2070afee15bd030f90a471d293025f21376056c1/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerCache.h
[delete] https://crrev.com/035cd9a4cde9a792be5b981d016d7728970aae1b/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerCacheError.h
[modify] https://crrev.com/2070afee15bd030f90a471d293025f21376056c1/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerCacheStorage.h
[modify] https://crrev.com/2070afee15bd030f90a471d293025f21376056c1/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/2070afee15bd030f90a471d293025f21376056c1/tools/metrics/histograms/histograms.xml

Components: Blink>Internals>Modularization
Owner: lucmult@chromium.org
Hi,

slangley@ assigned me to work on mojofying and onion soup-ing cache_storage.
Cc: cmumford@chromium.org
Awesome! cmumford@ may have some additional unlanded CLs and/or design docs that could help here - might make sense to ping him.
Hi all, 

I have reached to cmumford@ and he shared the pending cl [1].

I'm reading through current Cache Storage implementation to understand its work as well as some aspects of Chromium since I'm new to its code base and to C++.

I'll put the details in a design doc and share here, within a week or so (depending on the speed of my learnings here).

[1] - https://chromium-review.googlesource.com/c/chromium/src/+/556389

Comment 15 by costan@google.com, Jan 18 2018

Cc: pwnall@chromium.org
I have started the fist stage (convert IPC to mojo) on crrev.com/c/875510, but it isn't ready for review yet.

I'll send for review once all methods are converted to Mojo.
crrev.com/c/875510 has the code working for mojo conversion, I split 2 smaller CLs from it because it was too big:

* crrev.com/c/906046 - mojom and typemap for Service Worker Fetch Response.
* crrev.com/c/906164 - mojom and typemap for Cache Storage API.


Project Member

Comment 18 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51bde397a31f60dcbf7857625bf47556bd0a3548

commit 51bde397a31f60dcbf7857625bf47556bd0a3548
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Wed Feb 14 02:12:32 2018

Mojom and typemap for Service Worker Fetch Response

Add mojo struct and typemap to be used on Mojofication of Cache Storage
API.

Split from http://crrev.com/c/875510 .

Bug:  612287 
Change-Id: I1d9f0fba8a91ccd3d67a33ab90c574b66c2e7bfe
Reviewed-on: https://chromium-review.googlesource.com/906046
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536609}
[modify] https://crrev.com/51bde397a31f60dcbf7857625bf47556bd0a3548/content/common/DEPS
[modify] https://crrev.com/51bde397a31f60dcbf7857625bf47556bd0a3548/content/common/background_fetch/background_fetch_struct_traits.cc
[modify] https://crrev.com/51bde397a31f60dcbf7857625bf47556bd0a3548/content/common/service_worker/OWNERS
[modify] https://crrev.com/51bde397a31f60dcbf7857625bf47556bd0a3548/content/common/service_worker/service_worker_fetch_request.typemap
[rename] https://crrev.com/51bde397a31f60dcbf7857625bf47556bd0a3548/content/common/service_worker/service_worker_fetch_request_mojom_traits.cc
[rename] https://crrev.com/51bde397a31f60dcbf7857625bf47556bd0a3548/content/common/service_worker/service_worker_fetch_request_mojom_traits.h
[add] https://crrev.com/51bde397a31f60dcbf7857625bf47556bd0a3548/content/common/service_worker/service_worker_fetch_response.typemap
[add] https://crrev.com/51bde397a31f60dcbf7857625bf47556bd0a3548/content/common/service_worker/service_worker_fetch_response_mojom_traits.cc
[add] https://crrev.com/51bde397a31f60dcbf7857625bf47556bd0a3548/content/common/service_worker/service_worker_fetch_response_mojom_traits.h
[modify] https://crrev.com/51bde397a31f60dcbf7857625bf47556bd0a3548/content/common/typemaps.gni
[modify] https://crrev.com/51bde397a31f60dcbf7857625bf47556bd0a3548/mojo/public/cpp/bindings/map_traits_stl.h
[modify] https://crrev.com/51bde397a31f60dcbf7857625bf47556bd0a3548/third_party/WebKit/Source/platform/mojo/DEPS
[modify] https://crrev.com/51bde397a31f60dcbf7857625bf47556bd0a3548/third_party/WebKit/public/BUILD.gn
[add] https://crrev.com/51bde397a31f60dcbf7857625bf47556bd0a3548/third_party/WebKit/public/platform/modules/fetch/fetch_api_response.mojom

Project Member

Comment 19 by bugdroid1@chromium.org, Feb 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28110cf5484821b57281dec56d517fc60b4d3830

commit 28110cf5484821b57281dec56d517fc60b4d3830
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Thu Feb 15 02:35:06 2018

Add mojom and typemap for Cache Storage API

This is part of converting the follwoing IPC messages to Mojo:
https://cs.chromium.org/chromium/src/content/common/cache_storage/cache_storage_messages.h

This is a continuation of http://crrev.com/c/906046 .

This has been split from http://crrev.com/c/875510 .

In service_worker_types.h removed an include to avoid circular
includes also added include <vector> to fix lint error.

Bug:  612287 
Change-Id: Ifdd96596c709abc9f5e91b900bf21ee72f4a2b27
Reviewed-on: https://chromium-review.googlesource.com/906164
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536931}
[modify] https://crrev.com/28110cf5484821b57281dec56d517fc60b4d3830/content/common/cache_storage/OWNERS
[add] https://crrev.com/28110cf5484821b57281dec56d517fc60b4d3830/content/common/cache_storage/cache_storage.typemap
[add] https://crrev.com/28110cf5484821b57281dec56d517fc60b4d3830/content/common/cache_storage/cache_storage_mojom_traits.cc
[add] https://crrev.com/28110cf5484821b57281dec56d517fc60b4d3830/content/common/cache_storage/cache_storage_mojom_traits.h
[modify] https://crrev.com/28110cf5484821b57281dec56d517fc60b4d3830/content/common/service_worker/service_worker_types.h
[modify] https://crrev.com/28110cf5484821b57281dec56d517fc60b4d3830/content/common/typemaps.gni
[modify] https://crrev.com/28110cf5484821b57281dec56d517fc60b4d3830/third_party/WebKit/public/platform/modules/cache_storage/cache_storage.mojom

Project Member

Comment 20 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/626c99e870b04e474408a5b35e97f260b9d787ba

commit 626c99e870b04e474408a5b35e97f260b9d787ba
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Thu Mar 22 01:06:56 2018

Convert Cache Storage IPC to Mojo.

Mojo communication remains between CacheStorageDispatcherHost on
the browser side, on renderer side merged CacheStorageDispatcher
on WebServiceWorkerCacheStorageImpl, it now uses Mojo callbacks
instead of responding via another IPC call.

Changed the origin from an argument to be part of the mojo binding
context, using origin known by browser at binding time, instead of
trusting renderer to provide its origin.

Mojo interface split in 2 interfaces, CacheStorage for global
operations and CacheStorageCache for operations specific for each
individual cache. Add CacheImpl class to implement mojo interface
CacheStorageCache.

Add CacheRef on renderer side to maintain the mojo connection and
client callbacks to guarantee its execution independent of client
keeping a reference to WebCache.

Replace the timing of method calls from TimeMap member with function
arguments passed via base::Bind.

Add some includes to fix lint errors from "git cl lint".

Remove MessageFilter from CacheStorageDispatcherHost and added the
reference count directly to it, instead of inherited from MessageFilter.

Add new mojom CacheStorage to content_browser_manifest, allowing it to
be used on renderer on the 3 types of web workers and on navigation
frame.

Bug:  612287 
Change-Id: I9744f27c72be232e153595977c07f3a2df7c5e17
Reviewed-on: https://chromium-review.googlesource.com/875510
Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Chris Mumford <cmumford@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544932}
[modify] https://crrev.com/626c99e870b04e474408a5b35e97f260b9d787ba/content/browser/cache_storage/cache_storage.cc
[modify] https://crrev.com/626c99e870b04e474408a5b35e97f260b9d787ba/content/browser/cache_storage/cache_storage.h
[modify] https://crrev.com/626c99e870b04e474408a5b35e97f260b9d787ba/content/browser/cache_storage/cache_storage_cache.cc
[modify] https://crrev.com/626c99e870b04e474408a5b35e97f260b9d787ba/content/browser/cache_storage/cache_storage_cache.h
[modify] https://crrev.com/626c99e870b04e474408a5b35e97f260b9d787ba/content/browser/cache_storage/cache_storage_cache_unittest.cc
[modify] https://crrev.com/626c99e870b04e474408a5b35e97f260b9d787ba/content/browser/cache_storage/cache_storage_dispatcher_host.cc
[modify] https://crrev.com/626c99e870b04e474408a5b35e97f260b9d787ba/content/browser/cache_storage/cache_storage_dispatcher_host.h
[modify] https://crrev.com/626c99e870b04e474408a5b35e97f260b9d787ba/content/browser/cache_storage/cache_storage_manager.cc
[modify] https://crrev.com/626c99e870b04e474408a5b35e97f260b9d787ba/content/browser/cache_storage/cache_storage_manager.h
[modify] https://crrev.com/626c99e870b04e474408a5b35e97f260b9d787ba/content/browser/cache_storage/cache_storage_manager_unittest.cc
[modify] https://crrev.com/626c99e870b04e474408a5b35e97f260b9d787ba/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/626c99e870b04e474408a5b35e97f260b9d787ba/content/browser/renderer_host/render_process_host_impl.h
[modify] https://crrev.com/626c99e870b04e474408a5b35e97f260b9d787ba/content/browser/renderer_interface_binders.cc
[modify] https://crrev.com/626c99e870b04e474408a5b35e97f260b9d787ba/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/626c99e870b04e474408a5b35e97f260b9d787ba/content/renderer/BUILD.gn
[delete] https://crrev.com/05e32b12a408b22f5fd5ecd036fbc541b8ffb8b2/content/renderer/cache_storage/cache_storage_dispatcher.cc
[delete] https://crrev.com/05e32b12a408b22f5fd5ecd036fbc541b8ffb8b2/content/renderer/cache_storage/cache_storage_dispatcher.h
[delete] https://crrev.com/05e32b12a408b22f5fd5ecd036fbc541b8ffb8b2/content/renderer/cache_storage/cache_storage_message_filter.cc
[delete] https://crrev.com/05e32b12a408b22f5fd5ecd036fbc541b8ffb8b2/content/renderer/cache_storage/cache_storage_message_filter.h
[modify] https://crrev.com/626c99e870b04e474408a5b35e97f260b9d787ba/content/renderer/cache_storage/webserviceworkercachestorage_impl.cc
[modify] https://crrev.com/626c99e870b04e474408a5b35e97f260b9d787ba/content/renderer/cache_storage/webserviceworkercachestorage_impl.h
[modify] https://crrev.com/626c99e870b04e474408a5b35e97f260b9d787ba/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/626c99e870b04e474408a5b35e97f260b9d787ba/content/renderer/render_thread_impl.h
[modify] https://crrev.com/626c99e870b04e474408a5b35e97f260b9d787ba/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/626c99e870b04e474408a5b35e97f260b9d787ba/content/renderer/renderer_blink_platform_impl.h
[add] https://crrev.com/626c99e870b04e474408a5b35e97f260b9d787ba/third_party/WebKit/LayoutTests/http/tests/cachestorage/detached-context.html
[add] https://crrev.com/626c99e870b04e474408a5b35e97f260b9d787ba/third_party/WebKit/LayoutTests/http/tests/cachestorage/resources/self-detach-iframe.html
[modify] https://crrev.com/626c99e870b04e474408a5b35e97f260b9d787ba/third_party/WebKit/Source/modules/cachestorage/GlobalCacheStorage.cpp
[modify] https://crrev.com/626c99e870b04e474408a5b35e97f260b9d787ba/third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp
[modify] https://crrev.com/626c99e870b04e474408a5b35e97f260b9d787ba/third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.h
[modify] https://crrev.com/626c99e870b04e474408a5b35e97f260b9d787ba/third_party/WebKit/Source/platform/exported/Platform.cpp
[modify] https://crrev.com/626c99e870b04e474408a5b35e97f260b9d787ba/third_party/WebKit/public/platform/Platform.h
[modify] https://crrev.com/626c99e870b04e474408a5b35e97f260b9d787ba/third_party/WebKit/public/platform/modules/cache_storage/cache_storage.mojom
[modify] https://crrev.com/626c99e870b04e474408a5b35e97f260b9d787ba/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerCacheStorage.h

Owner: ----
Status: Available (was: Started)
Making this bug available.

Current status:
The conversion to Mojo is done. It's still pending the Onion Soup part.

There is only 2 files left on //content/renderer/ that needs to move to Blink and merge with its blink/web types.
Forgot to explain why I'm making it available. :-)

Stuart, my manager, changed my focus to chromeOS Files app and I'm reaching the end of my rotation at the end of April.
Thanks for all your hard work on this, lucmult@!

Comment 25 by lfg@chromium.org, Apr 24 2018

Labels: -Hotlist-Recharge-Cold
Owner: lfg@chromium.org
Status: Assigned (was: Available)
I'll take this.

Blockedon: 835611 831054

Comment 27 by lfg@chromium.org, Apr 27 2018

Status: Started (was: Assigned)
Project Member

Comment 28 by bugdroid1@chromium.org, May 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7085d55c66879c74bf08d9518292c6a4a3b6b2a4

commit 7085d55c66879c74bf08d9518292c6a4a3b6b2a4
Author: Lucas Furukawa Gadani <lfg@chromium.org>
Date: Mon May 07 18:21:49 2018

Pass the ServiceWorkerReponse's side data via mojo IPC.

When the CacheStorage IPC was mojo-ified, the side data wasn't added to
the mojom file, which causes the IPC to drop the side data when sending
it over to the browser process.

Bug:  612287 
Change-Id: I27b97db874f56379fb13e2fac56f534dc06df2ae
Reviewed-on: https://chromium-review.googlesource.com/1035907
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556503}
[modify] https://crrev.com/7085d55c66879c74bf08d9518292c6a4a3b6b2a4/content/common/service_worker/service_worker_fetch_response_mojom_traits.cc
[modify] https://crrev.com/7085d55c66879c74bf08d9518292c6a4a3b6b2a4/content/common/service_worker/service_worker_fetch_response_mojom_traits.h
[modify] https://crrev.com/7085d55c66879c74bf08d9518292c6a4a3b6b2a4/content/common/service_worker/service_worker_types_unittest.cc
[modify] https://crrev.com/7085d55c66879c74bf08d9518292c6a4a3b6b2a4/third_party/blink/public/platform/modules/fetch/fetch_api_response.mojom

Project Member

Comment 29 by bugdroid1@chromium.org, May 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ca5ccfe2fcd8de7061707a7db3a9005c1d91644

commit 3ca5ccfe2fcd8de7061707a7db3a9005c1d91644
Author: Lucas Furukawa Gadani <lfg@chromium.org>
Date: Tue May 15 13:54:57 2018

Migrate cache_storage from content/renderer to blink.

As part of onion soup, this CL removes content/renderer/cache_storage
layer and move its functionality into blink by using the mojo interface
directly.

This change also switches FetchAPIResponse and FetchAPIRequest to use
the SerializedBlob mojom types, instead of passing the combination of
{uuid,size,Blob}. This allows us to preserves the blob type when
creating the mojo types.

Bug:  612287 

Change-Id: I4a4abaf5607467dd39dbaff83bf43cb0f9c07d4d
Reviewed-on: https://chromium-review.googlesource.com/1034005
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558690}
[modify] https://crrev.com/3ca5ccfe2fcd8de7061707a7db3a9005c1d91644/content/common/cache_storage/cache_storage_mojom_traits.cc
[modify] https://crrev.com/3ca5ccfe2fcd8de7061707a7db3a9005c1d91644/content/common/service_worker/service_worker_fetch_request_mojom_traits.cc
[modify] https://crrev.com/3ca5ccfe2fcd8de7061707a7db3a9005c1d91644/content/common/service_worker/service_worker_fetch_request_mojom_traits.h
[modify] https://crrev.com/3ca5ccfe2fcd8de7061707a7db3a9005c1d91644/content/common/service_worker/service_worker_fetch_response_mojom_traits.cc
[modify] https://crrev.com/3ca5ccfe2fcd8de7061707a7db3a9005c1d91644/content/common/service_worker/service_worker_fetch_response_mojom_traits.h
[modify] https://crrev.com/3ca5ccfe2fcd8de7061707a7db3a9005c1d91644/content/common/service_worker/service_worker_types_unittest.cc
[modify] https://crrev.com/3ca5ccfe2fcd8de7061707a7db3a9005c1d91644/content/renderer/BUILD.gn
[delete] https://crrev.com/20deeaabc64e8389a17072af368031bdf4b90556/content/renderer/cache_storage/OWNERS
[delete] https://crrev.com/20deeaabc64e8389a17072af368031bdf4b90556/content/renderer/cache_storage/webserviceworkercachestorage_impl.cc
[delete] https://crrev.com/20deeaabc64e8389a17072af368031bdf4b90556/content/renderer/cache_storage/webserviceworkercachestorage_impl.h
[modify] https://crrev.com/3ca5ccfe2fcd8de7061707a7db3a9005c1d91644/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/3ca5ccfe2fcd8de7061707a7db3a9005c1d91644/content/renderer/renderer_blink_platform_impl.h
[modify] https://crrev.com/3ca5ccfe2fcd8de7061707a7db3a9005c1d91644/third_party/blink/public/BUILD.gn
[modify] https://crrev.com/3ca5ccfe2fcd8de7061707a7db3a9005c1d91644/third_party/blink/public/platform/modules/cache_storage/cache_storage.mojom
[modify] https://crrev.com/3ca5ccfe2fcd8de7061707a7db3a9005c1d91644/third_party/blink/public/platform/modules/fetch/fetch_api_request.mojom
[modify] https://crrev.com/3ca5ccfe2fcd8de7061707a7db3a9005c1d91644/third_party/blink/public/platform/modules/fetch/fetch_api_response.mojom
[delete] https://crrev.com/20deeaabc64e8389a17072af368031bdf4b90556/third_party/blink/public/platform/modules/serviceworker/web_service_worker_cache.h
[delete] https://crrev.com/20deeaabc64e8389a17072af368031bdf4b90556/third_party/blink/public/platform/modules/serviceworker/web_service_worker_cache_storage.h
[modify] https://crrev.com/3ca5ccfe2fcd8de7061707a7db3a9005c1d91644/third_party/blink/public/platform/modules/serviceworker/web_service_worker_request.h
[modify] https://crrev.com/3ca5ccfe2fcd8de7061707a7db3a9005c1d91644/third_party/blink/public/platform/platform.h
[modify] https://crrev.com/3ca5ccfe2fcd8de7061707a7db3a9005c1d91644/third_party/blink/renderer/core/fetch/fetch_response_data.cc
[modify] https://crrev.com/3ca5ccfe2fcd8de7061707a7db3a9005c1d91644/third_party/blink/renderer/core/fetch/fetch_response_data.h
[modify] https://crrev.com/3ca5ccfe2fcd8de7061707a7db3a9005c1d91644/third_party/blink/renderer/core/fetch/response.cc
[modify] https://crrev.com/3ca5ccfe2fcd8de7061707a7db3a9005c1d91644/third_party/blink/renderer/core/fetch/response.h
[modify] https://crrev.com/3ca5ccfe2fcd8de7061707a7db3a9005c1d91644/third_party/blink/renderer/modules/cache_storage/DEPS
[modify] https://crrev.com/3ca5ccfe2fcd8de7061707a7db3a9005c1d91644/third_party/blink/renderer/modules/cache_storage/cache.cc
[modify] https://crrev.com/3ca5ccfe2fcd8de7061707a7db3a9005c1d91644/third_party/blink/renderer/modules/cache_storage/cache.h
[modify] https://crrev.com/3ca5ccfe2fcd8de7061707a7db3a9005c1d91644/third_party/blink/renderer/modules/cache_storage/cache_storage.cc
[modify] https://crrev.com/3ca5ccfe2fcd8de7061707a7db3a9005c1d91644/third_party/blink/renderer/modules/cache_storage/cache_storage.h
[modify] https://crrev.com/3ca5ccfe2fcd8de7061707a7db3a9005c1d91644/third_party/blink/renderer/modules/cache_storage/cache_test.cc
[modify] https://crrev.com/3ca5ccfe2fcd8de7061707a7db3a9005c1d91644/third_party/blink/renderer/modules/cache_storage/global_cache_storage.cc
[modify] https://crrev.com/3ca5ccfe2fcd8de7061707a7db3a9005c1d91644/third_party/blink/renderer/modules/cache_storage/inspector_cache_storage_agent.cc
[modify] https://crrev.com/3ca5ccfe2fcd8de7061707a7db3a9005c1d91644/third_party/blink/renderer/modules/cache_storage/inspector_cache_storage_agent.h
[modify] https://crrev.com/3ca5ccfe2fcd8de7061707a7db3a9005c1d91644/third_party/blink/renderer/platform/exported/platform.cc
[modify] https://crrev.com/3ca5ccfe2fcd8de7061707a7db3a9005c1d91644/third_party/blink/renderer/platform/exported/web_service_worker_request.cc
[modify] https://crrev.com/3ca5ccfe2fcd8de7061707a7db3a9005c1d91644/third_party/blink/renderer/platform/mojo/DEPS
[modify] https://crrev.com/3ca5ccfe2fcd8de7061707a7db3a9005c1d91644/third_party/blink/renderer/platform/mojo/fetch_api_request_struct_traits.cc
[modify] https://crrev.com/3ca5ccfe2fcd8de7061707a7db3a9005c1d91644/third_party/blink/renderer/platform/mojo/fetch_api_request_struct_traits.h
[modify] https://crrev.com/3ca5ccfe2fcd8de7061707a7db3a9005c1d91644/third_party/blink/renderer/platform/mojo/referrer_struct_traits.h

Project Member

Comment 30 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a5a390d01e25feac7899c17c1f23f2d77d30c49

commit 7a5a390d01e25feac7899c17c1f23f2d77d30c49
Author: Lucas Furukawa Gadani <lfg@chromium.org>
Date: Wed May 16 12:51:17 2018

Remove CacheStorage mojom typemaps.

This CL removes the typemaps for CacheStorage and converts the browser usage of
CacheStorage types to mojo types.

Bug:  612287 
Change-Id: Ied68ed00f2cc7af71cc33660544be9894cbb2eb1
Reviewed-on: https://chromium-review.googlesource.com/1058334
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559058}
[modify] https://crrev.com/7a5a390d01e25feac7899c17c1f23f2d77d30c49/content/browser/cache_storage/cache_storage.cc
[modify] https://crrev.com/7a5a390d01e25feac7899c17c1f23f2d77d30c49/content/browser/cache_storage/cache_storage.h
[modify] https://crrev.com/7a5a390d01e25feac7899c17c1f23f2d77d30c49/content/browser/cache_storage/cache_storage_cache.cc
[modify] https://crrev.com/7a5a390d01e25feac7899c17c1f23f2d77d30c49/content/browser/cache_storage/cache_storage_cache.h
[modify] https://crrev.com/7a5a390d01e25feac7899c17c1f23f2d77d30c49/content/browser/cache_storage/cache_storage_cache_unittest.cc
[modify] https://crrev.com/7a5a390d01e25feac7899c17c1f23f2d77d30c49/content/browser/cache_storage/cache_storage_dispatcher_host.cc
[modify] https://crrev.com/7a5a390d01e25feac7899c17c1f23f2d77d30c49/content/browser/cache_storage/cache_storage_dispatcher_host.h
[modify] https://crrev.com/7a5a390d01e25feac7899c17c1f23f2d77d30c49/content/browser/cache_storage/cache_storage_manager.cc
[modify] https://crrev.com/7a5a390d01e25feac7899c17c1f23f2d77d30c49/content/browser/cache_storage/cache_storage_manager.h
[modify] https://crrev.com/7a5a390d01e25feac7899c17c1f23f2d77d30c49/content/browser/cache_storage/cache_storage_manager_unittest.cc
[modify] https://crrev.com/7a5a390d01e25feac7899c17c1f23f2d77d30c49/content/browser/renderer_host/render_message_filter.cc
[modify] https://crrev.com/7a5a390d01e25feac7899c17c1f23f2d77d30c49/content/browser/renderer_host/render_message_filter.h
[modify] https://crrev.com/7a5a390d01e25feac7899c17c1f23f2d77d30c49/content/browser/service_worker/service_worker_browsertest.cc
[modify] https://crrev.com/7a5a390d01e25feac7899c17c1f23f2d77d30c49/content/common/BUILD.gn
[delete] https://crrev.com/25ef50f762ba7f5d5e5ae66bf0fcf483b3db4eec/content/common/cache_storage/cache_storage.typemap
[delete] https://crrev.com/25ef50f762ba7f5d5e5ae66bf0fcf483b3db4eec/content/common/cache_storage/cache_storage_mojom_traits.cc
[delete] https://crrev.com/25ef50f762ba7f5d5e5ae66bf0fcf483b3db4eec/content/common/cache_storage/cache_storage_types.cc
[delete] https://crrev.com/25ef50f762ba7f5d5e5ae66bf0fcf483b3db4eec/content/common/cache_storage/cache_storage_types.h
[modify] https://crrev.com/7a5a390d01e25feac7899c17c1f23f2d77d30c49/content/common/typemaps.gni

Project Member

Comment 31 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb4fb3d4fac6691e9ce04a30fef27b8ae10ce4c3

commit eb4fb3d4fac6691e9ce04a30fef27b8ae10ce4c3
Author: Lucas Gadani <lfg@chromium.org>
Date: Wed May 16 15:11:14 2018

Revert "Remove CacheStorage mojom typemaps."

This reverts commit 7a5a390d01e25feac7899c17c1f23f2d77d30c49.

Reason for revert: Windows bots aren't happy.

Original change's description:
> Remove CacheStorage mojom typemaps.
> 
> This CL removes the typemaps for CacheStorage and converts the browser usage of
> CacheStorage types to mojo types.
> 
> Bug:  612287 
> Change-Id: Ied68ed00f2cc7af71cc33660544be9894cbb2eb1
> Reviewed-on: https://chromium-review.googlesource.com/1058334
> Reviewed-by: Joshua Bell <jsbell@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Commit-Queue: Lucas Gadani <lfg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#559058}

TBR=jsbell@chromium.org,kinuko@chromium.org,lfg@chromium.org

Change-Id: I3fc714c0984587beaed5cd4d21a7786e2288c662
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  612287 
Reviewed-on: https://chromium-review.googlesource.com/1061965
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559102}
[modify] https://crrev.com/eb4fb3d4fac6691e9ce04a30fef27b8ae10ce4c3/content/browser/cache_storage/cache_storage.cc
[modify] https://crrev.com/eb4fb3d4fac6691e9ce04a30fef27b8ae10ce4c3/content/browser/cache_storage/cache_storage.h
[modify] https://crrev.com/eb4fb3d4fac6691e9ce04a30fef27b8ae10ce4c3/content/browser/cache_storage/cache_storage_cache.cc
[modify] https://crrev.com/eb4fb3d4fac6691e9ce04a30fef27b8ae10ce4c3/content/browser/cache_storage/cache_storage_cache.h
[modify] https://crrev.com/eb4fb3d4fac6691e9ce04a30fef27b8ae10ce4c3/content/browser/cache_storage/cache_storage_cache_unittest.cc
[modify] https://crrev.com/eb4fb3d4fac6691e9ce04a30fef27b8ae10ce4c3/content/browser/cache_storage/cache_storage_dispatcher_host.cc
[modify] https://crrev.com/eb4fb3d4fac6691e9ce04a30fef27b8ae10ce4c3/content/browser/cache_storage/cache_storage_dispatcher_host.h
[modify] https://crrev.com/eb4fb3d4fac6691e9ce04a30fef27b8ae10ce4c3/content/browser/cache_storage/cache_storage_manager.cc
[modify] https://crrev.com/eb4fb3d4fac6691e9ce04a30fef27b8ae10ce4c3/content/browser/cache_storage/cache_storage_manager.h
[modify] https://crrev.com/eb4fb3d4fac6691e9ce04a30fef27b8ae10ce4c3/content/browser/cache_storage/cache_storage_manager_unittest.cc
[modify] https://crrev.com/eb4fb3d4fac6691e9ce04a30fef27b8ae10ce4c3/content/browser/renderer_host/render_message_filter.cc
[modify] https://crrev.com/eb4fb3d4fac6691e9ce04a30fef27b8ae10ce4c3/content/browser/renderer_host/render_message_filter.h
[modify] https://crrev.com/eb4fb3d4fac6691e9ce04a30fef27b8ae10ce4c3/content/browser/service_worker/service_worker_browsertest.cc
[modify] https://crrev.com/eb4fb3d4fac6691e9ce04a30fef27b8ae10ce4c3/content/common/BUILD.gn
[add] https://crrev.com/eb4fb3d4fac6691e9ce04a30fef27b8ae10ce4c3/content/common/cache_storage/cache_storage.typemap
[add] https://crrev.com/eb4fb3d4fac6691e9ce04a30fef27b8ae10ce4c3/content/common/cache_storage/cache_storage_mojom_traits.cc
[add] https://crrev.com/eb4fb3d4fac6691e9ce04a30fef27b8ae10ce4c3/content/common/cache_storage/cache_storage_types.cc
[add] https://crrev.com/eb4fb3d4fac6691e9ce04a30fef27b8ae10ce4c3/content/common/cache_storage/cache_storage_types.h
[modify] https://crrev.com/eb4fb3d4fac6691e9ce04a30fef27b8ae10ce4c3/content/common/typemaps.gni

Project Member

Comment 32 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ea2a52de3fd8309b510d90a38f43d995feac094

commit 3ea2a52de3fd8309b510d90a38f43d995feac094
Author: Lucas Gadani <lfg@chromium.org>
Date: Thu May 17 02:55:31 2018

Reland "Remove CacheStorage mojom typemaps."

This is a reland of 7a5a390d01e25feac7899c17c1f23f2d77d30c49

Original change's description:
> Remove CacheStorage mojom typemaps.
> 
> This CL removes the typemaps for CacheStorage and converts the browser usage of
> CacheStorage types to mojo types.
> 
> Bug:  612287 
> Change-Id: Ied68ed00f2cc7af71cc33660544be9894cbb2eb1
> Reviewed-on: https://chromium-review.googlesource.com/1058334
> Reviewed-by: Joshua Bell <jsbell@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Commit-Queue: Lucas Gadani <lfg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#559058}

Bug:  612287 
Change-Id: Iea6d8ef4f67616be7350edec7705d71b2b1ac126
Reviewed-on: https://chromium-review.googlesource.com/1061986
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559406}
[modify] https://crrev.com/3ea2a52de3fd8309b510d90a38f43d995feac094/content/browser/cache_storage/cache_storage.cc
[modify] https://crrev.com/3ea2a52de3fd8309b510d90a38f43d995feac094/content/browser/cache_storage/cache_storage.h
[modify] https://crrev.com/3ea2a52de3fd8309b510d90a38f43d995feac094/content/browser/cache_storage/cache_storage_cache.cc
[modify] https://crrev.com/3ea2a52de3fd8309b510d90a38f43d995feac094/content/browser/cache_storage/cache_storage_cache.h
[modify] https://crrev.com/3ea2a52de3fd8309b510d90a38f43d995feac094/content/browser/cache_storage/cache_storage_cache_unittest.cc
[modify] https://crrev.com/3ea2a52de3fd8309b510d90a38f43d995feac094/content/browser/cache_storage/cache_storage_dispatcher_host.cc
[modify] https://crrev.com/3ea2a52de3fd8309b510d90a38f43d995feac094/content/browser/cache_storage/cache_storage_dispatcher_host.h
[modify] https://crrev.com/3ea2a52de3fd8309b510d90a38f43d995feac094/content/browser/cache_storage/cache_storage_manager.cc
[modify] https://crrev.com/3ea2a52de3fd8309b510d90a38f43d995feac094/content/browser/cache_storage/cache_storage_manager.h
[modify] https://crrev.com/3ea2a52de3fd8309b510d90a38f43d995feac094/content/browser/cache_storage/cache_storage_manager_unittest.cc
[modify] https://crrev.com/3ea2a52de3fd8309b510d90a38f43d995feac094/content/browser/renderer_host/render_message_filter.cc
[modify] https://crrev.com/3ea2a52de3fd8309b510d90a38f43d995feac094/content/browser/renderer_host/render_message_filter.h
[modify] https://crrev.com/3ea2a52de3fd8309b510d90a38f43d995feac094/content/browser/service_worker/service_worker_browsertest.cc
[modify] https://crrev.com/3ea2a52de3fd8309b510d90a38f43d995feac094/content/common/BUILD.gn
[delete] https://crrev.com/96aa7670917d16ccdf48ce2028cc5f6836db71e8/content/common/cache_storage/cache_storage.typemap
[delete] https://crrev.com/96aa7670917d16ccdf48ce2028cc5f6836db71e8/content/common/cache_storage/cache_storage_mojom_traits.cc
[delete] https://crrev.com/96aa7670917d16ccdf48ce2028cc5f6836db71e8/content/common/cache_storage/cache_storage_types.cc
[delete] https://crrev.com/96aa7670917d16ccdf48ce2028cc5f6836db71e8/content/common/cache_storage/cache_storage_types.h
[modify] https://crrev.com/3ea2a52de3fd8309b510d90a38f43d995feac094/content/common/typemaps.gni

Comment 33 by lfg@chromium.org, May 22 2018

I forgot to add the bug # to the last CL:

Make the FetchAPIRequest optional in the CacheStorage API.

For the 2 calls where the idl doesn't require a Request to be passed,
MatchAll and Keys, make the mojom call also take an optional Request.
This allows the serializer to enforce that the attributes of the
FetchAPIRequest are valid, as we can guarantee that an uninitialized
request won't be dispatched.

Change-Id: I94b6154e69341a849f57172ec016916aa6020382
Reviewed-on: https://chromium-review.googlesource.com/1060334
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560639}

Comment 34 by lfg@chromium.org, May 22 2018

Cc: lfg@chromium.org
Owner: ----
Status: Available (was: Started)
With the last CL, both mojo conversion and onion-soup of the CacheStorage API should be complete.

Since this bug also includes the quota service conversion, I'm marking it as available.

Project Member

Comment 35 by bugdroid1@chromium.org, Jul 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/592ac0e7f24c135b0f14f429b8ffb6228ffa8845

commit 592ac0e7f24c135b0f14f429b8ffb6228ffa8845
Author: Lucas Furukawa Gadani <lfg@chromium.org>
Date: Thu Jul 05 14:23:21 2018

Remove dead code.

This should've been removed by r559058.

Bug:  612287 
Change-Id: I36da5c61720bf0900fb9795eb0c12f4ce350d2bf
Reviewed-on: https://chromium-review.googlesource.com/1126207
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572784}
[delete] https://crrev.com/24e22c7773f2aabdde32b823f177c67869980639/content/common/cache_storage/OWNERS
[delete] https://crrev.com/24e22c7773f2aabdde32b823f177c67869980639/content/common/cache_storage/cache_storage_mojom_traits.h

Components: -Internals>Services>Storage Internals>Storage
The Storage team monitors Internals>Storage. The Internals>Services>Storage label will be deprecated & removed.
Status: Fixed (was: Available)
Our thinking of what it means to modularize content has changed since this was filed. I don't see much benefit to move the browser side code of this outside of content at this point. The work done so far is enough.

Sign in to add a comment