New issue
Advanced search Search tips

Issue 612282 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

DevTools: intermittent crash when profile on reload.

Project Member Reported by pfeldman@chromium.org, May 16 2016

Issue description

#0 0x7f381e8e03c7 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#1 0x7f3818827340 <unknown>
#2 0x7f38223cdb53 WTF::StringTypeAdapter<>::writeTo()
#3 0x7f381f4f1d37 WTF::makeString<>()
#4 0x7f381f4ef74b WTF::StringAppend<>::operator ?()
#5 0x7f38204bc2ce blink::IdentifiersFactory::addProcessIdPrefixTo()
#6 0x7f38204bc341 blink::IdentifiersFactory::requestId()
#7 0x7f382037aa02 blink::InspectorReceiveDataEvent::data()
#8 0x7f3820395eb2 blink::FrameFetchContext::dispatchDidReceiveData()
#9 0x7f38202d14be blink::ResourceLoader::didReceiveData()
#10 0x7f3822842a49 content::WebURLLoaderImpl::Context::OnReceivedData()
#11 0x7f38228432ac content::WebURLLoaderImpl::RequestPeerImpl::OnReceivedData()
#12 0x7f382282dbb2 content::ResourceDispatcher::OnReceivedData()
#13 0x7f382282f651 _ZN3IPC8MessageTI29ResourceMsg_DataReceived_MetaSt5tupleIJiiiiEEvE8DispatchIN7content18ResourceDispatcherES7_vMS7_FviiiiEEEbPKNS_7MessageEPT_PT0_PT1_T2_
#14 0x7f382282c8c3 content::ResourceDispatcher::DispatchMessage()
#15 0x7f382282c26b content::ResourceDispatcher::OnMessageReceived()
#16 0x7f381e55c33f _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0EEEENS0_9BindStateINS0_15RunnableAdapterIPFvSt10unique_ptrIN13safe_browsing16IncidentReceiverESt14default_deleteIS8_EEEEESC_JNS0_13PassedWrapperISB_EEEEENS0_12InvokeHelperILb0EvSE_EEFvvEE3RunEPNS0_13BindStateBaseE
#17 0x7f381e941d26 base::debug::TaskAnnotator::RunTask()
#18 0x7f382285f027 scheduler::TaskQueueManager::ProcessTaskFromWorkQueue()
#19 0x7f382285e159 scheduler::TaskQueueManager::DoWork()
#20 0x7f382285f994 _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0ELm1ELm2EEEENS0_9BindStateINS0_15RunnableAdapterIMN9scheduler16TaskQueueManagerEFvNS_9TimeTicksEbEEEFvPS7_S8_bEJNS_7WeakPtrIS7_EERS8_bEEENS0_12InvokeHelperILb1EvSB_EEFvvEE3RunEPNS0_13BindStateBaseE
#21 0x7f381e941d26 base::debug::TaskAnnotator::RunTask()

 
Cc: dgozman@chromium.org
Owner: caseq@chromium.org
This could happen if we access IdentifiersFactory before initializing it, which happens here: https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp#90

Comment 3 by caseq@chromium.org, Jun 17 2016

Issue 620894 has been merged into this issue.

Comment 4 by caseq@chromium.org, Jun 17 2016

Labels: -Pri-3 Merge-Request-52 Stability-Crash Pri-1

Comment 5 by caseq@chromium.org, Jun 17 2016

Labels: -Stability-Crash -Merge-Request-52
Project Member

Comment 6 by sheriffbot@chromium.org, Jun 17 2016

Labels: FoundIn-M-52 Fracas
Users experienced this crash on the following builds:

Linux Beta 52.0.2743.33 -  0.94 CPM, 12 reports, 10 clients (signature blink::EventTarget::fireEventListeners)

If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates.

- Go/Fracas
Cc: caseq@chromium.org oysteine@chromium.org nedngu...@google.com
 Issue 622342  has been merged into this issue.
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0751df2ff806e1ed303c2f652a090057d6768ba1

commit 0751df2ff806e1ed303c2f652a090057d6768ba1
Author: ksakamoto <ksakamoto@chromium.org>
Date: Fri Jun 24 01:48:19 2016

Make IdentifiersFactory thread-safe

IdentifiersFactory can be used not only from main thread but also from
ScriptStreamer thread, so it should not hold process ID prefix as
thread-unsafe WTF::String. This fixes crash when devtools.timeline
tracing is enabled.

This patch also makes s_lastUsedIdentifier increment atomically.

BUG= 621473 ,  612282 

Review-Url: https://codereview.chromium.org/2088333003
Cr-Commit-Position: refs/heads/master@{#401778}

[modify] https://crrev.com/0751df2ff806e1ed303c2f652a090057d6768ba1/third_party/WebKit/Source/core/inspector/IdentifiersFactory.cpp
[modify] https://crrev.com/0751df2ff806e1ed303c2f652a090057d6768ba1/third_party/WebKit/Source/core/inspector/IdentifiersFactory.h

Comment 9 by caseq@chromium.org, Jul 29 2016

Status: Fixed (was: Assigned)

Sign in to add a comment