black border around drop-down selection controls at 1.5 dsf |
||||||||||||||||
Issue descriptionVersion: 52.0.2738.0 (Official Build) canary (64-bit) OS: Windows 10 Drop down input selection boxes have a weird black border around the top and left edge at 1.5 device scale factor (see attached screenshot). With enable-use-zoom-for-dsf on, the problem is less severe still present. There's a small black border along the top.
,
Aug 9 2016
Repros on most dropdowns on http://www.roboform.com/filling-test-shopping-cart
,
Aug 30 2016
I saw this issue with <input type=date> too. I guess this is not a popup content rendering issue, but a paint/compositing off-by-one. So the problem must be in third_party/WebKit/Source/web/WebPagePopupImpl.*, PageWidgetDelegate.*, or chromium compositor.
,
Oct 12 2016
,
Nov 23 2016
,
Nov 23 2016
,
Nov 23 2016
,
Dec 15 2016
,
Dec 15 2016
oshima: don't work on this right now. It requires some infrastructure work on Windows. See bug 668278.
,
Dec 15 2016
I thought the border one is separate issue, no?
,
Dec 15 2016
Yes, the border being wrong is separate from the font size being wrong from bug 674666 . But we can't fix the border being wrong right now. The <select> dropdowns are positioned in DIPs even though Windows expects pixels, and so we lose some precision. This is an old issue.
,
Dec 16 2016
so you're saying that the border is outside of the content?
,
Dec 16 2016
Yes, it spawns a separate window so it can hover over and outside the main window.
,
Dec 16 2016
I know it creates a window, but it doesn't automatically create a black border. My question was where this black border comes from.
,
Dec 16 2016
Ah yes, sorry. I'm not sure exactly why in this case, but the window's contents are aligned differently than the window. So the black border is area where we don't render anything. It is a little odd, because you'd expect the window area and the contents to have the same precision loss. I could be wrong about this since kulshin@ was the one investigating it.
,
Dec 16 2016
Ok, sounds like it's still worth looking into this, at least once. If this is indeed due to windows placement, yes, I agree that we need to wait.
,
Dec 16 2016
linux has simiar issue, so I'll work on linux first.
,
Dec 16 2016
Yep, it was just a bug, not positioning issue. I have a fix for linux, and I'd expect it will work for win too.
,
Jan 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0aafa24f1ad6b4331bdb65db12ffc1842ba69b1d commit 0aafa24f1ad6b4331bdb65db12ffc1842ba69b1d Author: oshima <oshima@chromium.org> Date: Wed Jan 11 00:25:34 2017 Correctly update the popup window position It was updating the child window instead. This CL hooks up the bounds change to the desktop widget correctly. BUG=612270 TEST=fixed test harness to do the correct check. Review-Url: https://codereview.chromium.org/2583873002 Cr-Commit-Position: refs/heads/master@{#442741} [modify] https://crrev.com/0aafa24f1ad6b4331bdb65db12ffc1842ba69b1d/content/browser/renderer_host/render_widget_host_view_aura.cc [modify] https://crrev.com/0aafa24f1ad6b4331bdb65db12ffc1842ba69b1d/content/browser/renderer_host/render_widget_host_view_aura.h [modify] https://crrev.com/0aafa24f1ad6b4331bdb65db12ffc1842ba69b1d/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc [modify] https://crrev.com/0aafa24f1ad6b4331bdb65db12ffc1842ba69b1d/ui/aura/window.cc [modify] https://crrev.com/0aafa24f1ad6b4331bdb65db12ffc1842ba69b1d/ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc [modify] https://crrev.com/0aafa24f1ad6b4331bdb65db12ffc1842ba69b1d/ui/views/widget/desktop_aura/desktop_screen_position_client.cc
,
Jan 12 2017
Verified on windows 7 using chrome clang M57 #57.0.2979.2 and issue is fixed. Navigated to the url provided in commeny #2 , and observed that no black border is seen on left and top edge of the dropdown input selction boxes. Attached screencast for reference. Adding TE-Verified labels. Thanks!
,
Jan 28 2017
,
Mar 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ba9b1f20d4f158b5cdeb359d9ab7d836e09858a commit 2ba9b1f20d4f158b5cdeb359d9ab7d836e09858a Author: malaykeshav <malaykeshav@chromium.org> Date: Tue Mar 07 21:51:44 2017 Revert of Correctly update the popup window position (patchset #6 id:160001 of https://codereview.chromium.org/2583873002/ ) Reason for revert: Breaking M57 crbug/698627 Original issue's description: > Correctly update the popup window position > > It was updating the child window instead. > This CL hooks up the bounds change to the desktop widget correctly. > > BUG=612270 > TEST=fixed test harness to do the correct check. > > Review-Url: https://codereview.chromium.org/2583873002 > Cr-Commit-Position: refs/heads/master@{#442741} > Committed: https://chromium.googlesource.com/chromium/src/+/0aafa24f1ad6b4331bdb65db12ffc1842ba69b1d TBR=sadrul@chromium.org,bsep@chromium.org,oshima@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=612270, 698627 Review-Url: https://codereview.chromium.org/2728293004 Cr-Commit-Position: refs/heads/master@{#455231} [modify] https://crrev.com/2ba9b1f20d4f158b5cdeb359d9ab7d836e09858a/content/browser/renderer_host/render_widget_host_view_aura.cc [modify] https://crrev.com/2ba9b1f20d4f158b5cdeb359d9ab7d836e09858a/content/browser/renderer_host/render_widget_host_view_aura.h [modify] https://crrev.com/2ba9b1f20d4f158b5cdeb359d9ab7d836e09858a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc [modify] https://crrev.com/2ba9b1f20d4f158b5cdeb359d9ab7d836e09858a/ui/aura/window.cc [modify] https://crrev.com/2ba9b1f20d4f158b5cdeb359d9ab7d836e09858a/ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc [modify] https://crrev.com/2ba9b1f20d4f158b5cdeb359d9ab7d836e09858a/ui/views/widget/desktop_aura/desktop_screen_position_client.cc
,
Mar 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/750f7aa5d49254312e77f3fc947acbe5d2927769 commit 750f7aa5d49254312e77f3fc947acbe5d2927769 Author: Steven Bennetts <stevenjb@chromium.org> Date: Tue Mar 07 22:50:04 2017 Revert of Correctly update the popup window position (patchset #6 id:160001 of https://codereview.chromium.org/2583873002/ ) Reason for revert: Breaking M57 crbug/698627 Original issue's description: > Correctly update the popup window position > > It was updating the child window instead. > This CL hooks up the bounds change to the desktop widget correctly. > > BUG=612270 > TEST=fixed test harness to do the correct check. > > Review-Url: https://codereview.chromium.org/2583873002 > Cr-Commit-Position: refs/heads/master@{#442741} > Committed: https://chromium.googlesource.com/chromium/src/+/0aafa24f1ad6b4331bdb65db12ffc1842ba69b1d TBR=sadrul@chromium.org,bsep@chromium.org,oshima@chromium.org BUG=612270, 698627 Review-Url: https://codereview.chromium.org/2728293004 Cr-Commit-Position: refs/heads/master@{#455231} (cherry picked from commit 2ba9b1f20d4f158b5cdeb359d9ab7d836e09858a) Review-Url: https://codereview.chromium.org/2732383002 . Cr-Commit-Position: refs/branch-heads/2987@{#791} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/750f7aa5d49254312e77f3fc947acbe5d2927769/content/browser/renderer_host/render_widget_host_view_aura.cc [modify] https://crrev.com/750f7aa5d49254312e77f3fc947acbe5d2927769/content/browser/renderer_host/render_widget_host_view_aura.h [modify] https://crrev.com/750f7aa5d49254312e77f3fc947acbe5d2927769/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc [modify] https://crrev.com/750f7aa5d49254312e77f3fc947acbe5d2927769/ui/aura/window.cc [modify] https://crrev.com/750f7aa5d49254312e77f3fc947acbe5d2927769/ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc [modify] https://crrev.com/750f7aa5d49254312e77f3fc947acbe5d2927769/ui/views/widget/desktop_aura/desktop_screen_position_client.cc
,
Mar 8 2017
Tested on windows 7 using chrome M57 #57.0.2924.87 and dark black line is observed on the drop down text field. Attached screencast for reference. Tested URL : http://www.roboform.com/filling-test-shopping-cart @Could someone look into this and confirm if this is the expected behavior or any steps to consider for testing . Thanks!
,
Mar 8 2017
As mentioned in comment #20 , when it was tested on M57 #57.0.2979.2 using url "http://www.roboform.com/filling-test-shopping-cart" ,no black line was seen sorrounded by drop down text field , but in M57 #57.0.2924.87 , black line is seen as attached in comment #24 . Hence , adding needs-feedback to get it confirmed. Thanks!
,
Mar 8 2017
#24-25, the fix for this issue was reverted on trunk and M57 branch.
,
Mar 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a2b327d0b8e2935ba42f8f4b084c4afccfc6cbf3 commit a2b327d0b8e2935ba42f8f4b084c4afccfc6cbf3 Author: Jacob Dufault <jdufault@google.com> Date: Mon Mar 13 18:55:57 2017 Revert of Correctly update the popup window position (patchset #6 id:160001 of https://codereview.chromium.org/2583873002/ ) Reason for revert: Breaking M57 crbug/698627 Original issue's description: > Correctly update the popup window position > > It was updating the child window instead. > This CL hooks up the bounds change to the desktop widget correctly. > > BUG=612270 > TEST=fixed test harness to do the correct check. > > Review-Url: https://codereview.chromium.org/2583873002 > Cr-Commit-Position: refs/heads/master@{#442741} > Committed: https://chromium.googlesource.com/chromium/src/+/0aafa24f1ad6b4331bdb65db12ffc1842ba69b1d TBR=sadrul@chromium.org,bsep@chromium.org,oshima@chromium.org BUG=612270, 698627 Review-Url: https://codereview.chromium.org/2728293004 Cr-Commit-Position: refs/heads/master@{#455231} (cherry picked from commit 2ba9b1f20d4f158b5cdeb359d9ab7d836e09858a) Review-Url: https://codereview.chromium.org/2747723004 . Cr-Commit-Position: refs/branch-heads/3029@{#159} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/a2b327d0b8e2935ba42f8f4b084c4afccfc6cbf3/content/browser/renderer_host/render_widget_host_view_aura.cc [modify] https://crrev.com/a2b327d0b8e2935ba42f8f4b084c4afccfc6cbf3/content/browser/renderer_host/render_widget_host_view_aura.h [modify] https://crrev.com/a2b327d0b8e2935ba42f8f4b084c4afccfc6cbf3/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc [modify] https://crrev.com/a2b327d0b8e2935ba42f8f4b084c4afccfc6cbf3/ui/aura/window.cc [modify] https://crrev.com/a2b327d0b8e2935ba42f8f4b084c4afccfc6cbf3/ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc [modify] https://crrev.com/a2b327d0b8e2935ba42f8f4b084c4afccfc6cbf3/ui/views/widget/desktop_aura/desktop_screen_position_client.cc
,
Oct 18 2017
,
Jan 17 2018
,
Nov 27
***UI Mass Triage *** Seems like WIP and bug is valid, hence tagging with appropriate label. |
||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||
Comment 1 by bsep@chromium.org
, Aug 9 2016Labels: Hotlist-Win10FrontendPolish
18.5 KB
18.5 KB View Download