Issue 612263 link

Starred by 2 users

Issue metadata

Status:	Fixed
Owner:	vakh@chromium.org
Closed:	May 2016
Cc:	█ kcaratt...@chromium.org nparker@chromium.org █ awoz@chromium.org █ noelutz@google.com vakh@chromium.org
Components:	Services>Safebrowsing
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	2
Type:	Bug

Change ThreatEntryType::URL_EXPRESSION to ThreatEntryType::URL, ThreatEntryType::BINARY_DIGEST to ThreatEntryType::EXECUTABLE in safebrowsing.proto

Project Member Reported by vakh@chromium.org, May 16 2016

Issue description

Change ThreatEntryType::URL_EXPRESSION to ThreatEntryType::URL to track a similar change in the internal proto.

Internal bug: http://b/28796118

Defined here: https://code.google.com/p/chromium/codesearch#chromium/src/components/safe_browsing_db/safebrowsing.proto&q=URL_EXPRESSION&sq=package:chromium&type=cs&l=350

Uses:
https://code.google.com/p/chromium/codesearch#search/&q=URL_EXPRESSION%20f:safe_browsing&sq=package:chromium&type=cs

Comment 1 by vakh@chromium.org, May 16 2016

Status: Started (was: Assigned)

Comment 2 by vakh@chromium.org, May 24 2016

Summary: Change ThreatEntryType::URL_EXPRESSION to ThreatEntryType::URL, ThreatEntryType::BINARY_DIGEST to ThreatEntryType::EXECUTABLE in safebrowsing.proto (was: Change ThreatEntryType::URL_EXPRESSION to ThreatEntryType::URL in safebrowsing.proto)

The internal but was updated to include another rename so adding that.

Project Member

Comment 3 by bugdroid1@chromium.org, May 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4976fd011b288796a5c9e0c0ed7ec40a4a4104c

commit e4976fd011b288796a5c9e0c0ed7ec40a4a4104c
Author: vakh <vakh@chromium.org>
Date: Tue May 24 19:51:56 2016

Replace ThreatEntryType::URL_EXPRESSION with ThreatEntryType::URL

Passes:
$ nice ninja -C out/gn_out -j 1000 components_unittests && out/gn_out/components_unittests --gtest_filter="*V4*"

BUG= 612263 ,  543161 

Review-Url: https://codereview.chromium.org/1988433002
Cr-Commit-Position: refs/heads/master@{#395678}

[modify] https://crrev.com/e4976fd011b288796a5c9e0c0ed7ec40a4a4104c/components/safe_browsing_db/safebrowsing.proto
[modify] https://crrev.com/e4976fd011b288796a5c9e0c0ed7ec40a4a4104c/components/safe_browsing_db/v4_get_hash_protocol_manager.cc
[modify] https://crrev.com/e4976fd011b288796a5c9e0c0ed7ec40a4a4104c/components/safe_browsing_db/v4_get_hash_protocol_manager_unittest.cc
[modify] https://crrev.com/e4976fd011b288796a5c9e0c0ed7ec40a4a4104c/components/safe_browsing_db/v4_local_database_manager.cc
[modify] https://crrev.com/e4976fd011b288796a5c9e0c0ed7ec40a4a4104c/components/safe_browsing_db/v4_update_protocol_manager_unittest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, May 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c4485f1ce7cac7ae82f7a4ae36ccc663afe806c

commit 9c4485f1ce7cac7ae82f7a4ae36ccc663afe806c
Author: vakh <vakh@chromium.org>
Date: Tue May 24 22:21:28 2016

s/BINARY_DIGEST/EXECUTABLE in safebrowsing.proto
Also updated the related comment in .proto

Passes:
$ nice ninja -C out/gn_out -j 1000 components_unittests && out/gn_out/components_unittests --gtest_filter="*V4*"

BUG= 612263 ,  543161 

Review-Url: https://codereview.chromium.org/2012553002
Cr-Commit-Position: refs/heads/master@{#395709}

[modify] https://crrev.com/9c4485f1ce7cac7ae82f7a4ae36ccc663afe806c/components/safe_browsing_db/safebrowsing.proto
[modify] https://crrev.com/9c4485f1ce7cac7ae82f7a4ae36ccc663afe806c/components/safe_browsing_db/v4_get_hash_protocol_manager_unittest.cc
[modify] https://crrev.com/9c4485f1ce7cac7ae82f7a4ae36ccc663afe806c/components/safe_browsing_db/v4_protocol_manager_util.h
[modify] https://crrev.com/9c4485f1ce7cac7ae82f7a4ae36ccc663afe806c/components/safe_browsing_db/v4_update_protocol_manager_unittest.cc

Comment 5 by vakh@chromium.org, May 24 2016

Status: Fixed (was: Started)

►

Issue 612263 link

Issue metadata

Change ThreatEntryType::URL_EXPRESSION to ThreatEntryType::URL, ThreatEntryType::BINARY_DIGEST to ThreatEntryType::EXECUTABLE in safebrowsing.proto

Issue description

Comment 1 by vakh@chromium.org, May 16 2016

Comment 1 Deleted

Comment 2 by vakh@chromium.org, May 24 2016

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, May 24 2016

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, May 24 2016

Comment 4 Deleted

Comment 5 by vakh@chromium.org, May 24 2016

Comment 5 Deleted

Sign in to add a comment