New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 612257 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 600469



Sign in to add a comment

git cl upload fails to upload large patch: TimeoutError

Project Member Reported by qyears...@chromium.org, May 16 2016

Issue description

I'm trying to upload a large patch that involves renaming a directory with about 2600 files ( bug 611762 ), and am getting an error.

Excerpt of the git cl upload output:

...

 2590 files changed, 551 insertions(+), 551 deletions(-)
This branch is associated with issue 1979363002. Adding patch to that issue.
Upload server: https://codereview.chromium.org (change with -s/--server)
Title describing this patch set: 
Patch is large, so uploading file patches separately.
Issue updated. URL: https://codereview.chromium.org/1979363002 (patchset: 20001)
Uploaded patch for third_party/WebKit/LayoutTests/imported/web-platform-tests/CONTRIBUTING.md
Uploaded patch for third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/BlobURL/support/file_test1.js
Uploaded patch for third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/BlobURL/support/file_test2.txt
Uploaded patch for third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/BlobURL/support/file_test3.html

...

  --> Failed to upload patch for third_party/WebKit/LayoutTests/imported/wpt/uievents/legacy-domevents-tests/approved/dispatchEvent.click.checkbox.html. Got 400 status code.
  --> Failed to upload patch for third_party/WebKit/LayoutTests/imported/wpt/uievents/legacy-domevents-tests/approved/domnodeinserted.html. Got 400 status code.
  --> Failed to upload patch for third_party/WebKit/LayoutTests/imported/wpt/uievents/legacy-domevents-tests/approved/stopImmediatePropagation.effect.html. Got 400 status code.
  --> Failed to upload patch for third_party/WebKit/LayoutTests/imported/wpt/uievents/legacy-domevents-tests/approved/stopPropagation.deferred.effect.html. Got 400 status code.

...

  --> Failed to upload patch for third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/README.chromium. Got 400 status code.
Traceback (most recent call last):
  File "/usr/local/google/home/qyearsley/bin/depot_tools/git_cl.py", line 4907, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/usr/local/google/home/qyearsley/bin/depot_tools/git_cl.py", line 4889, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/usr/local/google/home/qyearsley/bin/depot_tools/subcommand.py", line 252, in execute
    return command(parser, args[1:])
  File "/usr/local/google/home/qyearsley/bin/depot_tools/git_cl.py", line 3621, in CMDupload
    return cl.CMDUpload(options, args, orig_args)
  File "/usr/local/google/home/qyearsley/bin/depot_tools/git_cl.py", line 1398, in CMDUpload
    ret = self.CMDUploadChange(options, git_diff_args, change)
  File "/usr/local/google/home/qyearsley/bin/depot_tools/git_cl.py", line 1973, in CMDUploadChange
    issue, patchset = upload.RealMain(upload_args)
  File "/usr/local/google/home/qyearsley/bin/depot_tools/third_party/upload.py", line 2508, in RealMain
    result = UploadSeparatePatches(issue, rpc_server, patchset, data, options)
  File "/usr/local/google/home/qyearsley/bin/depot_tools/third_party/upload.py", line 2093, in UploadSeparatePatches
    result = t.get(timeout=60)
  File "/usr/lib/python2.7/multiprocessing/pool.py", line 554, in get
    raise TimeoutError
multiprocessing.TimeoutError


Note, I tried increasing the timeout in depot_tools/third_party/upload.py line 2093 to 120s; same failure.


Can we find out what the reason is for the 400 errors from Rietveld? Has this happened before for other large patches?
 
Blocking: 611762
Blocking: -611762
Labels: -Pri-1 Pri-2
Note, for  bug 611762  I'm planning to work around the issue by making smaller CLs. Not sure if this is still an issue that we want to track though; in general, Rietveld can't handle large CLs right now. If it's not feasible to make it handle large CLs, then a better warning message would also have saved a little time.
Blockedon: 600469
Cc: tandrii@chromium.org
Status: Available (was: Untriaged)
+tandrii for the better warning message.
Labels: -Pri-2 Pri-3
This is Rietveld, which has tons of limitations (most are blocked on  issue 600469 ). I won't invest time into fixing this for Rietveld, sorry.
Status: WontFix (was: Available)
Sounds fine; marking WontFix given that we're planning to eventually migrate away from Rietveld and probably won't decide to invest time into fixing Rietveld issues before that.

Sign in to add a comment