Tabs are being discarded more than once on Windows/Mac |
||||||||
Issue descriptionTabs are being discarded more than once on Windows/Mac. This is a regression that was introduced in bc49af93ba4d000aff3eb7d8b0b749af426ad9ed.
,
May 16 2016
We are requesting merging to both Stable & Beta as this regression is significant and the fix is very small.
,
May 17 2016
M50 stable is pretty much done, no further stable refresh is planned at this point. Before we approve merge to M51, Could you please confirm whether this bug is baked/verified in Canary and safe to merge?
,
May 17 2016
[Automated comment] Less than 2 weeks to go before stable on M51, manual review required.
,
May 17 2016
[Automated comment] Request affecting a post-stable build (M50), manual review required.
,
May 17 2016
[Automated comment] Request affecting a post-stable build (M50), manual review required.
,
May 18 2016
Before we approve merge to M51, Could you please confirm whether this bug is baked/verified in Canary and safe to merge?
,
May 18 2016
I just manually verified and can confirm the regression is gone: - On Stable (50.0.2661.102), regression is present - On Canary (52.0.2740.0), regression is gone
,
May 18 2016
Thank you georgesak@. Approving merge to M51 branch 2704 based on comment #8. Please merge ASAP as we're very close to M51 stable candidate cut.
,
May 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab7b1bc781d2510f6848263fce6725bee5a38d03 commit ab7b1bc781d2510f6848263fce6725bee5a38d03 Author: Georges Khalil <georgesak@chromium.org> Date: Wed May 18 22:00:43 2016 [TabManager] Fix discard only once regression. TBR=chrisha BUG=525216, 612256 Review-Url: https://codereview.chromium.org/1980143002 Cr-Commit-Position: refs/heads/master@{#393948} (cherry picked from commit 9351954662a74709359352a8629d340d2a114777) Review URL: https://codereview.chromium.org/1997463002 . Cr-Commit-Position: refs/branch-heads/2704@{#590} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/ab7b1bc781d2510f6848263fce6725bee5a38d03/chrome/browser/memory/tab_manager.cc
,
May 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e932f6660251e72cbf3b712be6ac28a9e00c11f0 commit e932f6660251e72cbf3b712be6ac28a9e00c11f0 Author: andersoncss <andersoncss@google.com> Date: Wed May 25 19:26:26 2016 [TabManager] Unit tests to make sure of the number of times tabs can be discarded. BUG= 612435 , 612256 Review-Url: https://codereview.chromium.org/2000833002 Cr-Commit-Position: refs/heads/master@{#395960} [modify] https://crrev.com/e932f6660251e72cbf3b712be6ac28a9e00c11f0/chrome/browser/memory/tab_manager.h [modify] https://crrev.com/e932f6660251e72cbf3b712be6ac28a9e00c11f0/chrome/browser/memory/tab_manager_unittest.cc |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, May 16 2016