New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 612256 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: May 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 0
Type: Bug



Sign in to add a comment

Tabs are being discarded more than once on Windows/Mac

Project Member Reported by georgesak@chromium.org, May 16 2016

Issue description

Tabs are being discarded more than once on Windows/Mac.

This is a regression that was introduced in bc49af93ba4d000aff3eb7d8b0b749af426ad9ed.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9351954662a74709359352a8629d340d2a114777

commit 9351954662a74709359352a8629d340d2a114777
Author: georgesak <georgesak@chromium.org>
Date: Mon May 16 22:04:32 2016

[TabManager] Fix discard only once regression.

BUG=525216, 612256 

Review-Url: https://codereview.chromium.org/1980143002
Cr-Commit-Position: refs/heads/master@{#393948}

[modify] https://crrev.com/9351954662a74709359352a8629d340d2a114777/chrome/browser/memory/tab_manager.cc

Cc: andersoncss@google.com
Labels: Merge-Request-50 Merge-Request-51
We are requesting merging to both Stable & Beta as this regression is significant and the fix is very small.

Comment 3 by gov...@chromium.org, May 17 2016

M50 stable is pretty much done, no further stable refresh is planned at this point. 

Before we approve merge to M51, Could you please confirm whether this bug is baked/verified in Canary and safe to merge?

Comment 4 by tin...@google.com, May 17 2016

Labels: -Merge-Request-51 Merge-Review-51
[Automated comment] Less than 2 weeks to go before stable on M51, manual review required.

Comment 5 by tin...@google.com, May 17 2016

Labels: -Merge-Request-50 Merge-Review-50 Hotlist-Merge-Review
[Automated comment] Request affecting a post-stable build (M50), manual review required.

Comment 6 by tin...@google.com, May 17 2016

Labels: -Merge-Request-50 Merge-Review-50 Hotlist-Merge-Review
[Automated comment] Request affecting a post-stable build (M50), manual review required.

Comment 7 by gov...@chromium.org, May 18 2016

Before we approve merge to M51, Could you please confirm whether this bug is baked/verified in Canary and safe to merge?
Status: Verified (was: Assigned)
I just manually verified and can confirm the regression is gone:

- On Stable (50.0.2661.102), regression is present
- On Canary (52.0.2740.0), regression is gone

Comment 9 by gov...@chromium.org, May 18 2016

Cc: sshruthi@chromium.org
Labels: -Merge-Review-51 Merge-Approved-51
Thank you georgesak@.  Approving merge to M51 branch 2704 based on comment #8. Please merge ASAP as we're very close to M51 stable candidate cut. 
Project Member

Comment 10 by bugdroid1@chromium.org, May 18 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab7b1bc781d2510f6848263fce6725bee5a38d03

commit ab7b1bc781d2510f6848263fce6725bee5a38d03
Author: Georges Khalil <georgesak@chromium.org>
Date: Wed May 18 22:00:43 2016

[TabManager] Fix discard only once regression.

TBR=chrisha
BUG=525216, 612256 

Review-Url: https://codereview.chromium.org/1980143002
Cr-Commit-Position: refs/heads/master@{#393948}
(cherry picked from commit 9351954662a74709359352a8629d340d2a114777)

Review URL: https://codereview.chromium.org/1997463002 .

Cr-Commit-Position: refs/branch-heads/2704@{#590}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/ab7b1bc781d2510f6848263fce6725bee5a38d03/chrome/browser/memory/tab_manager.cc

Project Member

Comment 11 by bugdroid1@chromium.org, May 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e932f6660251e72cbf3b712be6ac28a9e00c11f0

commit e932f6660251e72cbf3b712be6ac28a9e00c11f0
Author: andersoncss <andersoncss@google.com>
Date: Wed May 25 19:26:26 2016

[TabManager] Unit tests to make sure of the number of times tabs can be discarded.

BUG= 612435 , 612256 

Review-Url: https://codereview.chromium.org/2000833002
Cr-Commit-Position: refs/heads/master@{#395960}

[modify] https://crrev.com/e932f6660251e72cbf3b712be6ac28a9e00c11f0/chrome/browser/memory/tab_manager.h
[modify] https://crrev.com/e932f6660251e72cbf3b712be6ac28a9e00c11f0/chrome/browser/memory/tab_manager_unittest.cc

Sign in to add a comment