Issue metadata
Sign in to add a comment
|
certificate_reporting: ErrorReport::InitializeFromString may be removable |
||||||||||||||||||||||
Issue descriptionWe have ErrorReport::InitializeFromString, which just calls down to CertLoggerRequest::ParseFromString. There's a unittest covering this method, but the only invocation of this method appears to be CertificateReportingTest::MockReporter::SendExtendedReportingReport to extract the associated hostname. The unit tests in error_report_unittest (with the exception of of ErrorReportTest:ParseSerializedReport) just seem to directly deserialize the CertLoggerRequest One option is to rename ErrorReport::InitializeFromString to InitializeFromStringForTesting (e.g. enforcing it's test only), although alternatively, since the interface is such that it must maintain synchronicity with a remote server, having MockReporter::SendExtendedReportingReport just directly deserialize the CertLoggerRequest is another alternative.
,
Jun 4 2016
,
Jul 10 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 22 2016
,
Nov 22 2016
,
Apr 27 2017
This has been slightly complicated by the addition of CertificateReportingService which needs to deserialize the report to flip a boolean field in it: https://cs.chromium.org/chromium/src/chrome/browser/safe_browsing/certificate_reporting_service.cc?rcl=1ce49f64ab5be7af3fa0a06d9bd1f826a13a0962&l=120
,
Nov 10 2017
,
Feb 18 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by est...@chromium.org
, Jun 4 2016Components: Security>UX
Status: Available (was: Untriaged)