New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 612247 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug
Team-Security-UX



Sign in to add a comment

certificate_reporting: ErrorReport::InitializeFromString may be removable

Project Member Reported by rsleevi@chromium.org, May 16 2016

Issue description

We have ErrorReport::InitializeFromString, which just calls down to CertLoggerRequest::ParseFromString. There's a unittest covering this method, but the only invocation of this method appears to be CertificateReportingTest::MockReporter::SendExtendedReportingReport to extract the associated hostname.

The unit tests in error_report_unittest (with the exception of of ErrorReportTest:ParseSerializedReport) just seem to directly deserialize the CertLoggerRequest

One option is to rename ErrorReport::InitializeFromString to InitializeFromStringForTesting (e.g. enforcing it's test only), although alternatively, since the interface is such that it must maintain synchronicity with a remote server, having MockReporter::SendExtendedReportingReport just directly deserialize the CertLoggerRequest is another alternative.
 
Cc: dadrian@google.com
Components: Security>UX
Status: Available (was: Untriaged)
Status: Assigned (was: Available)
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 10 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Components: Internals>CertAnalysis
Components: -Security>UX

Comment 6 by mea...@chromium.org, Apr 27 2017

This has been slightly complicated by the addition of CertificateReportingService which needs to deserialize the report to flip a boolean field in it: https://cs.chromium.org/chromium/src/chrome/browser/safe_browsing/certificate_reporting_service.cc?rcl=1ce49f64ab5be7af3fa0a06d9bd1f826a13a0962&l=120

Comment 7 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt

Comment 8 by est...@chromium.org, Feb 18 2018

Labels: -Hotlist-EnamelAndFriendsFixIt

Sign in to add a comment