Issue 612245 link

Starred by 3 users

Issue metadata

Status:	Fixed
Owner:	█ wnwen@chromium.org OOO until Feb 4th
Closed:	Sep 2016
Cc:	█ dfalcant...@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	Android
Pri:	2
Type:	Bug
merge-merged-2795

Blocking:
issue 582539

Delete unused DocumentMode code

Project Member Reported by wnwen@chromium.org, May 16 2016

Issue description

With the revert of Hera, see  http://crbug.com/582539  and http://crbug.com/597147, this code is no longer used. It adds to the maintenance overhead of tab models and complicates reasoning about TabPersistentStore and other classes whose methods were used only in migration (outside of their own classes).

This code should be removed.

Comment 1 by wnwen@chromium.org, May 16 2016

Blocking: -597147 582539

Comment 2 by wnwen@chromium.org, May 16 2016

Labels: -Pri-1 Pri-2

Project Member

Comment 3 by bugdroid1@chromium.org, May 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5df8354b79028ebe02c4ac1ad911bc6e39037b8b

commit 5df8354b79028ebe02c4ac1ad911bc6e39037b8b
Author: wnwen <wnwen@chromium.org>
Date: Tue May 17 13:34:10 2016

Cleanup DocumentMode migration helpers.

Remove DocumentMigrationHelper and DocumentModePreference. This helps
to remove many dependencies on TabPersistentStore's methods.

BUG= 612245 

Review-Url: https://codereview.chromium.org/1982043002
Cr-Commit-Position: refs/heads/master@{#394109}

[modify] https://crrev.com/5df8354b79028ebe02c4ac1ad911bc6e39037b8b/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java
[delete] https://crrev.com/9019cf320fdcc79ec31ecfe89f07783a726156a2/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentMigrationHelper.java
[delete] https://crrev.com/9019cf320fdcc79ec31ecfe89f07783a726156a2/chrome/android/java/src/org/chromium/chrome/browser/preferences/DocumentModePreference.java
[modify] https://crrev.com/5df8354b79028ebe02c4ac1ad911bc6e39037b8b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java
[modify] https://crrev.com/5df8354b79028ebe02c4ac1ad911bc6e39037b8b/chrome/android/java_sources.gni

Project Member

Comment 4 by bugdroid1@chromium.org, May 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4804efe6387351c7802a2e9f34afe84e7ccbe7fe

commit 4804efe6387351c7802a2e9f34afe84e7ccbe7fe
Author: wnwen <wnwen@chromium.org>
Date: Fri May 27 01:14:48 2016

Remove unnecessary flag and DocumentModeManager.

- Clean-ups due to simpler logic of only migrating from document mode
  back to tabbed mode on update.

- Simplify opt-out check for document mode and consolidate to
  DocumentModeAssassin.

- Remove unused tests and simplify assumptions related to document
  mode.

BUG= 612245 , 582539 

Review-Url: https://codereview.chromium.org/2013883002
Cr-Commit-Position: refs/heads/master@{#396341}

[modify] https://crrev.com/4804efe6387351c7802a2e9f34afe84e7ccbe7fe/chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java
[modify] https://crrev.com/4804efe6387351c7802a2e9f34afe84e7ccbe7fe/chrome/android/java/src/org/chromium/chrome/browser/TabState.java
[modify] https://crrev.com/4804efe6387351c7802a2e9f34afe84e7ccbe7fe/chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java
[modify] https://crrev.com/4804efe6387351c7802a2e9f34afe84e7ccbe7fe/chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java
[delete] https://crrev.com/9b9e5ba584e32de6cf5202077b1cbe79a76619e6/chrome/android/java/src/org/chromium/chrome/browser/preferences/DocumentModeManager.java
[modify] https://crrev.com/4804efe6387351c7802a2e9f34afe84e7ccbe7fe/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassin.java
[modify] https://crrev.com/4804efe6387351c7802a2e9f34afe84e7ccbe7fe/chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java
[modify] https://crrev.com/4804efe6387351c7802a2e9f34afe84e7ccbe7fe/chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivity.java
[modify] https://crrev.com/4804efe6387351c7802a2e9f34afe84e7ccbe7fe/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
[modify] https://crrev.com/4804efe6387351c7802a2e9f34afe84e7ccbe7fe/chrome/android/java_sources.gni
[modify] https://crrev.com/4804efe6387351c7802a2e9f34afe84e7ccbe7fe/chrome/android/javatests/src/org/chromium/chrome/browser/BindingManagerIntegrationTest.java
[modify] https://crrev.com/4804efe6387351c7802a2e9f34afe84e7ccbe7fe/chrome/android/javatests/src/org/chromium/chrome/browser/TabTest.java
[modify] https://crrev.com/4804efe6387351c7802a2e9f34afe84e7ccbe7fe/chrome/android/javatests/src/org/chromium/chrome/browser/appmenu/AppMenuTest.java
[modify] https://crrev.com/4804efe6387351c7802a2e9f34afe84e7ccbe7fe/chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ContextMenuTest.java
[modify] https://crrev.com/4804efe6387351c7802a2e9f34afe84e7ccbe7fe/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java
[modify] https://crrev.com/4804efe6387351c7802a2e9f34afe84e7ccbe7fe/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
[modify] https://crrev.com/4804efe6387351c7802a2e9f34afe84e7ccbe7fe/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadTest.java
[modify] https://crrev.com/4804efe6387351c7802a2e9f34afe84e7ccbe7fe/chrome/android/javatests/src/org/chromium/chrome/browser/partnercustomizations/PartnerHomepageIntegrationTest.java
[modify] https://crrev.com/4804efe6387351c7802a2e9f34afe84e7ccbe7fe/chrome/android/javatests/src/org/chromium/chrome/browser/printing/PrintingControllerTest.java
[modify] https://crrev.com/4804efe6387351c7802a2e9f34afe84e7ccbe7fe/chrome/android/javatests/src/org/chromium/chrome/browser/tab/TabUmaTest.java
[modify] https://crrev.com/4804efe6387351c7802a2e9f34afe84e7ccbe7fe/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassinTest.java
[modify] https://crrev.com/4804efe6387351c7802a2e9f34afe84e7ccbe7fe/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappModeTest.java
[modify] https://crrev.com/4804efe6387351c7802a2e9f34afe84e7ccbe7fe/chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeTabbedActivityTestBase.java

Project Member

Comment 5 by bugdroid1@chromium.org, May 27 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/1280b6978f187a3343773e430246e6d8cb56fcc7

commit 1280b6978f187a3343773e430246e6d8cb56fcc7
Author: John Budorick <jbudorick@google.com>
Date: Fri May 27 02:46:20 2016

Project Member

Comment 6 by bugdroid1@chromium.org, May 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a918d71efc4e42d341f0a102a35743c1439fa125

commit a918d71efc4e42d341f0a102a35743c1439fa125
Author: wnwen <wnwen@chromium.org>
Date: Tue May 31 20:18:17 2016

Minor cleanup of launching document tabs.

BUG= 612245 , 509886 

Review-Url: https://codereview.chromium.org/2021913002
Cr-Commit-Position: refs/heads/master@{#396912}

[modify] https://crrev.com/a918d71efc4e42d341f0a102a35743c1439fa125/chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java
[modify] https://crrev.com/a918d71efc4e42d341f0a102a35743c1439fa125/chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java
[modify] https://crrev.com/a918d71efc4e42d341f0a102a35743c1439fa125/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java
[delete] https://crrev.com/c192fbb4329e5c5cf106d208ff359f5f085c34f2/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentMetricIds.java
[modify] https://crrev.com/a918d71efc4e42d341f0a102a35743c1439fa125/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentUtils.java
[modify] https://crrev.com/a918d71efc4e42d341f0a102a35743c1439fa125/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/AsyncTabCreationParams.java
[modify] https://crrev.com/a918d71efc4e42d341f0a102a35743c1439fa125/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/TabDelegate.java
[modify] https://crrev.com/a918d71efc4e42d341f0a102a35743c1439fa125/chrome/android/java_sources.gni
[modify] https://crrev.com/a918d71efc4e42d341f0a102a35743c1439fa125/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/tabmodel/document/MockTabDelegate.java

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/989b9ede81502507d5dc5bb8872f6535ce264d23

commit 989b9ede81502507d5dc5bb8872f6535ce264d23
Author: wnwen <wnwen@chromium.org>
Date: Wed Jul 13 16:17:07 2016

Remove obsolete flags.

- Remove command line flags enable-toolbar-swipe-in-document-mode and
  enable-tab-switcher-in-document-mode.

- Several corresponding methods in FeatureUtilities have become
  obsolete as it is no longer possible to have the tab switcher
  enabled in document mode.

BUG= 612245 

Review-Url: https://codereview.chromium.org/2141783002
Cr-Commit-Position: refs/heads/master@{#405177}

[modify] https://crrev.com/989b9ede81502507d5dc5bb8872f6535ce264d23/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/989b9ede81502507d5dc5bb8872f6535ce264d23/chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java
[modify] https://crrev.com/989b9ede81502507d5dc5bb8872f6535ce264d23/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChrome.java
[modify] https://crrev.com/989b9ede81502507d5dc5bb8872f6535ce264d23/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java
[modify] https://crrev.com/989b9ede81502507d5dc5bb8872f6535ce264d23/chrome/android/java/src/org/chromium/chrome/browser/device/DeviceClassManager.java
[modify] https://crrev.com/989b9ede81502507d5dc5bb8872f6535ce264d23/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarPhone.java
[modify] https://crrev.com/989b9ede81502507d5dc5bb8872f6535ce264d23/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
[modify] https://crrev.com/989b9ede81502507d5dc5bb8872f6535ce264d23/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java
[modify] https://crrev.com/989b9ede81502507d5dc5bb8872f6535ce264d23/chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java
[modify] https://crrev.com/989b9ede81502507d5dc5bb8872f6535ce264d23/chrome/browser/about_flags.cc
[modify] https://crrev.com/989b9ede81502507d5dc5bb8872f6535ce264d23/chrome/common/chrome_switches.cc
[modify] https://crrev.com/989b9ede81502507d5dc5bb8872f6535ce264d23/chrome/common/chrome_switches.h

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 13 2016

Labels: merge-merged-2795

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/989b9ede81502507d5dc5bb8872f6535ce264d23

commit 989b9ede81502507d5dc5bb8872f6535ce264d23
Author: wnwen <wnwen@chromium.org>
Date: Wed Jul 13 16:17:07 2016

Remove obsolete flags.

- Remove command line flags enable-toolbar-swipe-in-document-mode and
  enable-tab-switcher-in-document-mode.

- Several corresponding methods in FeatureUtilities have become
  obsolete as it is no longer possible to have the tab switcher
  enabled in document mode.

BUG= 612245 

Review-Url: https://codereview.chromium.org/2141783002
Cr-Commit-Position: refs/heads/master@{#405177}

[modify] https://crrev.com/989b9ede81502507d5dc5bb8872f6535ce264d23/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/989b9ede81502507d5dc5bb8872f6535ce264d23/chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java
[modify] https://crrev.com/989b9ede81502507d5dc5bb8872f6535ce264d23/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChrome.java
[modify] https://crrev.com/989b9ede81502507d5dc5bb8872f6535ce264d23/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java
[modify] https://crrev.com/989b9ede81502507d5dc5bb8872f6535ce264d23/chrome/android/java/src/org/chromium/chrome/browser/device/DeviceClassManager.java
[modify] https://crrev.com/989b9ede81502507d5dc5bb8872f6535ce264d23/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarPhone.java
[modify] https://crrev.com/989b9ede81502507d5dc5bb8872f6535ce264d23/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
[modify] https://crrev.com/989b9ede81502507d5dc5bb8872f6535ce264d23/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java
[modify] https://crrev.com/989b9ede81502507d5dc5bb8872f6535ce264d23/chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java
[modify] https://crrev.com/989b9ede81502507d5dc5bb8872f6535ce264d23/chrome/browser/about_flags.cc
[modify] https://crrev.com/989b9ede81502507d5dc5bb8872f6535ce264d23/chrome/common/chrome_switches.cc
[modify] https://crrev.com/989b9ede81502507d5dc5bb8872f6535ce264d23/chrome/common/chrome_switches.h

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9e4e266162e7f49031beb67c2c087e19d370e78

commit d9e4e266162e7f49031beb67c2c087e19d370e78
Author: wnwen <wnwen@chromium.org>
Date: Mon Aug 15 13:46:28 2016

Clean up document-mode specific UI.

- showMenuButtonInOmnibox and hasVisibleViewsAfterUrlBarWhenUnfocused
  are now always false.

- FeatureUtilities.isDocumentMode is always false outside of
  migration and loading related code.

- shouldShowMenuButton is now always true.

- Tests no longer need any document mode conditionals.

BUG= 612245 

Review-Url: https://codereview.chromium.org/2229353003
Cr-Commit-Position: refs/heads/master@{#411959}

[modify] https://crrev.com/d9e4e266162e7f49031beb67c2c087e19d370e78/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java
[modify] https://crrev.com/d9e4e266162e7f49031beb67c2c087e19d370e78/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegate.java
[modify] https://crrev.com/d9e4e266162e7f49031beb67c2c087e19d370e78/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java
[modify] https://crrev.com/d9e4e266162e7f49031beb67c2c087e19d370e78/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarPhone.java
[modify] https://crrev.com/d9e4e266162e7f49031beb67c2c087e19d370e78/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java
[modify] https://crrev.com/d9e4e266162e7f49031beb67c2c087e19d370e78/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java
[modify] https://crrev.com/d9e4e266162e7f49031beb67c2c087e19d370e78/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
[modify] https://crrev.com/d9e4e266162e7f49031beb67c2c087e19d370e78/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java
[modify] https://crrev.com/d9e4e266162e7f49031beb67c2c087e19d370e78/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java
[modify] https://crrev.com/d9e4e266162e7f49031beb67c2c087e19d370e78/chrome/android/javatests/src/org/chromium/chrome/browser/PopupTest.java
[modify] https://crrev.com/d9e4e266162e7f49031beb67c2c087e19d370e78/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java
[modify] https://crrev.com/d9e4e266162e7f49031beb67c2c087e19d370e78/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
[modify] https://crrev.com/d9e4e266162e7f49031beb67c2c087e19d370e78/chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastSwitchVideoTest.java
[modify] https://crrev.com/d9e4e266162e7f49031beb67c2c087e19d370e78/chrome/android/javatests/src/org/chromium/chrome/browser/policy/CombinedPolicyProviderTest.java
[modify] https://crrev.com/d9e4e266162e7f49031beb67c2c087e19d370e78/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferencesTest.java
[modify] https://crrev.com/d9e4e266162e7f49031beb67c2c087e19d370e78/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/OpenTabsTest.java
[modify] https://crrev.com/d9e4e266162e7f49031beb67c2c087e19d370e78/chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeActivityTestCaseBase.java
[modify] https://crrev.com/d9e4e266162e7f49031beb67c2c087e19d370e78/chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeInstrumentationTestRunner.java
[modify] https://crrev.com/d9e4e266162e7f49031beb67c2c087e19d370e78/chrome/test/android/javatests/src/org/chromium/chrome/test/util/NewTabPageTestUtils.java

Project Member

Comment 10 by bugdroid1@chromium.org, Aug 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ee82a9e022622d1fc4c35719f9737e54ba60b2f

commit 0ee82a9e022622d1fc4c35719f9737e54ba60b2f
Author: wnwen <wnwen@chromium.org>
Date: Wed Aug 24 13:21:50 2016

Delete more document mode specific code.

- Clean-up unused UMA stats.

- Remove unreachable code in ChromeTabbedActivity and
  ChromeApplication.

- Remove unnecessary bookmark title setter.

- Clean-up incognito code specific to document mode.

BUG= 612245 

Review-Url: https://codereview.chromium.org/2270163002
Cr-Commit-Position: refs/heads/master@{#414060}

[modify] https://crrev.com/0ee82a9e022622d1fc4c35719f9737e54ba60b2f/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/0ee82a9e022622d1fc4c35719f9737e54ba60b2f/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
[modify] https://crrev.com/0ee82a9e022622d1fc4c35719f9737e54ba60b2f/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/0ee82a9e022622d1fc4c35719f9737e54ba60b2f/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkActivity.java
[modify] https://crrev.com/0ee82a9e022622d1fc4c35719f9737e54ba60b2f/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkAddEditFolderActivity.java
[modify] https://crrev.com/0ee82a9e022622d1fc4c35719f9737e54ba60b2f/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkFolderSelectActivity.java
[modify] https://crrev.com/0ee82a9e022622d1fc4c35719f9737e54ba60b2f/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java
[modify] https://crrev.com/0ee82a9e022622d1fc4c35719f9737e54ba60b2f/chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationService.java

Project Member

Comment 11 by bugdroid1@chromium.org, Sep 8 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/2914ef99329af9b28219537ebb731b3331b15b4e

commit 2914ef99329af9b28219537ebb731b3331b15b4e
Author: Peter Wen <wnwen@google.com>
Date: Thu Sep 08 14:07:19 2016

Project Member

Comment 12 by bugdroid1@chromium.org, Sep 8 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/2914ef99329af9b28219537ebb731b3331b15b4e

commit 2914ef99329af9b28219537ebb731b3331b15b4e
Author: Peter Wen <wnwen@google.com>
Date: Thu Sep 08 14:07:19 2016

Project Member

Comment 13 by bugdroid1@chromium.org, Sep 8 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/2914ef99329af9b28219537ebb731b3331b15b4e

commit 2914ef99329af9b28219537ebb731b3331b15b4e
Author: Peter Wen <wnwen@google.com>
Date: Thu Sep 08 14:07:19 2016

Project Member

Comment 14 by bugdroid1@chromium.org, Sep 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2660f43bc6c4012295e725ccac98ebb534e1d3d5

commit 2660f43bc6c4012295e725ccac98ebb534e1d3d5
Author: wnwen <wnwen@chromium.org>
Date: Tue Sep 13 13:26:57 2016

Remove DocumentMode usage histogram.

BUG= 612245 

Review-Url: https://codereview.chromium.org/2331123002
Cr-Commit-Position: refs/heads/master@{#418228}

[modify] https://crrev.com/2660f43bc6c4012295e725ccac98ebb534e1d3d5/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/2660f43bc6c4012295e725ccac98ebb534e1d3d5/chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java
[modify] https://crrev.com/2660f43bc6c4012295e725ccac98ebb534e1d3d5/chrome/browser/android/feature_utilities.cc
[modify] https://crrev.com/2660f43bc6c4012295e725ccac98ebb534e1d3d5/chrome/browser/android/feature_utilities.h
[modify] https://crrev.com/2660f43bc6c4012295e725ccac98ebb534e1d3d5/chrome/browser/metrics/android_metrics_provider.cc
[modify] https://crrev.com/2660f43bc6c4012295e725ccac98ebb534e1d3d5/tools/metrics/histograms/histograms.xml

Comment 15 by wnwen@chromium.org, Sep 13 2016

Status: Fixed (was: Assigned)

►

Issue 612245 link

Issue metadata

Delete unused DocumentMode code

Issue description

Comment 1 by wnwen@chromium.org, May 16 2016

Comment 1 Deleted

Comment 2 by wnwen@chromium.org, May 16 2016

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, May 17 2016

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, May 27 2016

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, May 27 2016

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, May 31 2016

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Jul 13 2016

Comment 7 Deleted

Comment 8 by bugdroid1@chromium.org, Jul 13 2016

Comment 8 Deleted

Comment 9 by bugdroid1@chromium.org, Aug 15 2016

Comment 9 Deleted

Comment 10 by bugdroid1@chromium.org, Aug 24 2016

Comment 10 Deleted

Comment 11 by bugdroid1@chromium.org, Sep 8 2016

Comment 11 Deleted

Comment 12 by bugdroid1@chromium.org, Sep 8 2016

Comment 12 Deleted

Comment 13 by bugdroid1@chromium.org, Sep 8 2016

Comment 13 Deleted

Comment 14 by bugdroid1@chromium.org, Sep 13 2016

Comment 14 Deleted

Comment 15 by wnwen@chromium.org, Sep 13 2016

Comment 15 Deleted

Sign in to add a comment