mus needs to provide a DisplayConfigurator mojom for configuring the attached displays
First step in this bug is to define the necessary API surface to support the code we will find in mash / sysui.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/97a62c38c3f2d818c24190d3495853c3de8c7273 commit 97a62c38c3f2d818c24190d3495853c3de8c7273 Author: kylechar <kylechar@chromium.org> Date: Tue Jul 19 18:09:44 2016 Add a mojom/StructTrait for display::Display. There is currently a mojom that mostly corresponds to display::Display and a corresponding TypeConverter. However, the existing mojom has some extra information that is mus specific. In the future ui.mojom.Display will be modified to contain a display.mojom.Display to avoid duplication. This CL only adds the new mojom, StructTrait and unit tests to ensure StructTrait works correctly. The new mojom and StructTrait will be needed for the DisplayController Mojo interface to allow display configuration to happen. Unit tests will be added to trybots in a follow-up CL. BUG= 612242 Review-Url: https://codereview.chromium.org/2123613002 Cr-Commit-Position: refs/heads/master@{#406319} [modify] https://crrev.com/97a62c38c3f2d818c24190d3495853c3de8c7273/mojo/public/tools/bindings/chromium_bindings_configuration.gni [modify] https://crrev.com/97a62c38c3f2d818c24190d3495853c3de8c7273/services/ui/public/interfaces/BUILD.gn [add] https://crrev.com/97a62c38c3f2d818c24190d3495853c3de8c7273/services/ui/public/interfaces/display/BUILD.gn [add] https://crrev.com/97a62c38c3f2d818c24190d3495853c3de8c7273/services/ui/public/interfaces/display/OWNERS [add] https://crrev.com/97a62c38c3f2d818c24190d3495853c3de8c7273/services/ui/public/interfaces/display/display.mojom [add] https://crrev.com/97a62c38c3f2d818c24190d3495853c3de8c7273/services/ui/public/interfaces/display/display.typemap [add] https://crrev.com/97a62c38c3f2d818c24190d3495853c3de8c7273/services/ui/public/interfaces/display/display_struct_traits.cc [add] https://crrev.com/97a62c38c3f2d818c24190d3495853c3de8c7273/services/ui/public/interfaces/display/display_struct_traits.h [add] https://crrev.com/97a62c38c3f2d818c24190d3495853c3de8c7273/services/ui/public/interfaces/display/display_struct_traits_test.mojom [add] https://crrev.com/97a62c38c3f2d818c24190d3495853c3de8c7273/services/ui/public/interfaces/display/display_struct_traits_unittest.cc [add] https://crrev.com/97a62c38c3f2d818c24190d3495853c3de8c7273/services/ui/public/interfaces/display/typemaps.gni [modify] https://crrev.com/97a62c38c3f2d818c24190d3495853c3de8c7273/ui/display/DEPS [modify] https://crrev.com/97a62c38c3f2d818c24190d3495853c3de8c7273/ui/display/display.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/24ff7b7d6909448813aa15c0f9a2da2a4ce32af0 commit 24ff7b7d6909448813aa15c0f9a2da2a4ce32af0 Author: kylechar <kylechar@chromium.org> Date: Tue Oct 18 15:59:05 2016 Expand and split DisplayController mojom. Add two IPC calls to mojom::DisplayController. The first is to enable a keyboard shortcut for swapping primary display from ash. This is part of the existing developer shortcuts and will enable testing primary display work. Second, add a call to let ash to set the display workarea. The workarea IPC call needs to be implemented on the ash side. Split the existing IPC call to toggle adding/removing a fake display into a new test interface. Fix the way mus specific keyboard accelerators in ash work. The accelerators were being triggered from HandlesAction() which is wrong. Instead trigger accelerators from PerformAction(). BUG= 612242 Review-Url: https://codereview.chromium.org/2415163002 Cr-Commit-Position: refs/heads/master@{#425977} [modify] https://crrev.com/24ff7b7d6909448813aa15c0f9a2da2a4ce32af0/ash/mus/accelerators/accelerator_controller_delegate_mus.cc [modify] https://crrev.com/24ff7b7d6909448813aa15c0f9a2da2a4ce32af0/services/ui/display/platform_screen_ozone.cc [modify] https://crrev.com/24ff7b7d6909448813aa15c0f9a2da2a4ce32af0/services/ui/display/platform_screen_ozone.h [modify] https://crrev.com/24ff7b7d6909448813aa15c0f9a2da2a4ce32af0/services/ui/manifest.json [modify] https://crrev.com/24ff7b7d6909448813aa15c0f9a2da2a4ce32af0/services/ui/public/interfaces/display/BUILD.gn [modify] https://crrev.com/24ff7b7d6909448813aa15c0f9a2da2a4ce32af0/services/ui/public/interfaces/display/display_controller.mojom [add] https://crrev.com/24ff7b7d6909448813aa15c0f9a2da2a4ce32af0/services/ui/public/interfaces/display/test_display_controller.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef3c1eb093c6c7f93eb8cb8f06d39dfa9152bcc4 commit ef3c1eb093c6c7f93eb8cb8f06d39dfa9152bcc4 Author: kylechar <kylechar@chromium.org> Date: Thu Dec 01 22:55:46 2016 Add IPCs for ash display shortcuts. Add the IPCs and wire the ash keyboard shortcuts in mash. All IPCs are fire and forget. There is no implementation on the mus side yet, just stub methods. BUG= 612242 Review-Url: https://codereview.chromium.org/2537643008 Cr-Commit-Position: refs/heads/master@{#435748} [modify] https://crrev.com/ef3c1eb093c6c7f93eb8cb8f06d39dfa9152bcc4/ash/mus/accelerators/accelerator_controller_delegate_mus.cc [modify] https://crrev.com/ef3c1eb093c6c7f93eb8cb8f06d39dfa9152bcc4/ash/mus/accelerators/accelerator_controller_delegate_mus.h [modify] https://crrev.com/ef3c1eb093c6c7f93eb8cb8f06d39dfa9152bcc4/services/ui/display/screen_manager_ozone.cc [modify] https://crrev.com/ef3c1eb093c6c7f93eb8cb8f06d39dfa9152bcc4/services/ui/display/screen_manager_ozone.h [modify] https://crrev.com/ef3c1eb093c6c7f93eb8cb8f06d39dfa9152bcc4/services/ui/public/interfaces/display/display_controller.mojom
Is this still relevant with simplified display management?
There needs to DisplayConfigurationController-ish mojom for mustash chrome to ash communication. I think this can be safely closed thuogh.
Comment 1 by rjkroege@chromium.org
, May 17 2016Status: Assigned (was: Available)
Summary: define ScreenConfigurator mojom (was: create DisplayConfigurator mojom)