New issue
Advanced search Search tips

Issue 612240 link

Starred by 1 user
Status: Fixed
Owner:
csharrison@chromium.org
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

PredictorBrowserTest.CrossSiteSimplePredictionAfterTwoNavigations2 fails under DrMemory

Project Member Reported by csharrison@chromium.org, May 16 2016 
Relevant log lines:

[ RUN      ] PredictorBrowserTest.CrossSiteSimplePredictionAfterTwoNavigations2

[4884:3736:0516/012647:WARNING:chrome_browser_main_win.cc(420)] Command line too long for RegisterApplicationRestart

[4884:1132:0516/012932:WARNING:embedded_test_server.cc(190)] Request not handled. Returning 404: /favicon.ico

c:\b\build\slave\drm-cr\build\src\chrome\browser\net\predictor_browsertest.cc(906): error: Value of: observer()->CrossSitePreconnected()

  Actual: 0

Expected: 4

[15/26] PredictorBrowserTest.CrossSiteSimplePredictionAfterTwoNavigations2 (TIMED OUT)
Project Member

Comment 1 by bugdroid1@chromium.org, May 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fee59f9f4cf1ebbc6f208fc6b823fa6cf1385518

commit fee59f9f4cf1ebbc6f208fc6b823fa6cf1385518
Author: csharrison <csharrison@chromium.org>
Date: Mon May 16 21:17:49 2016

Add learning expectations to predictor browsertests

This patch adds some EXPECT calls to investigate DrMemory test failures.

The hypothesis is that the tests are so slow to run that by the time a
URLRequest starts, the navigation that triggered happened over 10s ago.
This would cause the predictor to not learn the request relationship.

BUG= 612240 

Review-Url: https://codereview.chromium.org/1978383002
Cr-Commit-Position: refs/heads/master@{#393929}

[modify] https://crrev.com/fee59f9f4cf1ebbc6f208fc6b823fa6cf1385518/chrome/browser/net/predictor_browsertest.cc

Comment 2 by csharrison@chromium.org, May 17 2016

Status: Fixed (was: Started)
The expectations were triggering failures, indicating timeouts in the 10 second limit in TimedCache.

The tests are now skipped on DrMemory bots.
►

Sign in to add a comment