New issue
Advanced search Search tips

Issue 612231 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

CQ doesn't pickup CLs from new aosp/platform/* repos

Project Member Reported by de...@chromium.org, May 16 2016

Issue description

This CL:
https://chromium-review.googlesource.com/#/c/344601/

is in the aosp/platform/external/libbrillo repo in the chromium gerrit instance; the repo is in the external and internal manifest but the CQ is not picking up those changes, nor there's a SUBMIT button in the CL to chump it.

(Manifest: https://chromium.googlesource.com/chromiumos/manifest/+/master/full.xml#39 )

An ACL change to make "aosp/" repo inherit from "chromiumos/" landed today, but the CQ still doesn't pick them up. Any other ideas?
 

Comment 1 by de...@chromium.org, May 17 2016

https://chromium-review.googlesource.com/#/c/344601/ still not picked up by the CQ. Do you see a "Submit" button in that CL? That should be independent from the CQ issue.
The pre-cq launcher needs to be reset to pick up the new chromite code. I'll do that now.
06:38:53: WARNING: git push failed for /b/cbuild/internal_master/src/aosp/system/connectivity/shill:master; was a change chumped in the middle of the CQ run?
Traceback (most recent call last):
  File "/b/cbuild/internal_master/chromite/cbuildbot/validation_pool.py", line 2076, in PushRepoBranch
    git.GitPush(repo, 'HEAD', push_to, skip=self.dryrun)
  File "/b/cbuild/internal_master/chromite/lib/git.py", line 1250, in GitPush
    RunGit(git_repo, cmd, retry=retry, capture_output=capture_output)
  File "/b/cbuild/internal_master/chromite/lib/git.py", line 829, in RunGit
    ['git'] + cmd, **kwargs)
  File "/b/cbuild/internal_master/chromite/lib/retry_util.py", line 88, in GenericRetry
    ret = functor(*args, **kwargs)
  File "/b/cbuild/internal_master/chromite/lib/cros_build_lib.py", line 619, in RunCommand
    raise RunCommandError(msg, cmd_result)
RunCommandError: return code: 1; command: git push https://chromium-review.googlesource.com/aosp/platform/system/connectivity/shill HEAD:master
remote: 
remote: Processing changes: refs: 1        
remote: Processing changes: refs: 1, done            
To https://chromium-review.googlesource.com/aosp/platform/system/connectivity/shill
 ! [remote rejected] HEAD -> master (prohibited by Gerrit)
error: failed to push some refs to 'https://chromium-review.googlesource.com/aosp/platform/system/connectivity/shill'

Trying to normalize aosp ACLs with the rest of chromiumos repos. https://chromium-review.googlesource.com/#/c/344742/

Comment 6 by de...@chromium.org, May 18 2016

looks like fixed now; need to double check that the last CL didn't break the mirroring.

Comment 7 by de...@chromium.org, May 24 2016

Status: Fixed (was: Assigned)
Status: Available (was: Fixed)
Do we have a bug open about the IsBranchable behavior? Still want to fix that before the next branch cut.
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/5cd848ff671b97d5c0e73062219026fde5b56e34

commit 5cd848ff671b97d5c0e73062219026fde5b56e34
Author: Aviv Keshet <akeshet@chromium.org>
Date: Tue May 31 19:41:40 2016

chromeos_config: make aosp/ projects branchable

BUG= chromium:612231 
TEST=manual test of re

Change-Id: Ia61d26cb6b7b92c095926e32120e51f1c43380a8
Reviewed-on: https://chromium-review.googlesource.com/348382
Commit-Ready: Aviv Keshet <akeshet@chromium.org>
Tested-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/5cd848ff671b97d5c0e73062219026fde5b56e34/cbuildbot/config_lib.py
[modify] https://crrev.com/5cd848ff671b97d5c0e73062219026fde5b56e34/cbuildbot/chromeos_config.py

Status: Assigned (was: Available)
There's an owner on this bug but the status != Assigned. Fixing. If you feel you don't own this bug, please remove yourself as the owner and mark it as "Available" or "Untriaged".
Components: Infra>Client>ChromeOS
Components: -Infra
Status: Fixed (was: Assigned)

Sign in to add a comment