Issue 612220 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	ajuma@chromium.org
Closed:	Jun 2016
Cc:	weiliangc@chromium.org █ vollick@chromium.org ajuma@chromium.org sunxd@chromium.org █ jaydasika@chromium.org
Components:	Internals>Compositing
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Feature

Blocking:
issue 611883

Make effect nodes aware of masks and replicas

Project Member Reported by ajuma@chromium.org, May 16 2016

Issue description

We currently using the owning layer of a render surface in order to find its mask and replica layers (e.g. in LTI::UpdateDrawProperties). This information needs to be added to effect nodes (though replica layers will hopefully go away once  bug 436475  is finished).

Comment 1 by ajuma@chromium.org, May 31 2016

Owner: ajuma@chromium.org
Status: Started (was: Available)

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db6216f2c2373d41f56f495b5da1c7f55e7cbc36

commit db6216f2c2373d41f56f495b5da1c7f55e7cbc36
Author: ajuma <ajuma@chromium.org>
Date: Tue Jun 07 21:44:05 2016

cc: Compute mask draw properties directly

This computes draw properties for mask layers directly rather than
by using the mask's owning layer's draw properties. This is a step
towards moving mask ownership to effect nodes from layers.

BUG= 612220 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2048723002
Cr-Commit-Position: refs/heads/master@{#398390}

[modify] https://crrev.com/db6216f2c2373d41f56f495b5da1c7f55e7cbc36/cc/trees/draw_property_utils.cc
[modify] https://crrev.com/db6216f2c2373d41f56f495b5da1c7f55e7cbc36/cc/trees/draw_property_utils.h
[modify] https://crrev.com/db6216f2c2373d41f56f495b5da1c7f55e7cbc36/cc/trees/layer_tree_host_common.cc
[modify] https://crrev.com/db6216f2c2373d41f56f495b5da1c7f55e7cbc36/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/db6216f2c2373d41f56f495b5da1c7f55e7cbc36/cc/trees/property_tree_builder.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d4026a36391cbac48d3d5fec5fe4a958807bea5

commit 1d4026a36391cbac48d3d5fec5fe4a958807bea5
Author: ajuma <ajuma@chromium.org>
Date: Tue Jun 14 13:18:50 2016

cc: Add mask and replica layer ids to the effect tree

This adds mask, replica, and replica mask layer ids to effect nodes,
removes mask_layer and replica_layer from LayerImpl, and adds
mask_layer and replica_layer to LayerImplTestProperties. With this
change, render surfaces can determine if they have a mask or replica
using their effect node rather than using their owning layer.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
BUG= 612220 

Review-Url: https://codereview.chromium.org/2035863003
Cr-Commit-Position: refs/heads/master@{#399690}

[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/debug/debug_rect_history.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/layers/layer_impl.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/layers/layer_impl.h
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/layers/layer_impl_test_properties.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/layers/layer_impl_test_properties.h
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/layers/layer_impl_unittest.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/layers/picture_layer_impl_unittest.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/layers/render_surface_impl.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/layers/render_surface_impl.h
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/layers/render_surface_impl_unittest.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/proto/property_tree.proto
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/test/layer_test_common.h
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/trees/damage_tracker.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/trees/damage_tracker_unittest.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/trees/draw_property_utils.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/trees/layer_tree_host_common.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/trees/layer_tree_host_common.h
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/trees/layer_tree_host_unittest_occlusion.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/trees/layer_tree_impl.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/trees/layer_tree_impl_unittest.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/trees/occlusion_tracker.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/trees/occlusion_tracker_unittest.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/trees/property_tree.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/trees/property_tree.h
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/trees/property_tree_builder.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/trees/property_tree_unittest.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/trees/tree_synchronizer.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/trees/tree_synchronizer_unittest.cc

Comment 4 by ajuma@chromium.org, Jun 14 2016

Status: Fixed (was: Started)

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d4026a36391cbac48d3d5fec5fe4a958807bea5

commit 1d4026a36391cbac48d3d5fec5fe4a958807bea5
Author: ajuma <ajuma@chromium.org>
Date: Tue Jun 14 13:18:50 2016

cc: Add mask and replica layer ids to the effect tree

This adds mask, replica, and replica mask layer ids to effect nodes,
removes mask_layer and replica_layer from LayerImpl, and adds
mask_layer and replica_layer to LayerImplTestProperties. With this
change, render surfaces can determine if they have a mask or replica
using their effect node rather than using their owning layer.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
BUG= 612220 

Review-Url: https://codereview.chromium.org/2035863003
Cr-Commit-Position: refs/heads/master@{#399690}

[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/debug/debug_rect_history.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/layers/layer_impl.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/layers/layer_impl.h
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/layers/layer_impl_test_properties.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/layers/layer_impl_test_properties.h
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/layers/layer_impl_unittest.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/layers/picture_layer_impl_unittest.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/layers/render_surface_impl.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/layers/render_surface_impl.h
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/layers/render_surface_impl_unittest.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/proto/property_tree.proto
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/test/layer_test_common.h
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/trees/damage_tracker.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/trees/damage_tracker_unittest.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/trees/draw_property_utils.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/trees/layer_tree_host_common.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/trees/layer_tree_host_common.h
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/trees/layer_tree_host_unittest_occlusion.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/trees/layer_tree_impl.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/trees/layer_tree_impl_unittest.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/trees/occlusion_tracker.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/trees/occlusion_tracker_unittest.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/trees/property_tree.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/trees/property_tree.h
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/trees/property_tree_builder.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/trees/property_tree_unittest.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/trees/tree_synchronizer.cc
[modify] https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5/cc/trees/tree_synchronizer_unittest.cc

►

Issue 612220 link

Issue metadata

Make effect nodes aware of masks and replicas

Issue description

Comment 1 by ajuma@chromium.org, May 31 2016

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Jun 7 2016

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Jun 14 2016

Comment 3 Deleted

Comment 4 by ajuma@chromium.org, Jun 14 2016

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Jun 15 2016

Comment 5 Deleted

Sign in to add a comment