New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 612214 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug

Blocking:
issue 453195



Sign in to add a comment

[Slave request] for LTO Perf builders

Project Member Reported by krasin@chromium.org, May 16 2016

Issue description

Please, allocate 30 slaves on GCE (n1-standard-32 type) for LTO Linux builders to support LTO launch on Linux.

The plan is to first put these slaves on https://build.chromium.org/p/chromium.fyi/builders/LTO Linux Perf and see if it keeps up with the incoming CLs. Then move the slaves to the real perf builder: https://build.chromium.org/p/chromium.perf/builders/Linux%20Builder and enable LTO for official builds by default.

Currently, LTO Linux Perf bot runs for ~47 minutes (41-53 mins range). With ~35 CLs per hour in the rush time, 30 slaves should be enough to handle the stream.
 

Comment 1 by krasin@chromium.org, May 16 2016

Summary: [Slave request] for LTO Perf builders (was: [Slave request] for LTO Perf bots)

Comment 2 by vhang@google.com, May 16 2016

Owner: jo...@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by krasin@chromium.org, May 16 2016

Oh, I made a typo. We need n1-highmem-32. LTO eats tons of RAM.

Comment 4 by vhang@google.com, May 17 2016

Cc: abw@chromium.org
+abw for approval

Comment 5 by jo...@chromium.org, May 17 2016

Cc: hinoka@chromium.org

Comment 6 by jo...@chromium.org, May 17 2016

Note: This request represents a total of 960 cores

Comment 7 by krasin@chromium.org, May 17 2016

This is correct. See also https://crbug.com/598011, where bare metal bots were upgraded. This is a GCE counterpart.

LTO is a costful feature (at least now, while ThinLTO is still in its infancy), but these costs for this particular launch (LTO and then CFI on Linux) was approved by mal@, as the benefits seem worthwhile: faster Chrome (if built with LTO) and more secure Chrome when CFI is enabled (LTO is a prerequisite for CFI).

Comment 9 by krasin@chromium.org, May 17 2016

friendly ping
Blocking: 453195
Labels: -Pri-2 Pri-1

Comment 12 by abw@chromium.org, May 18 2016

Approved ! We love this project, it is worth every cent.
Thank you, Adam!
Project Member

Comment 14 by bugdroid1@chromium.org, May 18 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal.git/+/a560a24c8c35a38661b6875c367ed20ef96496ba

commit a560a24c8c35a38661b6875c367ed20ef96496ba
Author: johnw <johnw@google.com>
Date: Wed May 18 22:07:22 2016

Thank you, John. Adding these slaves to 'LTO Linux Perf':
https://codereview.chromium.org/1992083002/

I will give them to run on Chromium.FYI for a day and if we see it can keep up with the incoming CL traffic, I will move them to Chromium.Perf:
https://build.chromium.org/p/chromium.perf/builders/Linux%20Builder

This will actually 'free' 5 existing slaves.
Project Member

Comment 16 by bugdroid1@chromium.org, May 18 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal.git/+/8f0d6317db158033b21eadc640e896cc3bea7728

commit 8f0d6317db158033b21eadc640e896cc3bea7728
Author: johnw <johnw@google.com>
Date: Wed May 18 23:34:33 2016

Project Member

Comment 17 by bugdroid1@chromium.org, May 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/4b00862ef7c87ecd73c5e40de4c8a1be097b8dbf

commit 4b00862ef7c87ecd73c5e40de4c8a1be097b8dbf
Author: krasin@google.com <krasin@google.com>
Date: Wed May 18 23:53:05 2016

Add 30 more slaves into 'LTO Linux Perf' buildbot.

The goal is to verify that we can (on average) have a build for every Chromium CL.
If that's true, these slaves will be moved to the real Perf Linux Builder:
https://build.chromium.org/p/chromium.perf/builders/Linux%20Builder

and then LTO will be launched on Linux.

BUG= 453195 , 612214 

Review-Url: https://codereview.chromium.org/1992083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@300641 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/4b00862ef7c87ecd73c5e40de4c8a1be097b8dbf/masters/master.chromium.fyi/slaves.cfg
[modify] https://crrev.com/4b00862ef7c87ecd73c5e40de4c8a1be097b8dbf/scripts/slave/compile.py

Slaves are granted. After chromium.fyi master restart (hopefully, EOD today), they will start building for 'LTO Linux Perf' bot. If everything goes well, I will switch them to the real Linux Perf builders tomorrow. That gives a chance to launch LTO on Friday, which likely means Monday to avoid unnecessary surprises.
Project Member

Comment 19 by bugdroid1@chromium.org, May 19 2016

The following revision refers to this bug:
  http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=88029

------------------------------------------------------------------
r88029 | recipe-roller@chromium.org | 2016-05-19T00:03:10.287391Z

-----------------------------------------------------------------
Status: Fixed (was: Assigned)

Sign in to add a comment