New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 612208 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature

Blocking:
issue 611883



Sign in to add a comment

Move copy request ownership from LayerImpl to effect nodes

Project Member Reported by ajuma@chromium.org, May 16 2016

Issue description

Currently, LTHI::CalculateRenderPasses gets copy request information from the owning layer of render surfaces. In order to remove the assumption that surfaces are owned by layers, this information needs to be moved to the effect tree.
 

Comment 1 by ajuma@chromium.org, May 18 2016

Labels: -OS-Linux OS-All
Owner: ajuma@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, May 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6f541bee0d43857dd85bb60479635d0c2810afc

commit e6f541bee0d43857dd85bb60479635d0c2810afc
Author: ajuma <ajuma@chromium.org>
Date: Tue May 31 16:50:50 2016

cc: Move copy requests from layers to the effect tree

This makes the effect tree own copy requests. Clients still add copy
requests to individual Layers, but these are moved to the effect tree
at property-tree-building time, and then pushed with the effect tree
during commit and activation. This is a step towards removing the
dependency of RenderSurfaceImpls on their owning LayerImpl.

BUG= 612208 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2017263002
Cr-Commit-Position: refs/heads/master@{#396848}

[modify] https://crrev.com/e6f541bee0d43857dd85bb60479635d0c2810afc/cc/layers/layer.cc
[modify] https://crrev.com/e6f541bee0d43857dd85bb60479635d0c2810afc/cc/layers/layer.h
[modify] https://crrev.com/e6f541bee0d43857dd85bb60479635d0c2810afc/cc/layers/layer_impl.cc
[modify] https://crrev.com/e6f541bee0d43857dd85bb60479635d0c2810afc/cc/layers/layer_impl.h
[modify] https://crrev.com/e6f541bee0d43857dd85bb60479635d0c2810afc/cc/layers/layer_impl_test_properties.cc
[modify] https://crrev.com/e6f541bee0d43857dd85bb60479635d0c2810afc/cc/layers/layer_impl_test_properties.h
[modify] https://crrev.com/e6f541bee0d43857dd85bb60479635d0c2810afc/cc/layers/render_surface_impl.cc
[modify] https://crrev.com/e6f541bee0d43857dd85bb60479635d0c2810afc/cc/layers/render_surface_impl.h
[modify] https://crrev.com/e6f541bee0d43857dd85bb60479635d0c2810afc/cc/test/fake_layer_tree_host.cc
[modify] https://crrev.com/e6f541bee0d43857dd85bb60479635d0c2810afc/cc/test/layer_test_common.cc
[modify] https://crrev.com/e6f541bee0d43857dd85bb60479635d0c2810afc/cc/trees/draw_property_utils.cc
[modify] https://crrev.com/e6f541bee0d43857dd85bb60479635d0c2810afc/cc/trees/layer_tree_host.cc
[modify] https://crrev.com/e6f541bee0d43857dd85bb60479635d0c2810afc/cc/trees/layer_tree_host_common.cc
[modify] https://crrev.com/e6f541bee0d43857dd85bb60479635d0c2810afc/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/e6f541bee0d43857dd85bb60479635d0c2810afc/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/e6f541bee0d43857dd85bb60479635d0c2810afc/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/e6f541bee0d43857dd85bb60479635d0c2810afc/cc/trees/layer_tree_impl.cc
[modify] https://crrev.com/e6f541bee0d43857dd85bb60479635d0c2810afc/cc/trees/layer_tree_impl.h
[modify] https://crrev.com/e6f541bee0d43857dd85bb60479635d0c2810afc/cc/trees/occlusion_tracker.cc
[modify] https://crrev.com/e6f541bee0d43857dd85bb60479635d0c2810afc/cc/trees/occlusion_tracker_unittest.cc
[modify] https://crrev.com/e6f541bee0d43857dd85bb60479635d0c2810afc/cc/trees/property_tree.cc
[modify] https://crrev.com/e6f541bee0d43857dd85bb60479635d0c2810afc/cc/trees/property_tree.h
[modify] https://crrev.com/e6f541bee0d43857dd85bb60479635d0c2810afc/cc/trees/property_tree_builder.cc

Comment 3 by ajuma@chromium.org, May 31 2016

Status: Fixed (was: Started)

Sign in to add a comment