New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 612205 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 429053



Sign in to add a comment

Implement compressed texture format support on Mac with core profile

Project Member Reported by zmo@chromium.org, May 16 2016

Issue description

It is part of ES3 core functionality, and unfortunately, it's missing on Mac. We will have to support them in software
 
Owner: geoffl...@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/6e4cfceb80110f24d7986a7bbd2015b4b616fb4d

commit 6e4cfceb80110f24d7986a7bbd2015b4b616fb4d
Author: Geoff Lang <geofflang@chromium.org>
Date: Mon Jun 13 19:06:31 2016

Refactor ANGLE's image manipulation code into a static library.

Allows for chromium to make use of some of the functionality.

BUG= 612205 

Change-Id: Ib4435ca44775a3a554b0fb3bd384bd4d31d7952d
Reviewed-on: https://chromium-review.googlesource.com/351753
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

[modify] https://crrev.com/6e4cfceb80110f24d7986a7bbd2015b4b616fb4d/src/common/mathutil.h
[add] https://crrev.com/6e4cfceb80110f24d7986a7bbd2015b4b616fb4d/src/image_util/generatemip.h
[add] https://crrev.com/6e4cfceb80110f24d7986a7bbd2015b4b616fb4d/src/common/Color.h
[delete] https://crrev.com/91d569454714b56de957db00f99b23fb6b44827a/src/libANGLE/renderer/d3d/generatemip.h
[add] https://crrev.com/6e4cfceb80110f24d7986a7bbd2015b4b616fb4d/src/image_util/loadimage_sse2.cpp
[rename] https://crrev.com/6e4cfceb80110f24d7986a7bbd2015b4b616fb4d/src/image_util/loadimage.inl
[modify] https://crrev.com/6e4cfceb80110f24d7986a7bbd2015b4b616fb4d/src/tests/gl_tests/SixteenBppTextureTest.cpp
[add] https://crrev.com/6e4cfceb80110f24d7986a7bbd2015b4b616fb4d/src/common/Color.inl
[add] https://crrev.com/6e4cfceb80110f24d7986a7bbd2015b4b616fb4d/src/image_util/imageformats.h
[rename] https://crrev.com/6e4cfceb80110f24d7986a7bbd2015b4b616fb4d/src/image_util/generatemip.inl
[modify] https://crrev.com/6e4cfceb80110f24d7986a7bbd2015b4b616fb4d/src/libANGLE/renderer/d3d/d3d11/gen_texture_format_table.py
[modify] https://crrev.com/6e4cfceb80110f24d7986a7bbd2015b4b616fb4d/src/libANGLE/renderer/d3d/d3d9/renderer9_utils.h
[modify] https://crrev.com/6e4cfceb80110f24d7986a7bbd2015b4b616fb4d/src/tests/gl_tests/D3DImageFormatConversionTest.cpp
[add] https://crrev.com/6e4cfceb80110f24d7986a7bbd2015b4b616fb4d/src/image_util/loadimage.h
[modify] https://crrev.com/6e4cfceb80110f24d7986a7bbd2015b4b616fb4d/src/libANGLE/State.h
[delete] https://crrev.com/91d569454714b56de957db00f99b23fb6b44827a/src/libANGLE/renderer/d3d/loadimage.cpp
[modify] https://crrev.com/6e4cfceb80110f24d7986a7bbd2015b4b616fb4d/src/angle.gyp
[modify] https://crrev.com/6e4cfceb80110f24d7986a7bbd2015b4b616fb4d/src/libANGLE/renderer/d3d/d3d11/load_functions_table_autogen.cpp
[modify] https://crrev.com/6e4cfceb80110f24d7986a7bbd2015b4b616fb4d/src/libANGLE/angletypes.h
[delete] https://crrev.com/91d569454714b56de957db00f99b23fb6b44827a/src/libANGLE/renderer/d3d/loadimage.h
[modify] https://crrev.com/6e4cfceb80110f24d7986a7bbd2015b4b616fb4d/src/libANGLE/renderer/d3d/d3d11/gen_load_functions_table.py
[delete] https://crrev.com/91d569454714b56de957db00f99b23fb6b44827a/src/libANGLE/renderer/d3d/loadimageSSE2.cpp
[modify] https://crrev.com/6e4cfceb80110f24d7986a7bbd2015b4b616fb4d/src/libANGLE/renderer/d3d/FramebufferD3D.h
[modify] https://crrev.com/6e4cfceb80110f24d7986a7bbd2015b4b616fb4d/src/libANGLE/renderer/d3d/d3d11/formatutils11.cpp
[modify] https://crrev.com/6e4cfceb80110f24d7986a7bbd2015b4b616fb4d/src/libANGLE/angletypes.inl
[rename] https://crrev.com/6e4cfceb80110f24d7986a7bbd2015b4b616fb4d/src/image_util/copyimage.cpp
[rename] https://crrev.com/6e4cfceb80110f24d7986a7bbd2015b4b616fb4d/src/image_util/copyimage.h
[delete] https://crrev.com/91d569454714b56de957db00f99b23fb6b44827a/src/libANGLE/renderer/imageformats.h
[modify] https://crrev.com/6e4cfceb80110f24d7986a7bbd2015b4b616fb4d/src/libANGLE/renderer/d3d/d3d9/formatutils9.cpp
[modify] https://crrev.com/6e4cfceb80110f24d7986a7bbd2015b4b616fb4d/src/libANGLE/renderer/renderer_utils.cpp
[add] https://crrev.com/6e4cfceb80110f24d7986a7bbd2015b4b616fb4d/src/image_util/imageformats.cpp
[add] https://crrev.com/6e4cfceb80110f24d7986a7bbd2015b4b616fb4d/src/image_util/loadimage.cpp
[modify] https://crrev.com/6e4cfceb80110f24d7986a7bbd2015b4b616fb4d/BUILD.gn
[modify] https://crrev.com/6e4cfceb80110f24d7986a7bbd2015b4b616fb4d/src/libGLESv2.gypi
[modify] https://crrev.com/6e4cfceb80110f24d7986a7bbd2015b4b616fb4d/src/libANGLE/renderer/d3d/d3d11/texture_format_table_autogen.cpp
[delete] https://crrev.com/91d569454714b56de957db00f99b23fb6b44827a/src/libANGLE/renderer/d3d/loadimage_etc.h
[rename] https://crrev.com/6e4cfceb80110f24d7986a7bbd2015b4b616fb4d/src/image_util/copyimage.inl
[rename] https://crrev.com/6e4cfceb80110f24d7986a7bbd2015b4b616fb4d/src/image_util/loadimage_etc.cpp
[modify] https://crrev.com/6e4cfceb80110f24d7986a7bbd2015b4b616fb4d/src/libANGLE/renderer/d3d/d3d11/renderer11_utils.h

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f88ffc45920456f0840acf3299c0a5e24bdebc9

commit 6f88ffc45920456f0840acf3299c0a5e24bdebc9
Author: geofflang <geofflang@chromium.org>
Date: Tue Jul 05 16:21:08 2016

Roll ANGLE 474a08c..3820e9c

https://chromium.googlesource.com/angle/angle.git/+log/474a08c..3820e9c

BUG= chromium:625363 , 612205 , chromium:616176 , 407309 

TBR=jmadill@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2126623002
Cr-Commit-Position: refs/heads/master@{#403788}

[modify] https://crrev.com/6f88ffc45920456f0840acf3299c0a5e24bdebc9/DEPS

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d70ba3bba80eb5e6969c7036f136e795d10a2c8

commit 5d70ba3bba80eb5e6969c7036f136e795d10a2c8
Author: geofflang <geofflang@chromium.org>
Date: Wed Jul 06 17:08:26 2016

Roll ANGLE 3820e9c..5695fc9

https://chromium.googlesource.com/angle/angle.git/+log/3820e9c..5695fc9

BUG= 612205 
NOTRY=true

TBR=cwallez@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2122253002
Cr-Commit-Position: refs/heads/master@{#403923}

[modify] https://crrev.com/5d70ba3bba80eb5e6969c7036f136e795d10a2c8/DEPS

Cc: yunchao...@intel.com
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 13 2016

Status: Fixed (was: Started)

Comment 9 by kbr@chromium.org, Jul 13 2016

Awesome!

Comment 10 by kbr@chromium.org, Aug 15 2016

Cc: zmo@chromium.org bajones@chromium.org qiankun....@intel.com jmad...@chromium.org
 Issue 565438  has been merged into this issue.
Components: -Internals>GPU>WebGL Blink>WebGL

Sign in to add a comment