chrome://credits/ -> safe-browsing has dead link |
||||||
Issue descriptionThe home-page for "google-safe-browsing" in credits links to this 404'ing page: https://code.google.com/p/google-safe-browsing/ We should point it to this: https://www.chromium.org/developers/design-documents/safebrowsing Or... just remove it. I think it comes from third_party/safe_browsing/README.chromium, which we might be able to remove since the testing code in that dir is dead.
,
Jun 3 2016
,
Jun 8 2016
,
Jun 29 2016
,
Jun 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b9b95345eb1f8a788ac3992bdec7ebd8bdccef65 commit b9b95345eb1f8a788ac3992bdec7ebd8bdccef65 Author: nparker <nparker@chromium.org> Date: Thu Jun 30 19:20:49 2016 Remove the Pver3 safe_browsing_test server and related bits. It is both broken and deprecated. It'll be sufficiently different for pver4 that we should start from scratch. BUG= 612189 , 86092 Review-Url: https://codereview.chromium.org/2108313002 Cr-Commit-Position: refs/heads/master@{#403244} [modify] https://crrev.com/b9b95345eb1f8a788ac3992bdec7ebd8bdccef65/.gitignore [modify] https://crrev.com/b9b95345eb1f8a788ac3992bdec7ebd8bdccef65/DEPS [delete] https://crrev.com/367c0f7641530f948475b3dcb530e137d6d357a8/chrome/browser/safe_browsing/local_safebrowsing_test_server.cc [delete] https://crrev.com/367c0f7641530f948475b3dcb530e137d6d357a8/chrome/browser/safe_browsing/local_safebrowsing_test_server.h [delete] https://crrev.com/367c0f7641530f948475b3dcb530e137d6d357a8/chrome/browser/safe_browsing/safe_browsing_test.cc [modify] https://crrev.com/b9b95345eb1f8a788ac3992bdec7ebd8bdccef65/chrome/browser_tests.isolate [modify] https://crrev.com/b9b95345eb1f8a788ac3992bdec7ebd8bdccef65/chrome/chrome_tests.gypi [modify] https://crrev.com/b9b95345eb1f8a788ac3992bdec7ebd8bdccef65/chrome/test/BUILD.gn [delete] https://crrev.com/367c0f7641530f948475b3dcb530e137d6d357a8/chrome/test/data/safe_browsing/safe_browsing_testserver.py [modify] https://crrev.com/b9b95345eb1f8a788ac3992bdec7ebd8bdccef65/extensions/BUILD.gn [delete] https://crrev.com/367c0f7641530f948475b3dcb530e137d6d357a8/third_party/safe_browsing/BUILD.gn [delete] https://crrev.com/367c0f7641530f948475b3dcb530e137d6d357a8/third_party/safe_browsing/README.chromium [delete] https://crrev.com/367c0f7641530f948475b3dcb530e137d6d357a8/third_party/safe_browsing/safe_browsing.gyp
,
Jun 30 2016
,
Jul 7 2016
@nparker -- Navigated to chrome://credits Clicking on Homepage is navigating to different pages. Accessibility Audit library, from Accessibility Developer Tools -- Homepage -- Navigates to gituserhubcontent Almost Native Graphics Layer Engine -- Homepage -- Navigates to Monorail American Fuzzy Lop -- Homepage -- Navigates to project page. Could you please confirm whether this is the required behavior. Thanks in Advance.
,
Jul 7 2016
Yea sorry I don't know what the intended behaviour is of the chrome://credits links in general. This bug was to remove the safe-browsing entry altogether, since it was busted. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by elawrence@chromium.org
, May 16 2016