New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 612189 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

chrome://credits/ -> safe-browsing has dead link

Project Member Reported by nparker@chromium.org, May 16 2016

Issue description

The home-page for "google-safe-browsing" in credits links to this 404'ing page:
https://code.google.com/p/google-safe-browsing/

We should point it to this: https://www.chromium.org/developers/design-documents/safebrowsing

Or... just remove it.  I think it comes from third_party/safe_browsing/README.chromium, which we might be able to remove since the testing code in that dir is dead.
 
There are a few others like this:

"Homepage" link in Chrome credits goes to bugtracker instead of project page:
<span class="homepage"><a href="http://code.google.com/p/pdfium/">homepage</a></span><span class="homepage"><a href="http://code.google.com/p/v8">homepage</a></span><span class="homepage"><a href="http://code.google.com/p/angleproject/">homepage</a></span><span class="homepage"><a href="http://code.google.com/p/nativeclient">homepage</a></span>

Comment 2 by vakh@chromium.org, Jun 3 2016

Labels: SafeBrowsing-Triaged
Owner: nparker@chromium.org
Status: Available (was: Untriaged)
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9b95345eb1f8a788ac3992bdec7ebd8bdccef65

commit b9b95345eb1f8a788ac3992bdec7ebd8bdccef65
Author: nparker <nparker@chromium.org>
Date: Thu Jun 30 19:20:49 2016

Remove the Pver3 safe_browsing_test server and related bits.

It is both broken and deprecated. It'll be
sufficiently different for pver4 that we should start
from scratch.

BUG= 612189 , 86092 

Review-Url: https://codereview.chromium.org/2108313002
Cr-Commit-Position: refs/heads/master@{#403244}

[modify] https://crrev.com/b9b95345eb1f8a788ac3992bdec7ebd8bdccef65/.gitignore
[modify] https://crrev.com/b9b95345eb1f8a788ac3992bdec7ebd8bdccef65/DEPS
[delete] https://crrev.com/367c0f7641530f948475b3dcb530e137d6d357a8/chrome/browser/safe_browsing/local_safebrowsing_test_server.cc
[delete] https://crrev.com/367c0f7641530f948475b3dcb530e137d6d357a8/chrome/browser/safe_browsing/local_safebrowsing_test_server.h
[delete] https://crrev.com/367c0f7641530f948475b3dcb530e137d6d357a8/chrome/browser/safe_browsing/safe_browsing_test.cc
[modify] https://crrev.com/b9b95345eb1f8a788ac3992bdec7ebd8bdccef65/chrome/browser_tests.isolate
[modify] https://crrev.com/b9b95345eb1f8a788ac3992bdec7ebd8bdccef65/chrome/chrome_tests.gypi
[modify] https://crrev.com/b9b95345eb1f8a788ac3992bdec7ebd8bdccef65/chrome/test/BUILD.gn
[delete] https://crrev.com/367c0f7641530f948475b3dcb530e137d6d357a8/chrome/test/data/safe_browsing/safe_browsing_testserver.py
[modify] https://crrev.com/b9b95345eb1f8a788ac3992bdec7ebd8bdccef65/extensions/BUILD.gn
[delete] https://crrev.com/367c0f7641530f948475b3dcb530e137d6d357a8/third_party/safe_browsing/BUILD.gn
[delete] https://crrev.com/367c0f7641530f948475b3dcb530e137d6d357a8/third_party/safe_browsing/README.chromium
[delete] https://crrev.com/367c0f7641530f948475b3dcb530e137d6d357a8/third_party/safe_browsing/safe_browsing.gyp

Status: Fixed (was: Started)
Cc: msrchandra@chromium.org
Labels: Needs-Feedback
@nparker -- Navigated to chrome://credits
Clicking on Homepage is navigating to different pages.

Accessibility Audit library, from Accessibility Developer Tools -- Homepage -- Navigates to gituserhubcontent
Almost Native Graphics Layer Engine -- Homepage -- Navigates to Monorail
American Fuzzy Lop -- Homepage -- Navigates to project page.

Could you please confirm whether this is the required behavior.
Thanks in Advance.
Yea sorry I don't know what the intended behaviour is of the chrome://credits links in general.  This bug was to remove the safe-browsing entry altogether, since it was busted.

Sign in to add a comment