New issue
Advanced search Search tips

Issue 612152 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

inspector.html Timeline loading query params are not URL-decoded

Project Member Reported by pmeenan@chromium.org, May 16 2016

Issue description

The dev tools timeline can load external timelines by URL by passing a "loadTimelineFromURL" query param with the URL for the timeline.  This is used by tools like WebPageTest for embedding timeline views directly in the browser.

It looks like the URL passed to the timeline viewer is used without url-decoding so it is not possible to pass URLs that themselves contain query params.  I expect this is true for all of the query params handled by the Runtime in the inspector.

i.e. this URL: http://static.webpagetest.org/chrome/inspector-20160510/inspector.html?experiments=true&loadTimelineFromURL=%2FgetTimeline.php%3Ftest%3D160515_G4_TED%26run%3D2%26cached%3D0

Should load the timeline from /getTimeline.php?test=160515_G4_TED&run=2&cached=0 but in debugging the actual timeline loader code, it is passing the encoded string straight through to loadFromURL and is trying to load %2FgetTimeline.php%3Ftest%3D160515_G4_TED%26run%3D2%26cached%3D0

Passing the query param through decoded won't work because the &'s in the URL for the timeline file will pass through as separate query params and won't be included in the URL.
 
Cc: -paulir...@chromium.org
Owner: paulir...@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, May 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2533b7ef90d37b358be2e8fb42734a04434f9f76

commit 2533b7ef90d37b358be2e8fb42734a04434f9f76
Author: pfeldman <pfeldman@chromium.org>
Date: Mon May 16 21:14:12 2016

DevTools: decode URI passed into loadTimelineFromURL.

R=alph
BUG= 612152 

Review-Url: https://codereview.chromium.org/1986463002
Cr-Commit-Position: refs/heads/master@{#393924}

[modify] https://crrev.com/2533b7ef90d37b358be2e8fb42734a04434f9f76/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

Status: Fixed (was: Assigned)

Sign in to add a comment