New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 612090 link

Starred by 2 users
Status: Fixed
Owner:
█ chowse@chromium.org
Last visit > 30 days ago
Closed: May 2016
Cc:
maxwalker@chromium.org
paulir...@chromium.org
pfeldman@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature



Sign in to add a comment

Update icons in new Resources/Application panel

Project Member Reported by chowse@chromium.org, May 16 2016 
While we're updating the Application (formerly Resources) panel, let's:

1. Add icons for the new sections (Manifest, Service Workers, Clear Storage) for
   consistency with the rest of the the panel.

2. Remove the Win95-style icons and update them to the new icon style used in Sources.

3. Fix a few icon inconsistencies, e.g. using the same icon for Frames as used in
   the Sources panel.

Before and After screenshots attached. @Max: Please let me know your feedback on the choice of icons and color.

CL forthcoming.
resources-sidebar-before.png
76.1 KB View Download
resources-sidebar-after.png
74.9 KB View Download

Comment 1 by chowse@chromium.org, May 16 2016

Labels: -Restrict-View-Google
CL: https://codereview.chromium.org/1979163003/

Comment 2 by maxwalker@chromium.org, May 17 2016 

>> @Max: Please let me know your feedback on the choice of icons and color.
I like the icons, but they feel a bit heavy to me, overpowering the text labels. Have you tried something lighter, e.g. with outlines and/or a light grey background?
Icons.png
78.0 KB View Download

Comment 3 by chowse@chromium.org, May 17 2016

Status: Assigned (was: Untriaged)
Yeah, they do come off a bit heavy now. I've dimmed the icons to 70% #5a5a5a so they're a bit more balanced with the label.

While I like the outline icons, I'd prefer to stick with solid icons for now. It maintains consistency with the surrounding icons, will scale better to smaller sizes w/o pixel tweaking, and will register better if we apply color here or elsewhere.
resources-sidebar-after-2.png
41.1 KB View Download

Comment 4 by maxwalker@chromium.org, May 18 2016 

Great, LGTM!
Project Member

Comment 5 by bugdroid1@chromium.org, May 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2294d7602983c1183ae966d995d15d3b695bf4d2

commit 2294d7602983c1183ae966d995d15d3b695bf4d2
Author: chowse <chowse@chromium.org>
Date: Wed May 18 23:45:42 2016

Updated icons in Resources/Application panel

BUG= 612090 
NOTRY=true

Review-Url: https://codereview.chromium.org/1979163003
Cr-Commit-Position: refs/heads/master@{#394604}

[modify] https://crrev.com/2294d7602983c1183ae966d995d15d3b695bf4d2/third_party/WebKit/Source/devtools/devtools.gypi
[delete] https://crrev.com/bf0c95b52ea71d32c4d5d38083ea978952516b0e/third_party/WebKit/Source/devtools/front_end/Images/database.png
[delete] https://crrev.com/bf0c95b52ea71d32c4d5d38083ea978952516b0e/third_party/WebKit/Source/devtools/front_end/Images/databaseTable.png
[delete] https://crrev.com/bf0c95b52ea71d32c4d5d38083ea978952516b0e/third_party/WebKit/Source/devtools/front_end/Images/indexedDB.png
[delete] https://crrev.com/bf0c95b52ea71d32c4d5d38083ea978952516b0e/third_party/WebKit/Source/devtools/front_end/Images/indexedDBIndex.png
[delete] https://crrev.com/bf0c95b52ea71d32c4d5d38083ea978952516b0e/third_party/WebKit/Source/devtools/front_end/Images/indexedDBObjectStore.png
[delete] https://crrev.com/bf0c95b52ea71d32c4d5d38083ea978952516b0e/third_party/WebKit/Source/devtools/front_end/Images/localStorage.png
[add] https://crrev.com/2294d7602983c1183ae966d995d15d3b695bf4d2/third_party/WebKit/Source/devtools/front_end/Images/resourceGlyphs.png
[add] https://crrev.com/2294d7602983c1183ae966d995d15d3b695bf4d2/third_party/WebKit/Source/devtools/front_end/Images/resourceGlyphs_2x.png
[delete] https://crrev.com/bf0c95b52ea71d32c4d5d38083ea978952516b0e/third_party/WebKit/Source/devtools/front_end/Images/serviceWorker.svg
[delete] https://crrev.com/bf0c95b52ea71d32c4d5d38083ea978952516b0e/third_party/WebKit/Source/devtools/front_end/Images/sessionStorage.png
[modify] https://crrev.com/2294d7602983c1183ae966d995d15d3b695bf4d2/third_party/WebKit/Source/devtools/front_end/Images/src/optimize_png.hashes
[add] https://crrev.com/2294d7602983c1183ae966d995d15d3b695bf4d2/third_party/WebKit/Source/devtools/front_end/Images/src/resourceGlyphs.svg
[modify] https://crrev.com/2294d7602983c1183ae966d995d15d3b695bf4d2/third_party/WebKit/Source/devtools/front_end/Images/src/svg2png.hashes
[modify] https://crrev.com/2294d7602983c1183ae966d995d15d3b695bf4d2/third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js
[modify] https://crrev.com/2294d7602983c1183ae966d995d15d3b695bf4d2/third_party/WebKit/Source/devtools/front_end/resources/resourcesSidebar.css

Comment 6 by chowse@chromium.org, May 26 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment