New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 612068 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 605821



Sign in to add a comment

Files app: Use custom iron-iconset-svg for iron icons

Project Member Reported by fukino@chromium.org, May 16 2016

Issue description

Files app should use custom-iconsets to save the Chrome save size.
https://groups.google.com/a/chromium.org/forum/#!msg/chromium-polymer/OihSj0QyYoo/_ERNUgIjFQAJ
 

Comment 1 by fukino@chromium.org, May 16 2016

Status: Started (was: Assigned)
Summary: Files app: Use custom iron-iconset-svg for iron icons (was: Files app: Use custom-iconsets for iron icons)
Oops, "custom-iconsets" from my message is not a thing. I just meant that we should create custom iconsets, using iron-iconset-svg. Thanks!
Blocking: 605821
Last update :-) I simplified things so you don't have to worry about that poly-icon URL anymore. If you've already started this work, just note that the comment in custom icon files is shorter now:

      <!--
      These icons are copied from Polymer's iron-icons and kept in sorted order.
      See http://goo.gl/Y1OdAq for instructions on adding additional icons.
      -->

https://codereview.chromium.org/1992503002/

Comment 4 by fukino@chromium.org, May 18 2016

Thank you for the update!
I'll remove iron-icons for M52.

Comment 6 by fukino@chromium.org, May 19 2016

Status: Fixed (was: Started)
Labels: Needs-Feedback
@fukino Hi, trying to verify this bug. Could you please provide test steps to verify?
Cc: sdantul...@chromium.org
This doesn't include any user-visible change, so I think we can mark this as Verified by comment#5 (the commit message)
Status: Verified (was: Fixed)
Thanks fukino@.

Marking verified as per comment#5

Sign in to add a comment