New issue
Advanced search Search tips

Issue 612067 link

Starred by 1 user
Status: Duplicate
Merged: issue 605374
Owner: ----
Closed: Dec 2016
Cc:
tapted@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

MacViews: Open/Save File dialogs do not open when there is an active bubble.

Project Member Reported by karandeepb@chromium.org, May 16 2016 
Version: 52.0.2735.0 
OS: Mac

What steps will reproduce the problem?
(1) Enable chrome://flags/#mac-views-dialogs.
(2) Go to google.com and click on the Green Lock icon on address bar. The website settings bubble should become visible.
(3) Press Command+O (shortcut to launch Open file dialog)

What is the expected output?
Open file dialog should launch.

What do you see instead?
Nothing happens.

This also happens with the bookmark bubble and permissions bubble.

Comment 1 by tapted@chromium.org, May 16 2016 

It's possible that it was a bug that allowed this to work in Cocoa.

And, for example, the permissions bubble in Cocoa doesn't allow Cmd+o to open window sheets. (e.g. https://permission.site/ -> Location/Notifications). These are the "persistent" type. Whereas "video" for example surfaces a notification on the right of the omnibox which is a non-persistent type.

The non-persistent type actually used to work in MacViews as well, but then I landed r392448 so the keystate wasn't shared.

I think there's a general consensus that "Cmd+w should always close a tab". So that should work. Cmd+o is more gray. If we don't want to handle it we shouldn't flash the `File` menu, but instead disable an appropriate set of menu items so that Mac will <beep> if you attempt to Cmd+o while a bubble is open.

But I'm more inclined to set things up so that bubbles explicitly feed unmapped shortcuts to their parent window.

Comment 2 by tapted@chromium.org, Dec 12 2016

Mergedinto: 605374
Status: Duplicate (was: Available)

Comment 3 by varkha@chromium.org, Mar 24 2017

Cc: tapted@chromium.org
https://codereview.chromium.org/2666523002/ seems to have fixed this bug. If so does it still make sense to have it duped into  bug 605374 ?
►

Sign in to add a comment