New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 612055 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Clean up stale FIXMEs re: snapping/rawValue in InlineTextBox.

Project Member Reported by wkorman@chromium.org, May 15 2016

Issue description

Brief tracking bug for http://crrev.com/1966913002 which looks like it will require some minor rebaselines.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/afc18e1ee0f60d03916954684c8e77d57606fe17

commit afc18e1ee0f60d03916954684c8e77d57606fe17
Author: wkorman <wkorman@chromium.org>
Date: Wed May 18 00:03:40 2016

Clean up obsolete LayoutUnit.rawValue() FIXME comments.

One comment references altering enclosingIntRect() to do pixel snapping, but
we've made many pixel snapping changes since that comment was written, so
without an explicit open bug or known broken test case removal seems reasonable.

BUG= 612055 

Review-Url: https://codereview.chromium.org/1966913002
Cr-Commit-Position: refs/heads/master@{#394275}

[modify] https://crrev.com/afc18e1ee0f60d03916954684c8e77d57606fe17/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/afc18e1ee0f60d03916954684c8e77d57606fe17/third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp

Project Member

Comment 2 by bugdroid1@chromium.org, May 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48a2f86c728e869f9ac9d95f4c606e1a5fac9f0e

commit 48a2f86c728e869f9ac9d95f4c606e1a5fac9f0e
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Wed May 18 01:12:26 2016

Auto-rebaseline for r394275

https://chromium.googlesource.com/chromium/src/+/afc18e1ee

BUG= 612055 
TBR=wkorman@chromium.org

Review URL: https://codereview.chromium.org/1989683003 .

Cr-Commit-Position: refs/heads/master@{#394304}

[modify] https://crrev.com/48a2f86c728e869f9ac9d95f4c606e1a5fac9f0e/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/48a2f86c728e869f9ac9d95f4c606e1a5fac9f0e/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/line-flow-with-floats-10-expected.txt
[modify] https://crrev.com/48a2f86c728e869f9ac9d95f4c606e1a5fac9f0e/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/line-flow-with-floats-3-expected.txt
[modify] https://crrev.com/48a2f86c728e869f9ac9d95f4c606e1a5fac9f0e/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/line-flow-with-floats-4-expected.txt
[add] https://crrev.com/48a2f86c728e869f9ac9d95f4c606e1a5fac9f0e/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/block-layout-inline-children-float-positioned-expected.txt
[modify] https://crrev.com/48a2f86c728e869f9ac9d95f4c606e1a5fac9f0e/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/bugzilla-5699-expected.txt
[modify] https://crrev.com/48a2f86c728e869f9ac9d95f4c606e1a5fac9f0e/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/bugzilla-6278-expected.txt
[modify] https://crrev.com/48a2f86c728e869f9ac9d95f4c606e1a5fac9f0e/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/line-flow-with-floats-1-expected.txt
[modify] https://crrev.com/48a2f86c728e869f9ac9d95f4c606e1a5fac9f0e/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/line-flow-with-floats-10-expected.txt
[modify] https://crrev.com/48a2f86c728e869f9ac9d95f4c606e1a5fac9f0e/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/line-flow-with-floats-3-expected.txt
[modify] https://crrev.com/48a2f86c728e869f9ac9d95f4c606e1a5fac9f0e/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/line-flow-with-floats-4-expected.txt
[modify] https://crrev.com/48a2f86c728e869f9ac9d95f4c606e1a5fac9f0e/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/line-flow-with-floats-5-expected.txt
[add] https://crrev.com/48a2f86c728e869f9ac9d95f4c606e1a5fac9f0e/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/line-flow-with-floats-7-expected.txt
[modify] https://crrev.com/48a2f86c728e869f9ac9d95f4c606e1a5fac9f0e/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/line-flow-with-floats-9-expected.txt
[modify] https://crrev.com/48a2f86c728e869f9ac9d95f4c606e1a5fac9f0e/third_party/WebKit/LayoutTests/platform/win/fast/repaint/bugzilla-5699-expected.txt
[modify] https://crrev.com/48a2f86c728e869f9ac9d95f4c606e1a5fac9f0e/third_party/WebKit/LayoutTests/platform/win/fast/repaint/line-flow-with-floats-5-expected.txt
[modify] https://crrev.com/48a2f86c728e869f9ac9d95f4c606e1a5fac9f0e/third_party/WebKit/LayoutTests/platform/win/fast/repaint/line-flow-with-floats-8-expected.txt

Status: Fixed (was: Started)

Sign in to add a comment