WindowTreeClientImpl Should Clear Focus on Deletion |
|||||||||||||
Issue descriptionWindowTreeClientImpl caches the focused window, and does not clear this upon deletion. It is possible to receive focus update messages from the window server after local deletion. We should update WindowTreeClientImpl to clear the local focus state on deletion to avoid attempting to access the window after free
,
Jun 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/14f17517b43e58c9017bc911f36b60f4d6de44fd commit 14f17517b43e58c9017bc911f36b60f4d6de44fd Author: jonross <jonross@chromium.org> Date: Fri Jun 03 02:48:36 2016 Update WindowTreeClientImpl OnWindowDestroying Update capture handling, forcing the queue to revert to null capture is incorrect. The in flight queue is listening for window destruction, and updates the revert target appropriately. Capture does not need to be explicitly released here. mus::Window removes focus upon destruction. The in flight queue listens for this to update revert target appropriately. TEST=views_mus_unittests, mus_public_unittests BUG= 611983 Review-Url: https://codereview.chromium.org/2021383002 Cr-Commit-Position: refs/heads/master@{#397602} [modify] https://crrev.com/14f17517b43e58c9017bc911f36b60f4d6de44fd/components/mus/public/cpp/lib/window_tree_client.cc
,
Jun 7 2016
Ended up proving that deletion appropriately clears focus state.
,
Jul 1 2016
,
Aug 29 2016
,
Oct 7 2016
,
Nov 19 2016
,
Jan 21 2017
,
Mar 4 2017
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
,
Feb 26 2018
|
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by rjkroege@chromium.org
, May 17 2016