Awaiting designer spec and conclusion on this before work can start
What is the current elevation of snippets?
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/84ee518a8941b23498f9c3dc6c5421808143c855 commit 84ee518a8941b23498f9c3dc6c5421808143c855 Author: mcwilliams <mcwilliams@chromium.org> Date: Wed May 18 21:58:24 2016 Adding elevation to NTP snippets Add elevation to the snippet cards so the peeking card is more prominent and the last snippet has elevation especially when you dismiss cards and when there is a space between the last snippet and the bottom of the screen Video: https://drive.google.com/open?id=0B1IgAIJ9cgizb2FWM29QU1JSSU0 BUG= 611974 , 611445 Review-Url: https://codereview.chromium.org/1995433003 Cr-Commit-Position: refs/heads/master@{#394563} [modify] https://crrev.com/84ee518a8941b23498f9c3dc6c5421808143c855/base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java [delete] https://crrev.com/2c30f24ecc1c52d3dcadf4c6025b6f8f14f426af/chrome/android/java/res/drawable/snippet_separator.xml [modify] https://crrev.com/84ee518a8941b23498f9c3dc6c5421808143c855/chrome/android/java/res/values/colors.xml [modify] https://crrev.com/84ee518a8941b23498f9c3dc6c5421808143c855/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/84ee518a8941b23498f9c3dc6c5421808143c855/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java [modify] https://crrev.com/84ee518a8941b23498f9c3dc6c5421808143c855/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java [modify] https://crrev.com/84ee518a8941b23498f9c3dc6c5421808143c855/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetItemDecoration.java
Issue 611769 has been merged into this issue.
Comment 1 by nepper@chromium.org
, May 15 2016Labels: zine-mr-mile-MVP M-52
Owner: bettes@chromium.org
Status: Assigned (was: Untriaged)