New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 611974 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Add elevation to the peeking card on the new tap page to give it a more material feel

Project Member Reported by mcwilliams@chromium.org, May 14 2016

Issue description

Awaiting designer spec and conclusion on this before work can start
 

Comment 1 by nepper@chromium.org, May 15 2016

Cc: -bettes@chromium.org mcwilliams@chromium.org
Labels: zine-mr-mile-MVP M-52
Owner: bettes@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by bettes@chromium.org, May 16 2016

What is the current elevation of snippets?
Labels: zine-mr-iter-15
Owner: mcwilliams@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, May 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84ee518a8941b23498f9c3dc6c5421808143c855

commit 84ee518a8941b23498f9c3dc6c5421808143c855
Author: mcwilliams <mcwilliams@chromium.org>
Date: Wed May 18 21:58:24 2016

Adding elevation to NTP snippets

Add elevation to the snippet cards so the peeking card is more prominent and the last snippet has elevation especially when you dismiss cards and when there is a space between the last snippet and the bottom of the screen

Video: https://drive.google.com/open?id=0B1IgAIJ9cgizb2FWM29QU1JSSU0

BUG= 611974 ,  611445 

Review-Url: https://codereview.chromium.org/1995433003
Cr-Commit-Position: refs/heads/master@{#394563}

[modify] https://crrev.com/84ee518a8941b23498f9c3dc6c5421808143c855/base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java
[delete] https://crrev.com/2c30f24ecc1c52d3dcadf4c6025b6f8f14f426af/chrome/android/java/res/drawable/snippet_separator.xml
[modify] https://crrev.com/84ee518a8941b23498f9c3dc6c5421808143c855/chrome/android/java/res/values/colors.xml
[modify] https://crrev.com/84ee518a8941b23498f9c3dc6c5421808143c855/chrome/android/java/res/values/dimens.xml
[modify] https://crrev.com/84ee518a8941b23498f9c3dc6c5421808143c855/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java
[modify] https://crrev.com/84ee518a8941b23498f9c3dc6c5421808143c855/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
[modify] https://crrev.com/84ee518a8941b23498f9c3dc6c5421808143c855/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetItemDecoration.java

Status: Fixed (was: Assigned)

Comment 6 by bauerb@chromium.org, May 20 2016

 Issue 611769  has been merged into this issue.

Comment 7 by fi...@chromium.org, Jul 1 2016

Labels: zine-mr-MVP

Comment 8 by finkm@google.com, Jul 1 2016

Labels: -zine-mr-mvp

Comment 9 by fi...@chromium.org, Jul 1 2016

Labels: zine-mr-MVP

Sign in to add a comment